Siu Chi Chan
ac10afb0f7
remove old style triple name
...
[ROCm/hip commit: d37f9e6b2d ]
2019-03-11 19:51:51 +00:00
Siu Chi Chan
fc9af438a4
move triple_to_hsa_isa into the header
...
[ROCm/hip commit: 824ee1aa72 ]
2019-03-11 19:51:44 +00:00
Siu Chi Chan
15061ddfcc
Fix memory leak introduced by previous change to Agent_global.
...
Make Agent_global manage the lifetime of the name string
[ROCm/hip commit: bf1d48bf78 ]
2019-03-11 19:51:32 +00:00
Aaron Enye Shi
1e07be3ab3
Fix Agent_global variables failing hipTestDeviceSymbol
...
Issue: Header uses std::vector<Agent_global> agent_globals which is created by hip_module.cpp
- Move iterator fails to copy Agent_global from library source into header version
- Due to different versions of std::string name in struct Agent_global
Fix: Change Agent_global to use char* name instead of std::string name
[ROCm/hip commit: 00d24d254d ]
2019-03-11 19:51:25 +00:00
Aaron Enye Shi
4b87bd25e8
Fix hash_for undefined reference in hipTestConstant test
...
Issue: mismatch undefined symbols in different user env
- Binary expects modified return value std::string&
- Fails to match libhip_hcc.so: return value is std::string& but doesn't match modified C++ env
Fix: Change return value to char*, create new key std::string in header from char*
[ROCm/hip commit: 23e9968752 ]
2019-03-11 19:51:18 +00:00
Michael Liao
c0f6fa358f
[hip] Re-implement hipLaunchKernelGGL as macros.
...
[ROCm/hip commit: 30185b4114 ]
2019-03-08 09:10:51 -05:00
Maneesh Gupta
645c29159c
Merge pull request #951 from tycho/nvcc-hipDeviceSetCacheConfig
...
nvcc_detail/hip_runtime_api.h: add missing hipDeviceSetCacheConfig API
[ROCm/hip commit: 250bd58254 ]
2019-03-08 09:22:25 +05:30
foreman
ea245a71ec
P4 to Git Change 1753099 by cpaquot@cpaquot-ocl-lc-lnx on 2019/03/07 16:43:54
...
SWDEV-145570 - [HIP] Change IS_HIP into a dynamic variable set by HIP layer
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#16 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#127 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palsettings.cpp#69 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.cpp#18 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#303 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/macros.hpp#11 edit
[ROCm/hip commit: e461d71afa ]
2019-03-07 17:24:23 -05:00
foreman
0838a3f1d8
P4 to Git Change 1752994 by kjayapra@2_HIPWS_SL_D32 on 2019/03/07 14:06:54
...
SWDEV-145570 - Implementation of ihipMemsetD32 and ihipMemsetD32Async
HIP-HCC Info: https://github.com/ROCm-Developer-Tools/HIP/pull/933
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#11 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#12 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#44 edit
[ROCm/hip commit: e66470b435 ]
2019-03-07 14:58:49 -05:00
Yaxun Sam Liu
a431326408
Fix HIP/VDI build failure due to dlopen change
...
[ROCm/hip commit: 6e9e90addd ]
2019-03-07 14:45:45 -05:00
Steven Noonan
17e2bfe3f8
nvcc_detail/hip_runtime_api.h: add missing hipDeviceSetCacheConfig API
...
Signed-off-by: Steven Noonan <steven@uplinklabs.net >
[ROCm/hip commit: ee750d5ea4 ]
2019-03-06 11:21:36 -08:00
Evgeny Mankov
1397bf79d8
[HIPIFY][tests] Update lit testing infrastructure
...
+ Set -D__LP64__ in case of 64-bit hipify-clang binary
[partial workaround for clang's bug https://bugs.llvm.org/show_bug.cgi?id=38811 ]
C:/GIT/LLVM/trunk/llvm-64-release-vs2017/dist/lib/clang/9.0.0\include\__clang_cuda_device_functions.h(1609,45): error GEF7559A7: no matching function for call to 'roundf'
__DEVICE__ long lroundf(float __a) { return roundf(__a); }
#if defined(__LP64__)
__DEVICE__ long lround(double __a) { return llround(__a); }
__DEVICE__ long lroundf(float __a) { return llroundf(__a); } // ok: llroundf should be used when 64-bit
#else
__DEVICE__ long lround(double __a) { return round(__a); }
__DEVICE__ long lroundf(float __a) { return roundf(__a); } // error
#endif
+ Print more system info while testing in the following form:
========================================
CUDA 9.0 - will be used for testing
LLVM 9.0.0svn - will be used for testing
AMD64 - Platform architecture
Windows 10 - Platform OS
64 - hipify-clang binary bitness
32 - python 3.7.2 binary bitness
========================================
[ROCm/hip commit: e899ee0e06 ]
2019-03-06 19:26:05 +03:00
eshcherb
7f40a2cd9a
roctracer-proto header find_path ( #884 )
...
[ROCm/hip commit: 88b4621dbd ]
2019-03-06 17:36:34 +05:30
Maneesh Gupta
3f5e937afc
Merge pull request #949 from gargrahul/single_stream_concurrent_kernels
...
Add extension for kernel concurrency on same stream
[ROCm/hip commit: 352b17346c ]
2019-03-06 17:34:54 +05:30
Maneesh Gupta
df7d8c46ed
Merge pull request #932 from ROCm-Developer-Tools/feature_maybe_dlopen_test
...
Add one test case for complex dynamic loading behavior
[ROCm/hip commit: 0c4a40efcc ]
2019-03-06 17:32:23 +05:30
Alex Voicu
0c16497abd
dlopen() fixes ( #929 )
...
* Initial attempt to switch over to internally linked state.
* Add missing CMake update.
* hipLaunchKernelGGLImpl must be inline as well. Ensure internal linkage.
* Ensure global retrieval uses internally linked state.
* Hide HC in the implementation. Minimise ADL woes.
* Strange software exists, and must be catered to.
* Use a less spammy mechanism for ensuring internal linkage / non-export.
* Remove leftover internal detail.
[ROCm/hip commit: ea0fcf3e61 ]
2019-03-06 17:31:44 +05:30
Rahul Garg
5d6fd17fbe
Add extension for kernel concurrency on same stream
...
[ROCm/hip commit: 59081c69fc ]
2019-03-06 12:55:39 +05:30
Maneesh Gupta
2264e69da3
Merge pull request #936 from mangupta/swdev-174923
...
[hipconfig] Update HIP_PLATFORM detection logic
[ROCm/hip commit: 2d67bc5e9c ]
2019-03-06 06:08:11 +05:30
Evgeny Mankov
effdffc006
[HIPIFY] Change CUDA Driver's functions' cuMemsetD32(Async) mapping
...
cuMemsetD32(Async) -> hipMemsetD32(Async) (was hipMemset(Async))
based on:
[#933 ] https://github.com/ROCm-Developer-Tools/HIP/pull/933
[ROCm/hip commit: a87d798d90 ]
2019-03-05 18:13:18 +03:00
Maneesh Gupta
54c72c1079
Update hipMemset.cpp
...
Address build issues on nvcc path.
[ROCm/hip commit: 51f29b9cee ]
2019-03-05 12:11:11 +05:30
Maneesh Gupta
19b6b2b570
Update hip_runtime_api.h
...
Use hipCUResultTohipError instead of hipCUDAErrorTohipError in hipMemsetD32 & hipMemsetD32Async.
[ROCm/hip commit: 8db717c769 ]
2019-03-05 12:10:01 +05:30
Wen-Heng (Jack) Chung
da589e38ed
Address code review comments to use hipDeviceptr_t
...
[ROCm/hip commit: 5cbd28f29b ]
2019-03-05 05:51:05 +00:00
Wen-Heng (Jack) Chung
ea689f63ca
Add implementation for NVCC path
...
[ROCm/hip commit: 0337b686ef ]
2019-03-04 20:11:12 -08:00
Wen-Heng (Jack) Chung
085c6c15b2
Add direct test for hipMemsetD32 and hipMemsetD32Async
...
[ROCm/hip commit: bfde8a7fab ]
2019-03-04 17:20:32 +00:00
Wen-Heng (Jack) Chung
0b7f38d100
Add hipMemsetD32 and hipMemsetD32Async
...
Add 2 extra memset functions which fills memory with integer-typed data
Also change the parameters of ihipMemset to better explain the semantic
[ROCm/hip commit: 7ebbbd3525 ]
2019-03-04 17:00:33 +00:00
Maneesh Gupta
a60c0222f0
Merge pull request #939 from gargrahul/update_hipmemset_test
...
[dtest] Update hipMemset test
[ROCm/hip commit: de4a9b8446 ]
2019-03-03 20:29:55 +05:30
Rahul Garg
7a9ebee08a
Fix review comments
...
[ROCm/hip commit: 131c0ea326 ]
2019-03-02 23:38:37 +05:30
Maneesh Gupta
91f6e6b1e8
Merge pull request #945 from wkwchau/hipMemset3D_fix
...
Fix hipMemset3D test
[ROCm/hip commit: d28c13ed69 ]
2019-03-01 21:18:12 +05:30
Wilkin Chau
4a0d68ba3f
Fix hipMemset3D test
...
Calculate the allocated size based on the width, height and depth.
[ROCm/hip commit: 8d92d1ebd7 ]
2019-02-28 22:42:46 +00:00
Rahul Garg
4093c03dd7
Fix hipMemset test for HIP/NVCC
...
[ROCm/hip commit: 77c6d5451f ]
2019-03-01 03:46:57 +05:30
Yaxun Sam Liu
d9f59b18f8
Revert "hipcc should consume -mcode-object-v3 flag"
...
This reverts commit 1a8b50e63c .
[ROCm/hip commit: e8556388f9 ]
2019-02-28 11:21:47 -05:00
Yaxun Sam Liu
e748fd2ae0
Revert "Change code-object flag to only HIP-Clang"
...
This reverts commit 17a853c277 .
[ROCm/hip commit: 1bd8d24278 ]
2019-02-28 11:20:04 -05:00
Yaxun Sam Liu
f46d2a3010
Revert "Consume the code obj args to prevent duplicates"
...
This reverts commit b19e4b5b63 .
[ROCm/hip commit: 737972d31c ]
2019-02-28 11:19:35 -05:00
Maneesh Gupta
f3def1c107
Merge pull request #938 from gargrahul/fix_hipBusBW_p2p_bidir
...
Fix hipBusBW sample for P2P bidirectional test
[ROCm/hip commit: b93666bdde ]
2019-02-28 07:14:38 +05:30
Maneesh Gupta
f0bb5690f1
Merge pull request #937 from yxsamliu/nan2
...
Fix nan for windows
[ROCm/hip commit: 07b0e9574c ]
2019-02-28 07:14:27 +05:30
Maneesh Gupta
2e700104de
Merge pull request #935 from gargrahul/fix_hipbusbw_beatsoverflow
...
Fix hipBusBW overflow with setting beats/iterations
[ROCm/hip commit: 2da14e97f2 ]
2019-02-28 07:14:16 +05:30
Rahul Garg
fa0c9d8a73
Update hipMemset test
...
[ROCm/hip commit: 026dc9457e ]
2019-02-28 06:54:49 +05:30
Rahul Garg
c7620fc4e9
Fix hipBusBW sample for P2P bidirectional test
...
[ROCm/hip commit: 70278f1777 ]
2019-02-28 00:56:07 +05:30
Yaxun Sam Liu
48ab0aa588
Fix nan for windows
...
[ROCm/hip commit: 278007218a ]
2019-02-27 12:33:26 -05:00
Maneesh Gupta
55da014b79
[hipcofig] Update HIP_PLATFORM detection logic
...
HIP_PLATFORM detection logic relied on finding a working KFD. If it was
found, the platform was set as hcc else as nvcc.
However this logic is flawed since it is possible for the development
system to only have the user mode bits to build HIP application code.
Hence the better logic is to rely on finding a suitable compiler.
The new logic is as follows:
- look for a working HCC. If found, platform is set as hcc.
- else look for a working NVCC. If found, platform is set as nvcc.
- else the platform defaults to hcc for now.
Change-Id: Ifcc42c29a19f722153d5c23c55f1a8765dceaf6b
[ROCm/hip commit: 8b25f7b4cf ]
2019-02-27 14:10:21 +05:30
Rahul Garg
6391066444
Fix hipBusBW overflow with setting beats/iterations
...
[ROCm/hip commit: 673ecd02fe ]
2019-02-27 00:18:52 +05:30
Rahul Garg
67723bd3e7
Fix forceinline for non HCC compilation
...
[ROCm/hip commit: 55145feae6 ]
2019-02-26 07:50:09 +05:30
Wen-Heng (Jack) Chung
c79a5a798e
Add one test case for complex dynamic loading behavior
...
Existing HIT syntax doesn't seem to support the expected build and run steps
for this test.
[ROCm/hip commit: 8e5bb3c57a ]
2019-02-25 17:03:31 +00:00
Evgeny Mankov
55d9cd6a65
[HIPIFY][doc] Update README.md
...
+ Populate Dependencies section with upcoming LLVM versions
+ Add clang bugs for not working configs LLVM+CUDA
+ Update Testing section
[ROCm/hip commit: 391aa7221b ]
2019-02-25 18:26:25 +03:00
Evgeny Mankov
5f4b9a8f8f
[HIPIFY][tests] caffe2 test fix
...
[ROCm/hip commit: 3a8ef9c8a2 ]
2019-02-25 17:12:32 +03:00
Evgeny Mankov
3a57fc0a4b
[HIPIFY][Caffe2] Initial Caffe2 support
...
[ROCm/hip commit: 2619f22e5c ]
2019-02-23 20:46:22 +03:00
foreman
67a5235c22
P4 to Git Change 1747723 by cpaquot@cpaquot-ocl-lc-lnx on 2019/02/22 19:30:33
...
SWDEV-145570 - [HIP] Texture object implementation
hipTextureObject2D test passes on PAL backend.
Still needs to have sampler handled properly on ROCm backend.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#22 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#10 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#333 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.hpp#36 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palmemory.hpp#10 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocmemory.hpp#14 edit
[ROCm/hip commit: c49cb353ca ]
2019-02-22 19:43:36 -05:00
Maneesh Gupta
992f431c99
Merge pull request #925 from yxsamliu/h2f
...
Add __gnu_h2f_ieee and __gnu_f2h_ieee
[ROCm/hip commit: 31c4cc78b1 ]
2019-02-22 13:38:15 +05:30
foreman
5fde143688
P4 to Git Change 1746912 by cpaquot@cpaquot-ocl-lc-lnx on 2019/02/21 14:16:35
...
SWDEV-178453 - [HIP] Add extra parameter for sharedMemBytes
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#20 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#129 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.hpp#58 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.cpp#72 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.hpp#21 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.cpp#91 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.hpp#91 edit
[ROCm/hip commit: 38d6d7f87f ]
2019-02-21 17:42:08 -05:00
Yaxun Sam Liu
7ef8b1138f
Add __gnu_h2f_ieee and __gnu_f2h_ieee
...
The implementation is copied from HCC runtime.
For hcc it has no effect since apps can find them in either hcc runtime or HIP
runtime.
hip-clang needs it in HIP/HCC runtime so that HIP/HCC and HIP/VDI runtime are
swappable.
[ROCm/hip commit: c5e813f64c ]
2019-02-21 12:48:28 -05:00