fb210abcd0
Skip output lines that have UTF8 decoding error ( #441 )
...
* Avoid crash if non-UTF8 character is encountered in output
Signed-off-by: benrichard-amd <ben.richard@amd.com >
* Ignore lines with non-UTF-8 characters. Do not print error.
Signed-off-by: benrichard-amd <ben.richard@amd.com >
* Remove trailing whitespace
Signed-off-by: benrichard-amd <ben.richard@amd.com >
---------
Signed-off-by: benrichard-amd <ben.richard@amd.com >
2024-10-03 11:27:55 -04:00
69e5c32d52
Work around crash when profiling multi-process/multi-GPU application ( #376 )
...
* Fix crash in multi-GPU scenario
Exclude -o option when invoking rocprof so that each rocprof process
writes to a different .csv file. Concatenate into a single .csv file
when finished.
Signed-off-by: benrichard-amd <ben.richard@amd.com >
* Only combine csv files when using rocprofv2
rocprofv1 does not have separate csv files
Signed-off-by: benrichard-amd <ben.richard@amd.com >
* Fix indices in combined CSV file
Use ignore_index flag to ensure there are no duplicate indices.
Signed-off-by: benrichard-amd <ben.richard@amd.com >
* Fix Dispatch_ID column and remove unnamed column
-Pandas was inserting an unnamed column (index column)
-Overwrite the Dispatch_ID column so that every row is unique, starting at 0
-Remove fixup_rocprofv2_dispatch_ids as no longer needed
Signed-off-by: benrichard-amd <ben.richard@amd.com >
* Fix code formatting
Signed-off-by: benrichard-amd <ben.richard@amd.com >
* Fix code formatting (for real this time)
Signed-off-by: benrichard-amd <ben.richard@amd.com >
---------
Signed-off-by: benrichard-amd <ben.richard@amd.com >
2024-08-09 09:46:42 -04:00
7046ea15bd
Comply to formatting
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-06-03 13:47:45 -05:00
295b344646
Re-implementing HBM stack / XCD info for incoming product sku
...
Co-authored-by: Nicholas Curtis <nicholas.curtis@amd.com >
Signed-off-by: coleramos425 <colramos@amd.com >
2024-06-03 13:47:45 -05:00
1f370c9fe7
Format CMake and Python
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-05-10 09:07:40 -06:00
dba868973b
Add support for --quiet flag to roofline
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-05-10 09:07:40 -06:00
7d34e80567
Replace deprecated roofline warning with logging helper function
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-04-25 18:43:20 +00:00
b5011ff0ae
additional mod needed to support roofline binaries potentially
...
executing from two different locations
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-04-22 09:00:18 -05:00
093a4511ee
update logic to detect roofline binaries in two alternate paths
...
depending on whether user is running within local clone or from form
install.
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-04-21 14:53:14 -05:00
3c562588ff
update logic to detect VERSION file to accommodate rocm packaging;
...
check two locations to cover case where user is running within local
git clone directly or alternatively, from package install.
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-04-21 14:53:14 -05:00
e0556f32ab
Move dispatch id patch to proper util func in utils. Enable in rocprofv2 post-processing
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-04-01 14:30:21 -05:00
f4070e3654
apply formatter
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-03-15 14:04:49 -05:00
2dcad38028
Update roofline distro_map for Ubuntu22.04 ( #319 )
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-15 12:47:30 -05:00
69af2ffc83
update logging formatter handling for consistent behavior with error messsages
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-03-14 17:37:30 -05:00
e7cc326d5a
Fix missing argv in console_warning()
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-12 16:44:02 -05:00
e85037fdfb
move set_locale_encoding() to occur after logging is setup - allows
...
function to use console_error() directly (https://github.com/AMDResearch/omniperf/pull/308#discussion_r1519914083 )
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-03-11 14:19:01 -05:00
5e21dc35fd
Update src/utils/utils.py
...
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com >
2024-03-11 14:19:01 -05:00
8e45cc897f
Update src/utils/utils.py
...
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com >
2024-03-11 14:19:01 -05:00
27a57bdafb
refactor setting of local encoding; remove from top-level omniperf
...
wrapper and push into base class via a companion utility function
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-03-11 14:19:01 -05:00
15c86ba424
update print_status() to use console logger; convert some info logs to debug logs
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-03-11 14:19:01 -05:00
2b24375e8d
add a exit keyword to console_error function; allows multiple error
...
lines prior to code exit
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-03-11 14:19:01 -05:00
377c642ac2
updates for run_prof() routine:
...
* add a profileMode keyword option, used to indent profiling output
* update logic if forked process is not successful, output is
displayed directly with INFO logging or lower; also dispaly output
in ERROR mode if the process fails
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-03-11 14:19:01 -05:00
dcdef37c34
remove duplicate process output within run_prof()
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-03-11 14:19:01 -05:00
61267ee262
include ERROR delimiter directly for console_error() messsages
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-03-11 14:19:01 -05:00
cc7a725ae8
add a profileMode option to capture_subprocess_output() - includes
...
indented output with profiler selection when enabled
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-03-11 14:19:01 -05:00
6bb4210d94
minor refactor of print_status()
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-03-11 14:19:01 -05:00
63129e4247
add indent support to console_log()
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-03-11 14:19:01 -05:00
6c5a3623b6
Fix dangling merge conflict
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-11 14:19:01 -05:00
f2aac37178
Fix python formatting
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-11 14:19:01 -05:00
233905071c
Dedicated logging function for each log level
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-11 14:19:01 -05:00
f4511e7280
Force encoding before Omniperf execution ( #299 )
...
* Force encoding before Omniperf execution
Signed-off-by: colramos-amd <colramos@amd.com >
* Fix circular dependency in utils module
Signed-off-by: colramos-amd <colramos@amd.com >
---------
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-06 17:01:07 -06:00
ea9783f105
Fix typo, patch issue in kernel filtering in standalone GUI, and error on version mismatch
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-03 14:38:28 -06:00
1c3e7598a6
Remove hardcoded gfx90a in gen_sysinfo util
...
Signed-off-by: coleramos425 <colramos@amd.com >
2024-03-01 15:50:42 -06:00
d6f45411eb
Python formatting
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-01 15:50:42 -06:00
200961ffd9
Re-implement machine-specs to contain documentation, units, etc. Print using tabulate
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
2024-03-01 15:50:42 -06:00
18dfc35c14
typo
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
2024-03-01 15:50:42 -06:00
a70dc4999d
Hide L2Banks in sysinfo and update roofline module
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-01 15:50:42 -06:00
86b6c8e848
Renaming global spec vars. Replacing L2Banks with total_l2_chan ( #251 )
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-01 15:50:42 -06:00
3b1b8d7b5b
Reorganize the specs module to reduce duplicate code
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-01 15:50:42 -06:00
76873dd0c4
more code formatting updates
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-02-22 16:02:25 -06:00
852cc13f2a
Fix clocks ( #246 )
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Co-authored-by: Nicholas Curtis <nicurtis@amd.com >
2024-02-13 20:22:11 -06:00
c60f031558
Fix hbmBW calculation, ( #243 )
...
* Fix hbmBW calculation, currently we're reading the wrong value of the mclk out of rocm-smi
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
* Fix for earlier smi
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
---------
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Co-authored-by: Nicholas Curtis <nicurtis@amd.com >
2024-02-13 20:19:56 -06:00
7bb211a465
Fix logic for roofline field in sysinfo
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-12 17:07:55 -06:00
33a2cd34ce
Revert sbios fix. Catch commas
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-08 12:52:07 -06:00
d16f58b797
Add numPipes built-in-var for updated metrics
...
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-06 16:19:40 -06:00
9b464503fe
Fix reporting of --roof-only runs in sys_info
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-04 12:44:47 -06:00
f44ce21252
profile: fix parsing tcc per channel on mi300 ( #234 )
...
Co-authored-by: fei.zheng <fei.zheng@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
2024-01-31 09:34:50 -06:00
e1867d34d3
Enable database mode
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-01-30 10:43:30 -06:00
a1bfa83764
Patch roofline debug logging
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-01-29 10:22:37 -06:00
911943acee
Add missing input file to Mi300 flattening
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-01-26 10:32:13 -06:00
Ben Richard
coleramos425
Karl W Schulz
Karl W. Schulz
Nicholas Curtis
Nick Curtis