AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
6,602 Commits 3 Branches 0 Tags
fc3f04fa7dea938420ff523eabcc97ccfcf2511f
Commit Graph

78 Commits

Author SHA1 Message Date
pghafari a20fb7d571 SWDEV-342010 - in progress keeping track of events 
Change-Id: Ic87e4b46d4eebe9922a34af5867e9fc32fcb4066


[ROCm/clr commit: ec16be77fc]
 2022-08-22 03:45:57 -04:00
Rakesh Roy 7d378eccef SWDEV-342025 - Fix hipEventCreateWithFlags API 
- Return hipErrorInvalidValue if hipEventInterprocess flag is set, but hipEventDisableTiming flag isn't set

Change-Id: Ifbb9d83b018c360f312083bb25dba1187bcdaefa


[ROCm/clr commit: 21d7f35c84]
 2022-06-21 10:59:17 -04:00
Saleel Kudchadker d0e5a9583a SWDEV-335780 - Revert commit 
This reverts commit a206abcaa1.

Change-Id: I589d495b448a5ecc7def9dbca3f70b033a962f45


[ROCm/clr commit: 1cea2c0412]
 2022-06-14 19:08:22 -04:00
Satyanvesh Dittakavi a206abcaa1 SWDEV-335780 - Address OOM issue with BERT MLPerf 
Memory free was not happening due to no flush

Change-Id: Iee9d2c9f8c50aa9b6012ca9d8fd792a51973b8c8


[ROCm/clr commit: f6e21144ae]
 2022-05-11 13:03:32 -04:00
Jaydeep Patel 342d552ba7 SWDEV-333848 - Regression fix 
Change-Id: I328770d5c51418c7f5bcb73696c81311d8dc3aef


[ROCm/clr commit: 118fad741a]
 2022-04-29 13:27:46 -04:00
haoyuan2 558467643d SWDEV-333187 - Support IPC in HIP runtime on Windows 
enable shared memory based IPC

Change-Id: I2657ef4713240b6f82a34f416d53f222630263ca


[ROCm/clr commit: 59b1ae0a79]
 2022-04-27 11:14:59 -07:00
Sarbojit Sarkar e22f2e1714 SWDEV-323441 - support for default stream per thread 
Change-Id: I0032da0357f5cffbf5e4ec4a02435d2a128a262b


[ROCm/clr commit: fc1f02bbed]
 2022-04-18 23:19:55 -04:00
Saleel Kudchadker d4991641bd SWDEV-301667 - Add separate field for event scope 
Change-Id: I0e6b50d1a34b275ea4f1a4c659430c406d9a5a7e


[ROCm/clr commit: aace42cfab]
 2022-04-18 15:48:33 -04:00
Satyanvesh Dittakavi 3db2dd9812 SWDEV-332371 - Address seg fault with hip event tests on Windows 
Change-Id: I0367f6dbb395b3032c97692c5bde6e99d503c6a9


[ROCm/clr commit: 3b525ad298]
 2022-04-18 04:19:23 -04:00
Saleel Kudchadker 50f0103648 SWDEV-276210 - Honor scopes for hipEventRecord 
Honor hipEventReleaseToDevice and hipEventReleaseToSystem flags.
hipEventRecord would flush caches if no release flags are provided. To
change this behavior set ROC_EVENT_NO_FLUSH=1

Change-Id: I03e41b515b1d0cf963b0c2d5b9901b09e71a0e59


[ROCm/clr commit: f320acb797]
 2022-04-13 00:35:19 -04:00
Saleel Kudchadker eaa9ce833f SWDEV-301667 - Query event time directly 
Change-Id: I566bfa95b8b6fa2bd4771e0c20224a4e74d5abb8


[ROCm/clr commit: 73ff72bca9]
 2022-03-25 01:08:07 -04:00
Sarbojit Sarkar 8108b3dd74 SWDEV-327455 - Fix for event node crash 
Change-Id: I4418800f04450f1bd23cef4e7812631727458a3b


[ROCm/clr commit: 33687d8cab]
 2022-03-18 06:22:38 -04:00
anusha GodavarthySurya 76457e470d SWDEV-306833 - Refactor HIPEvent IPC code 
Change-Id: I118e41ac843d14fa3b42b4eb538c5d112dff1c03


[ROCm/clr commit: 1564f2cd77]
 2021-12-02 12:20:40 -05:00
German Andryeyev 8c508e5dba SWDEV-305016 - Check for HW event ready 
Runtime can skip the marker if HW event was completed already.

Change-Id: Ie9fbc08b06b375c5586cbe1aa93922f1880608e4


[ROCm/clr commit: 21a2fdb80a]
 2021-11-01 10:07:08 -04:00
anusha GodavarthySurya 9327ed2617 SWDEV-24806 - Fix windows dk build 
Change-Id: Iaa497c5736f300c71b63499fc218cfd7769d2e20


[ROCm/clr commit: 13ada9b193]
 2021-10-07 10:05:17 -07:00
anusha GodavarthySurya 26e317f519 SWDEV-24806 - Fix windows dk build 
Change-Id: Ie309da9dbbf5037510ec7e6913a711ea631d3df8


[ROCm/clr commit: 3a5c80386d]
 2021-10-06 22:52:44 -07:00
anusha GodavarthySurya 20e5aace05 SWDEV-24806 - Added support for event wait and event record graph APIs 
hip graph implementation for APIs AddEventRecordNode, AddEventWaitNode, EventRecordNodeGetEvent, EventWaitNodeGetEvent, EventRecordNodeSetEvent,EventWaitNodeSetEvent, ExecEventRecordNodeSetEvent, ExecEventWaitNodeSetEvent

Change-Id: Ifde51f4591067795d6cbf5595372cbdbd8a7bc26


[ROCm/clr commit: f6456c5e27]
 2021-10-06 00:31:42 -07:00
Julia Jiang 6883ccde42 SWDEV-286322 - Remove execution permission 
Change-Id: I96e603fc8d407c3a76fa1053bad81e45744b59ad


[ROCm/clr commit: 8835b897d5]
 2021-08-05 14:04:06 -04:00
Tao Sang eac431380a SWDEV-294591 - Fix hipEventIpc failure on NV 
make hipIpcOpenEventHandle has the same behavour of cudaIpcOpenEventHandle.

Change-Id: I3fe6dbc35a7b14ba9119df297b7885df83d28149


[ROCm/clr commit: c87a352288]
 2021-07-28 20:34:11 -04:00
agunashe fae697b4d6 SWDEV-293742 - Update copyrights end year for hipamd 
Change-Id: I08f620f84563a9214b59f1b943ed091b67229eab


[ROCm/clr commit: d9d9e81acb]
 2021-07-09 12:08:39 -04:00
Satyanvesh Dittakavi d1ed2e9a31 SWDEV-1 - Rearrange error conditions in elapsed time 
- when the first argument is null API should return hipErrorInvalidValue
- but when first and second argument both are null API was returning hipErrorInvalidHandle causing catch2 event tests to fail

Change-Id: I0978ce8b8462e4baa043be75a40b5bc45b036bb6


[ROCm/clr commit: 688288c2e3]
 2021-07-09 00:47:12 -04:00
German Andryeyev 03fa65d857 SWDEV-292018 - Make sure start event is done 
HSA signal callback order is undefined. Make sure start event is
also done before calculating the elapsed time.

Change-Id: Ic69bfe336b20cd62ef35194261a5d0d234bc65ce


[ROCm/clr commit: 910d8bdfde]
 2021-06-24 20:02:54 -04:00
German Andryeyev e7580989cc SWDEV-290160 - Add blocking command for callbacks in IPC and graph 
Change-Id: I1474e19db6ebf2559e1b2c8dd7d06139bd699835


[ROCm/clr commit: 52f5b0fa16]
 2021-06-24 17:01:55 -04:00
German Andryeyev 08611a1fe4 SWDEV-290367 - Make sure HIP checks for GPU signal 
Check GPU signal status for event before falling into CPU command
status validation

Change-Id: I66f15752d7dca550c0fa1a2252ec5a63817391c3


[ROCm/clr commit: dd8265fc87]
 2021-06-11 16:40:00 -04:00
Saleel Kudchadker 9381438151 SWDEV-247372 - Always enable marker_ts_ events 
Change-Id: I7579ba1ee228809ce38f6f130fb33f1164587903


[ROCm/clr commit: 712963a97e]
 2021-06-11 00:04:21 -04:00
Rahul Garg dd95d3d23c ROCMOPS-1956 - Push restructured code to hipamd 
hipamd will have AMD's ROCCLR based HIP backend implementation

Change-Id: Id7de9634519b4ce46fca71a1b61f3d5b1e3fc459


[ROCm/clr commit: 19c84bc604]
 2021-06-07 21:42:44 +00:00
Tao Sang 6227f3fae2 Remove hip-hcc codes: Part one 
Remove hip-hcc codes from hip code base
Simplify hip CMakeLists.txt to exclude hip-hcc
Simplify cmake cmd for hip-rocclr building
Some minor fixes

Change-Id: I1ae357ecfd638d6c25bca293c1724b026be21ecd


[ROCm/clr commit: 1cba7ec965]
 2020-12-09 15:49:47 -05:00
Jeff Daily 8b0a909b2b add IPC event support (#1996) 
[ROCm/clr commit: e943144b31]
 2020-04-17 10:31:22 +05:30
Sarbojit2019 77fd519260 hipEventElapsedTime should respect device (#1992) 
Fixes SWDEV-228636.
Also added a unit test to verify this.

[ROCm/clr commit: 3523219b43]
 2020-04-06 15:38:25 +05:30
Evgeny Mankov d191980c6a [HIP] Clean-up deprecated HIP error codes 
hipErrorMemoryAllocation -> hipErrorOutOfMemory
hipErrorInitializationError -> hipErrorNotInitialized
hipErrorMapBufferObjectFailed -> hipErrorMapFailed
hipErrorInvalidResourceHandle -> hipErrorInvalidHandle


[ROCm/clr commit: 4aaa2336a8]
 2019-12-23 17:01:35 +03:00
Sarbojit2019 7d5bc56ab7 Added null check in hipEventSynchronize (#1627) 
* Added missing null check in hipEventSynchronize
* Minor correction in the Event API description


[ROCm/clr commit: 7985ad218f]
 2019-11-18 12:18:55 +05:30
Jeff Daily 39a98df790 hipEventRecord only needs one lock; remove locked_eventIsReady 
[ROCm/clr commit: b2af1820f5]
 2019-11-06 15:56:32 +00:00
Jeff Daily 539d0c2ae3 remove ihipEvent_t::refreshEventStatus(), new hipEventElapsedTime 
This fixes possible races in hipEventElapsedTime.


[ROCm/clr commit: 444122dfb9]
 2019-11-06 15:46:46 +00:00
Jeff Daily f7e255c3c4 fix race condition in hipEventRecord 
[ROCm/clr commit: 6c3479a155]
 2019-11-04 17:45:11 +00:00
Jeff Daily df457ce2bd remove stream locks where it is safe to do so 
[ROCm/clr commit: 734c4b92c3]
 2019-07-22 17:38:51 +00:00
Anusha Godavarthy Surya 27722855b4 Added missing NULL checks 
[ROCm/clr commit: 1a7c7e3b06]
 2019-06-27 20:19:30 +05:30
Anusha Godavarthy Surya e643bae27d Added missing NULL checks and corrected API return values as per validation 
[ROCm/clr commit: 4989452413]
 2019-06-27 00:19:05 +05:30
Evgeny 96b7f0404e renaming HIP_INIT_CB_API to HIP_INIT_API 
[ROCm/clr commit: e362688adf]
 2018-11-13 15:33:26 +00:00
Evgeny 7519b3f75e adding activity prof layer 
[ROCm/clr commit: 084a68be63]
 2018-11-13 15:33:26 +00:00
Maneesh Gupta 46ddefedee Apply .clangformat to all repo source files 
Change-Id: I7e79c6058f0303f9a98911e3b7dd2e8596079344


[ROCm/clr commit: 9e47fccc89]
 2018-03-12 11:29:03 +05:30
Ben Sander 2c95d48f87 Check for null event in hipEventElapsedTime 
[ROCm/clr commit: e71456cc6c]
 2017-11-06 23:49:31 +00:00
Ben Sander 379b3fc7a0 Make hipEvent_t thread safe. 
Support re-recording of same event by different threads.

- Add criticalData structure to hipEvent_t, similar to mechanism used
  for streams, contexts, device.  Events are always locked
  after streams to avoid deadlock.
- ihipEvent_t::locked_copyCrit can be used to copy critical state
  including marker.  The critical state in the event can then
  be re-recorded.
- refactor hipEventElapsedTime.  Remmove stale debug code, native signal
  refs.


[ROCm/clr commit: 955cfbfdc7]
 2017-11-06 23:49:25 +00:00
Maneesh Gupta db9b583cb6 Merge pull request #251 from ROCm-Developer-Tools/fix_event_state 
Set event state AFTER it is recorded.

[ROCm/clr commit: dbb6b2bab8]
 2017-11-06 07:28:11 +05:30
Ben Sander 0c5ce41d7c Set event state AFTER it is recorded. 
[ROCm/clr commit: 1c65bb1684]
 2017-11-05 10:33:18 -06:00
Ben Sander 6e82cc25df Add HIP_DB=warn + message if sync on dangerous event. 
[ROCm/clr commit: 172b9f96e6]
 2017-11-01 10:44:34 -07:00
Ben Sander 070bdb3736 Lock streams when waiting on event completion or querying event safety. 
[ROCm/clr commit: bc9ba7cd81]
 2017-08-28 18:40:16 -05:00
Ben Sander 967ca1a44e Add some new HIP_TRACE_API options. 
[ROCm/clr commit: d6aee9ad8f]
 2017-08-16 04:00:33 +00:00
Maneesh Gupta a73a17763d Don't crash for hipEventDestroy(NULL) 
Change-Id: I3f4de1ad2712dbe8af81e10c5d3bef16d468c582


[ROCm/clr commit: 21de66889c]
 2017-07-18 11:01:02 +05:30
Ben Sander 7237ed04f3 Fix HIP_SYNC_NULL_STREAM=0 mode. 
- Fix null-stream sync
- hipStreamDestroy of null stream returns hipErrorInvalidResourceHandle
- Update documentation.
- Add tests for null stream sync, hipEventElapsedTime.
- Rename internal enum hipEventStatusRecorded to hipEventStatusComplete
- refactor hipStreamWaitEvent to streamline control-flow


[ROCm/clr commit: 823281dcba]
 2017-06-05 08:50:22 -05:00
Ben Sander 81354999e8 Set event->_stream on hipHccModuleLaunchKernel path if start/stop used 
Ensure _stream is always non-null in recorded events.
Fixes isDefaultStream fault.


[ROCm/clr commit: 6cc5dc0326]
 2017-05-30 21:55:46 -05:00