Commit Graph

74713 Commits

Author SHA1 Message Date
Bindhiya Kanangot Balakrishnan 9d0ce8ba42 [SWDEV-414304] Reduce excessive hwmon operations
Previously, the function was iterating through all enum
values(0-250). This fix reduces the number of hwmon operations
by calling add_temp_sensor_entry only for temperature types
that fall within the defined enum ranges.

Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>


[ROCm/amdsmi commit: 17ffe5a1bd]
2025-09-09 10:30:51 -05:00
Joseph Macaranas 5f517d37ee Add DVC setup step to Windows CI workflow (#890)
To coordinate with changes in ROCm/TheRock#1358
2025-09-09 11:29:01 -04:00
Park, Peter 5e92adc5b3 [SWDEV-551318] Add doc about RAS / CPER (#636)
* add doc about ras/cper
* add sample code examples for CPER and AFID
---------

Signed-off-by: Park, Peter <Peter.Park@amd.com>
Signed-off-by: Arif, Maisam <Maisam.Arif@amd.com>
Co-authored-by: Oosman Saeed <oossaeed@amd.com>
2025-09-09 10:27:15 -05:00
Park, Peter 0f75c19e4d [SWDEV-551318] Add doc about RAS / CPER (#636)
* add doc about ras/cper
* add sample code examples for CPER and AFID
---------

Signed-off-by: Park, Peter <Peter.Park@amd.com>
Signed-off-by: Arif, Maisam <Maisam.Arif@amd.com>
Co-authored-by: Oosman Saeed <oossaeed@amd.com>

[ROCm/amdsmi commit: 5e92adc5b3]
2025-09-09 10:27:15 -05:00
Kanangot Balakrishnan, Bindhiya edaae978a2 [SWDEV-553557] Add bad_page_threshold_exceeded to RAS (#677)
Added bad_page_threshold_exceeded field to ras, which
compares retired pages count against bad page threshold.
This field displays True if retired pages exceed the
threshold, False if within threshold, or N/A if
threshold data is unavailable.

---------

Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>
Signed-off-by: Arif, Maisam <Maisam.Arif@amd.com>
Co-authored-by: Arif, Maisam <Maisam.Arif@amd.com>
2025-09-09 09:15:37 -05:00
Kanangot Balakrishnan, Bindhiya e5ba10d4c2 [SWDEV-553557] Add bad_page_threshold_exceeded to RAS (#677)
Added bad_page_threshold_exceeded field to ras, which
compares retired pages count against bad page threshold.
This field displays True if retired pages exceed the
threshold, False if within threshold, or N/A if
threshold data is unavailable.

---------

Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>
Signed-off-by: Arif, Maisam <Maisam.Arif@amd.com>
Co-authored-by: Arif, Maisam <Maisam.Arif@amd.com>

[ROCm/amdsmi commit: edaae978a2]
2025-09-09 09:15:37 -05:00
vedithal-amd 4238ddb185 Add unsupported counters for rocprofv1 (#889) 2025-09-09 09:42:08 -04:00
ggottipa-amd f6b5c45723 Enclosing copyright headers in /**/ (#894) 2025-09-09 18:56:57 +05:30
systems-assistant[bot] d341a6263a Put safeguard to avoid defining target more than once
authored-by: Mathieu Taillefumier <mathieu.taillefumier@free.fr>
2025-09-09 13:51:15 +01:00
ggottipa-amd 70907c7810 Users/ggottipa amd/copyright header inclusion (#892)
* Including copyright headers.

* license block is properly enclosed in /* ... */
2025-09-09 13:10:57 +05:30
Satyanvesh Dittakavi 85065dab32 SWDEV-550521 - Add the JIT options for HIPRTC linker APIs (#762)
* SWDEV-550521 - Add the JIT options for HIPRTC linker APIs

* Address review comments about using C++ datatypes
2025-09-09 12:24:08 +05:30
systems-assistant[bot] 662ee1c7e1 SWDEV-543997 - Expose numXCC device property in hipGetDevicePropertie… (#527)
* SWDEV-543997 - Expose numXCC device property in hipGetDeviceProperties api

* SWDEV-543997 - Expose numXCC device property in hipGetDeviceProperties api

---------

Co-authored-by: Anavena Venkatesh <Anavena.Venkatesh@amd.com>
Co-authored-by: systems-assistant[bot] <systems-assistant[bot]@users.noreply.github.com>
Co-authored-by: jainprad <92369414+jainprad@users.noreply.github.com>
2025-09-09 11:27:28 +05:30
ggottipa-amd 5288d47275 Including copyright headers. (#879) 2025-09-09 11:02:47 +05:30
Ioannis Assiouras 4c6fce8ba0 SWDEV-546223 - Remove comgr query for image support from windows path (#861) 2025-09-09 07:54:48 +05:30
Flora Cui e7cb108a5e [rocr-runtime] Add support for WSL DXG devices (#854)
* rocr/rocdxg: add rocdxg support

* rocr/dxg: set flags for dxg env

* rocr: ring doorbell for dtif/dxg

* rocr/dxg: sdma changes

1. align command size to 64
2. call hsaKmtQueueRingDoorbell
3. disable gcr && hdp flush


Signed-off-by: Flora Cui <flora.cui@amd.com>
Signed-off-by: Horatio Zhang <Hongkun.Zhang@amd.com>
Signed-off-by: tiancyin <tianci.yin@amd.com>
Signed-off-by: Longlong Yao <Longlong.Yao@amd.com>
2025-09-09 10:16:57 +08:00
SaleelK e197aa83ba SWDEV-543723 - Execute permission for kernArg buf (#728)
- Refactor deviceLocalAlloc arguments
- Refactor hostAlloc code, have cleaner interface
- Kern args buffer need to have execute flag set as CP enforces this on
  certain newer HW.
2025-09-08 12:21:30 -07:00
systems-assistant[bot] dcc526e1fd SWDEV-545947 - Tests for hipSetValidDevices (#534)
* SWDEV-545947 - Tests for hipSetValidDevices

* SWDEV-546342 - [catch2][dtest] Additional Test cases for hipSetValidDevices

* Address psdb issues

* Correct the negative test case

---------

Co-authored-by: Satyanvesh Dittakavi <Satyanvesh.Dittakavi@amd.com>
Co-authored-by: Rambabu Swargam <rambabu.swargam@amd.com>
Co-authored-by: systems-assistant[bot] <systems-assistant[bot]@users.noreply.github.com>
Co-authored-by: jainprad <92369414+jainprad@users.noreply.github.com>
2025-09-09 00:05:25 +05:30
systems-assistant[bot] d58adf96da [DOC] TUI kernel selection (#94) 2025-09-08 13:52:39 -04:00
yugang-amd e0fb92c2e2 Update descriptions about hardware support (#236)
[ROCm/rocshmem commit: b3e2e72f29]
2025-09-08 13:26:05 -04:00
yugang-amd b3e2e72f29 Update descriptions about hardware support (#236) 2025-09-08 13:26:05 -04:00
systems-assistant[bot] e84f93ea3b SWDEV-544502 - Fixes in Unit_hipMallocManaged_MGpuMThread (#538)
Co-authored-by: Ioannis Assiouras <Ioannis.Assiouras@amd.com>
2025-09-08 16:56:59 +01:00
Yiltan 9b8404693c Implemented workgroup puts (#238)
[ROCm/rocshmem commit: 58f96af7ec]
2025-09-08 10:57:39 -04:00
Yiltan 58f96af7ec Implemented workgroup puts (#238) 2025-09-08 10:57:39 -04:00
Aurelien Bouteiller fb7d89c7e6 Cleanup/remove a2a buff (#232)
* Do not allocate a large unused buffer for alltoall

* Remove ATA_MAX_WRKDATA_SIZE from include/rocshmem_common.hpp

[ROCm/rocshmem commit: 30ba79bcad]
2025-09-08 10:55:06 -04:00
Aurelien Bouteiller 30ba79bcad Cleanup/remove a2a buff (#232)
* Do not allocate a large unused buffer for alltoall

* Remove ATA_MAX_WRKDATA_SIZE from include/rocshmem_common.hpp
2025-09-08 10:55:06 -04:00
abchoudh-amd 682ae2d014 Streamline --list-metrics command line option in rocprof-compute (#310)
* Remove L2 channels from --list-metrics

--list-metrics moved to general options

List metrics for the current architecture

Filter blocks for metrics

Removed test for --list-metrics in profile mode

Test the options don't throw error

Fixed --config-dir error

Test stdout for command line options

Provide path list for loading panel configs

Show L2 Cache (per) channel metrics

Changed command line option names

Can show two levels only

Removed filtering blocks

Moved blocks to original position

Removed filter block tests

Removed filtering

Formaating fix

Readability enhancement

Test formatting

Filter L2 channels without sysinfo

Show avilable metrics for current arch

Intermediate commit

Fixed tests

Added argument sanitization

Added list_metrics to ctest

merge iconflict resolution

Updated test marker

Updated changelog

Fixed formatting

* Updated docs
2025-09-08 20:21:46 +05:30
vstojilj f17e332fe0 Release graph if hipStreamEndCapture fails (#738) 2025-09-08 16:32:03 +02:00
ywang103-amd c9b1ad72a5 scientific notion of memchart(CLI, TUI and GUI) (#764) 2025-09-08 01:30:30 -04:00
AL Musaffar, Yazen 4a8ee27225 [SWDEV-545894] Folder name defaulting to lower case fix (#611)
* Folder name defaulting to lower case

* Update amdsmi_cli/amdsmi_cli.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Pham, Gabriel <Gabriel.Pham@amd.com>

* Fixed Based On Comments

* Remove unused variable 'skip_next'

Signed-off-by: AL Musaffar, Yazen <Yazen.ALMusaffar@amd.com>

---------

Signed-off-by: Pham, Gabriel <Gabriel.Pham@amd.com>
Signed-off-by: AL Musaffar, Yazen <Yazen.ALMusaffar@amd.com>
Co-authored-by: yalmusaf_amdeng <yalmusaf@amd.com>
Co-authored-by: Pham, Gabriel <Gabriel.Pham@amd.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-09-07 20:38:29 -05:00
AL Musaffar, Yazen 851354429f [SWDEV-545894] Folder name defaulting to lower case fix (#611)
* Folder name defaulting to lower case

* Update amdsmi_cli/amdsmi_cli.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Pham, Gabriel <Gabriel.Pham@amd.com>

* Fixed Based On Comments

* Remove unused variable 'skip_next'

Signed-off-by: AL Musaffar, Yazen <Yazen.ALMusaffar@amd.com>

---------

Signed-off-by: Pham, Gabriel <Gabriel.Pham@amd.com>
Signed-off-by: AL Musaffar, Yazen <Yazen.ALMusaffar@amd.com>
Co-authored-by: yalmusaf_amdeng <yalmusaf@amd.com>
Co-authored-by: Pham, Gabriel <Gabriel.Pham@amd.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

[ROCm/amdsmi commit: 4a8ee27225]
2025-09-07 20:38:29 -05:00
hkasivis a5713c85bb Users/hkasivis/sync kfd ioctl header (#848)
* libhsakmt: Update ioctl version to 1.18

Sync with kernel ioctl version.

Also explicitly set the ioctl flag to KFD_PROC_FLAG_MFMA_HIGH_PRECISION

Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>

* libhsakmt: Sync ioctl header by adding kfd_ioctl_profiler

Sync with kernel ioctl version. Add kfd_ioctl_profiler.

Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>

---------

Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
2025-09-07 20:04:31 -04:00
cfallows-amd 2e750763e7 Fix file naming for roofline PDF outputs when using --kernel (#803)
Move check for kernel filtering to add to roofline pdfs- was originally only labelling pdfs with the filtered kernel names from --kernel when --kernel-names was called, we want it at all times when kernels are filtered. 

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-09-06 02:34:51 -04:00
Galantsev, Dmitrii 0cd05bf307 Create run-clang-tidy.sh
Change-Id: I4faa950a59434ba4706da581af51dd8a7e071dcb
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-09-05 17:44:17 -05:00
Galantsev, Dmitrii d0b5e20440 Create run-clang-tidy.sh
Change-Id: I4faa950a59434ba4706da581af51dd8a7e071dcb
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/amdsmi commit: 0cd05bf307]
2025-09-05 17:44:17 -05:00
Galantsev, Dmitrii 85e37bb6ce Add extra element to array for bounds checking
Decrement padding to keep struct size the same

Change-Id: I4bea5d4b4d5c908423c7cc55a7e8c404b4a6b5e8
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-09-05 17:44:17 -05:00
Galantsev, Dmitrii 7bbfc98588 Add extra element to array for bounds checking
Decrement padding to keep struct size the same

Change-Id: I4bea5d4b4d5c908423c7cc55a7e8c404b4a6b5e8
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/amdsmi commit: 85e37bb6ce]
2025-09-05 17:44:17 -05:00
Galantsev, Dmitrii 20bc3aeeef Ignore more warnings in clang and clang-tidy
Change-Id: I6f7c7e478f0f176da550d5bccf833dae1a4f1878
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-09-05 17:44:17 -05:00
Galantsev, Dmitrii 6797de3ed5 Ignore more warnings in clang and clang-tidy
Change-Id: I6f7c7e478f0f176da550d5bccf833dae1a4f1878
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/amdsmi commit: 20bc3aeeef]
2025-09-05 17:44:17 -05:00
Galantsev, Dmitrii aba1c792b4 Clean up clang-tidy warnings and unused variables
Change-Id: I1365edf8926908b3a49652fb87f079f8fbf1f56b
2025-09-05 17:44:17 -05:00
Galantsev, Dmitrii 74efdc57a7 Clean up clang-tidy warnings and unused variables
Change-Id: I1365edf8926908b3a49652fb87f079f8fbf1f56b


[ROCm/amdsmi commit: aba1c792b4]
2025-09-05 17:44:17 -05:00
Mario Limonciello (AMD) 66eb189396 Remove an impossible check
amdsmi/tests/amd_smi_test/functional/memorypartition_read_write.cc:453:32: warning: the address of ‘orig_memory_partition’ will never be NULL [-Waddress]
  453 |     if ((orig_memory_partition == nullptr) ||
      |          ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~

Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
2025-09-05 17:44:17 -05:00
Mario Limonciello (AMD) 3a7b4a283a Remove an impossible check
amdsmi/tests/amd_smi_test/functional/memorypartition_read_write.cc:453:32: warning: the address of ‘orig_memory_partition’ will never be NULL [-Waddress]
  453 |     if ((orig_memory_partition == nullptr) ||
      |          ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~

Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>


[ROCm/amdsmi commit: 66eb189396]
2025-09-05 17:44:17 -05:00
Mario Limonciello (AMD) eacec681dd Use nested namespace for amd::smi
Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
2025-09-05 17:44:17 -05:00
Mario Limonciello (AMD) 0c7c849c42 Use nested namespace for amd::smi
Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>


[ROCm/amdsmi commit: eacec681dd]
2025-09-05 17:44:17 -05:00
Mario Limonciello (AMD) 4a863b27ab Drop an unnecessary NULL comparison
warning: the address of ‘amdsmi_asic_info_t::vendor_name’ will never be NULL [-Waddress]

Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
2025-09-05 17:44:17 -05:00
Mario Limonciello (AMD) 47b2e80ab8 Drop an unnecessary NULL comparison
warning: the address of ‘amdsmi_asic_info_t::vendor_name’ will never be NULL [-Waddress]

Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>


[ROCm/amdsmi commit: 4a863b27ab]
2025-09-05 17:44:17 -05:00
Mario Limonciello (AMD) a15bad1c9e Fix a comparison between signed and unsigned integer
Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
2025-09-05 17:44:17 -05:00
Mario Limonciello (AMD) 02b357526b Fix a comparison between signed and unsigned integer
Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>


[ROCm/amdsmi commit: a15bad1c9e]
2025-09-05 17:44:17 -05:00
Mario Limonciello (AMD) a99e827d97 Drop unused variables
Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
2025-09-05 17:44:17 -05:00
Mario Limonciello (AMD) 08eec3c675 Drop unused variables
Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>


[ROCm/amdsmi commit: a99e827d97]
2025-09-05 17:44:17 -05:00