Ben Sander
5933ca7300
Fix some cppcheck style issues.
2017-12-01 20:45:34 +00:00
Ben Sander
743c54a012
Fix warning from default cppchek.
2017-12-01 20:45:33 +00:00
Ben Sander
1a6727e2fc
Merge pull request #246 from AlexVlx/feature_use_module_based_dispatch_instead_of_pfe
...
Use natural dispatch syntax
2017-12-01 14:21:25 -06:00
foreman
7a79256506
P4 to Git Change 1489221 by johtaylo@johtaylo-jtincrementor2-increment on 2017/12/01 03:00:05
...
SWDEV-2 - Change OpenCL version number from 2547 to 2548.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2295 edit
2017-12-01 03:06:44 -05:00
foreman
f6b43efd00
P4 to Git Change 1488953 by wchau@wchau_OCL_boltzmann on 2017/11/30 15:44:58
...
SWDEV-119491 - Add support for cl_amd_assembly_program extension - Enabling Extension
This is the last part of the following four requirements:
(1) OpenCL API / Runtime (CL1487653), (2) ROCm Runtime - compiler invocation (CL1487815), (3) ROCm Driver (CL1488115), (4) Enabling Extension
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocsettings.cpp#29 edit
2017-11-30 16:04:19 -05:00
Jenkins
f83f9f2916
Merge 'master' into 'amd-master'
...
Change-Id: I1bb9891e5cb4b85f2f265a8723cf16bb631904f3
2017-11-30 04:11:08 -06:00
foreman
7969ad569d
P4 to Git Change 1488675 by johtaylo@johtaylo-jtincrementor2-increment on 2017/11/30 03:00:05
...
SWDEV-2 - Change OpenCL version number from 2546 to 2547.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2294 edit
2017-11-30 03:06:16 -05:00
Alex Voicu
33bb425013
Fix legacy mode detection of the address of an agent allocated variable. In this mode, there exist two executables per each code object, one created by HCC and one created by HIP. Since we dispatch through HCC in legacy mode, we should obtain the address for an agent allocated variable from the latter's executable. Also add two omitted validity checks, whose absence could lead to segfaults when the current process had no .kernel section and / or when an invalid or empty blob was extracted from the latter.
2017-11-30 03:29:04 +00:00
Alex Voicu
2e39534377
Add missing space (the final frontier).
2017-11-29 21:50:43 +00:00
Alex Voicu
4966518846
Revert "Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions."
...
This reverts commit 4792475
2017-11-29 21:49:10 +00:00
Alex Voicu
92e80f0943
Use a much simpler guard for version 1.6, which allows for direct CUDA indexing to be used.
2017-11-29 21:47:04 +00:00
Alex Voicu
30e4d445b1
Merge branch 'feature_use_module_based_dispatch_instead_of_pfe' of https://github.com/AlexVlx/HIP into feature_use_module_based_dispatch_instead_of_pfe
2017-11-29 21:45:56 +00:00
Alex Voicu
2557000b56
Revert "Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions."
...
This reverts commit d2fd1f5
2017-11-29 21:36:29 +00:00
Ben Sander
2f542c46c8
Merge pull request #275 from mangupta/bump_version_1.5
...
Bumped HIP version to 1.5 and updated summary in HIP release notes
2017-11-29 15:06:02 -06:00
Alex Voicu
4792475d01
Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions.
2017-11-29 21:01:28 +00:00
Maneesh Gupta
2d5e0274ef
Bumped HIP version to 1.5 and updated summary in HIP release notes
...
Change-Id: I4b612da88236674fac2c585ab6891bdd495511b0
2017-11-29 13:56:17 +05:30
foreman
6bd1e02aa0
P4 to Git Change 1488107 by johtaylo@johtaylo-jtincrementor2-increment on 2017/11/29 03:00:04
...
SWDEV-2 - Change OpenCL version number from 2545 to 2546.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2293 edit
2017-11-29 03:06:04 -05:00
Alex Voicu
93e595c267
Fix compiler version check.
2017-11-29 03:05:53 +00:00
Alex Voicu
e305d3fc94
Add missing file.
2017-11-29 02:16:44 +00:00
Alex Voicu
37c1811b2a
Fix oversight in selection mechanism which led to erroneous code to be compiled for the grid_launch_GGL component.
2017-11-29 01:37:52 +00:00
Alex Voicu
c6ab6f292b
Choose whether or not to use functional grid_launch based on the version of HCC used to compile.
2017-11-29 00:17:44 +00:00
foreman
a5884cdbf4
P4 to Git Change 1487815 by emankov@em-hsa-lightning on 2017/11/28 16:19:33
...
SWDEV-134396 - cl_amd_assembly_program extension support. Part 2 of 4. Rocm Runtime: Compiler invocation.
precheckin:
http://ocltc.amd.com:8111/viewModification.html?modId=94552&personal=true&init=1&tab=vcsModificationBuilds
reviewed by:
German Andryeyev
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/lib/include/v0_8/aclEnums.h#27 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/roccompiler.cpp#40 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.cpp#77 edit
2017-11-28 16:25:11 -05:00
Alex Voicu
45a9f4f7b1
Remove leftover agent allocated globals.
2017-11-28 19:56:04 +00:00
Alex Voicu
d5c8de3f41
Change memset kernel to use memcpy instead of placement new. Simplify indexers.
2017-11-28 19:45:47 +00:00
Alex Voicu
6a0efb7ed2
Re-sync with upstream and re-factor platform global management for texture references.
2017-11-28 19:15:29 +00:00
Alex Voicu
d37a5a6008
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
# Conflicts:
# src/hip_module.cpp
2017-11-28 17:29:11 +00:00
Maneesh Gupta
cc418da654
Fix float2int rounding functions
...
Change-Id: I67943859a6344c5eec0eaa23418c9b802ef72468
2017-11-28 17:23:43 +00:00
Alex Voicu
bb35299560
This actually (tries) to do the right thing all the way, by using memcpy for bitcasting, and not rely on undefined behaviour of a different flavour as a substitute for the original undefined behaviour. Note that the compiler will (should) optimise down to the same emitted code, since this is a pattern it understands.
2017-11-28 17:23:06 +00:00
Alex Voicu
4b7cb0624e
This fixes some outright quaint choices made when implementing HIP's bitwise conversion functions, by using simple reinterpret_casts, as is idiomatic. These functions are supposed to be re-entrant, correct and efficient. Sadly, they were neither: they hid a massive race condition against a value stored in global memory, which means that they were also unreasonably slow if they ever managed to be correct, and relied on union based type punning which is in a grey area of the standard. It is difficult to ascertain what may have been the reason for coming up with this quirky solution.
2017-11-28 17:23:06 +00:00
Chris Kitching
7761f63bbc
Add hipify mappings for all CUDA headers that have HIP equivalents
...
I'm particularly running into issues with `device_types.h` in real
CUDA code...
2017-11-28 17:23:06 +00:00
foreman
ea28466b7b
P4 to Git Change 1487653 by wchau@wchau_OCL_boltzmann on 2017/11/28 11:28:09
...
SWDEV-119491 - Add support for cl_amd_assembly_program extension
This is a sub-task of SWDEV-134396. Part 1/4 of the required changes:
(1) OpenCL API / Runtime, (2) ROCm Runtime - compiler invocation, (3) ROCm Driver, (4) Enabling Extension
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_common.hpp#19 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_context.cpp#57 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_program.cpp#45 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/khronos/headers/opencl1.2/CL/cl_ext.h#19 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/khronos/headers/opencl2.0/CL/cl_ext.h#35 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/khronos/headers/opencl2.1/CL/cl_ext.h#12 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/khronos/headers/opencl2.2/CL/cl_ext.h#6 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.cpp#215 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#293 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/program.cpp#90 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/program.hpp#42 edit
2017-11-28 11:41:42 -05:00
foreman
1f86279494
P4 to Git Change 1487653 by wchau@wchau_OCL_boltzmann on 2017/11/28 11:28:09
...
SWDEV-119491 - Add support for cl_amd_assembly_program extension
This is a sub-task of SWDEV-134396. Part 1/4 of the required changes:
(1) OpenCL API / Runtime, (2) ROCm Runtime - compiler invocation, (3) ROCm Driver, (4) Enabling Extension
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_common.hpp#19 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_context.cpp#57 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_program.cpp#45 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/khronos/headers/opencl1.2/CL/cl_ext.h#19 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/khronos/headers/opencl2.0/CL/cl_ext.h#35 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/khronos/headers/opencl2.1/CL/cl_ext.h#12 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/khronos/headers/opencl2.2/CL/cl_ext.h#6 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.cpp#215 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#293 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/program.cpp#90 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/program.hpp#42 edit
2017-11-28 11:41:42 -05:00
foreman
e304c22316
P4 to Git Change 1487650 by wchau@wchau_OCL_boltzmann on 2017/11/28 11:21:33
...
SWDEV-139422 - Lexa Linux Support - OCL
- fixed the OpenCL/LC sanity failures on Windows by adding support of Polaris12 in Settings::create()
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palsettings.cpp#38 edit
2017-11-28 11:37:01 -05:00
Jenkins
9e953711e4
Merge 'master' into 'amd-master'
...
Change-Id: I0dccd195692aea64254d91bb899c093459b376b9
2017-11-28 04:11:35 -06:00
foreman
57eac2965e
P4 to Git Change 1487469 by johtaylo@johtaylo-jtincrementor2-increment on 2017/11/28 03:00:04
...
SWDEV-2 - Change OpenCL version number from 2544 to 2545.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2292 edit
2017-11-28 03:07:17 -05:00
Ben Sander
e93a24bdbe
Merge pull request #256 from gargrahul/texture_driver_api_support
...
Texture driver APIs support
2017-11-27 13:52:39 -06:00
Rahul Garg
6c18df987d
Added note in Release notes for texture driver APIs
2017-11-27 22:06:50 +05:30
Evgeny Mankov
f55bfb60f3
Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP
2017-11-27 17:33:48 +03:00
Evgeny Mankov
b25d199111
Merge pull request #262 from ChrisKitching/frontendaction
...
[HIPIFY] Mostly fix preprocessor-or-template induced issues
2017-11-27 17:30:11 +03:00
foreman
713bf036bb
P4 to Git Change 1486756 by johtaylo@johtaylo-jtincrementor2-increment on 2017/11/25 03:00:05
...
SWDEV-2 - Change OpenCL version number from 2543 to 2544.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2291 edit
2017-11-25 03:11:18 -05:00
foreman
88936eb203
P4 to Git Change 1486724 by wchau@wchau_OCL_boltzmann on 2017/11/24 17:48:34
...
SWDEV-139422 - Lexa Linux Support - OCL
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/legacy-lib/utils/v0_8/target_mappings.h#21 edit
... //depot/stg/opencl/drivers/opencl/compiler/legacy-lib/utils/v0_8/target_mappings_amdil.h#22 edit
... //depot/stg/opencl/drivers/opencl/compiler/legacy-lib/utils/v0_8/target_mappings_amdil64.h#21 edit
... //depot/stg/opencl/drivers/opencl/compiler/legacy-lib/utils/v0_8/target_mappings_hsail.h#25 edit
... //depot/stg/opencl/drivers/opencl/compiler/legacy-lib/utils/v0_8/target_mappings_hsail64.h#25 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/target_mappings.h#53 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/target_mappings_amdil.h#48 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/target_mappings_amdil64.h#44 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/target_mappings_hsail.h#50 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/target_mappings_hsail64.h#45 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudefs.hpp#150 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#579 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldefs.hpp#25 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#66 edit
2017-11-24 17:58:22 -05:00
Alex Voicu
fd406fce20
Re-sync with upstream.
2017-11-24 13:04:12 +00:00
Jenkins
d5aac47d05
Merge 'master' into 'amd-master'
...
Change-Id: I9b15fd04a369c32b6c9bef1c0d67a90b28dfe69b
2017-11-24 04:10:50 -06:00
foreman
ab0e2fb2fe
P4 to Git Change 1486480 by johtaylo@johtaylo-jtincrementor2-increment on 2017/11/24 03:00:04
...
SWDEV-2 - Change OpenCL version number from 2542 to 2543.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2290 edit
2017-11-24 03:10:32 -05:00
Rahul Garg
3e9a4cfdd1
Porting guides update for texture APIs usage
2017-11-24 12:00:55 +05:30
foreman
460f5d125e
P4 to Git Change 1486043 by johtaylo@johtaylo-jtincrementor2-increment on 2017/11/23 03:00:05
...
SWDEV-2 - Change OpenCL version number from 2541 to 2542.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2289 edit
2017-11-23 13:15:43 -05:00
Ben Sander
77de4b96cf
Merge pull request #273 from mangupta/swdev-129574
...
Fix float2int rounding functions
2017-11-23 12:04:36 -06:00
Jenkins
c1dc716d76
Merge 'master' into 'amd-master'
...
Change-Id: I74751b8fe8b223a9bdcb18c6e340c5ff8c771a64
2017-11-23 04:10:36 -06:00
Maneesh Gupta
822743845c
Fix float2int rounding functions
...
Change-Id: I67943859a6344c5eec0eaa23418c9b802ef72468
2017-11-23 09:57:24 +05:30
Alex Voicu
dfa532db98
Remove leftover comment.
2017-11-22 19:37:03 +00:00