SWDEV-86253 - [QR] 6 to 7% performance drop is observed in BasemarkCL test
CL1226184 adds serialization to LHIO, because pxproxy accesses global state, without locks, leading to crash, etc.
To fix OpenCL perf regressions, allow unserialized access to pxproxy. It may be that OpenCL design leads away from racy behavior, so it may be safe. This was checked in to gather information. What software gets perf drops? Does any software get fixed?
The dangerous functions are CreateDevice, CreateContext, because the handles from the OS are saved in global caches, and if those global caches are modified in one thread, while other threads are looking-up from the caches - that is a problem.
TC: http://ocltc:8111/viewModification.html?modId=66278&personal=true
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp#158 edit
SWDEV-2 - Change OpenCL version number from 2023 to 2024.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1770 edit
SWDEV-2 - Change OpenCL version number from 2022 to 2023.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1769 edit
changed Cuda to CUDA for consistency
changed NVIDIA to Nvidia for consistency
corrected apostrophes
corrected section "What hardware does HIP support?"
SWDEV-2 - Change OpenCL version number from 2021 to 2022.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1768 edit
SWDEV-2 - Change OpenCL version number from 2020 to 2021.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1767 edit
SWDEV-2 - Change OpenCL version number from 2019 to 2020.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1766 edit
SWDEV-2 - Change OpenCL version number from 2018 to 2019.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1765 edit
SWDEV-85649 - The return of owner() needs to be casted to get amd::Image.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpumemory.cpp#125 edit
SWDEV-79308 - Use 64-bit to calculate the scratch buffer size for OCL. We observed that the computed scratch buffer size could be > 4G when compilier optimization option is not used.
Cross branch change - requires CL1231547.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp#157 edit
SWDEV-2 - Change OpenCL version number from 2017 to 2018.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1764 edit
SWDEV-2 - Change OpenCL version number from 2016 to 2017.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1763 edit
SWDEV-2 - Change OpenCL version number from 2015 to 2016.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1762 edit
SWDEV-2 - Change OpenCL version number from 2014 to 2015.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1761 edit
SWDEV-2 - Change OpenCL version number from 2013 to 2014.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1760 edit
SWDEV-2 - Change OpenCL version number from 2012 to 2013.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1759 edit
SWDEV-82353 - Remove assert and only assign the customHostAllocDevice_ with the first device that has customHostAllocator.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/platform/context.cpp#38 edit
SWDEV-2 - Change OpenCL version number from 2011 to 2012.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1758 edit
SWDEV-82159 - [CQE OCL][ISV][QR] Error is observed while debugging the sample with CodeXL; Faulty CL:1208929
[Synopsis]
compile from binary logic changes caused issue with resulting binary generation in CodeXL
[Solution]
do not use compile options from binary if they are explicitly specified
[Testing]
precheckin, MCL
Reviewed by Evgeniy Mankov, German Andryeyev
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/platform/program.cpp#78 edit
SWDEV-2 - Change OpenCL version number from 2010 to 2011.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1757 edit
foreman
Peng Sun
scchan
Ben Sander
streamhsa
Jack Chung
Maneesh Gupta
Paul Jähne
sunway513
Aditya Avinash Atluri