Commit Graph

13474 Commits

Author SHA1 Message Date
Maneesh Gupta 2801be2372 SWDEV-366831 - Revert "File reorg backward compatibility message changed to #error"
This reverts commit 810c4ac244.

Reason for revert: Need app fixes first

Change-Id: I1fea9a2ca8d57ef79a4f407bbc0d906976292eb1
2023-02-14 22:55:40 -05:00
victzhan 4e324a9c63 SWDEV-376995 - Added if statement so that when AQL dispatch failed it returns corresponding hip error instead of hipSuccess
Change-Id: I0724fbcf0833c5dd8b2e4d6e443b3e226046dddf
2023-02-14 14:30:50 -05:00
sdashmiz e34be4fbee SWDEV-377862 - wrong format for memcpy1d
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ide6d252083b1812b0ad9cd182b1435e3e59b3aa1
2023-02-14 09:47:04 -05:00
Sourabh Betigeri 191b468d89 SWDEV-375194 - Fixes graph dot file descriptions to include labelId matching CUDA
Change-Id: Ia0e6b77e38678b13457f86755ed8f3b852c9b7a1
2023-02-13 19:43:12 -05:00
Saleel Kudchadker 695f169ed0 SWDEV-301667 - Refactor code
Change-Id: I8f20d994d88acb14f392eaa9d5cd14620667d7f6
2023-02-13 14:58:17 -08:00
David Yat Sin fa1b7925cf SWDEV-365908 - Do not align mem size for IPC
Remove alignment to granularity for IPC handles as ROCr has a patch that
will internally validate pointer sizes against requested size during
allocation instead of size aligned to page size. This patch is needed
together with this patch from ROCr:
f8a42a3a:Use user requested size for memory fragments

Change-Id: I28b25558ea03c836b44fafdb34b7330cf6887424
2023-02-13 17:32:02 -05:00
Ranjith Ramakrishnan c86bd74c67 SWDEV-366831 - File reorg backward compatibility message changed to #error
Change-Id: Ic346b403bcc5df52fdab54ddf95472f649a00cc0
2023-02-10 13:09:46 -05:00
Chauncey Hui dbeb2f5495 SWDEV-2 - Change OpenCL version number from 3569 to 3570 2023-02-10 03:00:12 -05:00
Jeremy Newton 70bdb7a597 SWDEV-1 - device: Add missing include
Newer GCC's seem to require this.

Change-Id: I85926d4fa552b772f2eb9f8ede7863a546c47f54
Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
2023-02-09 14:57:14 -05:00
Sourabh Betigeri 4cbf9a4a16 SWDEV-375202 - Fixes print formatting for flags in hipGraphDebugPrint() to match CUDA
Change-Id: I2d85fc38d2c65bc12534109883fe00802e77e62d
2023-02-09 13:07:57 -05:00
Ranjith Ramakrishnan 810c4ac244 SWDEV-366831 - File reorg backward compatibility message changed to #error
Change-Id: I44adb1a4b9bba0bd89edb75be715504ede2e3d08
2023-02-09 12:46:13 -05:00
Satyanvesh Dittakavi 99556449b6 SWDEV-370552 - Correct the HIPRTC behavior to optimize the ISA only once
Change-Id: Idaf0ea8294657db3666e9548deb6a9629e0ee718
2023-02-09 11:55:41 -05:00
Jacob Lambert 5168485d23 SWDEV-376413 - Revert "SWDEV-376413 - Replace deprecated Comgr device-lib action"
This reverts commit 0969056f66.

Reason for revert: Test failures with Luxmark, blender, and Indigobench. Need to investigate before re-applying

Change-Id: I6b08273a8f9c8bcaa4e7a06cd42d15048e52ca2a
2023-02-09 10:02:47 -05:00
German Andryeyev 67af16bdf3 SWDEV-381633 - Use blit manager on app's queue
Heap initialization used device queue, but it shoudl be used for
cooperative launches only. Heap initialization must use the same queue
as the current dispatch.

Change-Id: I856621bf82bbdeb1c2d0fbc4970e90d09af805cb
2023-02-09 09:43:13 -05:00
sdashmiz 5c5b220561 SWDEV-374378 - correct setparam for memcpy node
- params should be valid when used for default flag since we support
  unified virtual address space

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I75d40e437b12ee58e72e423bb4818b484ce35b66
2023-02-09 09:39:20 -05:00
Chauncey Hui 5e27676afb SWDEV-2 - Change OpenCL version number from 3568 to 3569 2023-02-09 03:00:04 -05:00
Saleel Kudchadker 7619b53e9b SWDEV-381633 - Better log
Change-Id: Ie151d73aa4b1dae7d0d9acd0457e7dbdf35f21ee
2023-02-08 17:54:11 -05:00
Jeremy Newton 158e79358c SWDEV-1 - cltrace: Add missing include
Newer GCC's seem to require this.

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Change-Id: I56ef934600729e892f1cd7ab11662760df48aed8
2023-02-08 14:26:47 -05:00
Saleel Kudchadker 2e4ce59cf4 SWDEV-381633 - Better log
Change-Id: I5c59d42462fe8a233ef10e26ec67314219aeb167
2023-02-08 10:21:57 -08:00
Jaydeep Patel e940beb459 SWDEV-380405 - Check for invalid stream for hipMemcpyPeerAsync.
Change-Id: I6dfccb4d20bb638bd596c071030c68889743d706
2023-02-08 00:47:35 -05:00
jatang b798c85272 SWDEV-380792 - Fix floating point exception when maxEngineClockFrequency_ is 0
Change-Id: Ic443ceae586c4c84995ed2abef9bd7f32f8b60f9
2023-02-07 11:43:10 -05:00
pghafari 03f62b90ef SWDEV-377571 - adding scopelock for hipDeviceReset
Change-Id: I3dd95a40d6abff721a4774f26e99d1162bafdfa1
2023-02-07 11:29:20 -05:00
Matt Arsenault eacf63673b SWDEV-1 - Use proper __builtin_amdgcn_rcph builtin
Change-Id: Ic0b1b25a5ab7d132cb51425f2a17bc779c762668
2023-02-07 10:58:48 -05:00
Matt Arsenault bebbf3c4ec SWDEV-1 - Eliminate rcp_2f16 pseudo intrinsic
No such wrapper or intrinsic would ever exist because there is no such
underlying instruction.

Change-Id: I6c3f64cd2df2a58edf32037da8f5712868f296ea
2023-02-07 10:58:31 -05:00
Ioannis Assiouras 6704f3d0f0 SWDEV-380687 - Fixed typo in safe atomicAdd for gfx90a
Change-Id: I87bc6d9e0ef1f564d679c6280c71c4633d3aa619
2023-02-07 10:14:34 -05:00
Ioannis Assiouras 24d3d8216b SWDEV-380466 - Fixed typo in unsafe atomicAdd for doubles and gfx940
Change-Id: I3b9ea4773f94bf6a9b9dfb655062f42aeb3b5eba
2023-02-07 10:06:17 -05:00
Chauncey Hui 4435ddd997 SWDEV-2 - Change OpenCL version number from 3567 to 3568 2023-02-07 03:00:09 -05:00
Jaydeep Patel 5f231c55e3 SWDEV-380405 - Make hipMemcpyPeer async w.r.t. host and let dst device wait till copy finishes by src device.
Change-Id: Idbe25404d0c31b93436e190b548f12f327f47a04
2023-02-07 00:34:45 -05:00
kjayapra-amd 297223a763 SWDEV-378648 - Adding checks in runtime to abort when bad/invalid payload is sent.
Change-Id: Ibaa7927bacef1ba067ded5ccbf3f1111f31200a2
2023-02-06 10:37:29 -05:00
German Andryeyev 0fe03b6494 SWDEV-353281 - Switch Graph to operate with stream
MemPool was designed to use hip::Stream, but graph implementation uses
amd::HostQueue. Hence switch graph to hip::Stream management.

Change-Id: Ia319389de45e4c3c6043d17473279a6f27a13140
2023-02-06 10:11:55 -05:00
German 7b50c935f8 SWDEV-368235 - Remove obsolete env variables
Change-Id: I7e14d53297e79e2f68b3a6cc40251ad7db9eb5ab
2023-02-03 13:44:24 -05:00
Matthew Arsenault 8c7391398a SWDEV-1 - Reapply "SWDEV-1 - Directly call __builtin_amdgcn_fence"
This reverts commit 5b39c346ad.

Resubmit after https://github.com/ROCmSoftwarePlatform/rocPRIM/commit/ba8a86166ec9c4cf3a40ecde7017feeb1484e7f6

Change-Id: I194559484a5a0d7f4443381fe77218ea73d2def9
2023-02-03 10:54:27 -05:00
Chauncey Hui ce37f3ba26 SWDEV-2 - Change OpenCL version number from 3566 to 3567 2023-02-03 03:00:10 -05:00
Ranjith Ramakrishnan 689425433f SWDEV-366831 - Correct the include path for new directory layout
Change-Id: I7c826ed9c2f2d839d350e5150f578830655616f0
2023-02-02 03:19:47 -05:00
Chauncey Hui 2a592f8968 SWDEV-2 - Change OpenCL version number from 3565 to 3566 2023-02-02 03:00:07 -05:00
Jaydeep Patel 01c3299425 SWDEV-379395 - Use getQueue as it handles null stream and flags can be combination.
Change-Id: If37854a9fc0fc57acb30e652953a7f283831cad8
2023-02-01 12:03:42 -05:00
Jaydeep Patel f9e27bcdd4 SWDEV-377804 - Initial commit to support hipGraphInstantiateFlagAutoFreeOnLaunch
Change-Id: I7a35becb6c98a6ff70264e141317d98be7457a37
2023-02-01 11:51:39 -05:00
German 7b4de0df0f SWDEV-352197 - Use static VM ID for capture
Use static VM ID if available for capture.
Add a delay in RGP trace finish to help RGP server to complete
file operations.

Change-Id: Id0dab2fe4398ac2df79f25608fdd06b1f84e7fe0
2023-02-01 11:46:10 -05:00
Matt Arsenault 14477c24d0 SWDEV-1 - Use proper builtins for math intrinsics
Change-Id: If0e420332c718abe0e9f6316c467b6b29b80b183
2023-02-01 07:19:45 -05:00
Chauncey Hui 202b6c0f16 SWDEV-2 - Change OpenCL version number from 3564 to 3565 2023-02-01 03:00:07 -05:00
sdashmiz 34d087da93 SWDEV-361623 - correct remove edge behaviour
- remove node dependency before checking parents
- reduce edge level acording to new value of node

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Id4bff1684f7e0b42beeebc4d2e009bfdb507fb5f
2023-01-31 12:48:59 -05:00
David Yat Sin 08d72c4f98 SWDEV-380258 - Fix invalid iterator after erase
Fix rare segfault due to invalid iterator after erase

Change-Id: Id5b54d6cf10075deff0d613fec12af249c6c55a3
2023-01-31 17:46:15 +00:00
German ad33a021cb SWDEV-352197 - Destroy virtual device in thread destructor
Windows kills threads on exit without any notification. However,
runtime can still destroy VirtualGPU object from the host thread with
HostQueue destruction.
This change also forces RGP trace transfer on the last capture without
any delays.

Change-Id: I768e87e99e1d23a021e63c12f36e450817743759
2023-01-31 10:53:48 -05:00
Chauncey Hui 054ab2d4ae SWDEV-2 - Change OpenCL version number from 3563 to 3564 2023-01-31 03:00:08 -05:00
Rahul Garg 118e7144f8 SWDEV-379678 - Remove catch build option
Change-Id: Idedf5e61da1e6c7fbdd9a65e57220875a3b24112
2023-01-30 11:04:03 -05:00
sdashmiz b251c8fdb2 SWDEV-374368 - dependency list should not have duplicate
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I67e1c8203f10916b98408e2004e6c64e96b1933b
2023-01-30 10:28:35 -05:00
sdashmiz 23edcd3e23 SWDEV-374389 - correct update dependency behaviour
- nodes should belong to graph
- num of passed dependency cant be larger than graph nodes

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ia6f2283546bc44edee705b0483bfe506b7b1177a
2023-01-30 10:05:52 -05:00
Sourabh Betigeri 2388f61705 SWDEV-340649 - Removes calls to commitMemory in hmm path
Change-Id: I8d381b4c3f5cf95628487e0d10ae643443c9709d
2023-01-27 13:15:23 -05:00
Chauncey Hui e3aa7a5b3d SWDEV-2 - Change OpenCL version number from 3562 to 3563 2023-01-27 03:00:07 -05:00
victzhan 96cd9f7b76 SWDEV-345751 - Added parameter check for clEnqueueWriteImage
Change-Id: I9606ea1c3698d009f23b7da673c02fa05b009dbc
2023-01-26 16:49:56 -05:00