Commit Graph

13474 Commits

Author SHA1 Message Date
Chauncey Hui 5fdf5d05df SWDEV-2 - Change OpenCL version number from 3320 to 3321 2021-08-22 23:56:07 -07:00
Vladislav Sytchenko 0b1481d4f1 SWDEV-289548 - [PAL] Revive Raven 2 support
Revert back to using the Raven (gfx902) target ID for Raven 2 (gfx909).
This is due to the HSAIL compiler not supporting gfx909.

In theory there should be no issue with running Raven isa on Raven 2.

Change-Id: I425edebc99075799eda5522fad231b8fb3184873
2021-08-22 23:56:07 -07:00
Chauncey Hui 957b73c39e SWDEV-2 - Change OpenCL version number from 3319 to 3320 2021-08-22 23:56:07 -07:00
Saleel Kudchadker 9d0846e732 SWDEV-286092 - Enable handler for marker always
For DD, send a NOP packet so that we leverage the handler to indicate
completion.

Change-Id: Ie57ea0124a8497d39cc49da1c4575c2cd86b9319
2021-08-22 23:56:07 -07:00
Chauncey Hui 9dfc938118 SWDEV-2 - Change OpenCL version number from 3318 to 3319 2021-08-22 23:56:07 -07:00
kjayapra-amd d2bf9f9b58 SWDEV-288690 - Updating the return value with roc::Device::init
Change-Id: I132fa424cf9bec608e5c8429e93d20e78b76c6f0
2021-08-22 23:56:07 -07:00
German Andryeyev 89b69638d1 SWDEV-240804 - Update ReadMostly attribute
Switch HSA_AMD_SVM_ATTRIB_READ_ONLY to
HSA_AMD_SVM_ATTRIB_READ_MOSTLY to match Cuda. The new attribute
was just exposed in ROCr/KFD.

Change-Id: I2ee522d33c347ba52a4e272d2cd7f67960490cf7
2021-08-22 23:56:07 -07:00
Vladislav Sytchenko 1423c1db64 SWDEV-273235 - Find UGL headers based on AMD_DRIVERS_PATH
All KMD/asic_reg/UGL headers are located under the drivers folder. No
need for the AMD_UGL_PATH variable as it essentially is
${AMD_DRIVERS_PATH}/ugl.

Change-Id: I070d737d50f2096493b3e75ef9b9e824cb19d048
2021-08-22 23:56:07 -07:00
Chauncey Hui 7264e90fd1 SWDEV-2 - Change OpenCL version number from 3317 to 3318 2021-08-22 23:56:07 -07:00
cjatin 228662bf3f SWDEV-283267 - Fix a bug where rocclr appends compiler options twice
Change-Id: I54ca6e8458cf6414c263df7a8bf61f7ce39a64df
2021-08-22 23:56:07 -07:00
German Andryeyev a9a1e21445 SWDEV-240804 - Add coarse grain memory support
Add an extension to memory advise to disable cache coherency for
better performance

Change-Id: I283703d81d9c36ddfa2c8fffa15eef60e2195056
2021-08-22 23:56:07 -07:00
Chauncey Hui 1d63bd0eb1 SWDEV-2 - Change OpenCL version number from 3316 to 3317 2021-08-22 23:56:07 -07:00
Vladislav Sytchenko 77d6373502 SWDEV-273235 - Fix Windows CMake build
Change-Id: I337b8d3b38a492b77b55602ab3a6bb3c05e693e0
2021-08-22 23:56:07 -07:00
Chauncey Hui 383aa8900e SWDEV-2 - Change OpenCL version number from 3315 to 3316 2021-08-22 23:56:07 -07:00
German Andryeyev d93df7037c SWDEV-287137 - Add blocking signal logic
With HIP API callback runtime has to stall the queue until the
callback is done. Rocclr will introduce SW blocking HSA signal,
which will be released after the callback is done.

Change-Id: I6411f3efab31b468e3b87ebb5c8d155e116b613d
2021-08-22 23:56:07 -07:00
Vladislav Sytchenko 7f0c18457d SWDEV-273235 - Initial support for Windows CMake
This change refactors the current ROCclr cmake build to accomodate a
more modular approach. This allows easier support for multiple compiler
and/or multiple runtime backends.

Currently supported compilers:
    HSAIL - enabled by ROCCLR_ENABLE_HSAIL (defaults to OFF)
    LC    - enabled by ROCCLR_ENABLE_LC    (defaults to ON)

Currently supported runtimes:
    HSA - enabled by ROCCLR_ENABLE_HSA (defaults to ON)
    PAL - enabled by ROCCLR_ENABLE_PAL (defaults to OFF)

Any configuration is supported as long as at least one compiler and one
runtime is enabled.

Since ROCclr clients can configure it differently, one cannot reuse the
same ROCclr build artifacts between different clients. To assure this,
this patch assumes that ROCclr will be built as part of the clients
project.

Change-Id: Id4a5c43634296802b8ae87d1ad5984968391ccaf
2021-08-22 23:56:00 -07:00
anusha GodavarthySurya 4bcca82634 SWDEV-287884 - [HIP] Package Versioning
Change-Id: I4a4d96f947a67713036437ed525359fd422fefe2
2021-08-19 06:15:44 -04:00
Payam 710bedf5da SWDEV-245531 - GLInterop - merging changes from opencl
Change-Id: I3e21ff89b64afaa406bf46221c0f82045e905b1f
2021-08-16 19:22:46 -04:00
Satyanvesh Dittakavi a984cbf90c SWDEV-298982 - hipMemPrefetchAsync should not allow more bytes than the actual size allocated
Change-Id: If8df97a79a16d39c66c508a8927ae1b4c276663e
2021-08-16 13:19:04 -04:00
Julia Jiang a41c5c783b SWDEV-291894 - update readme for branch info
Change-Id: Ib8e9462e4f67a5d51f75544a5034ef4427aea421
2021-08-16 11:01:58 -04:00
cjatin 06e1e4f0de SWDEV-296918 - Adding unsafe atomic add operation for float and double type
Change-Id: I98eabb7412f604733a999bf5e89c2c80b91cfbb1
2021-08-14 12:22:53 +05:30
Julia Jiang fdb61872c8 SWDEV-291894 - update branch info in OpenCL readme
Change-Id: I18e497f08ac3ef98e7b383eda62ec42ec7559912
2021-08-13 12:47:03 -04:00
Laurent Morichetti 73ee1afb17 Fix a build failure on Windows
Terse static_assert is only available starting with c++17. Add the
message argument since HIP is not compiled using c++17.

Change-Id: I77bc7ddb635e50ac3e6744d73c8751dc8299087e
2021-08-11 21:25:49 -07:00
Ammar ELWazir 0670e49806 SWDEV-294248 (Fixing Race Conditions):
Fixing race conditions that happened when enabling trace-period feature on the following code:
#include <hip/hip_runtime.h>
__global__ void
kernel ()
{
}
int
main (int argc, char **argv)
{
  for (size_t i = 0; i < 10000; ++i) {
    hipLaunchKernelGGL (kernel, 1, 1, 0, 0);
    hipDeviceSynchronize ();
  }
  return 0;
}

Change-Id: I6d2407ad06ecd602b93f53970859e1f4b67072e8
2021-08-11 11:06:10 -04:00
Vladislav Sytchenko 88f6f3d581 SWDEV-297808 - Correct sampler destruction logic
If the texture object was created from an array, then the array owns
the image SRD. Otherwise, if the texture object is a view, or was
created from a buffer, then it owns the image SRD.

The texture object always owns the sampler SRD.

Change-Id: Id88360c23b2b82418c8c3ae2dd569f427574d420
2021-08-10 11:37:49 -04:00
Vladislav Sytchenko b41d5d73d4 SWDEV-297808 - Free sampler when destroying textures
Change-Id: Idaab76392d18c7f5fedc89497e93f0d17835001a
2021-08-09 21:49:36 -04:00
Julia Jiang 8835b897d5 SWDEV-286322 - Remove execution permission
Change-Id: I96e603fc8d407c3a76fa1053bad81e45744b59ad
2021-08-05 14:04:06 -04:00
Sourabh Betigeri 8a4ca88477 SWDEV-297689 - Moving the vendor specific builtin function calls to hip_cooperative_helper.h header file
Change-Id: I797bdde8fbb01285dfda0eac0f960ded260beb8e
2021-08-02 19:14:42 -04:00
Rahul Garg ec39f62ee1 SWDEV-297563 - Move surface types
Change-Id: Ie2393fb32a30a76c39c81ce17497fa3b131a85b1
2021-08-02 18:48:15 +00:00
Rahul Garg 3dd9dbb359 SWDEV-297563 - Move declarations to hip
Change-Id: Ifdab79945ea2e625e8cef5cd71d638552e9a740b
2021-08-02 11:56:08 -04:00
pghafari 65fcb6a0aa SWDEV-245531 - GLInterop: linux - Buffer Interop
in progress...

Change-Id: I6f2cd8ee19ffef93e4f2aa6a08e002a13722d78a
2021-07-30 02:43:41 -04:00
Rahul Garg 91df8fc0e9 Revert "SWDEV-293742 - script to update the copyrights end year"
This reverts commit 5b5f934d58.

Reason for revert: Copyright year to be updated only when a file is getting modified in that year. 

Change-Id: Id1ece634dce7e67da9f3f6e10103ef6214e72dab
2021-07-29 19:06:52 -04:00
kjayapra-amd bf677f91af SWDEV-282289 - Do not compare Pre-processor directive with string.
Change-Id: I9cd76c57a5cdea8059f69cc56ba9dca278b4d04c
2021-07-29 06:55:42 -04:00
Anusha GodavarthySurya 50e57158eb SWDEV-287869 - [HIP] Package rename
Change-Id: Ic4ddece01bfc34d586cfaba3193c56ce0540626d
2021-07-29 05:55:44 -04:00
Tao Sang c87a352288 SWDEV-294591 - Fix hipEventIpc failure on NV
make hipIpcOpenEventHandle has the same behavour of cudaIpcOpenEventHandle.

Change-Id: I3fe6dbc35a7b14ba9119df297b7885df83d28149
2021-07-28 20:34:11 -04:00
Vladislav Sytchenko 578b6d32f4 SWDEV-240806 - Fix Windows build
Fixes error "All control paths should return a value".

Change-Id: I4178ee4b644cd54629bd2a2f4c57eb58d2709ab8
2021-07-28 19:18:04 -04:00
Tao Sang 3452a09975 SWDEV-296812 - Fix LINK_LANGUAGE issue
LINK_LANGUAGE support has some issue in CMake versions from 3.18.0 to
3.19.8 when complex libs' dependence exists. Jump to a known CMake
version 3.20.0 where the issue is fixed.

Change-Id: I3fe6dbc35a7b14baa210df297b7885df83d28178
2021-07-28 11:34:38 -04:00
Anusha GodavarthySurya a71f54d9e9 SWDEV-240806 - Added API hipGraphAddMemcpyNode1D, hipGraphAddEmptyNode, hipGraphExecKernelNodeSetParams
Change-Id: I0d7ec8c0ea1abc3fc0f1e10fa7865f355d9cf2ad
2021-07-28 00:09:16 -04:00
Vladislav Sytchenko a89d34d0c9 SWDEV-292547 - Fix Windows build
This addresses the warning `not all control paths return a value`.

Change-Id: Ibbb5eda9758dca5cc94c8efba9bbc6910362d6ba
2021-07-27 10:52:28 -04:00
German Andryeyev a852370a25 SWDEV-290384 - Add compilation option for direct disaptch
DISABLE_DIRECT_DISPATCH flag will control compilation.
Default is OFF.

Change-Id: I7d4207b8a79f5e3eb61440c5fbe5034c6ce75cce
2021-07-27 00:07:27 -04:00
Sarbojit Sarkar c3ca1faee7 SWDEV-292547 - hipStreamPerThread support
Change-Id: Id621ce073b0fee9eac03c59ffb78b197fda4ddb5
2021-07-26 20:51:51 -04:00
Tao Sang 203c4b9b35 SWDEV-294594 - Fix hipPointerGetAttributes test on NV
Replace return value of hipPointerGetAttributes() on NV from
hipErrorUnknown to hipErrorInvalidValue if memory has been freed.

Change-Id: I3fe6dbc35a7a14aa9109df297b7885df83d28149
2021-07-26 11:30:22 -04:00
Tao Sang b58355b065 SWDEV-294596 - Make hipModuleGetGlobal match cuda
Make hipModuleGetGlobal match cuModuleGetGlobal behavour.
That is, if one of the first two parameters is nullptr, ignore it.

Change-Id: I3fe6dbc35a7b14aa9119df297b7885df83d28048
2021-07-23 23:06:56 -04:00
Rahul Garg ba0220578e SWDEV-288929 - Fix typo
Change-Id: I56acb7ce3021304b2cd2c8bc2b840cbdcdefd072
2021-07-23 07:10:31 -04:00
Sourabh Betigeri cbbf627662 SWDEV-292523 - [hipamd]Change in the signature of streamOperations APIs, particularly 'value' arg to unsigned 'value'
Change-Id: I7e31508622865b9986c886c4218ba394ffe9cf9e
2021-07-22 16:24:27 -04:00
Vladislav Sytchenko d3062d3bc2 SWDEV-240807 - Fix Windows build
These are defined as structs in HIP headers, not as classes.

Change-Id: Ie53424a026424c71fd45db3a60e5be906d472c5d
2021-07-21 20:40:16 -04:00
Vladislav Sytchenko f9732d7f20 SWDEV-286884 - Correct hiprtc installation on Windows
Generated .lib binary should go into the lib/ folder.

Change-Id: I552552745457368dc48f3a4b727a731a6bea822b
2021-07-21 09:29:17 -04:00
Christophe Paquot 9a510f1cf1 SWDEV-281658 - Preserve the callback IDs enum ordering
Use continue instead of break to make sure we process the
whole hip_runtime_api.h file.

Change-Id: Ied2a8df69ed9eb1dc04d6b2d0d7b117ce2a2b6b3
2021-07-20 20:12:21 -07:00
Christophe Paquot 223c0364f8 SWDEV-240807 - Fix header file
Remove class useage from header file

Change-Id: Ibe1a59241f000cc162dd865484c313e56c4db95f
2021-07-20 20:32:55 -04:00
Julia Jiang 70e18827a6 SWDEV-288929 - update hipamd document
Change-Id: I638afb4c7f0b96df3f0c1cc0b3bf04ab57692d27
2021-07-19 17:21:39 -04:00