Commit Graph

13474 Commits

Author SHA1 Message Date
Vladislav Sytchenko ae36b6c0aa SWDEV-273235 - Fix warning in the cmake build
Change-Id: I9840da22fcce11712c32e68f07ad886d08c8b16f
2021-05-27 18:09:26 -04:00
Vladislav Sytchenko e34a7e8c0c SWDEV-273235 - Initial support for Windows CMake
This change is tied to the ROCclr cmake rework. ROCclr will now be built
as part of HIP itself.

All the dependencies on comgr and rocr have been moved into ROCclr
itself. This allows HIP to pull in all the required compiler/runtime
dependencies by simply linking against ROCclr. Note that ROCclr needs to
be configured from HIP cmake command line. If not, we will default to
LC + ROCr support.

Since HIP depends on ROCclr and ROCclr depends on OpenCL, HIP will
transitevly pull in all the required OpenCL headers. No need to keep a
local copy of them anymore.

Change-Id: Ib39f4929e88da1248be962490c150b10fc7abd3a
2021-05-27 15:21:05 -04:00
Vladislav Sytchenko 1c16690617 SWDEV-273235 - Initial support for Windows CMake
This change is tied to the ROCclr cmake rework. ROCclr will now be built
as part of OpenCL itself.

All the dependencies on comgr and rocr have been moved into ROCclr
itself. This allows OpenCL to pull in all the required compiler/runtime
dependencies by simply linking against ROCclr. Note that ROCclr needs to
be configured from OpenCL cmake command line. If not, we will default to
LC + ROCr support.

Change-Id: I5271302d073aef8cfa617828d218c856711bf9ba
2021-05-27 13:08:12 -04:00
Jason Tang 1b832c0182 SWDEV-287945 - LinuxPro: Disable PAL for gfx9+
Change-Id: Ief81629e53a4c0ca529a510dac5063a8885257bf
2021-05-27 11:05:43 -04:00
Chauncey Hui be7bb4b63c SWDEV-2 - Change OpenCL version number from 3314 to 3315 2021-05-27 03:00:06 -04:00
Anusha GodavarthySurya ba28a01258 SWDEV-288065 - allow hipcc to recognize .C files
Change-Id: I0ec884eb6e083e823cf27ca1251c354a7f3b744c
2021-05-26 10:25:57 -07:00
German Andryeyev 148a5cac39 SWDEV-287137 - Fix regression with dependent signals
- Make sure barrier with dependent signals issues before queue
index reservation
- Don't issue extra barrier if it's already a barrier command
with dependent signals

Change-Id: I179a8b7adac79eed698f4a4d9eca2606d8e913aa
2021-05-26 12:36:56 -04:00
Aaron En Ye Shi ec22410ca5 SWDEV-283266 - Fix Linux Pro build for hiprtc
Linux Pro build uses the LLVM_ROOT variable to
specify where llvm is located. We must use a different
name, HIP_LLVM_ROOT for LLVM's prefix location.

Change-Id: I28baf8672217a438a5dd45829d9af04b3553f615
2021-05-26 10:37:44 -04:00
Jason Tang 7932b5a562 SWDEV-287332 - Disable NullDevice in HIP
Change-Id: I45c6010d2a3fcd0576438e3c72fbed78dff09b6b
2021-05-26 09:27:59 -04:00
Chauncey Hui a3f24ec93e SWDEV-2 - Change OpenCL version number from 3313 to 3314 2021-05-26 03:00:03 -04:00
Tao Sang b9d70a3da9 SWDEV-288106 - Fix g++/hipMalloc
Fix a typo

Change-Id: I71328687b2dd4a3f563571f2b755079d83dca63e
2021-05-25 17:23:36 -04:00
jujiang 401fabbf13 SWDEV-286322 - add an attribute file to modify EOL
Change-Id: I5ca49a0107e129a2f949d767d2d6e0169140191d
2021-05-25 15:19:29 -04:00
German Andryeyev fa2e154a8b SWDEV-278894 - Use GPU waits for HIP events
Save HW events in amd::Event.
Use HW events for synchronization

Change-Id: I98cf9c2d0ec3c7fcaf254b749ac6c568d7270ae0
2021-05-25 13:41:15 -04:00
Tao Sang e594ae6581 SWDEV-276853 - Add test for mem perf
Add memory filling performance test for large bar device memory,
hip managed memory, conherent/non-coherent host memory and fine
grained device memory

Change-Id: Id3f9bcad45d643e493daf9d5f47b3a012a427178
2021-05-25 12:32:44 -04:00
Jatin Chaudhary bfc6eed3d5 SWDEV-277697 - Make sure hipcc can handle standard CXX options when being used with nvcc
Change-Id: I76b1f2943a660eefda858397218a775083b99228
2021-05-25 07:35:02 -04:00
Jatin Chaudhary 8749e231e6 SWDEV-277697 - [CatchTest] Fix Documentation, Add test to AMD specific, Add HIP Macros, New Binary for multiproc tests
Change-Id: I3783caf85c694b724ed55b778220b8ef9a39f84b
2021-05-25 07:12:54 -04:00
Jatin Chaudhary ed4c4fbcba SWDEV-280067 - Document hipErrorNoBinaryForGpu error in hip faq
Change-Id: Ie8cab47ecac5a1b0972041d6e3e58e4fca278c41
2021-05-25 15:14:08 +05:30
Satyanvesh Dittakavi 5738bf4a29 SWDEV-286830 - Fix hipStreamACb_ThrdBehaviour on windows
use sleep_for which works cross-platform
for other tests as well

Change-Id: I915444d620e9fad0b9eda93bcdd244f9956ab8d5
2021-05-24 03:18:36 -04:00
Aaron En Ye Shi 414c80644b SWDEV-283266 - Workaround RTC macro in vector types
Temporarily disable __HIPCC_RTC__ in hip_vector_types.h
while the upstream clang headers are outdated on mainline.
Once upstream patch has landed in mainline, revert this
change. This is a workaround for hiprtc testing.

Change-Id: Ib2cf6023b71431bbfbe3c699076caa4f90f7170c
2021-05-21 15:53:59 +00:00
Chauncey Hui af4efc3b22 SWDEV-2 - Change OpenCL version number from 3312 to 3313 2021-05-21 03:00:03 -04:00
Satyanvesh Dittakavi 247a1e1fee SWDEV-278464 - Update unit test hipEventMultiThreaded
Run with multiple threads to catch possible race condition
Disable running the test by default on CI as this takes lot of time

Change-Id: I1c1a66fd5c72f8d2bf7ad120461384488b46abbd
2021-05-21 02:57:14 -04:00
Satyanvesh Dittakavi e9ac835e0e SWDEV-285521 - SWDEV-284626 - Fix P2P and Caffe2 test failures
- waitList was released before the awaitcompletion
causing stream sync after the async copies fail

- Enable the hipPeerToPeer_simple test

Change-Id: I1eeaa7e6320ab38c106902078f034dfec4c3f3ea
2021-05-21 02:54:22 -04:00
Aaron En Ye Shi 561310c6d6 SWDEV-283266 - Fix hipRTC mcin missing symbol
Add back the .type directive needed for ELF
format to add the section to symbol table.
For COFF format the symbol is already added
to the symbol table.

Change-Id: I4920e8dae0af23b4dcabd324b47abc228fcab10f
2021-05-20 20:24:55 +00:00
Jason Tang 8cac880779 SWDEV-277566 - HSAIL: put back the original setKernels logic for now
In HSAIL path, kernel akc info is obtained after code object
loading, and kernel signature creation requires the akc info
when one of the kernel argument is a reference object.

Change-Id: I9cdb1dbf2c72f4620b0b6e46a88402a2473c3e97
2021-05-20 11:16:48 -04:00
German Andryeyev a81756bba3 SWDEV-285318 - Wait for the queue before destruction
With direct dispatch enabled make sure the queue is done before
destruction.

Change-Id: Ib80af3efb97dfb93e2dce60a11db34fb5c45f5cd
2021-05-20 10:28:24 -04:00
Chauncey Hui 721c3eb150 SWDEV-2 - Change OpenCL version number from 3311 to 3312 2021-05-20 03:00:05 -04:00
Ravi C Akkenapally 0aa524363d SWDEV-245531 - GLInterop: Add Buffer Interop support
Change-Id: I38326173475e84f8eca2605522542ef89a3cf524
2021-05-19 12:24:24 -07:00
Julia Jiang e1a640bfc2 SWDEV-286322 - Fix EOL in files
Change-Id: I1746e80aceeeaa4fc5df65c858f4816d99010186
2021-05-19 14:48:53 -04:00
Chauncey Hui e637c2f637 SWDEV-2 - Change OpenCL version number from 3310 to 3311 2021-05-19 03:00:35 -04:00
cjatin 93bd76672e SWDEV-277697 - Adding Infra and dependent libs: Catch2 and json parser, for new HIP Testing framework
Change-Id: Iedfa041ec9acc13eeb631ff67e1677e2fe29463d
2021-05-19 00:47:00 -04:00
kjayapra-amd 1c49d8816c SWDEV-286346 - Implement Arena Memory Object for externally created memory.
Change-Id: I8530602d89edf83ad367c52167e48a1559ee1e18
2021-05-18 10:59:52 -04:00
Jason Tang ed923eb12e SWDEV-269983 - Re-enable OpenCL Offline Compilation in ROCr path
Change-Id: I160c56a6964219c56c85ebeb5f475be535c39022
2021-05-18 10:46:46 -04:00
Payam Ghafari 0762c948b6 Revert "SWDEV-197835 - adding Khronos OpenCL ICD build"
This reverts commit 932c83fe8f.

Reason for revert: need to update other projects (linuxpro & marnier)

Change-Id: Ib02194d052170e487cd56480eb0d9226895aa580
2021-05-18 10:31:25 -04:00
kjayapra-amd 7fc700c348 SWDEV-286346 - Implement Arena Memory Object for externally created memory.
Change-Id: I1aae0d24b28eebaf7f67e941aaa475a53831e9b8
2021-05-18 10:24:40 -04:00
German Andryeyev 302e527225 SWDEV-240804 - Allow system memory creation.
Always allocate managed memory in ROCclr and backend will decide
what kind of memory to use. Currently ROCclr should fall to
GPU accessible system memory if HMM isn't available

Change-Id: I71328687b2dd4a3f563571f2b755079d82dca433
2021-05-18 09:32:57 -04:00
German Andryeyev 9b3072ae12 SWDEV-240804 - Switch SVM attribute for the first alloc
Use HSA_AMD_SVM_ATTRIB_AGENT_ACCESSIBLE flag for the initial
allocation instead of HSA_AMD_SVM_ATTRIB_AGENT_ACCESSIBLE_IN_PLACE.

Change-Id: Ia52fe205563df1ea916dc2dc81e749e11c16f83d
2021-05-18 09:32:29 -04:00
Chauncey Hui 8514ab4fa4 SWDEV-2 - Change OpenCL version number from 3309 to 3310 2021-05-18 03:00:06 -04:00
Payam 932c83fe8f SWDEV-197835 - adding Khronos OpenCL ICD build
Change-Id: Id7d9cd6076c6f1670eedbea06a6976c05e391520
2021-05-17 18:19:30 -04:00
Jason Tang 8aa89274c8 SWDEV-277566 - Fix LinuxPro build
Change-Id: I3e15ae55591d669a87ce0d69fecf9fa32b85b0a6
2021-05-17 15:18:40 -04:00
Saleel Kudchadker ce0f1c7c35 SWDEV-286092 - Flush log file
Flush log file for every log line, helps in cases where there is a softhang.
Change-Id: I3e396678d82b57ec275c3a079fafd1d08f0706a3
2021-05-17 13:48:46 -04:00
Tao Sang 26235f49e6 SWDEV-282588 - Improve clock64()
Let clock64() read s_memtime to prevent rolling over
Add wall_clock64() to read s_memrealtime

Change-Id: I706387355add75852c570be2656131ef99e8968f
2021-05-17 13:19:04 -04:00
Siu Chi Chan 8341fd31d1 SWDEV-286082 - Fix C string processing in GPU printf
This fixes an issue in hostcall when processing printf of a C string.
The calculation to round-up the string size to the next data chunk
didn't include the extra byte for the null terminating character.

Change-Id: I4cf0c250fa4fda253b0db15be461819ffce76d32
2021-05-17 12:41:19 -04:00
cjatin 82610fe3d5 SWDEV-285685 - Make sure the output of hipconfig is without quotes on linux
Change-Id: I620cd41c7e6087b0d3d7da9ef7f9cecaf2f740ba
2021-05-17 20:50:36 +05:30
Jason Tang e1b226588f SWDEV-277566 - Fix HIP/PAL build
Change-Id: Ib460ac70423ebc3aceab22829cd2606d0db20f59
2021-05-15 12:24:18 -04:00
Chauncey Hui 32cac1471b SWDEV-2 - Change OpenCL version number from 3308 to 3309 2021-05-15 03:00:07 -04:00
German Andryeyev 3f7a6b01e3 SWDEV-240804 - Remove AMD_HMM_SUPPORT define
Use dynamic logic for HMM based on it's availability

Change-Id: I63751d94571d5af6eb57bef2cb0e071120bfa103
2021-05-14 17:41:06 -04:00
Ravi C Akkenapally 93ae30730a SWDEV-286446 - StreamOperations: Enable for all gfx9
Change-Id: I913a31c8bfdf1031d4cd491f1c689aa4df05c02c
2021-05-14 16:15:27 -04:00
Vladislav Sytchenko 73b833a741 SWDEV-273235 - Fix Windows runtime error
Variables passed by reference need to be initialized beforehand.

Change-Id: Ic29e3b7f6e04ef5bb153a2e6bd81419e1955935b
2021-05-14 15:03:10 -04:00
Aaron En Ye Shi dd643ec517 SWDEV-263959 - Fix device decl with long and llong
Windows may expect long and ulong to be 4 bytes, while
Linux expects 8 bytes. Instead, use uint64_t for
unsigned long, and unsigned long long, and use int64_t
for long and long long to be consistent.

Change-Id: I6ed1cdde43721bcaaab0245644d607b1adbf9884
2021-05-14 11:59:27 -04:00
Julia Jiang 77ba798177 SWDEV-286322 - Fix EOL
Change-Id: Ie266135ebf754b5af27c1dc768bda1ca0245d936
2021-05-14 11:32:55 -04:00