Commit Graph

41 Commits

Author SHA1 Message Date
Wenkai Du b7253710ca Revert "Port alltoall[v]" (#325)
This reverts commit 2c49121171.

[ROCm/rccl commit: 8e180cf087]
2021-03-06 13:59:31 -08:00
Gilbert Lee b36d93ae91 Using GTEST_SKIP() to skip unit tests that have insufficient devices. Skipping out earlier
[ROCm/rccl commit: f1a9ce3fa5]
2021-02-09 03:54:04 +00:00
Stanley Tsang f152c8d160 Update MP UT to support arbitrary # of GPUs; multiple bugfixes (#16)
* Fixing temp file creation/deletion for Clique kernel mode.

* Refactoring of MP unit tests; include bugfixes and general support for any number of GPUs

* GroupCall MP UT properly quits when too many devices specified

* MP UT will programmatically set NCCL_COMM_ID if not specified; updated install script

[ROCm/rccl commit: d00b7d17bd]
2021-02-05 16:49:25 -08:00
Wenkai Du ae5779702a Merge remote-tracking branch 'origin/develop' into 2.8.3
[ROCm/rccl commit: ab1e7a0318]
2021-02-04 20:02:34 -05:00
Gilbert Lee 6bf9b0d36a Removing in-place tests from Combined calls (no support for send/recv)
[ROCm/rccl commit: 01a998b17c]
2021-01-28 20:09:03 +00:00
gilbertlee-amd c981e76efe Clique kernel support (#295) (#15)
* Adding experimental clique-based kernels (opt-in only)

Co-authored-by: Stanley Tsang <stanley.tsang@amd.com>
Co-authored-by: Gilbert Lee <gilbert.lee@amd.com>
Co-authored-by: Wenkai Du <43822138+wenkaidu@users.noreply.github.com>

Co-authored-by: Stanley Tsang <stanley.tsang@amd.com>
Co-authored-by: Wenkai Du <43822138+wenkaidu@users.noreply.github.com>

[ROCm/rccl commit: 3e62ceddc5]
2021-01-28 09:45:01 -07:00
Stanley Tsang d7ed44eb9a Adding multiprocess unit tests (#312)
Adding multiprocess unit tests for collectives.  

To run, NCCL_COMM_ID=$HOSTNAME:12345 build/release/test/UnitTestsMultiProcess

[ROCm/rccl commit: d3fa257682]
2021-01-15 16:34:36 -07:00
Wenkai Du 560224fe9f gtest: add scatter to combined calls and use loops (#303)
* gtest: add scatter to combined calls and use loops

* gtest: run validation inside loop

* gtest: revert small element count to 2520

* gtest: fix memory leak in validation

(cherry picked from commit 36935cfbee)

* Fix combined call UT

* Fix memory leak

* Fix alltoallv test


[ROCm/rccl commit: b33a2cac8b]
2021-01-14 19:28:01 -05:00
Wenkai Du 36935cfbee gtest: add scatter to combined calls and use loops (#303)
* gtest: add scatter to combined calls and use loops

* gtest: run validation inside loop

* gtest: revert small element count to 2520

* gtest: fix memory leak in validation

[ROCm/rccl commit: b0853ccd51]
2020-11-13 17:57:44 -08:00
gilbertlee-amd a7ef699687 Clique kernel support (#295)
* Adding experimental clique-based kernels (opt-in only)

Co-authored-by: Stanley Tsang <stanley.tsang@amd.com>
Co-authored-by: Gilbert Lee <gilbert.lee@amd.com>
Co-authored-by: Wenkai Du <43822138+wenkaidu@users.noreply.github.com>

[ROCm/rccl commit: 41bcfb8878]
2020-11-10 15:44:10 -07:00
Wenkai Du dbde26e681 Add Alltoallv RCCL kernel implementation (#269)
* Add alltoallv API and implementation

* Extend Rome P2P channel limit to multinode and alltoall kernels

* topo_expl: fix compilation and sync up with main

* gtest: use RCCL alltoallv API

* Code review changes

[ROCm/rccl commit: b871ea3c0c]
2020-09-30 16:25:36 -07:00
Wenkai Du a3402d6aeb Merge pull request #262 from wenkaidu/alignment
Make data alignment requirements matching ISA manual

[ROCm/rccl commit: 60819dcf8d]
2020-09-08 10:40:42 -07:00
Aaron Enye Shi 0a3a397481 Add RCCL Static Lib Creation with -fgpu-rdc
RCCL uses -fgpu-rdc to compile its source objects. When linking
the RCCL static library, the link and archive step must do through
hipcc and uses the flag --emit-static-lib. When compiling
UnitTests, the librccl.a must be consumed through -l and -L.


[ROCm/rccl commit: 958b213428]
2020-09-03 11:25:41 -04:00
Wenkai Du 81bf52ddee gtest: add alltoallv test
[ROCm/rccl commit: b163a8898f]
2020-09-02 21:28:32 +00:00
Wenkai Du 14ad6ff3b4 Merge remote-tracking branch 'nccl/master' into 2.7.8
[ROCm/rccl commit: 7e3f841fab]
2020-08-10 16:11:00 +00:00
saadrahim e5432857db Download GTest if not found in system (#237)
Co-authored-by: Stanley Tsang <stanley.tsang@amd.com>

[ROCm/rccl commit: 0dc019e35f]
2020-08-06 09:36:58 -06:00
Stanley Tsang 56d8c7c893 Adding better naming to unit tests for filtering; adding short and full unit test suites (#235)
[ROCm/rccl commit: 684f3e6af4]
2020-07-21 12:19:47 -06:00
saadrahim f80136bbba Changing GTest inclusion in cmake to use find_package (#234)
* GTest is used via find_package. No longer downloaded in cmake.

* Adding error handling

[ROCm/rccl commit: 99a491273f]
2020-07-15 20:51:48 -06:00
gilbertlee-amd b83acc8032 Removing UnitTest as install, removing unused env var (#231)
[ROCm/rccl commit: f87ba17737]
2020-07-10 09:30:28 -06:00
Wenkai Du ac87c9db37 gtest: extend testing up to 8 GPUs
[ROCm/rccl commit: 8db0aa8f4c]
2020-06-29 09:32:31 -07:00
Wenkai Du d1f8fdc3a8 gtest: add scatter, gather and all to all unit tests
[ROCm/rccl commit: fee1a20b74]
2020-06-09 17:44:15 -07:00
Stanley Tsang e5419407c4 Updating copyright notices for 2020.
[ROCm/rccl commit: 20fa04d9b6]
2020-01-29 15:28:08 -08:00
Wenkai Du e6b5933d7e Merge remote-tracking branch 'remotes/rccl/master' into rccl_2.5.6_cleanup
[ROCm/rccl commit: fe6d012eb0]
2020-01-29 15:28:03 -08:00
Wenkai Du d2fbcfea02 Misc fixes and improvements for 2.5.6
1. Fix RCCL unit test
2. Add ROME detection and tuning
3. Change default P2P level
4. Fix search algorithm for XGMI
5. Remove explicit channel duplication with implicit by using half of link speed
6. Add collective trace support
7. Correct Intel Skylake CPU detection and bandwidth
8. Fix topo connect function
9. Disable GDR read and remove unreachable code
10. Disable LL128 kernels
11. Add tuning parameters
12. Use original clock64() implementation which returns RTC counter value
13. Print out timestamp of collective trace
14. Do not use struct ncclColl in kernel launch parameter
15. Fix abort handling and add tracing
17. Add __launch_bounds__ to kernel functions
18. Remove unused abortCount
19. Unset default MIN_NRINGS and MIN_NCHANNELS
20. Do not allocate shared memory when not using LL128 kernels
21. Correct time print out in tuning log


[ROCm/rccl commit: 1e55645d97]
2020-01-29 15:27:05 -08:00
gilbertlee-amd 71635198b8 Removing OpenMP from unit tests (#163)
[ROCm/rccl commit: 000bce6f27]
2019-12-20 11:41:56 -07:00
Wenkai Du 55ad3c801e Support bfloat16 on rest of the unit tests
[ROCm/rccl commit: 4ca05c1297]
2019-11-18 14:18:34 -08:00
Wenkai Du 7dc39b8928 Add bfloat16 all reduce unit test
[ROCm/rccl commit: bdac0256a5]
2019-11-18 13:50:29 -08:00
Akila Premachandra 94b33a7550 Added hip-clang options to install script, and openmp/pthread options to CMakeLists.txt
[ROCm/rccl commit: f48ae5c98d]
2019-08-23 22:02:42 +00:00
Wenkai Du 6047487815 RCCL 2.4 update
[ROCm/rccl commit: f11c8f60cd]
2019-08-14 10:42:35 -07:00
Sylvain Jeaugey 8ffcfac437 2.3.5-5
Add support for inter-node communication using sockets and InfiniBand/RoCE.
Improve latency.
Add support for aggregation.
Improve LL/regular tuning.
Remove tests as those are now at github.com/nvidia/nccl-tests .


[ROCm/rccl commit: f93fe9bfd9]
2018-09-25 14:12:01 -07:00
sclarkson 42037d978f fix tests on maxwell
[ROCm/rccl commit: 680a35c6b7]
2017-11-11 19:22:06 -08:00
Sylvain Jeaugey 9ec80e0873 Replace min BW by average BW in tests
[ROCm/rccl commit: 1093821c33]
2016-12-01 15:16:35 -08:00
Sylvain Jeaugey d4c7d8014a Add scan tests
[ROCm/rccl commit: ca330b110a]
2016-09-22 11:58:33 -07:00
Sylvain Jeaugey 5dd42ff223 Make tests check for deltas and report bandwidth
[ROCm/rccl commit: 6c77476cc1]
2016-09-22 11:58:28 -07:00
Sylvain Jeaugey a59d93cf7a Updated LICENCE.txt
[ROCm/rccl commit: 75bad643bd]
2016-08-26 15:08:20 -07:00
Nathan Luehr 159408c5d5 Fixed redundant contexts in multi-process apps
Change-Id: If787014450fd281304f0c7baf01d25963e40905d


[ROCm/rccl commit: 55c42ad681]
2016-07-25 10:10:30 -07:00
Sylvain Jeaugey c57ef415a8 Changed CURAND generator to work on a wider set of platforms.
[ROCm/rccl commit: bd3cf73e6e]
2016-06-06 14:34:03 -07:00
Nathan Luehr 6d6120cd1e Moved no-as-needed flag to link rule.
Avoids link errors for tests linked with nvcc.


[ROCm/rccl commit: 03df4c7759]
2016-04-19 14:51:03 -07:00
Sylvain Jeaugey 6e57ed83df Fix MPI test usage
Only display usage from rank 0 and exit instead of continuing (and seg fault).


[ROCm/rccl commit: 9de361a1b9]
2016-04-19 10:43:38 -07:00
Nathan Luehr 16379ec27b Added NCCL error checking to tests.
Also cleaned up makefile so that tests and lib are not built unnecessarily.

Change-Id: Ia0c596cc2213628de2f066be97615c09bb1bb262
Reviewed-on: http://git-master/r/999627
Reviewed-by: Przemek Tredak <ptredak@nvidia.com>
Tested-by: Przemek Tredak <ptredak@nvidia.com>


[ROCm/rccl commit: 2758353380]
2016-01-29 11:09:05 -08:00
Sylvain Jeaugey 42c3edc35a Moved tests to separate dir and improved MPI test
test sources moved to test/ directory.
MPI test displays PASS/FAIL and returns code accordingly.

Change-Id: I058ebd1bd5202d8f38cc9787898b2480100c102b
Reviewed-on: http://git-master/r/936086
Reviewed-by: Przemek Tredak <ptredak@nvidia.com>
Tested-by: Przemek Tredak <ptredak@nvidia.com>


[ROCm/rccl commit: c05312f151]
2016-01-28 12:56:36 -08:00