/* Copyright (c) 2022 Advanced Micro Devices, Inc. All rights reserved. Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */ #include #include #include #include "graph_dependency_common.hh" /** * @addtogroup hipGraphAddDependencies hipGraphAddDependencies * @{ * @ingroup GraphTest * `hipGraphAddDependencies(hipGraph_t graph, const hipGraphNode_t *from, const hipGraphNode_t *to, * size_t numDependencies)` - adds dependency edges to a graph */ /** * Test Description * ------------------------ * - Functional Test for adding dependencies in graph and verifying execution: * -# Create dependencies node by node * -# Create dependencies with node lists * Test source * ------------------------ * - catch\unit\graph\hipGraphAddDependencies.cc * Test requirements * ------------------------ * - HIP_VERSION >= 5.2 */ TEST_CASE("Unit_hipGraphAddDependencies_Positive_Functional") { constexpr size_t N = 1024; hipGraph_t graph; hipStream_t streamForGraph; int *A_d, *B_d, *C_d; int *A_h, *B_h, *C_h; hipGraphExec_t graphExec; HIP_CHECK(hipStreamCreate(&streamForGraph)); HipTest::initArrays(&A_d, &B_d, &C_d, &A_h, &B_h, &C_h, N, false); HIP_CHECK(hipGraphCreate(&graph, 0)); std::vector from_nodes; std::vector to_nodes; std::vector nodelist; graphNodesCommon(graph, A_h, A_d, B_h, B_d, C_h, C_d, N, from_nodes, to_nodes, nodelist); SECTION("Create dependencies node by node") { // Create dependencies HIP_CHECK(hipGraphAddDependencies(graph, &from_nodes[0], &to_nodes[0], 1)); HIP_CHECK(hipGraphAddDependencies(graph, &from_nodes[1], &to_nodes[1], 1)); HIP_CHECK(hipGraphAddDependencies(graph, &from_nodes[2], &to_nodes[2], 1)); HIP_CHECK(hipGraphAddDependencies(graph, &from_nodes[3], &to_nodes[3], 1)); HIP_CHECK(hipGraphAddDependencies(graph, &from_nodes[4], &to_nodes[4], 1)); HIP_CHECK(hipGraphAddDependencies(graph, &from_nodes[5], &to_nodes[5], 1)); } SECTION("Create dependencies with node lists") { hipGraphNode_t* from_list = &from_nodes[0]; hipGraphNode_t* to_list = &to_nodes[0]; // Create dependencies HIP_CHECK(hipGraphAddDependencies(graph, from_list, to_list, 6)); } // Instantiate and launch the graph HIP_CHECK(hipGraphInstantiate(&graphExec, graph, nullptr, nullptr, 0)); HIP_CHECK(hipGraphLaunch(graphExec, streamForGraph)); HIP_CHECK(hipStreamSynchronize(streamForGraph)); // Verify graph execution result HipTest::checkVectorADD(A_h, B_h, C_h, N); HipTest::freeArrays(A_d, B_d, C_d, A_h, B_h, C_h, false); HIP_CHECK(hipGraphExecDestroy(graphExec)); HIP_CHECK(hipGraphDestroy(graph)); HIP_CHECK(hipStreamDestroy(streamForGraph)); } /** * Test Description * ------------------------ * - Test to verify API behavior with special cases of valid arguments: * -# numDependencies is zero, To/From are nullptr * -# numDependencies is zero, To or From are nullptr * -# numDependencies is zero, To/From are valid * -# numDependencies is zero, To/From are the same * -# numDependencies < To/From length * Test source * ------------------------ * - catch\unit\graph\hipGraphAddDependencies.cc * Test requirements * ------------------------ * - HIP_VERSION >= 5.2 */ TEST_CASE("Unit_hipGraphAddDependencies_Positive_Parameters") { constexpr size_t Nbytes = 1024; hipGraphNode_t memcpyH2D_A; hipGraphNode_t memcpyD2H_A; hipGraphNode_t memset_A; hipMemsetParams memsetParams{}; char* A_d; char* A_h; hipGraph_t graph; HIP_CHECK(hipGraphCreate(&graph, 0)); HIP_CHECK(hipMalloc(&A_d, Nbytes)); A_h = reinterpret_cast(malloc(Nbytes)); memset(&memsetParams, 0, sizeof(memsetParams)); memsetParams.dst = reinterpret_cast(A_d); memsetParams.value = 0; memsetParams.pitch = 0; memsetParams.elementSize = sizeof(char); memsetParams.width = Nbytes; memsetParams.height = 1; HIP_CHECK(hipGraphAddMemsetNode(&memset_A, graph, nullptr, 0, &memsetParams)); HIP_CHECK(hipGraphAddMemcpyNode1D(&memcpyH2D_A, graph, nullptr, 0, A_d, A_h, Nbytes, hipMemcpyHostToDevice)); HIP_CHECK(hipGraphAddMemcpyNode1D(&memcpyD2H_A, graph, nullptr, 0, A_h, A_d, Nbytes, hipMemcpyDeviceToHost)); SECTION("numDependencies is zero, To/From are nullptr") { HIP_CHECK(hipGraphAddDependencies(graph, nullptr, nullptr, 0)); } SECTION("numDependencies is zero, To or From are nullptr") { HIP_CHECK(hipGraphAddDependencies(graph, &memcpyH2D_A, nullptr, 0)); HIP_CHECK(hipGraphAddDependencies(graph, nullptr, &memcpyH2D_A, 0)); } SECTION("numDependencies is zero, To/From are valid") { HIP_CHECK(hipGraphAddDependencies(graph, &memcpyH2D_A, &memcpyD2H_A, 0)); } SECTION("numDependencies is zero, To/From are the same") { HIP_CHECK(hipGraphAddDependencies(graph, &memcpyH2D_A, &memcpyH2D_A, 0)); } SECTION("numDependencies < To/From length") { size_t numDependencies = 0; hipGraphNode_t from_list[] = {memset_A, memcpyH2D_A}; hipGraphNode_t to_list[] = {memcpyH2D_A, memcpyD2H_A}; HIP_CHECK(hipGraphAddDependencies(graph, from_list, to_list, 1)); HIP_CHECK(hipGraphNodeGetDependencies(memcpyH2D_A, nullptr, &numDependencies)); REQUIRE(numDependencies == 1); HIP_CHECK(hipGraphNodeGetDependencies(memcpyD2H_A, nullptr, &numDependencies)); REQUIRE(numDependencies == 0); } // Destroy HIP_CHECK(hipFree(A_d)); HIP_CHECK(hipGraphDestroy(graph)); free(A_h); } /** * Test Description * ------------------------ * - Test to verify API behavior with invalid arguments: * -# Null Graph * -# Graph is uninitialized * -# To or From is nullptr * -# To/From are null graph node * -# From belongs to different graph * -# To belongs to different graph * -# From is uninitialized * -# To is uninitialized * -# Duplicate Dependencies * -# Same Node Dependencies * -# numDependencies > To/From length * Test source * ------------------------ * - catch\unit\graph\hipGraphAddDependencies.cc * Test requirements * ------------------------ * - HIP_VERSION >= 5.2 */ TEST_CASE("Unit_hipGraphAddDependencies_Negative_Parameters") { // Initialize constexpr size_t Nbytes = 1024; hipGraph_t graph; HIP_CHECK(hipGraphCreate(&graph, 0)); char* A_d; hipGraphNode_t memset_A; hipMemsetParams memsetParams{}; HIP_CHECK(hipMalloc(&A_d, Nbytes)); memset(&memsetParams, 0, sizeof(memsetParams)); memsetParams.dst = reinterpret_cast(A_d); memsetParams.value = 0; memsetParams.pitch = 0; memsetParams.elementSize = sizeof(char); memsetParams.width = Nbytes; memsetParams.height = 1; hipGraphNode_t memcpyH2D_A; hipGraphNode_t memcpyD2H_A; char* A_h; A_h = reinterpret_cast(malloc(Nbytes)); SECTION("Null Graph") { HIP_CHECK(hipGraphAddMemsetNode(&memset_A, graph, nullptr, 0, &memsetParams)); HIP_CHECK(hipGraphAddMemcpyNode1D(&memcpyH2D_A, graph, nullptr, 0, A_d, A_h, Nbytes, hipMemcpyHostToDevice)); HIP_CHECK_ERROR(hipGraphAddDependencies(nullptr, &memset_A, &memcpyH2D_A, 1), hipErrorInvalidValue); } SECTION("graph is uninitialized") { hipGraph_t graph_uninit{}; HIP_CHECK_ERROR(hipGraphAddDependencies(graph_uninit, &memset_A, &memcpyH2D_A, 1), hipErrorInvalidValue); } SECTION("To or From is nullptr") { HIP_CHECK(hipGraphAddMemsetNode(&memset_A, graph, nullptr, 0, &memsetParams)); HIP_CHECK_ERROR(hipGraphAddDependencies(graph, &memset_A, nullptr, 1), hipErrorInvalidValue); HIP_CHECK_ERROR(hipGraphAddDependencies(graph, nullptr, &memset_A, 1), hipErrorInvalidValue); } SECTION("To/From are nullptr") { HIP_CHECK_ERROR(hipGraphAddDependencies(graph, nullptr, nullptr, 1), hipErrorInvalidValue); } SECTION("From belongs to different graph") { hipGraph_t graph1; HIP_CHECK(hipGraphCreate(&graph1, 0)); HIP_CHECK(hipGraphAddMemsetNode(&memset_A, graph1, nullptr, 0, &memsetParams)); HIP_CHECK(hipGraphAddMemcpyNode1D(&memcpyH2D_A, graph, nullptr, 0, A_d, A_h, Nbytes, hipMemcpyHostToDevice)); HIP_CHECK_ERROR(hipGraphAddDependencies(graph, &memset_A, &memcpyH2D_A, 1), hipErrorInvalidValue); HIP_CHECK(hipGraphDestroy(graph1)); } SECTION("To belongs to different graph") { hipGraph_t graph1; HIP_CHECK(hipGraphCreate(&graph1, 0)); HIP_CHECK(hipGraphAddMemsetNode(&memset_A, graph, nullptr, 0, &memsetParams)); HIP_CHECK(hipGraphAddMemcpyNode1D(&memcpyH2D_A, graph1, nullptr, 0, A_d, A_h, Nbytes, hipMemcpyHostToDevice)); HIP_CHECK_ERROR(hipGraphAddDependencies(graph, &memset_A, &memcpyH2D_A, 1), hipErrorInvalidValue); HIP_CHECK(hipGraphDestroy(graph1)); } SECTION("From is uninitialized") { HIP_CHECK(hipGraphAddMemcpyNode1D(&memcpyH2D_A, graph, nullptr, 0, A_d, A_h, Nbytes, hipMemcpyHostToDevice)); HIP_CHECK_ERROR(hipGraphAddDependencies(graph, &memset_A, &memcpyH2D_A, 1), hipErrorInvalidValue); } SECTION("To is uninitialized") { HIP_CHECK(hipGraphAddMemsetNode(&memset_A, graph, nullptr, 0, &memsetParams)); HIP_CHECK_ERROR(hipGraphAddDependencies(graph, &memset_A, &memcpyH2D_A, 1), hipErrorInvalidValue); } SECTION("Duplicate Dependencies") { HIP_CHECK(hipGraphAddMemsetNode(&memset_A, graph, nullptr, 0, &memsetParams)); HIP_CHECK(hipGraphAddMemcpyNode1D(&memcpyH2D_A, graph, nullptr, 0, A_d, A_h, Nbytes, hipMemcpyHostToDevice)); HIP_CHECK(hipGraphAddDependencies(graph, &memset_A, &memcpyH2D_A, 1)); HIP_CHECK_ERROR(hipGraphAddDependencies(graph, &memset_A, &memcpyH2D_A, 1), hipErrorInvalidValue); } SECTION("Same Node Dependencies") { HIP_CHECK(hipGraphAddMemsetNode(&memset_A, graph, nullptr, 0, &memsetParams)); HIP_CHECK_ERROR(hipGraphAddDependencies(graph, &memset_A, &memset_A, 1), hipErrorInvalidValue); } SECTION("numDependencies > To/From length") { HIP_CHECK(hipGraphAddMemsetNode(&memset_A, graph, nullptr, 0, &memsetParams)); HIP_CHECK(hipGraphAddMemcpyNode1D(&memcpyH2D_A, graph, nullptr, 0, A_d, A_h, Nbytes, hipMemcpyHostToDevice)); HIP_CHECK(hipGraphAddMemcpyNode1D(&memcpyD2H_A, graph, nullptr, 0, A_h, A_d, Nbytes, hipMemcpyDeviceToHost)); hipGraphNode_t from_list[] = {memset_A, memcpyH2D_A}; hipGraphNode_t to_list[] = {memcpyH2D_A, memcpyD2H_A}; HIP_CHECK_ERROR(hipGraphAddDependencies(graph, from_list, to_list, 3), hipErrorInvalidValue); } // Destroy HIP_CHECK(hipFree(A_d)); HIP_CHECK(hipGraphDestroy(graph)); free(A_h); } /** * End doxygen group GraphTest. * @} */