/* Copyright (c) 2022 Advanced Micro Devices, Inc. All rights reserved. Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */ /* hipMalloc3DArray API test scenarios 1. Basic Functionality 2. Negative Scenarios 3. Allocating Small and big chunk data 4. Multithreaded scenario */ #include #include #include "hipArrayCommon.hh" static constexpr auto ARRAY_SIZE{4}; static constexpr auto BIG_ARRAY_SIZE{100}; static constexpr auto ARRAY_LOOP{100}; /* * This API verifies memory allocations for small and * bigger chunks of data. * Two scenarios are verified in this API * 1. SmallArray: Allocates ARRAY_SIZE in a loop and * releases the memory and verifies the meminfo. * 2. BigArray: Allocates BIG_ARRAY_SIZE in a loop and * releases the memory and verifies the meminfo * * In both cases, the memory info before allocation and * after releasing the memory should be the same * */ static void Malloc3DArray_DiffSizes(int gpu) { HIP_CHECK_THREAD(hipSetDevice(gpu)); //Use of GENERATE in thead function causes random failures with multithread condition. std::vector runs {ARRAY_SIZE, BIG_ARRAY_SIZE}; for (const auto& size : runs) { size_t width{size}, height{size}, depth{size}; hipChannelFormatDesc channelDesc = hipCreateChannelDesc(); std::array arr; for (int i = 0; i < ARRAY_LOOP; i++) { HIP_CHECK_THREAD(hipMalloc3DArray(&arr[i], &channelDesc, make_hipExtent(width, height, depth), hipArrayDefault)); } for (int i = 0; i < ARRAY_LOOP; i++) { HIP_CHECK_THREAD(hipFreeArray(arr[i])); } } } TEST_CASE("Unit_hipMalloc3DArray_DiffSizes") { CHECK_IMAGE_SUPPORT Malloc3DArray_DiffSizes(0); HIP_CHECK_THREAD_FINALIZE(); } /* This testcase verifies the hipMalloc3DArray API in multithreaded scenario by launching threads in parallel on multiple GPUs and verifies the hipMalloc3DArray API with small and big chunks data */ TEST_CASE("Unit_hipMalloc3DArray_MultiThread") { CHECK_IMAGE_SUPPORT std::vector threadlist; int devCnt = 0; devCnt = HipTest::getDeviceCount(); for (int i = 0; i < devCnt; i++) { threadlist.push_back(std::thread(Malloc3DArray_DiffSizes, i)); } for (auto& t : threadlist) { t.join(); } HIP_CHECK_THREAD_FINALIZE(); } namespace { void checkArrayIsExpected(hipArray_t array, const hipChannelFormatDesc& expected_desc, const hipExtent& expected_extent, const unsigned int expected_flags) { // hipArrayGetInfo doesn't currently exist (EXSWCPHIPT-87) #if HT_AMD std::ignore = array; std::ignore = expected_desc; std::ignore = expected_extent; std::ignore = expected_flags; #else cudaChannelFormatDesc queried_desc; cudaExtent queried_extent; unsigned int queried_flags; cudaArrayGetInfo(&queried_desc, &queried_extent, &queried_flags, array); REQUIRE(expected_desc.x == queried_desc.x); REQUIRE(expected_desc.y == queried_desc.y); REQUIRE(expected_desc.z == queried_desc.z); REQUIRE(expected_desc.f == queried_desc.f); REQUIRE(expected_extent.width == queried_extent.width); REQUIRE(expected_extent.height == queried_extent.height); REQUIRE(expected_extent.depth == queried_extent.depth); REQUIRE(expected_flags == queried_flags); #endif } } // namespace TEMPLATE_TEST_CASE("Unit_hipMalloc3DArray_happy", "", char, uchar2, uint2, int4, short4, float, float2, float4) { CHECK_IMAGE_SUPPORT hipArray_t array; const auto desc = hipCreateChannelDesc(); #if HT_AMD const unsigned int flags = hipArrayDefault; #else const unsigned int flags = GENERATE(hipArrayDefault, hipArraySurfaceLoadStore, hipArrayTextureGather); #endif constexpr size_t size = 64; std::vector extents; extents.reserve(3); extents.push_back({size, size, 0}); // 2D array if (flags != hipArrayTextureGather) { extents.push_back({size, 0, 0}); // 1D array extents.push_back({size, size, size}); // 3D array }; for (const auto extent : extents) { CAPTURE(flags, extent.width, extent.height, extent.depth); HIP_CHECK(hipMalloc3DArray(&array, &desc, extent, flags)); checkArrayIsExpected(array, desc, extent, flags); HIP_CHECK(hipFreeArray(array)); } } TEMPLATE_TEST_CASE("Unit_hipMalloc3DArray_MaxTexture", "", int, uint4, short, ushort2, unsigned char, float, float4) { CHECK_IMAGE_SUPPORT hipArray_t array; const hipChannelFormatDesc desc = hipCreateChannelDesc(); #if HT_AMD const unsigned int flag = hipArrayDefault; #else const unsigned int flag = GENERATE(hipArrayDefault, hipArraySurfaceLoadStore); #endif if (flag == hipArraySurfaceLoadStore) { HipTest::HIP_SKIP_TEST("EXSWCPHIPT-58"); return; } CAPTURE(flag); const Sizes sizes(flag); CAPTURE(sizes.max1D, sizes.max2D, sizes.max3D); const size_t s = 64; SECTION("Happy") { // stored in a vector so some values can be ifdef'd out std::vector extentsToTest{ make_hipExtent(sizes.max1D, 0, 0), // 1D max make_hipExtent(sizes.max2D[0], s, 0), // 2D max width make_hipExtent(s, sizes.max2D[1], 0), // 2D max height make_hipExtent(sizes.max2D[0], sizes.max2D[1], 0), // 2D max make_hipExtent(sizes.max3D[0], s, s), // 3D max width make_hipExtent(s, sizes.max3D[1], s), // 3D max height make_hipExtent(s, s, sizes.max3D[2]), // 3D max depth make_hipExtent(s, sizes.max3D[1], sizes.max3D[2]), // 3D max height and depth make_hipExtent(sizes.max3D[0], s, sizes.max3D[2]), // 3D max width and depth make_hipExtent(sizes.max3D[0], sizes.max3D[1], s), // 3D max width and height make_hipExtent(sizes.max3D[0], sizes.max3D[1], sizes.max3D[2]) // 3D max }; const auto extent = GENERATE_COPY(from_range(std::begin(extentsToTest), std::end(extentsToTest))); CAPTURE(extent.width, extent.height, extent.depth); auto maxArrayCreateError = hipMalloc3DArray(&array, &desc, extent, flag); // this can try to alloc many GB of memory, so out of memory is acceptable if (maxArrayCreateError == hipErrorOutOfMemory) return; HIP_CHECK(maxArrayCreateError); checkArrayIsExpected(array, desc, extent, flag); HIP_CHECK(hipFreeArray(array)); } SECTION("Negative") { std::vector extentsToTest { make_hipExtent(sizes.max1D + 1, 0, 0), // 1D max make_hipExtent(sizes.max2D[0] + 1, s, 0), // 2D max width make_hipExtent(s, sizes.max2D[1] + 1, 0), // 2D max height make_hipExtent(sizes.max2D[0] + 1, sizes.max2D[1] + 1, 0), // 2D max make_hipExtent(sizes.max3D[0] + 1, s, s), // 3D max width make_hipExtent(s, sizes.max3D[1] + 1, s), // 3D max height #if !HT_NVIDIA // leads to hipSuccess on NVIDIA make_hipExtent(s, s, sizes.max3D[2] + 1), // 3D max depth #endif make_hipExtent(s, sizes.max3D[1] + 1, sizes.max3D[2] + 1), // 3D max height and depth make_hipExtent(sizes.max3D[0] + 1, s, sizes.max3D[2] + 1), // 3D max width and depth make_hipExtent(sizes.max3D[0] + 1, sizes.max3D[1] + 1, s), // 3D max width and height make_hipExtent(sizes.max3D[0] + 1, sizes.max3D[1] + 1, sizes.max3D[2] + 1) // 3D max }; const auto extent = GENERATE_COPY(from_range(std::begin(extentsToTest), std::end(extentsToTest))); CAPTURE(extent.width, extent.height, extent.depth); HIP_CHECK_ERROR(hipMalloc3DArray(&array, &desc, extent, flag), hipErrorInvalidValue); } } #if HT_AMD constexpr std::array validFlags{hipArrayDefault}; #else constexpr std::array validFlags{ hipArrayDefault, hipArrayDefault | hipArraySurfaceLoadStore, hipArrayLayered, hipArrayLayered | hipArraySurfaceLoadStore, hipArrayCubemap, hipArrayCubemap | hipArrayLayered, hipArrayCubemap | hipArraySurfaceLoadStore, hipArrayCubemap | hipArrayLayered | hipArraySurfaceLoadStore, hipArrayTextureGather}; #endif hipExtent makeExtent(unsigned int flag, size_t s) { if (flag == hipArrayTextureGather) { return make_hipExtent(s, s, 0); } return make_hipExtent(s, s, s); } // Providing the array pointer as nullptr should return an error TEST_CASE("Unit_hipMalloc3DArray_Negative_NullArrayPtr") { CHECK_IMAGE_SUPPORT hipChannelFormatDesc desc = hipCreateChannelDesc(); constexpr size_t s = 6; const auto flag = GENERATE(from_range(std::begin(validFlags), std::end(validFlags))); HIP_CHECK_ERROR(hipMalloc3DArray(nullptr, &desc, makeExtent(flag, s), flag), hipErrorInvalidValue); } // Providing the description pointer as nullptr should return an error TEST_CASE("Unit_hipMalloc3DArray_Negative_NullDescPtr") { CHECK_IMAGE_SUPPORT constexpr size_t s = 6; // 6 to keep cubemap happy hipArray_t array; const auto flag = GENERATE(from_range(std::begin(validFlags), std::end(validFlags))); HIP_CHECK_ERROR(hipMalloc3DArray(&array, nullptr, makeExtent(flag, s), flag), hipErrorInvalidValue); } // Zero width arrays are not allowed TEST_CASE("Unit_hipMalloc3DArray_Negative_ZeroWidth") { CHECK_IMAGE_SUPPORT constexpr size_t s = 6; // 6 to keep cubemap happy hipArray_t array; hipChannelFormatDesc desc = hipCreateChannelDesc(); const auto flag = GENERATE(from_range(std::begin(validFlags), std::end(validFlags))); HIP_CHECK_ERROR(hipMalloc3DArray(&array, &desc, make_hipExtent(0, s, s), flag), hipErrorInvalidValue); } // Zero height arrays are only allowed for 1D arrays and layered arrays TEST_CASE("Unit_hipMalloc3DArray_Negative_ZeroHeight") { CHECK_IMAGE_SUPPORT constexpr size_t s = 6; // 6 to keep cubemap happy hipArray_t array; hipChannelFormatDesc desc = hipCreateChannelDesc(); std::array exceptions{hipArrayLayered, hipArrayLayered | hipArraySurfaceLoadStore}; const auto flag = GENERATE(from_range(std::begin(validFlags), std::end(validFlags))); if (std::find(std::begin(exceptions), std::end(exceptions), flag) == std::end(exceptions)) { // flag is not in list of exceptions HIP_CHECK_ERROR(hipMalloc3DArray(&array, &desc, make_hipExtent(s, 0, s), flag), hipErrorInvalidValue); } } TEST_CASE("Unit_hipMalloc3DArray_Negative_InvalidFlags") { CHECK_IMAGE_SUPPORT constexpr size_t s = 6; // 6 to keep cubemap happy hipArray_t array; hipChannelFormatDesc desc = hipCreateChannelDesc(); #if HT_AMD const unsigned int flag = 0xDEADBEEF; #else const unsigned int flag = GENERATE(0xDEADBEEF, hipArrayTextureGather | hipArraySurfaceLoadStore, hipArrayTextureGather | hipArrayCubemap, hipArrayTextureGather | hipArraySurfaceLoadStore | hipArrayCubemap); #endif CAPTURE(flag); REQUIRE(std::find(std::begin(validFlags), std::end(validFlags), flag) == std::end(validFlags)); HIP_CHECK_ERROR(hipMalloc3DArray(&array, &desc, makeExtent(flag, s), flag), hipErrorInvalidValue); } void testInvalidDescription(hipChannelFormatDesc desc) { constexpr size_t s = 6; // 6 to keep cubemap happy hipArray_t array; #if HT_NVIDIA hipError_t expectedError = hipErrorUnknown; #else hipError_t expectedError = hipErrorInvalidValue; #endif const auto flag = GENERATE(from_range(std::begin(validFlags), std::end(validFlags))); HIP_CHECK_ERROR(hipMalloc3DArray(&array, &desc, makeExtent(flag, s), flag), expectedError); } TEST_CASE("Unit_hipMalloc3DArray_Negative_InvalidFormat") { CHECK_IMAGE_SUPPORT hipChannelFormatDesc desc = hipCreateChannelDesc(); desc.f = GENERATE(hipChannelFormatKindNone, 0xBEEF); testInvalidDescription(desc); } TEST_CASE("Unit_hipMalloc3DArray_Negative_BadChannelLayout") { CHECK_IMAGE_SUPPORT const int bits = GENERATE(8, 16, 32); const hipChannelFormatKind formatKind = GENERATE(hipChannelFormatKindSigned, hipChannelFormatKindUnsigned, hipChannelFormatKindFloat); if (bits == 8 && formatKind == hipChannelFormatKindFloat) return; hipChannelFormatDesc desc = GENERATE_COPY(hipCreateChannelDesc(bits, bits, bits, 0, formatKind), hipCreateChannelDesc(0, bits, bits, 0, formatKind), hipCreateChannelDesc(0, bits, bits, bits, formatKind), hipCreateChannelDesc(bits, 0, bits, 0, formatKind), hipCreateChannelDesc(bits, bits, 0, bits, formatKind), hipCreateChannelDesc(0, 0, bits, 0, formatKind), hipCreateChannelDesc(0, 0, bits, bits, formatKind)); INFO("kind: " << channelFormatString(formatKind)); INFO("x: " << desc.x << ", y: " << desc.y << ", z: " << desc.z << ", w: " << desc.w); testInvalidDescription(desc); } TEST_CASE("Unit_hipMalloc3DArray_Negative_8BitFloat") { CHECK_IMAGE_SUPPORT hipChannelFormatDesc desc = GENERATE(hipCreateChannelDesc(8, 0, 0, 0, hipChannelFormatKindFloat), hipCreateChannelDesc(8, 8, 0, 0, hipChannelFormatKindFloat), hipCreateChannelDesc(8, 8, 8, 8, hipChannelFormatKindFloat)); testInvalidDescription(desc); } TEST_CASE("Unit_hipMalloc3DArray_Negative_DifferentChannelSizes") { CHECK_IMAGE_SUPPORT const int bitsX = GENERATE(8, 16, 32); const int bitsY = GENERATE(8, 16, 32); const int bitsZ = GENERATE(8, 16, 32); const int bitsW = GENERATE(8, 16, 32); if (bitsX == bitsY && bitsY == bitsZ && bitsZ == bitsW) return; // skip when they are equal const hipChannelFormatKind channelFormat = GENERATE(hipChannelFormatKindSigned, hipChannelFormatKindUnsigned, hipChannelFormatKindFloat); if (channelFormat == hipChannelFormatKindFloat && (bitsX == 8 || bitsY == 8 || bitsZ == 8 || bitsW == 8)) return; // 8 bit floats aren't allowed hipChannelFormatDesc desc = hipCreateChannelDesc(bitsX, bitsY, bitsZ, bitsW, channelFormat); INFO("format: " << channelFormatString(channelFormat) << ", x bits: " << bitsX << ", y bits: " << bitsY << ", z bits: " << bitsZ << ", w bits: " << bitsW); testInvalidDescription(desc); } TEST_CASE("Unit_hipMalloc3DArray_Negative_BadChannelSize") { CHECK_IMAGE_SUPPORT const int badBits = GENERATE(-1, 0, 10, 100); const hipChannelFormatKind formatKind = GENERATE(hipChannelFormatKindSigned, hipChannelFormatKindUnsigned, hipChannelFormatKindFloat); hipChannelFormatDesc desc = hipCreateChannelDesc(badBits, badBits, badBits, badBits, formatKind); INFO("Number of bits: " << badBits); testInvalidDescription(desc); } // hipMalloc3DArray should handle the max numeric value gracefully. TEST_CASE("Unit_hipMalloc3DArray_Negative_NumericLimit") { CHECK_IMAGE_SUPPORT hipArray_t arrayPtr; hipChannelFormatDesc desc = hipCreateChannelDesc(); size_t size = std::numeric_limits::max(); const auto flag = GENERATE(from_range(std::begin(validFlags), std::end(validFlags))); HIP_CHECK_ERROR(hipMalloc3DArray(&arrayPtr, &desc, makeExtent(flag, size), flag), hipErrorInvalidValue); } // texture gather arrays are only allowed to be 2D TEMPLATE_TEST_CASE("Unit_hipMalloc3DArray_Negative_Non2DTextureGather", "", char, uchar2, short4, float2, float4) { #if HT_AMD HipTest::HIP_SKIP_TEST("Texture Gather arrays not supported using AMD backend"); return; #endif hipArray_t array; const auto desc = hipCreateChannelDesc(); constexpr unsigned int flags = hipArrayTextureGather; constexpr size_t size = 64; const hipExtent extent = GENERATE(make_hipExtent(size, 0, 0), make_hipExtent(size, size, size)); HIP_CHECK_ERROR(hipMalloc3DArray(&array, &desc, extent, flags), hipErrorInvalidValue); }