JonathanLichtnerAMD
f31afe1d20
hipMemPtrGetInfo was returning the error hipErrorInvalidValue if it was called on a nullptr. However, this does not match the malloc convention where a nullptr has size zero; for example, malloc_usable_size() returns zero if called on a nullptr. This commit changes hipMemPtrGetInfo to set the size to zero and return hipSuccess when called with a nullptr. (This also fits with hipMalloc and hipFree usage, since hipMalloc of size zero results in a nullptr, and hipFree of a nullptr is successful.)
73 línte
2.4 KiB
C++
73 línte
2.4 KiB
C++
/*
|
|
Copyright (c) 2021 - 2025 Advanced Micro Devices, Inc. All rights reserved.
|
|
|
|
Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
of this software and associated documentation files (the "Software"), to deal
|
|
in the Software without restriction, including without limitation the rights
|
|
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
copies of the Software, and to permit persons to whom the Software is
|
|
furnished to do so, subject to the following conditions:
|
|
|
|
The above copyright notice and this permission notice shall be included in
|
|
all copies or substantial portions of the Software.
|
|
|
|
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
THE SOFTWARE.
|
|
*/
|
|
|
|
/*
|
|
This testfile verifies the basic scenario of hipMemPtrGetInfo API
|
|
*/
|
|
#include <hip_test_common.hh>
|
|
struct MemInfo {
|
|
float a;
|
|
int b;
|
|
void* c;
|
|
};
|
|
|
|
/*
|
|
This testcase verifies the basic scenario of
|
|
hipMemPtrGetInfo API
|
|
1. Allocates specific size of memory for the variables
|
|
2. Gets the allocated size of that variable using hipMemPtrGetInfo API
|
|
3. Validates the initial size and allocated size
|
|
*/
|
|
TEST_CASE("Unit_hipMemPtrGetInfo_Basic") {
|
|
int* iPtr;
|
|
float* fPtr;
|
|
MemInfo* sPtr;
|
|
size_t sSetSize = 1024, sGetSize;
|
|
HIP_CHECK(hipMalloc(&iPtr, sSetSize));
|
|
HIP_CHECK(hipMalloc(&fPtr, sSetSize));
|
|
HIP_CHECK(hipMalloc(&sPtr, sSetSize));
|
|
HIP_CHECK(hipMemPtrGetInfo(iPtr, &sGetSize));
|
|
REQUIRE(sGetSize == sSetSize);
|
|
HIP_CHECK(hipMemPtrGetInfo(fPtr, &sGetSize));
|
|
REQUIRE(sGetSize == sSetSize);
|
|
HIP_CHECK(hipMemPtrGetInfo(sPtr, &sGetSize));
|
|
REQUIRE(sGetSize == sSetSize);
|
|
|
|
HIP_CHECK(hipFree(iPtr));
|
|
HIP_CHECK(hipFree(fPtr));
|
|
HIP_CHECK(hipFree(sPtr));
|
|
}
|
|
|
|
/*
|
|
This testcase verifies the scenario of
|
|
hipMemPtrGetInfo API being called on a zero-sized allocation.
|
|
*/
|
|
TEST_CASE("Unit_hipMemPtrGetInfo_SizeZeroAllocation") {
|
|
int* iPtr;
|
|
size_t sSetSize = 0, sGetSize;
|
|
HIP_CHECK(hipMalloc(&iPtr, sSetSize));
|
|
HIP_CHECK(hipMemPtrGetInfo(iPtr, &sGetSize));
|
|
REQUIRE(sGetSize == sSetSize);
|
|
|
|
HIP_CHECK(hipFree(iPtr));
|
|
}
|