Mythreya Kuricheti
36d9d33d90
* [rocprofiler-sdk] Fix fmt::join build errors - remedy use of fmt::join without include <fmt/ranges.h> * include memory header * Disable FMT build for SDK CI * Add -DROCPROFILER_BUILD_FMT=OFF to sanitizer steps * Add temporary workaround for rccl.h issue * Add ROCPROFILER_INTERNAL_RCCL_API_TRACE to SDK CI builds * disable clang-tidy for vendored includes --------- Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com> Co-authored-by: jbonnell-amd <jason.bonnell@amd.com>
101 строка
3.6 KiB
CMake
101 строка
3.6 KiB
CMake
# ----------------------------------------------------------------------------------------#
|
|
#
|
|
# Clang Tidy
|
|
#
|
|
# ----------------------------------------------------------------------------------------#
|
|
|
|
include_guard(DIRECTORY)
|
|
|
|
include(rocprofiler_utilities)
|
|
|
|
if(ROCPROFILER_BUILD_DEVELOPER)
|
|
set(_TIDY_REQUIRED REQUIRED)
|
|
else()
|
|
set(_TIDY_REQUIRED)
|
|
endif()
|
|
|
|
# checks that clang-tidy is version >= 15.x.x and < 20.x.x
|
|
function(_rocprofiler_check_clang_tidy_version _OUT _EXE)
|
|
execute_process(
|
|
COMMAND ${_EXE} --version
|
|
WORKING_DIRECTORY ${PROJECT_BINARY_DIR}
|
|
OUTPUT_VARIABLE _CLANG_TIDY_OUT
|
|
RESULT_VARIABLE _CLANG_TIDY_RET
|
|
OUTPUT_STRIP_TRAILING_WHITESPACE ERROR_QUIET)
|
|
if(_CLANG_TIDY_RET EQUAL 0 AND "${_CLANG_TIDY_OUT}" MATCHES
|
|
"version 1[5-9]\\.([0-9]+)\\.([0-9]+)")
|
|
set(${_OUT}
|
|
ON
|
|
PARENT_SCOPE)
|
|
else()
|
|
set(${_OUT}
|
|
OFF
|
|
PARENT_SCOPE)
|
|
endif()
|
|
endfunction()
|
|
|
|
_rocprofiler_get_python_user_bin(_PYTHON_USER_BIN)
|
|
if(NOT ROCPROFILER_CLANG_TIDY_EXE
|
|
AND _PYTHON_USER_BIN
|
|
AND EXISTS "${_PYTHON_USER_BIN}/clang-tidy")
|
|
_rocprofiler_check_clang_tidy_version(_IS_VALID_CLANG_TIDY
|
|
"${_PYTHON_USER_BIN}/clang-tidy")
|
|
if(_IS_VALID_CLANG_TIDY)
|
|
set(ROCPROFILER_CLANG_TIDY_EXE
|
|
"${_PYTHON_USER_BIN}/clang-tidy"
|
|
CACHE FILEPATH "clang-tidy exe")
|
|
endif()
|
|
endif()
|
|
|
|
find_program(
|
|
ROCPROFILER_CLANG_TIDY_EXE ${_TIDY_REQUIRED}
|
|
NAMES clang-tidy-19 clang-tidy-18 clang-tidy-17 clang-tidy-16 clang-tidy-15 clang-tidy
|
|
PATHS ${_PYTHON_USER_BIN}
|
|
HINTS ${_PYTHON_USER_BIN}
|
|
PATH_SUFFIXES bin)
|
|
|
|
_rocprofiler_check_clang_tidy_version(_IS_VALID_CLANG_TIDY
|
|
"${ROCPROFILER_CLANG_TIDY_EXE}")
|
|
if(NOT _IS_VALID_CLANG_TIDY)
|
|
if(ROCPROFILER_BUILD_DEVELOPER)
|
|
message(
|
|
AUTHOR_WARNING
|
|
"[rocprofiler] clang-tidy version >= 15, < 20 not found. Please see rocprofiler-sdk CONTRIBUTING.md for instructions on installing clang-tidy"
|
|
)
|
|
endif()
|
|
unset(ROCPROFILER_CLANG_TIDY_EXE CACHE)
|
|
endif()
|
|
|
|
macro(ROCPROFILER_ACTIVATE_CLANG_TIDY)
|
|
if(ROCPROFILER_ENABLE_CLANG_TIDY)
|
|
if(NOT ROCPROFILER_CLANG_TIDY_EXE)
|
|
message(
|
|
FATAL_ERROR
|
|
"ROCPROFILER_ENABLE_CLANG_TIDY is ON but clang-tidy is not found!")
|
|
endif()
|
|
|
|
rocprofiler_add_feature(ROCPROFILER_CLANG_TIDY_EXE
|
|
"path to clang-tidy executable")
|
|
|
|
set(CMAKE_CXX_CLANG_TIDY
|
|
${ROCPROFILER_CLANG_TIDY_EXE}
|
|
-header-filter=${PROJECT_SOURCE_DIR}/source/.*
|
|
--exclude-header-filter=${PROJECT_SOURCE_DIR}/source/include/rocprofiler-sdk/rccl/details/.*
|
|
--warnings-as-errors=*,-misc-header-include-cycle)
|
|
|
|
# Create a preprocessor definition that depends on .clang-tidy content so the
|
|
# compile command will change when .clang-tidy changes. This ensures that a
|
|
# subsequent build re-runs clang-tidy on all sources even if they do not otherwise
|
|
# need to be recompiled. Nothing actually uses this definition. We add it to
|
|
# targets on which we run clang-tidy just to get the build dependency on the
|
|
# .clang-tidy file.
|
|
file(SHA1 ${PROJECT_SOURCE_DIR}/.clang-tidy clang_tidy_sha1)
|
|
set(CLANG_TIDY_DEFINITIONS "CLANG_TIDY_SHA1=${clang_tidy_sha1}")
|
|
unset(clang_tidy_sha1)
|
|
endif()
|
|
endmacro()
|
|
|
|
macro(ROCPROFILER_DEACTIVATE_CLANG_TIDY)
|
|
set(CMAKE_CXX_CLANG_TIDY)
|
|
endmacro()
|