Omri Mor
5bc35a7eb6
* Add environment variable configuration infrastructure
- Namespace rocshmem::envvar
- Track all config env vars in per-category lists
- Remove duplicates from list of allowed env var types
- Reject negative inputs for unsigned integer types
- Accept empty strings for std::string
- Print error source location using C++20 std::source_location
- Unit tests
* Port environment variables
- ROCSHMEM_UNIQUEID_WITH_MPI
- ROCSHMEM_RO_DISABLE_IPC
- ROCSHMEM_BOOTSTRAP_TIMEOUT
- ROCSHMEM_BOOTSTRAP_HOSTID
- ROCSHMEM_BOOTSTRAP_SOCKET_IFNAME
- ROCSHMEM_RO_PROGRESS_DELAY
- ROCSHMEM_BOOTSTRAP_SOCKET_FAMILY
- ROCSHMEM_MAX_NUM_CONTEXTS
+ Merge the independent per-backend copies into a single variable
that is used by all three backends (IPC, RO, GDA).
+ Set default to 32 (for GDA); prior default for IPC and RO was 1024.
- ROCSHMEM_MAX_NUM_HOST_CONTEXTS
- ROCSHMEM_MAX_WF_BUFFERS
- ROCSHMEM_SQ_SIZE
- ROCSHMEM_RO_NET_CPU_QUEUE
+ Renamed from RO_NET_CPU_QUEUE
+ Change env var input type to bool, default to false
+ Invert code logic: setting RO_NET_CPU_QUEUE to anything
would /disable/ a variable gpu_queue, which defaulted to true.
Variable is now named config::ro::net_cpu_queue,
with all prior checks for gpu_queue inverted.
- ROCSHMEM_USE_IB_HCA
- ROCSHMEM_HEAP_SIZE
+ Defaults to 1L << 30 i.e. 1 GiB,
from default heap size in memory/heap_memory.hpp.
- ROCSHMEM_MAX_NUM_TEAMS
+ Unlike other env vars, this can be referenced from devices.
+ Function currently narrows from size_t to int: uses need to be audited
for safety and correctness in using size_t directly.
- ROCSHMEM_GDA_ALTERNATE_QP_PORTS
* New env var ROCSHMEM_DEBUG
- Debug levels:
+ NONE
+ VERSION
+ WARN
+ INFO
+ TRACE
- Currently unused - will be added later
- Mirrors RCCL debug control
* Remove rocshmem::rocshmem_env_config
* Change interface for GetClosestNicToGpu
to accept const char** instead of char**:
the pointed-to string does not need to be modified
- Files were not audited for inclusion of util.hpp only for env vars
---------
Signed-off-by: Omri Mor <Omri.Mor@amd.com>
[ROCm/rocshmem commit: a0fcbf8d35]
98 γραμμές
3.0 KiB
C++
98 γραμμές
3.0 KiB
C++
/******************************************************************************
|
|
* Copyright (c) Advanced Micro Devices, Inc. All rights reserved.
|
|
*
|
|
* SPDX-License-Identifier: MIT
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to
|
|
* deal in the Software without restriction, including without limitation the
|
|
* rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
|
|
* sell copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*****************************************************************************/
|
|
|
|
#ifndef ROCSHMEM_ENVVAR_GTEST_HPP
|
|
#define ROCSHMEM_ENVVAR_GTEST_HPP
|
|
|
|
#include <cstdlib>
|
|
#include <sstream>
|
|
#include <string>
|
|
|
|
#include "gtest/gtest.h"
|
|
#include "../src/envvar.hpp"
|
|
|
|
namespace rocshmem {
|
|
|
|
class EnvVarTestFixture : public ::testing::Test
|
|
{
|
|
public:
|
|
static constexpr envvar::category::tag category_ = envvar::category::tag::ROCSHMEM;
|
|
static constexpr const char* var_name_ = "GTEST";
|
|
static constexpr const char* var_prefix_ = envvar::category::prefix<category_>;
|
|
static inline const std::string var_full_name_{std::string(var_prefix_).append("_").append(var_name_)};
|
|
static constexpr const char* var_doc_ = "Test envvar documentation: documents the test envvar.";
|
|
|
|
static int setenv(const char* value) {
|
|
return ::setenv(var_full_name_.c_str(), value, true);
|
|
}
|
|
|
|
static int setenv(const std::string& value) {
|
|
return setenv(value.c_str());
|
|
}
|
|
|
|
static int unsetenv() {
|
|
return ::unsetenv(var_full_name_.c_str());
|
|
}
|
|
|
|
protected:
|
|
static void SetUpTestSuite() {
|
|
unsetenv();
|
|
}
|
|
|
|
static void TearDownTestSuite() {
|
|
unsetenv();
|
|
}
|
|
|
|
void SetUp() override {
|
|
unsetenv();
|
|
}
|
|
|
|
void TearDown() override {
|
|
unsetenv();
|
|
}
|
|
};
|
|
|
|
template <typename T>
|
|
class EnvVarUnsetTestFixture : public EnvVarTestFixture
|
|
{
|
|
protected:
|
|
const envvar::var<T> var_{var_name_, var_doc_};
|
|
};
|
|
|
|
template <typename T>
|
|
class EnvVarSetTestFixture : public EnvVarTestFixture
|
|
{
|
|
protected:
|
|
const envvar::var<T> var_{var_name_, var_doc_};
|
|
|
|
static void SetUpTestSuite() {
|
|
std::ostringstream oss{};
|
|
oss << T{};
|
|
setenv(oss.str());
|
|
}
|
|
};
|
|
} // namespace rocshmem
|
|
|
|
#endif // ROCSHMEM_ENVVAR_GTEST_HPP
|