d4a33cf33a
Squashed commit of the following:
commit f029195705a15700380c6f832ba5d15d46fd6de7
Author: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
Date: Thu Jul 13 14:38:56 2023 -0500
Formatting workflows for source (clang-format) and cmake (cmake-format) (#4)
* Add .cmake-format.yaml file
* Add formatting workflow
* provide base input for creating PR
* Update scheme for extracting branch name
- disable running formatting on push to amd-staging branch
* patch .cmake-format.yaml for find_package signature
- apparently cmake-format doesn't format the full signature of find_package
* run formatting (clang-format v11) (#7)
Co-authored-by: jrmadsen <jrmadsen@users.noreply.github.com>
* run cmake formatting (cmake-format) (#6)
Co-authored-by: jrmadsen <jrmadsen@users.noreply.github.com>
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit bc4d135fdd8a1a9e51235f18a5d575fd2b3735e6
Author: Ammar ELWazir <aelwazir@amd.com>
Date: Thu Jul 13 12:55:17 2023 -0500
Removing Build cache for potential issues with auto-generated header files (#5)
Change-Id: I9e2319f4335e2f88585ffa6fac2bd88a1c952e6e
commit ce86dea6a311d44d880fa684eb78f3329295e2a4
Author: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
Date: Thu Jul 13 11:08:58 2023 -0500
Fix decltype(<hsa-function>) function pointer usage (#3)
- the following is done in several places:
decltype(hsa_memory_allocate)* hsa_memory_allocate
- above can cause compiler errors
- replace decltype(<hsa-function>) with decltype(::<hsa-function>)
- this ensures that the type within the decltype is recognized as the global scope HSA function, not the variable
- in many places, the variable has a "_fn" suffix to prevent this issue but added '::' anyway for consistency
commit ac49fdd92a72e9c99394253a02da413a6c2e3b3a
Merge: a07946a 03a0855
Author: Ammar ELWazir <aelwazir@amd.com>
Date: Wed Jul 12 11:36:24 2023 -0500
Merge pull request #2 from ROCm-Developer-Tools/gerrit-amd-staging
Pull from gerrit
commit 03a085588cffe863e8f466de67be1cfb205b675a
Merge: e88cad2 a07946a
Author: Ammar ELWazir <aelwazir@amd.com>
Date: Wed Jul 12 10:57:30 2023 -0500
Merge branch 'amd-staging' into gerrit-amd-staging
commit a07946a5cd4c670c83c27ad1a076a9d4567ce6d7
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date: Wed Jul 12 15:46:04 2023 +0000
Enabling Cached Builds
commit 525e494a7f13941077a8fd4ad6840904db4d27d4
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date: Wed Jul 12 04:53:54 2023 +0000
Updating missed GPU Targets
commit 42c75862f628c9bee7cfb7dc04dff2619430efbc
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date: Wed Jul 12 04:43:02 2023 +0000
Adding V1 Testing
commit 9d72fd4aee85e4b0c12e717060d2730fa5b73be1
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date: Wed Jul 12 03:34:31 2023 +0000
Fixing Artifacts directory path
commit f4000cc558b3b2e4676f7994f7ce8c8e6f94518e
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date: Wed Jul 12 03:27:26 2023 +0000
Fixing CMake for test build job
commit 2ce8115d4c33948c3c8f957f545a95a04e1d6cd2
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date: Wed Jul 12 03:16:18 2023 +0000
Fixing Ubuntu CMake for ubuntu test build
commit 6d0ed439191be900748d0c025157f9d689a73ec7
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date: Wed Jul 12 01:28:41 2023 +0000
Removing Navi21
commit e349a7642e5ae5eb03ab9fcd0a0f74f09f78cab5
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date: Wed Jul 12 01:14:14 2023 +0000
Removing Navi21
commit fefd02fe68d2a4bca7ec2e381960ad004ee9fc5b
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date: Wed Jul 12 00:42:48 2023 +0000
Fixing CMake Job
commit 2ea46abf7bf92643efa8c549fa70346ffbd79d65
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date: Wed Jul 12 00:35:13 2023 +0000
Fixing CMake Job
commit d99d681ed1999c5fcf291dc678b11a77205fb0f3
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date: Wed Jul 12 00:32:13 2023 +0000
Fixing Pull Latest Dockers and CMake Jobs
commit dfc4498072d13b4a1df3a63047d34c682c3d9a29
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date: Tue Jul 11 23:54:21 2023 +0000
Fixing CMake job
commit 919efe04de707f7c702031be15c3e2c5f8442cbb
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date: Tue Jul 11 23:52:13 2023 +0000
Adding Pull Last dockers job
commit be1b1256e8b0e05308e8f7e7e69bee3acca55281
Author: Ammar ELWazir <aelwazir@amd.com>
Date: Tue Jul 11 18:25:40 2023 -0500
Update cmake.yml
commit 212299fa4355ae6ec18f9aaacbb79c51ea6c6f97
Author: Ammar ELWazir <aelwazir@amd.com>
Date: Tue Jul 11 18:23:35 2023 -0500
Update cmake.yml
commit 7c2c1327086a61466cc6cac39f70865c051a8bc7
Author: Ammar ELWazir <aelwazir@amd.com>
Date: Tue Jul 11 18:18:53 2023 -0500
Update cmake.yml
commit 191b5ce007e612e814c1d7a3afb4ad398f3852e1
Author: Ammar ELWazir <aelwazir@amd.com>
Date: Tue Jul 11 16:03:22 2023 -0500
Update cmake.yml
commit 8824113d95f3e13c7ce4d0af8e0d9d8f522a6c4a
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date: Tue Jul 11 16:28:09 2023 +0000
Fixing Pull from Gerrit job name
Change-Id: I9e7ed9a27a13ca49d62c93bdadb30f0057e4d385
commit cc3d5e4b02ffb439e8cc2b3efa53527c376f9982
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date: Tue Jul 11 16:21:43 2023 +0000
Adding Staging sync job
Change-Id: I0551f43878b0678ce4b3e74e27d62357cf95ad95
commit b9be2eee71380a2e6dd34d520e92d0c4209277a0
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date: Tue Jul 11 15:57:11 2023 +0000
Fixing build.sh
Change-Id: Ia987b0244f0875370d5fe69907b3f5e9cea914de
commit 9eee33a95a1abd656a7ac5ca10a9f245e9825431
Author: Ammar ELWazir <aelwazir@amd.com>
Date: Mon Jul 10 21:39:46 2023 -0500
Update cmake.yml
commit 7093b85a78497140e8b52632ca2a002bdaeacd62
Author: Ammar ELWazir <aelwazir@amd.com>
Date: Mon Jul 10 21:33:29 2023 -0500
Update cmake.yml
commit f54697172c72a67740f9fdfa0c217b6ea6931576
Author: Ammar ELWazir <aelwazir@amd.com>
Date: Mon Jul 10 21:01:26 2023 -0500
Update cmake.yml
commit 1b6620e16f8940386b0f4f04e69e2410d21c0e26
Author: Ammar ELWazir <aelwazir@amd.com>
Date: Mon Jul 10 20:21:02 2023 -0500
Update cmake.yml
commit a94bec740c6b42c4b79c87bca20fa87b99bf060d
Author: Ammar ELWazir <aelwazir@amd.com>
Date: Mon Jul 10 19:46:35 2023 -0500
Update cmake.yml
commit 85d6b29d4375a69d575c18ece8542c50f2ddfcc3
Author: Ammar ELWazir <aelwazir@amd.com>
Date: Mon Jul 10 19:34:39 2023 -0500
Update cmake.yml
commit 8c004887cf1435f1a6214c3d2455299a8a27bd4c
Author: Ammar ELWazir <aelwazir@amd.com>
Date: Mon Jul 10 19:31:17 2023 -0500
Update cmake.yml
commit a14a9168e17d9348a53c6e9c9a47ba1edb4c4509
Author: Ammar ELWazir <aelwazir@amd.com>
Date: Mon Jul 10 19:25:46 2023 -0500
Update cmake.yml
commit 000f2f40b84e6a2f7d4becdbf5aed01436ca4c83
Author: Ammar ELWazir <aelwazir@amd.com>
Date: Mon Jul 10 19:08:18 2023 -0500
Update cmake.yml
commit a28a53d56731cad848fa9133d1c4dbaa8fc7afa7
Author: Ammar ELWazir <aelwazir@amd.com>
Date: Mon Jul 10 19:03:39 2023 -0500
Update cmake.yml
commit a6a2db01027f0b01fdfbb5997ddb772c7f51b649
Author: Ammar ELWazir <aelwazir@amd.com>
Date: Mon Jul 10 18:21:53 2023 -0500
Update cmake.yml
commit 118ef2a88b2d44e3207c31c343da3e5e5ec6f176
Author: Ammar ELWazir <aelwazir@amd.com>
Date: Mon Jul 10 17:55:57 2023 -0500
Update cmake.yml
commit 03c4c232396440cd0be6d2dd7baf4ceea1c2589d
Author: Ammar ELWazir <aelwazir@amd.com>
Date: Mon Jul 10 17:48:49 2023 -0500
Create cmake.yml
Change-Id: I77992f15694e77cbae49c56f9ff02f4f9079235d
289 라인
10 KiB
C++
289 라인
10 KiB
C++
/* Copyright (c) 2018-2022 Advanced Micro Devices, Inc.
|
|
|
|
Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
of this software and associated documentation files (the "Software"), to deal
|
|
in the Software without restriction, including without limitation the rights
|
|
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
copies of the Software, and to permit persons to whom the Software is
|
|
furnished to do so, subject to the following conditions:
|
|
|
|
The above copyright notice and this permission notice shall be included in
|
|
all copies or substantial portions of the Software.
|
|
|
|
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
THE SOFTWARE. */
|
|
|
|
#ifndef TOOL_TRACE_BUFFER_H_
|
|
#define TOOL_TRACE_BUFFER_H_
|
|
|
|
#include <atomic>
|
|
#include <cassert>
|
|
#include <condition_variable>
|
|
#include <functional>
|
|
#include <future>
|
|
#include <iostream>
|
|
#include <list>
|
|
#include <mutex>
|
|
#include <optional>
|
|
#include <sstream>
|
|
#include <string>
|
|
#include <thread>
|
|
|
|
namespace rocprofiler {
|
|
|
|
class TraceBufferBase {
|
|
public:
|
|
static void FlushAll() {
|
|
std::lock_guard lock(mutex_);
|
|
|
|
for (auto* trace_buffer = head_; trace_buffer != nullptr; trace_buffer = trace_buffer->next_)
|
|
trace_buffer->Flush();
|
|
}
|
|
|
|
static void Register(TraceBufferBase* elem) {
|
|
std::lock_guard lock(mutex_);
|
|
|
|
auto** prev_ptr = &head_;
|
|
while (*prev_ptr != nullptr && elem->priority_ > (*prev_ptr)->priority_)
|
|
prev_ptr = &(*prev_ptr)->next_;
|
|
|
|
elem->next_ = *prev_ptr;
|
|
*prev_ptr = elem;
|
|
}
|
|
|
|
static void Unregister(TraceBufferBase* elem) {
|
|
std::lock_guard lock(mutex_);
|
|
|
|
auto** prev_ptr = &head_;
|
|
while (*prev_ptr != nullptr && *prev_ptr != elem) prev_ptr = &(*prev_ptr)->next_;
|
|
|
|
assert(*prev_ptr != nullptr && "elem is not in the list");
|
|
*prev_ptr = elem->next_;
|
|
}
|
|
|
|
TraceBufferBase(std::string name, int priority)
|
|
: name_(std::move(name)), priority_(priority), next_(nullptr) {}
|
|
|
|
TraceBufferBase(const TraceBufferBase&) = delete;
|
|
TraceBufferBase& operator=(const TraceBufferBase&) = delete;
|
|
|
|
virtual ~TraceBufferBase() { Unregister(this); }
|
|
|
|
virtual void Flush() = 0;
|
|
|
|
std::string name() && { return std::move(name_); }
|
|
const std::string& name() const& { return name_; }
|
|
|
|
private:
|
|
const std::string name_;
|
|
const int priority_;
|
|
TraceBufferBase* next_;
|
|
|
|
static TraceBufferBase* head_;
|
|
static std::mutex mutex_;
|
|
};
|
|
|
|
enum TraceEntryState { TRACE_ENTRY_INVALID = 0, TRACE_ENTRY_INIT = 1, TRACE_ENTRY_COMPLETE = 2 };
|
|
|
|
template <typename Entry, typename Allocator = std::allocator<Entry>>
|
|
class TraceBuffer : protected TraceBufferBase {
|
|
public:
|
|
using callback_t = std::function<void(Entry*)>;
|
|
|
|
TraceBuffer(std::string name, uint64_t size, callback_t flush_callback, int priority = 0)
|
|
: TraceBufferBase(std::move(name), priority),
|
|
flush_callback_(std::move(flush_callback)),
|
|
size_(size) {
|
|
assert(size_ != 0 && "cannot create an empty trace buffer");
|
|
|
|
Entry* write_buffer = allocator_.allocate(size_);
|
|
assert(write_buffer != nullptr);
|
|
buffer_list_.push_back(write_buffer);
|
|
|
|
read_index_ = 0;
|
|
write_index_ = {0, write_buffer};
|
|
|
|
AllocateFreeBuffer();
|
|
|
|
// Add this instance to the link list of all trace buffers in the process.
|
|
Register(this);
|
|
}
|
|
|
|
~TraceBuffer() override {
|
|
// Flush the remaining records. After flushing, there should not be any records left in the
|
|
// trace buffer.
|
|
Flush();
|
|
assert(read_index_ == write_index_.load().index);
|
|
|
|
// Acquire both the writer and worker lock as we are accessing shared variables they protect.
|
|
std::unique_lock writer_lock(write_mutex_, std::defer_lock);
|
|
std::unique_lock worker_lock(worker_mutex_, std::defer_lock);
|
|
std::lock(writer_lock, worker_lock);
|
|
|
|
// Deallocate the buffers.
|
|
allocator_.deallocate(write_index_.load().buffer, size_);
|
|
allocator_.deallocate(free_buffer_, size_);
|
|
|
|
// Stop the worker thread. The worker thread loop checks the 'worker_thread_' std::optional
|
|
// after waking up, and exits if it does not have a value.
|
|
if (worker_thread_) {
|
|
std::thread worker_thread = std::move(worker_thread_.value());
|
|
{
|
|
// Tell the worker thread loop to exit.
|
|
worker_thread_.reset();
|
|
free_buffer_ = nullptr;
|
|
worker_cond_.notify_one();
|
|
}
|
|
// Release the worker lock to allow the worker thread to exit.
|
|
worker_lock.unlock();
|
|
worker_thread.join();
|
|
}
|
|
}
|
|
|
|
// Flush all entries between read_pointer and write_pointer. read_pointer and write_pointer are
|
|
// monotonically increasing indices, with read_pointer % size always indexing inside the first
|
|
// buffer in the list. Stop flushing if an incomplete entry is found, it will be flushed with
|
|
// the next invocation after changing its state to 'complete'.
|
|
void Flush() override {
|
|
std::lock_guard lock(write_mutex_);
|
|
auto write_index = write_index_.load(std::memory_order_relaxed);
|
|
|
|
for (auto it = buffer_list_.begin(); it != buffer_list_.end();) {
|
|
auto end_of_buffer = read_index_ - read_index_ % size_ + size_;
|
|
|
|
while (read_index_ < std::min(write_index.index, end_of_buffer)) {
|
|
Entry* entry = &(*it)[read_index_ % size_];
|
|
|
|
// The entry is not yet complete, stop flushing here.
|
|
if (entry->valid.load(std::memory_order_acquire) != TRACE_ENTRY_COMPLETE) return;
|
|
|
|
flush_callback_(entry);
|
|
entry->~Entry();
|
|
|
|
++read_index_;
|
|
}
|
|
|
|
// The buffer is still in use or the read pointer did not reach the end of the buffer.
|
|
if (*it == write_index.buffer || read_index_ != end_of_buffer) return;
|
|
|
|
// All entries in the current buffer are now processed. Destroy the buffer and move onto the
|
|
// next buffer in the list.
|
|
allocator_.deallocate(*it, size_);
|
|
it = buffer_list_.erase(it);
|
|
}
|
|
}
|
|
|
|
template <typename... Args> Entry& Emplace(Args... args) {
|
|
return *new (GetEntry()) Entry(std::forward<Args>(args)...);
|
|
}
|
|
|
|
private:
|
|
Entry* GetEntry() {
|
|
auto current = write_index_.load(std::memory_order_relaxed);
|
|
|
|
while (true) {
|
|
// If the pointer is at the end of the current buffer, switch to the available free buffer and
|
|
// notify the worker thread to allocate a new buffer.
|
|
if (current.index != 0 && current.index % size_ == 0) {
|
|
std::lock_guard lock(write_mutex_);
|
|
|
|
// If the worker thread wasn't already started, start it now. This avoids starting a new
|
|
// thread when the trace buffer is created.
|
|
if (!worker_thread_) {
|
|
std::promise<void> ready;
|
|
auto future = ready.get_future();
|
|
{
|
|
std::lock_guard worker_lock(worker_mutex_);
|
|
worker_thread_.emplace(&TraceBuffer::WorkerThreadLoop, this, std::move(ready));
|
|
}
|
|
future.wait();
|
|
}
|
|
|
|
// Re-check the pointer overflow under the writer lock, another thread could have beaten us
|
|
// to it and already bumped the write_index_.
|
|
current = write_index_.load(std::memory_order_relaxed);
|
|
if (current.index % size_ == 0) {
|
|
std::unique_lock worker_lock(worker_mutex_);
|
|
|
|
// Wait for the free buffer to become available.
|
|
worker_cond_.wait(worker_lock, [this]() { return free_buffer_ != nullptr; });
|
|
|
|
current.buffer = free_buffer_;
|
|
buffer_list_.push_back(current.buffer);
|
|
write_index_.store({current.index + 1, current.buffer}, std::memory_order_relaxed);
|
|
|
|
// Tell the worker thread to allocate a new free buffer.
|
|
free_buffer_ = nullptr;
|
|
worker_cond_.notify_one();
|
|
|
|
// We successfully allocated a new buffer, return the first element.
|
|
return ¤t.buffer[0];
|
|
}
|
|
}
|
|
|
|
if (write_index_.compare_exchange_weak(current, {current.index + 1, current.buffer},
|
|
std::memory_order_relaxed))
|
|
return ¤t.buffer[current.index % size_];
|
|
}
|
|
}
|
|
|
|
void AllocateFreeBuffer() {
|
|
assert(free_buffer_ == nullptr);
|
|
|
|
free_buffer_ = allocator_.allocate(size_);
|
|
assert(free_buffer_ != nullptr);
|
|
|
|
for (size_t i = 0; i < size_; ++i)
|
|
free_buffer_[i].valid.store(TRACE_ENTRY_INVALID, std::memory_order_relaxed);
|
|
}
|
|
|
|
void WorkerThreadLoop(std::promise<void> ready) {
|
|
std::unique_lock lock(worker_mutex_);
|
|
|
|
// This worker thread is now ready to accept work.
|
|
ready.set_value();
|
|
|
|
while (true) {
|
|
worker_cond_.wait(lock, [this]() { return free_buffer_ == nullptr; });
|
|
if (!worker_thread_) break;
|
|
AllocateFreeBuffer();
|
|
worker_cond_.notify_one();
|
|
}
|
|
}
|
|
|
|
// The WriteIndex is used to store both the index and the buffer associated with that index (the
|
|
// buffer contains the trace buffer records at [index - index % size, index - index % size_t +
|
|
// size_ - 1]) in a single atomic variable.
|
|
struct WriteIndex {
|
|
uint64_t index;
|
|
Entry* buffer;
|
|
};
|
|
|
|
const callback_t flush_callback_;
|
|
const uint64_t size_;
|
|
|
|
uint64_t read_index_; // The index of the next record to flush.
|
|
std::atomic<WriteIndex> write_index_; // The index of the next record that could be written.
|
|
Entry* free_buffer_{nullptr}; // The next available free buffer.
|
|
|
|
std::optional<std::thread> worker_thread_;
|
|
std::mutex worker_mutex_;
|
|
std::condition_variable worker_cond_;
|
|
|
|
std::mutex write_mutex_;
|
|
std::list<Entry*> buffer_list_;
|
|
Allocator allocator_;
|
|
};
|
|
} // namespace rocprofiler
|
|
|
|
#define TRACE_BUFFER_INSTANTIATE() \
|
|
rocprofiler::TraceBufferBase* rocprofiler::TraceBufferBase::head_ = nullptr; \
|
|
std::mutex rocprofiler::TraceBufferBase::mutex_;
|
|
|
|
#endif // TOOL_TRACE_BUFFER_H_
|