Files
rocm-systems/source/lib/omnitrace/library/components/pthread_create_gotcha.cpp
T
Jonathan R. Madsen 1688a027d8 Add RedHat CI and release packaging (#251)
- additional miscellaneous tweaks to workflows and docker scripts, e.g. install perfetto python bindings
- improves the stability of MPI finalization
- reduces some debug messages within timemory when `OMNITRACE_DEBUG=ON`
- fixes issue found in RHEL where libunwind is using mutex and omnitrace was not treating this as an internal mutex call
  - this may have been affecting the causal profiling slightly (tests seem a bit more stable now)
- fix data race in timemory

* Add RedHat CI and release packaging

- additional miscellaneous tweaks to workflows and docker scripts, e.g. install perfetto python bindings

* Fix URL for ROCm packages in redhat workflow

* Fix dnf --enable-repo for ROCm perl packages

* Dockerfile.rhel and redhat.yml updates

- Fix dnf repo for ROCm PERL packages
- Disable python in CI (interpreter segfaults)
- Exclude parallel-overhead-locks tests due to inclusion of internal locks
  - This needs to be remedied in the future

* Exclude _dl_relocate_static_pie from instrumentation

* Testing updates

- OMNITRACE_SAMPLING_KEEP_INTERNAL=OFF for parallel-overhead-locks

* Fix redhat workflow

* redhat.yml update

- remove if condition on config/build/test step

* Update timemory submodule

- tweaks to verbosity messages

* Set thread state before unw_step

- on Redhat, unw_step calls mutex

* Update timemory submodule

- verbosity changes
- gotcha uses spin_lock/spin_mutex

* Remove using gsplit-dwarf unless OMNITRACE_BUILD_NUMBER > 2

* Re-enable parallel-overhead-locks tests in redhat workflow

* Always disable timemory manager metadata auto output

* testing updates

- tweak parallel-overhead-locks-timemory to higher instruction count min
- OMNITRACE_SAMPLING_KEEP_INTERNAL=OFF for parallel-overhead-locks-perfetto

* Update timemory submodule

- quiet realpath queries

* omnitrace exe updates

- detect text files
- improved bin/lib locating

* cmake format

* test-install.sh and redhat workflow updates

- handle testing when ls is script
- re-enable python testing on redhat workflow
- invoke test-install.sh in redhat workflow

* Misc guards for finalization

* omnitrace-exe, testing updates

- test-install.sh: LS_EXEC -> LS_NAME
- handle /usr/bin/ls being script in source/bin/tests
- improve locating the binary

* Fix mpi_gotcha compile error

* omnitrace-exe updates

- improve file locating

* formatting

* Misc fixes

- remove -static-libstdc++ for RHEL packaging (rocky-linux doesn't distribute static lib)

* omnitrace-exe paths

* Replace realpath with absolute

- using absolute path to symlink fixes issues with locating libdyninstAPI_RT at runtime

* omnitrace exe updates

- judicious use of realpath

* Update timemory submodule

- fix update main hash ids/aliases data race in merge

* bin tests update

- change working directory of omnitrace-exe-simulate-lib-basename

* omnitrace exe updates

- Update resolved exe/lib messaging

* bin tests update

- change working directory of omnitrace-exe-simulate-lib-basename
2023-03-07 06:04:19 -06:00

497 строки
17 KiB
C++

// MIT License
//
// Copyright (c) 2022 Advanced Micro Devices, Inc. All Rights Reserved.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in all
// copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
// SOFTWARE.
#include "library/components/pthread_create_gotcha.hpp"
#include "core/config.hpp"
#include "core/debug.hpp"
#include "core/state.hpp"
#include "core/utility.hpp"
#include "library/causal/delay.hpp"
#include "library/components/category_region.hpp"
#include "library/components/roctracer.hpp"
#include "library/runtime.hpp"
#include "library/sampling.hpp"
#include "library/thread_data.hpp"
#include "library/thread_info.hpp"
#include <timemory/backends/threading.hpp>
#include <timemory/components/macros.hpp>
#include <timemory/components/timing/wall_clock.hpp>
#include <timemory/sampling/allocator.hpp>
#include <timemory/utility/types.hpp>
#include <ostream>
#include <pthread.h>
#include <utility>
namespace omnitrace
{
namespace sampling
{
std::set<int>
setup();
std::set<int>
shutdown();
} // namespace sampling
namespace component
{
using bundle_t = tim::lightweight_tuple<comp::wall_clock, comp::roctracer_data>;
using category_region_t = tim::lightweight_tuple<category_region<category::pthread>>;
namespace
{
auto* is_shutdown = new bool{ false }; // intentional data leak
auto* bundles = new std::map<int64_t, std::shared_ptr<bundle_t>>{};
auto* bundles_mutex = new std::mutex{};
auto bundles_dtor = scope::destructor{ []() {
pthread_create_gotcha::shutdown();
delete bundles;
delete bundles_mutex;
bundles = nullptr;
bundles_mutex = nullptr;
} };
template <typename... Args>
inline void
start_bundle(bundle_t& _bundle, Args&&... _args)
{
if(!get_use_timemory() && !get_use_perfetto()) return;
OMNITRACE_BASIC_VERBOSE_F(3, "starting bundle '%s'...\n", _bundle.key().c_str());
if constexpr(sizeof...(Args) > 0)
{
const char* _name = nullptr;
if(tim::get_hash_identifier(_bundle.hash(), _name) && _name != nullptr)
{
category_region_t{}.audit(quirk::config<quirk::perfetto>{},
std::string_view{ _name }, _args...);
}
}
else
{
tim::consume_parameters(_args...);
}
if(get_use_timemory())
{
_bundle.push();
_bundle.start();
}
}
template <typename... Args>
inline void
stop_bundle(bundle_t& _bundle, int64_t _tid, Args&&... _args)
{
if(!get_use_timemory() && !get_use_perfetto()) return;
auto _main_manager = tim::manager::master_instance();
auto _this_manager = tim::manager::instance();
if(!_main_manager || !_this_manager || _main_manager->is_finalized() ||
_this_manager->is_finalized())
return;
OMNITRACE_BASIC_VERBOSE_F(3, "stopping bundle '%s' in thread %li...\n",
_bundle.key().c_str(), _tid);
if(get_use_timemory())
{
auto _wc = *_bundle.get<comp::wall_clock>();
_wc.stop();
// update roctracer_data
_bundle.store(std::plus<double>{}, _wc.get() * _wc.unit());
// stop all
_bundle.stop();
// exclude popping wall-clock
_bundle.pop(_tid);
}
if constexpr(sizeof...(Args) > 0)
{
const char* _name = nullptr;
if(tim::get_hash_identifier(_bundle.hash(), _name) && _name != nullptr)
{
category_region_t{}.audit(quirk::config<quirk::perfetto>{},
std::string_view{ _name }, _args...);
}
}
else
{
tim::consume_parameters(_args...);
}
}
} // namespace
//--------------------------------------------------------------------------------------//
pthread_create_gotcha::wrapper::wrapper(routine_t _routine, void* _arg,
wrapper_config _config)
: m_routine{ _routine }
, m_arg{ _arg }
, m_config{ std::move(_config) }
{}
void*
pthread_create_gotcha::wrapper::operator()() const
{
using thread_bundle_data_t = thread_data<thread_bundle_t>;
if(is_shutdown && *is_shutdown)
{
if(m_config.promise) m_config.promise->set_value();
// execute the original function
return m_routine(m_arg);
}
push_thread_state(ThreadState::Internal);
int64_t _tid = -1;
void* _ret = nullptr;
auto _is_sampling = false;
auto _bundle = std::shared_ptr<bundle_t>{};
auto _signals = std::set<int>{};
auto _coverage = (get_mode() == Mode::Coverage);
const auto& _parent_info = thread_info::get(m_config.parent_tid, InternalTID);
const auto& _info = thread_info::init(m_config.offset);
auto _dtor = [&]() {
set_thread_state(ThreadState::Internal);
if(_is_sampling)
{
if(m_config.enable_causal)
{
causal::sampling::block_signals(_signals);
causal::sampling::shutdown();
}
else if(m_config.enable_sampling)
{
sampling::block_signals(_signals);
sampling::shutdown();
}
}
if(_tid >= 0)
{
auto _active = (get_state() == ::omnitrace::State::Active &&
bundles != nullptr && bundles_mutex != nullptr);
if(!_active) return;
thread_info::set_stop(comp::wall_clock::record());
auto& _thr_bundle = thread_bundle_data_t::instance();
if(_thr_bundle && _thr_bundle->get<comp::wall_clock>() &&
_thr_bundle->get<comp::wall_clock>()->get_is_running())
_thr_bundle->stop();
if(_bundle) stop_bundle(*_bundle, _tid);
pthread_create_gotcha::shutdown(_tid);
OMNITRACE_BASIC_VERBOSE(
1, "[PID=%i][rank=%i] Thread %s (parent: %s) exited\n", process::get_id(),
dmp::rank(), _info->index_data->as_string().c_str(),
_parent_info->index_data->as_string().c_str());
}
};
auto _active = (get_state() == ::omnitrace::State::Active && bundles != nullptr &&
bundles_mutex != nullptr);
if(_active && !_coverage && !m_config.offset)
{
_tid = _info->index_data->sequent_value;
OMNITRACE_BASIC_VERBOSE(1, "[PID=%i][rank=%i] Thread %s (parent: %s) created\n",
process::get_id(), dmp::rank(),
_info->index_data->as_string().c_str(),
_parent_info->index_data->as_string().c_str());
threading::set_thread_name(TIMEMORY_JOIN(" ", "Thread", _tid).c_str());
auto _manager = tim::manager::instance();
if(_manager) _manager->initialize();
if(!thread_bundle_data_t::instances().at(_tid))
{
thread_data<thread_bundle_t>::construct(
TIMEMORY_JOIN('/', "omnitrace/process", process::get_id(), "thread",
_tid),
quirk::config<quirk::auto_start>{});
thread_bundle_data_t::instances().at(_tid)->start();
}
if(bundles && bundles_mutex)
{
std::unique_lock<std::mutex> _lk{ *bundles_mutex };
_bundle = bundles->emplace(_tid, std::make_shared<bundle_t>("start_thread"))
.first->second;
}
if(_bundle) start_bundle(*_bundle);
get_cpu_cid_stack(_tid, m_config.parent_tid);
if(m_config.enable_causal)
{
// children inherit the parent delay data
if(_parent_info && _parent_info->index_data)
causal::delay::get_local(_tid) =
causal::delay::get_local(_parent_info->index_data->sequent_value);
_is_sampling = true;
OMNITRACE_SCOPED_SAMPLING_ON_CHILD_THREADS(false);
_signals = causal::sampling::setup();
causal::sampling::unblock_signals();
}
else if(m_config.enable_sampling)
{
_is_sampling = true;
OMNITRACE_SCOPED_SAMPLING_ON_CHILD_THREADS(false);
_signals = sampling::setup();
sampling::unblock_signals();
}
}
else if(m_config.offset)
{
OMNITRACE_BASIC_VERBOSE(
2,
"[PID=%i][rank=%i] Thread %s (parent: %s) created [started by omnitrace]\n",
process::get_id(), dmp::rank(), _info->index_data->as_string().c_str(),
_parent_info->index_data->as_string().c_str());
}
// notify the wrapper that all internal work is completed
if(m_config.promise) m_config.promise->set_value();
// Internal -> Enabled
pop_thread_state();
push_thread_state(ThreadState::Enabled);
// execute the original function
_ret = m_routine(m_arg);
if(get_state() < ::omnitrace::State::Finalized)
{
pop_thread_state();
// execute the destructor actions
_dtor();
set_thread_state(ThreadState::Completed);
}
return _ret;
}
void*
pthread_create_gotcha::wrapper::wrap(void* _arg)
{
if(_arg == nullptr) return nullptr;
// convert the argument
wrapper* _wrapper = static_cast<wrapper*>(_arg);
// execute the original function
void* _ret = (*_wrapper)();
// eliminate memory leak
if(_ret != _arg) delete _wrapper;
return _ret;
}
void
pthread_create_gotcha::configure()
{
pthread_create_gotcha_t::get_initializer() = []() {
if(!tim::settings::enabled()) return;
pthread_create_gotcha_t::template configure<
0, int, pthread_t*, const pthread_attr_t*, void* (*) (void*), void*>(
"pthread_create");
};
}
void
pthread_create_gotcha::shutdown()
{
if(is_shutdown)
{
if(*is_shutdown) return;
*is_shutdown = true;
}
if(!bundles_mutex || !bundles) return;
std::unique_lock<std::mutex> _lk{ *bundles_mutex };
unsigned long _ndangling = 0;
for(auto itr : *bundles)
{
if(itr.second)
{
stop_bundle(*itr.second, itr.first);
++_ndangling;
}
itr.second.reset();
}
bundles->clear();
if(config::settings_are_configured())
{
OMNITRACE_VERBOSE(2 && _ndangling > 0,
"[pthread_create_gotcha] cleaned up %lu dangling bundles\n",
_ndangling);
}
else
{
OMNITRACE_BASIC_VERBOSE(
2 && _ndangling > 0,
"[pthread_create_gotcha] cleaned up %lu dangling bundles\n", _ndangling);
}
}
void
pthread_create_gotcha::shutdown(int64_t _tid)
{
if(_tid == 0) shutdown();
if(is_shutdown && *is_shutdown) return;
if(!bundles_mutex || !bundles) return;
std::unique_lock<std::mutex> _lk{ *bundles_mutex };
auto itr = bundles->find(_tid);
if(itr != bundles->end())
{
if(itr->second) stop_bundle(*itr->second, itr->first);
itr->second.reset();
bundles->erase(itr);
}
}
void
pthread_create_gotcha::set_data(wrappee_t _v)
{
m_wrappee = _v;
}
// pthread_create
int
pthread_create_gotcha::operator()(pthread_t* thread, const pthread_attr_t* attr,
void* (*func)(void*), void* arg) const
{
auto _tid = utility::get_thread_index();
auto _thr_state = get_thread_state();
auto _glob_state = get_state();
auto _mode = get_mode();
auto _disabled = (_thr_state == ThreadState::Disabled);
auto _enabled = (_thr_state == ThreadState::Enabled);
auto _bundle = std::optional<bundle_t>{};
auto _sample_child = sampling_enabled_on_child_threads();
auto _active = (_glob_state == ::omnitrace::State::Active && !_disabled);
const auto& _info = thread_info::init(!_active || !_sample_child || _disabled);
OMNITRACE_SCOPED_THREAD_STATE(ThreadState::Internal);
auto _coverage = (_mode == Mode::Coverage);
auto _use_sampling = config::get_use_sampling();
auto _use_causal = config::get_use_causal();
auto _offset = (!_enabled || !_active || _info->is_offset);
auto _use_bundle = (_active && !_coverage && !_offset);
auto _enable_sampling =
(_use_sampling && _sample_child && _active && !_coverage && !_offset);
auto _enable_causal =
(_use_causal && _sample_child && _active && !_coverage && !_offset);
static bool debug_threading_get_id =
get_env<bool>(TIMEMORY_SETTINGS_PREFIX "DEBUG_THREADING_GET_ID", false);
auto _verbose = (debug_threading_get_id) ? 0 : 3;
OMNITRACE_VERBOSE(
_verbose,
"Creating new thread :: global_state=%s, thread_state=%s, mode=%s, active=%s, "
"coverage=%s, use_causal=%s, use_sampling=%s, sample_children=%s, tid=%li, "
"use_bundle=%s, enable_causal=%s, enable_sampling=%s, thread_info=(%s)...\n",
std::to_string(_glob_state).c_str(), std::to_string(_thr_state).c_str(),
std::to_string(_mode).c_str(), std::to_string(_active).c_str(),
std::to_string(_coverage).c_str(), std::to_string(_use_causal).c_str(),
std::to_string(_use_sampling).c_str(), std::to_string(_sample_child).c_str(),
_tid, std::to_string(_use_bundle).c_str(), std::to_string(_enable_causal).c_str(),
std::to_string(_enable_sampling).c_str(), JOIN("", *_info).c_str());
if(debug_threading_get_id)
{
timemory_print_demangled_backtrace<8>(std::cerr, std::string{},
std::string{ "threading::get_id() [id=" } +
std::to_string(_tid) +
std::string{ "]" },
std::string{ " " }, false);
}
if(_active && !_disabled && !_info->is_offset)
{
OMNITRACE_BASIC_VERBOSE(2, "[PID=%i][rank=%i] Starting new thread on %s...\n",
process::get_id(), dmp::rank(),
_info->index_data->as_string().c_str());
}
// ensure that cpu cid stack exists on the parent thread if active
if(_active && !_coverage)
{
OMNITRACE_DEBUG("blocking signals...\n");
get_cpu_cid_stack();
}
set_thread_state(ThreadState::Disabled);
auto _blocked = get_sampling_signals();
auto _promise = (_active) ? std::make_shared<std::promise<void>>() : promise_t{};
auto _config =
wrapper_config{ _enable_causal, _enable_sampling, _offset, _tid, _promise };
auto* _wrap = new wrapper{ func, arg, _config };
set_thread_state(ThreadState::Internal);
// block the signals in entire process
if(_enable_sampling && !_blocked.empty())
{
OMNITRACE_DEBUG("blocking signals...\n");
tim::signals::block_signals(_blocked, tim::signals::sigmask_scope::process);
}
if(_use_bundle)
{
_bundle = bundle_t{ "pthread_create" };
start_bundle(*_bundle, audit::incoming{}, thread, attr, func, arg);
}
// threads must process their delays before creating a new thread
causal::delay::process();
// create the thread
auto _ret = (*m_wrappee)(thread, attr, &wrapper::wrap, static_cast<void*>(_wrap));
// wait for thread to set promise
if(_promise)
{
OMNITRACE_DEBUG("waiting for child to signal it is setup...\n");
_promise->get_future().wait_for(std::chrono::milliseconds{ 500 });
}
if(_use_bundle)
stop_bundle(*_bundle, _info->index_data->sequent_value, audit::outgoing{}, _ret);
// unblock the signals in the entire process
if(_enable_sampling && !_blocked.empty())
{
OMNITRACE_DEBUG("unblocking signals...\n");
tim::signals::unblock_signals(_blocked, tim::signals::sigmask_scope::process);
}
OMNITRACE_DEBUG("returning success...\n");
return _ret;
}
} // namespace component
} // namespace omnitrace
TIMEMORY_INITIALIZE_STORAGE(component::roctracer_data)