1f4cf1aa39
* Srnagara/tool counters collect (#331) * Adding counter collection capability to tools * Adding counter collection feature to tools * Adding counter collection capability to tools * Fixing merge down issues * Small tool fixes for build + prevent profile realloc * Reproducing the counter name query issue in buffered callback * Minor fix for init order + sample that directly uses sdk-tool for debug purposes * Adding a temporary fix to print the counter names * Fixing the output file name and reverting the changes of caching the profile config * Fixing SGPR_Count value * cleaning up debug prints * Adding header to counter collection file * Adding kernel filtering support * Remove threading * Cleaning up the code * Removing redundant prints * Revert "Remove threading" This reverts commit 05c58fb9de826e92cf8d2e3d1c31d5578525dcb4. * Revert "Cleaning up the code" This reverts commit 1d964882bf2396dee8ad020cbb6c83b36e0674e9. * Changing the tools code to align with init-order fix * cmake formatting (cmake-format) (#335) Co-authored-by: SrirakshaNag <SrirakshaNag@users.noreply.github.com> * source formatting (clang-format v11) (#336) Co-authored-by: SrirakshaNag <SrirakshaNag@users.noreply.github.com> * Adding support for async memory copy * source formatting (clang-format v11) (#391) Co-authored-by: SrirakshaNag <SrirakshaNag@users.noreply.github.com> * Fixing header typo * Fixing tool_fini * Replaceing the direction and kind fields values with description * Update lib/rocprofiler-sdk-tool/helper.cpp - Remove use of VLA * Update lib/rocprofiler-sdk-tool/tool.cpp - Formatting * Migrate common/config.* to rocprofiler-sdk-tool * Update lib/rocprofiler-sdk-tool/tool.cpp - fix clang-tidy issues * source formatting (clang-format v11) (#392) Co-authored-by: jrmadsen <jrmadsen@users.noreply.github.com> * Update lib/common/mpl.hpp - is_string_type / is_string_type_impl for deducing if type is a string type * Update include/rocprofiler-sdk/fwd.h - ROCPROFILER_BUFFER_TRACING_MEMORY_COPY_NONE starts at zero * Update lib/rocprofiler-sdk/hsa/async_copy.* - functions for operation ids and names * Update lib/rocprofiler-sdk/buffer_tracing.cpp - support iterating and getting names for ROCPROFILER_BUFFER_TRACING_MEMORY_COPY * Update lib/rocprofiler-sdk-tool/config.* - env ROCPROFILER_ prefix -> ROCPROF_ prefix - add support for memory copy tracing, counter collection, etc. * Update lib/rocprofiler-sdk-tool/helper.* - removed TracerFlushRecord - removed cxa_demangle (use one in common library) - removed GetCounterNames (handled in config) - removed GetKernelNames (handled in config) * Add lib/rocprofiler-sdk-tool/output_file.* - separate out get_output_stream function and output_file struct from tool.cpp * Add lib/rocprofiler-sdk-tool/csv.hpp - write_csv_entry automatically quotes strings - csv_encoder struct enforces correct number of columns * Update lib/rocprofiler-sdk-tool/CMakeLists.txt - add new files * Update lib/rocprofiler-sdk-tool/tool.cpp - update construction of output_file class - add kernel_symbol_data for serializing kernel trace data - use config instead of env lookups - optimize counter collection profile config lookup/creation * Update bin/rocprofv3 - rocprofv3 --help exits with 0 (as it should) - command-line arg for memory copy tracing - command-line arg for mangled kernels - command-line arg for truncated kernels - env ROCPROFILER_ prefix -> env ROCPROF_ prefix * Update tests/async-copy-tracing/validate.py - update test_async_copy_direction to new enum values * Update tests/kernel-tracing/validate.py - update test_async_copy_direction to new enum values * Update tests/tools/json-tool.cpp - add ROCPROFILER_BUFFER_TRACING_MEMORY_COPY to supported buffer_name_info * Update samples/counter_collection/{CMakeLists.txt,main.cpp} - remove counter-collection-sdk-tool * Update .github/workflows/docs.yml - fix paths triggering running the workflow --------- Co-authored-by: Benjamin Welton <bewelton@amd.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: SrirakshaNag <SrirakshaNag@users.noreply.github.com> Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com> Co-authored-by: jrmadsen <jrmadsen@users.noreply.github.com> * adding counter collection support * Adding counter collection test * changing directory structure of counter collection tests * Fixing test path for rocprofv3 * Adding hsa-tracing basic test * cmake formatting (cmake-format) (#362) Co-authored-by: bgopesh <bgopesh@users.noreply.github.com> * counter collection tests drop2 * fixing hsa-trace test for rocprofv3 path * python formatting (black) (#371) Co-authored-by: bgopesh <bgopesh@users.noreply.github.com> * both counter colleciton and tracing should work together * Fixing rocprofv3 path * Attempt to fix Segfault with AddressSanitizer * fixing sanitizer segfault * Update rocprofv3 * Update lib/rocprofiler-sdk-tool/README.md - update env variables * Update lib/rocprofiler-sdk/buffer_tracing.cpp - return ROCPROFILER_STATUS_BUFFER_NOT_FOUND if buffer tracing service is configured with invalid buffer * Update lib/rocprofiler-sdk-tool/tool.cpp - designated hsa API trace buffer * Update tests/hsa-tracing/CMakeLists.txt - Fix environment * Update rocprofv3 - do not override HSA_TOOLS_LIB - support ROCPROF_PRELOAD - LD_PRELOAD librocprofiler-sdk.so * Restructure tests directory - move all rocprofv3 integration tests into subfolder * Update cmake/Templates/rocprofiler-sdk/config.cmake.in - create rocprofiler-sdk::rocprofv3 cmake target * Update tests/rocprofv3/hsa-tracing - improve validate.py - convert input to dict via csv.DictReader * Update tests/apps/CMakeLists.txt - fix build rpath for simple-transpose * Update cmake/rocprofiler_memcheck.cmake - prefer libtsan.so.0 * Update tests/rocprofv3/hsa-tracing - move to tests/rocprofv3/tracing - include kernel tracing and memory copy tracing * Update lib/rocprofiler-sdk-tool/tool.cpp - normalize "_ID" vs. "_Id" in CSV column names (use "_Id") * Update lib/rocprofiler-sdk/buffer.{hpp,cpp} - change signature of buffer::get_buffers() - buffer::get_buffers() uses static_object * Update lib/rocprofiler-sdk/context/context.cpp - update usage of buffer::get_buffers() - now returns pointer * Update lib/rocprofiler-sdk/tests/buffer.cpp - update to change for signature of buffer::get_buffers() * Update tests/rocprofv3/tracing/CMakeLists.txt - use %argt% with -d argument * Update lib/rocprofiler-sdk-tool/tool.cpp - use atexit for finalization * Update tests/rocprofv3/tracing/CMakeLists.txt - tweaked name of tests * Update lib/rocprofiler-sdk/hsa/async_copy.* - async_copy_fini + reference counting signals * Update lib/rocprofiler-sdk/registration.cpp - invoke hsa::async_copy_fini() to prevent data race on signals --------- Co-authored-by: SrirakshaNag <104580803+SrirakshaNag@users.noreply.github.com> Co-authored-by: Benjamin Welton <bewelton@amd.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: SrirakshaNag <SrirakshaNag@users.noreply.github.com> Co-authored-by: gobhardw <gopesh.bhardwaj@amd.com> Co-authored-by: bgopesh <bgopesh@users.noreply.github.com>
435 строки
13 KiB
C++
435 строки
13 KiB
C++
// MIT License
|
|
//
|
|
// Copyright (c) 2023 Advanced Micro Devices, Inc. All rights reserved.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in all
|
|
// copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
// SOFTWARE.
|
|
|
|
#include <rocprofiler-sdk/buffer_tracing.h>
|
|
#include <rocprofiler-sdk/fwd.h>
|
|
#include <rocprofiler-sdk/rocprofiler.h>
|
|
|
|
#include "lib/common/container/stable_vector.hpp"
|
|
#include "lib/common/static_object.hpp"
|
|
#include "lib/common/synchronized.hpp"
|
|
#include "lib/common/utility.hpp"
|
|
#include "lib/rocprofiler-sdk/buffer.hpp"
|
|
#include "lib/rocprofiler-sdk/context/context.hpp"
|
|
#include "lib/rocprofiler-sdk/counters/core.hpp"
|
|
|
|
#include <glog/logging.h>
|
|
|
|
#include <unistd.h>
|
|
#include <atomic>
|
|
#include <cstddef>
|
|
#include <deque>
|
|
#include <memory>
|
|
#include <mutex>
|
|
#include <optional>
|
|
#include <random>
|
|
|
|
namespace rocprofiler
|
|
{
|
|
namespace context
|
|
{
|
|
namespace
|
|
{
|
|
using reserve_size_t = common::container::reserve_size;
|
|
using unique_context_vec_t =
|
|
common::container::stable_vector<allocator::unique_static_ptr_t<context>, 8>;
|
|
using active_context_vec_t = common::container::stable_vector<std::atomic<const context*>, 8>;
|
|
|
|
constexpr auto invalid_client_idx = std::numeric_limits<uint32_t>::max();
|
|
|
|
auto&
|
|
get_contexts_mutex()
|
|
{
|
|
static auto _v = std::mutex{};
|
|
return _v;
|
|
}
|
|
|
|
uint64_t
|
|
get_contexts_offset()
|
|
{
|
|
static uint64_t _v = []() {
|
|
auto gen = std::mt19937{std::random_device{}()};
|
|
auto rng = std::uniform_int_distribution<uint64_t>{std::numeric_limits<uint8_t>::max(),
|
|
std::numeric_limits<uint16_t>::max()};
|
|
return rng(gen);
|
|
}();
|
|
return _v;
|
|
}
|
|
|
|
auto&
|
|
get_client_index()
|
|
{
|
|
static auto _v = invalid_client_idx;
|
|
return _v;
|
|
}
|
|
|
|
unique_context_vec_t&
|
|
get_registered_contexts_impl()
|
|
{
|
|
static auto _v = unique_context_vec_t{reserve_size_t{unique_context_vec_t::chunk_size}};
|
|
return _v;
|
|
}
|
|
|
|
auto&
|
|
get_num_active_contexts()
|
|
{
|
|
static auto _v = std::atomic<int64_t>{0};
|
|
return _v;
|
|
}
|
|
|
|
active_context_vec_t&
|
|
get_active_contexts_impl()
|
|
{
|
|
static auto* _v = new active_context_vec_t{reserve_size_t{active_context_vec_t::chunk_size}};
|
|
static auto _once = std::once_flag{};
|
|
std::call_once(_once, std::atexit, []() {
|
|
for(auto& itr : *_v)
|
|
{
|
|
itr.store(nullptr);
|
|
}
|
|
});
|
|
return *_v;
|
|
}
|
|
|
|
auto*&
|
|
get_correlation_id_map()
|
|
{
|
|
using data_type = std::vector<std::unique_ptr<correlation_id>>;
|
|
static auto*& _v = common::static_object<common::Synchronized<data_type>>::construct();
|
|
return _v;
|
|
}
|
|
|
|
auto*&
|
|
get_latest_correlation_id_impl()
|
|
{
|
|
static thread_local correlation_id* _v = nullptr;
|
|
return _v;
|
|
}
|
|
|
|
uint64_t
|
|
get_unique_internal_id()
|
|
{
|
|
static auto _v = std::atomic<uint64_t>{};
|
|
return ++_v;
|
|
}
|
|
} // namespace
|
|
|
|
correlation_id*
|
|
correlation_tracing_service::construct(uint32_t _init_ref_count)
|
|
{
|
|
auto _internal_id = get_unique_internal_id();
|
|
auto* corr_id_map = get_correlation_id_map();
|
|
if(!corr_id_map) return nullptr;
|
|
auto& ret = corr_id_map->wlock([](auto& data) -> auto& { return data.emplace_back(); });
|
|
ret = std::make_unique<correlation_id>(_init_ref_count, common::get_tid(), _internal_id);
|
|
|
|
get_latest_correlation_id_impl() = ret.get();
|
|
|
|
return ret.get();
|
|
}
|
|
|
|
correlation_id*
|
|
get_latest_correlation_id()
|
|
{
|
|
return get_latest_correlation_id_impl();
|
|
}
|
|
|
|
void
|
|
pop_latest_correlation_id(const correlation_id* val)
|
|
{
|
|
if(get_latest_correlation_id_impl() == val) get_latest_correlation_id_impl() = nullptr;
|
|
}
|
|
|
|
context_array_t&
|
|
get_registered_contexts(context_array_t& data, context_filter_t filter)
|
|
{
|
|
data.clear();
|
|
auto num_ctx = get_registered_contexts_impl().size();
|
|
if(num_ctx <= 0) return data;
|
|
|
|
data.reserve(num_ctx);
|
|
for(auto& itr : get_registered_contexts_impl())
|
|
{
|
|
const auto* ctx = itr.get();
|
|
if(ctx)
|
|
{
|
|
if(!filter || (filter && filter(ctx))) data.emplace_back(ctx);
|
|
}
|
|
}
|
|
return data;
|
|
}
|
|
|
|
context_array_t
|
|
get_registered_contexts(context_filter_t filter)
|
|
{
|
|
auto data = context_array_t{};
|
|
get_registered_contexts(data, filter);
|
|
return data;
|
|
}
|
|
|
|
context_array_t&
|
|
get_active_contexts(context_array_t& data, context_filter_t filter)
|
|
{
|
|
data.clear();
|
|
auto num_ctx = get_num_active_contexts().load(std::memory_order_acquire);
|
|
if(num_ctx <= 0) return data;
|
|
|
|
data.reserve(num_ctx);
|
|
for(auto& itr : get_active_contexts_impl())
|
|
{
|
|
const auto* ctx = itr.load(std::memory_order_acquire);
|
|
if(ctx)
|
|
{
|
|
if(!filter || (filter && filter(ctx))) data.emplace_back(ctx);
|
|
}
|
|
if(static_cast<int64_t>(data.size()) == num_ctx)
|
|
{
|
|
// if the number of active contexts changed, restart
|
|
if(num_ctx != get_num_active_contexts().load(std::memory_order_relaxed))
|
|
{
|
|
data.clear();
|
|
return get_active_contexts(data, filter);
|
|
}
|
|
break;
|
|
}
|
|
}
|
|
return data;
|
|
}
|
|
|
|
context_array_t
|
|
get_active_contexts(context_filter_t filter)
|
|
{
|
|
auto data = context_array_t{};
|
|
get_active_contexts(data, filter);
|
|
return data;
|
|
}
|
|
|
|
// set the client index needs to be called before allocate_context()
|
|
void
|
|
push_client(uint32_t value)
|
|
{
|
|
LOG_ASSERT(get_client_index() == invalid_client_idx)
|
|
<< " rocprofiler client index is currently " << get_client_index()
|
|
<< "... which means that a new client is initializing before the last client finished "
|
|
"initializing. This is an internal error, please file a bug report with a reproducer";
|
|
get_client_index() = value;
|
|
}
|
|
|
|
// remove the client index
|
|
void
|
|
pop_client(uint32_t value)
|
|
{
|
|
LOG_ASSERT(get_client_index() == value)
|
|
<< " rocprofiler client index is currently not " << value
|
|
<< "... which means that a new client was initialized before this client finished "
|
|
"initializing. This is an internal error, please file a bug report with a reproducer";
|
|
get_client_index() = invalid_client_idx;
|
|
}
|
|
|
|
std::optional<rocprofiler_context_id_t>
|
|
allocate_context()
|
|
{
|
|
// ... allocate any internal space needed to handle another context ...
|
|
auto _lk = std::unique_lock<std::mutex>{get_contexts_mutex()};
|
|
|
|
// initial context identifier number
|
|
auto _idx = get_registered_contexts_impl().size() + get_contexts_offset();
|
|
|
|
// make space in registered
|
|
get_registered_contexts_impl().emplace_back(nullptr);
|
|
|
|
// create an entry in the registered
|
|
auto& _cfg_v = get_registered_contexts_impl().back();
|
|
_cfg_v = allocator::make_unique_static<context>();
|
|
auto* _cfg = _cfg_v.get();
|
|
// ...
|
|
|
|
if(!_cfg) return std::nullopt;
|
|
|
|
_cfg->size = sizeof(context);
|
|
_cfg->context_idx = _idx;
|
|
_cfg->client_idx = get_client_index();
|
|
|
|
LOG_ASSERT(_cfg->client_idx != invalid_client_idx)
|
|
<< " rocprofiler internal error: a context was allocated without an associated tool client "
|
|
"identifier";
|
|
|
|
return rocprofiler_context_id_t{_idx};
|
|
}
|
|
|
|
context*
|
|
get_mutable_registered_context(rocprofiler_context_id_t id)
|
|
{
|
|
if(id.handle < get_contexts_offset()) return nullptr;
|
|
auto _idx = id.handle - get_contexts_offset();
|
|
if(_idx >= get_registered_contexts_impl().size()) return nullptr;
|
|
return get_registered_contexts_impl().at(_idx).get();
|
|
}
|
|
|
|
const context*
|
|
get_registered_context(rocprofiler_context_id_t id)
|
|
{
|
|
return get_mutable_registered_context(id);
|
|
}
|
|
|
|
rocprofiler_status_t
|
|
validate_context(const context* cfg)
|
|
{
|
|
return (cfg) ? ROCPROFILER_STATUS_SUCCESS : ROCPROFILER_STATUS_ERROR_CONTEXT_NOT_FOUND;
|
|
}
|
|
|
|
rocprofiler_status_t
|
|
start_context(rocprofiler_context_id_t context_id)
|
|
{
|
|
if(context_id.handle < get_contexts_offset()) return ROCPROFILER_STATUS_ERROR_CONTEXT_NOT_FOUND;
|
|
|
|
if((context_id.handle - get_contexts_offset()) >= get_registered_contexts_impl().size())
|
|
return ROCPROFILER_STATUS_ERROR_CONTEXT_NOT_FOUND;
|
|
|
|
const auto* cfg = get_registered_context(context_id);
|
|
|
|
if(!cfg) return ROCPROFILER_STATUS_ERROR_CONTEXT_NOT_FOUND;
|
|
|
|
if(validate_context(cfg) != ROCPROFILER_STATUS_SUCCESS)
|
|
return ROCPROFILER_STATUS_ERROR_CONTEXT_INVALID;
|
|
|
|
auto current_contexts = context_array_t{};
|
|
for(const auto* itr : get_active_contexts(current_contexts))
|
|
{
|
|
if(cfg->context_idx == itr->context_idx)
|
|
{
|
|
return ROCPROFILER_STATUS_SUCCESS;
|
|
}
|
|
else if(cfg->counter_collection && itr->counter_collection)
|
|
{
|
|
// conflicting context
|
|
return ROCPROFILER_STATUS_ERROR_CONTEXT_CONFLICT;
|
|
}
|
|
}
|
|
|
|
uint64_t rocp_tot_contexts = get_registered_contexts_impl().size();
|
|
auto idx = rocp_tot_contexts;
|
|
auto& active_contexts = get_active_contexts_impl();
|
|
{
|
|
// hold a lock here to prevent multiple threads from finding the same nullptr slot
|
|
auto _lk = std::unique_lock<std::mutex>{get_contexts_mutex()};
|
|
// try to find a nullptr slot first
|
|
for(size_t i = 0; i < active_contexts.size(); ++i)
|
|
{
|
|
const auto* itr = active_contexts.at(i).load(std::memory_order_relaxed);
|
|
if(itr == nullptr)
|
|
{
|
|
idx = i;
|
|
break;
|
|
}
|
|
else if(context_id.handle == itr->context_idx)
|
|
{
|
|
return ROCPROFILER_STATUS_SUCCESS;
|
|
}
|
|
}
|
|
// if no nullptr slot was found, then create one while lock is held
|
|
if(idx == rocp_tot_contexts)
|
|
{
|
|
idx = active_contexts.size();
|
|
active_contexts.emplace_back();
|
|
}
|
|
|
|
get_num_active_contexts().fetch_add(1, std::memory_order_release);
|
|
}
|
|
|
|
// atomic swap the pointer into the "active" array used internally
|
|
const context* _expected = nullptr;
|
|
bool success = active_contexts.at(idx).compare_exchange_strong(
|
|
_expected, get_registered_context(context_id));
|
|
|
|
if(!success)
|
|
{
|
|
get_num_active_contexts().fetch_sub(1, std::memory_order_release);
|
|
return ROCPROFILER_STATUS_ERROR_CONTEXT_NOT_STARTED;
|
|
}
|
|
|
|
if(cfg->counter_collection) rocprofiler::counters::start_context(cfg);
|
|
|
|
return ROCPROFILER_STATUS_SUCCESS;
|
|
}
|
|
|
|
rocprofiler_status_t
|
|
stop_context(rocprofiler_context_id_t idx)
|
|
{
|
|
// hold a lock here to prevent other thread from changing the active contexts array
|
|
auto _lk = std::unique_lock<std::mutex>{get_contexts_mutex()};
|
|
|
|
// atomically assign the context pointer to NULL so that it is skipped in future
|
|
// callbacks
|
|
for(auto& itr : get_active_contexts_impl())
|
|
{
|
|
const context* _expected = itr.load(std::memory_order_acquire);
|
|
if(_expected && _expected->context_idx == idx.handle)
|
|
{
|
|
bool success = itr.compare_exchange_strong(_expected, nullptr);
|
|
|
|
if(success)
|
|
{
|
|
auto nactive = get_num_active_contexts().load(std::memory_order_acquire);
|
|
if(nactive > 0) get_num_active_contexts().fetch_sub(1, std::memory_order_release);
|
|
|
|
if(_expected->counter_collection)
|
|
rocprofiler::counters::stop_context(const_cast<context*>(_expected));
|
|
return ROCPROFILER_STATUS_SUCCESS;
|
|
}
|
|
}
|
|
}
|
|
|
|
return ROCPROFILER_STATUS_ERROR_CONTEXT_NOT_FOUND; // compare exchange failed
|
|
}
|
|
|
|
void
|
|
deactivate_client_contexts(rocprofiler_client_id_t client_id)
|
|
{
|
|
for(auto& itr : get_active_contexts_impl())
|
|
{
|
|
const auto* itr_v = itr.load();
|
|
if(itr_v && itr_v->client_idx == client_id.handle)
|
|
{
|
|
itr.store(nullptr);
|
|
}
|
|
}
|
|
}
|
|
|
|
void
|
|
deregister_client_contexts(rocprofiler_client_id_t client_id)
|
|
{
|
|
for(auto& itr : get_registered_contexts_impl())
|
|
{
|
|
if(itr->client_idx == client_id.handle && buffer::get_buffers())
|
|
{
|
|
for(auto& bitr : *buffer::get_buffers())
|
|
{
|
|
if(bitr && bitr->context_id == itr->context_idx) bitr.reset();
|
|
}
|
|
itr.reset();
|
|
}
|
|
}
|
|
}
|
|
} // namespace context
|
|
} // namespace rocprofiler
|