Milan Radosavljevic
318d13870f
## Motivation - Structured logging with proper log levels (TRACE, DEBUG, INFO, WARNING, ERROR, CRITICAL) - Better performance through compile-time formatting - Consistent formatting using fmt library - Runtime log level control via arguments and environment variables - Easier maintenance and debugging capabilities ## Technical Details - Added spdlog as a submodule and integrated it into CMake build system - Created new `rocprofiler-systems-logger` library wrapping spdlog functionality - Replaced custom logging macros (`ROCPROFSYS_VERBOSE`, `ROCPROFSYS_DEBUG`, `ROCPROFSYS_FATAL`, `ROCPROFSYS_REQUIRE`, `ROCPROFSYS_CI_THROW`, etc.) with spdlog equivalents (`LOG_DEBUG`, `LOG_WARNING`, `LOG_CRITICAL`, etc.) - Implemented log level control through command-line arguments and environment variables - Converted assertion macros to proper error handling with exceptions and std::abort()
425 line
18 KiB
C++
425 line
18 KiB
C++
// MIT License
|
|
//
|
|
// Copyright (c) 2022-2025 Advanced Micro Devices, Inc. All Rights Reserved.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in all
|
|
// copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
// SOFTWARE.
|
|
|
|
#include "library/components/vaapi_gotcha.hpp"
|
|
#include "core/common.hpp"
|
|
#include "core/config.hpp"
|
|
#include "core/state.hpp"
|
|
#include "core/timemory.hpp"
|
|
#include "library/components/category_region.hpp"
|
|
#include "library/runtime.hpp"
|
|
|
|
#include <timemory/backends/threading.hpp>
|
|
#include <timemory/components/macros.hpp>
|
|
#include <timemory/mpl/concepts.hpp>
|
|
#include <timemory/utility/types.hpp>
|
|
|
|
#include <cstddef>
|
|
#include <cstdlib>
|
|
|
|
namespace rocprofsys
|
|
{
|
|
namespace component
|
|
{
|
|
namespace
|
|
{
|
|
auto&
|
|
get_vaapi_gotcha()
|
|
{
|
|
static auto _v = tim::lightweight_tuple<vaapi_gotcha_t>{};
|
|
return _v;
|
|
}
|
|
} // namespace
|
|
|
|
void
|
|
vaapi_gotcha::configure()
|
|
{
|
|
// don't emit warnings for missing functions unless debug or verbosity >= 3
|
|
if(get_verbose_env() < 3 && !get_debug_env())
|
|
{
|
|
for(size_t i = 0; i < vaapi_gotcha_t::capacity(); ++i)
|
|
{
|
|
auto* itr = vaapi_gotcha_t::at(i);
|
|
if(itr) itr->verbose = -1;
|
|
}
|
|
}
|
|
|
|
vaapi_gotcha_t::get_initializer() = []() {
|
|
vaapi_gotcha_t::configure<0, VAStatus, VADisplay, VAContextID, VASurfaceID>(
|
|
"vaBeginPicture");
|
|
vaapi_gotcha_t::configure<1, VAStatus, VADisplay, VAContextID, VABufferType,
|
|
unsigned int, unsigned int, void*, VABufferID*>(
|
|
"vaCreateBuffer");
|
|
vaapi_gotcha_t::configure<2, VAStatus, VADisplay, VAProfile, VAEntrypoint,
|
|
VAConfigAttrib*, int, VAConfigID*>("vaCreateConfig");
|
|
vaapi_gotcha_t::configure<3, VAStatus, VADisplay, VAConfigID, int, int, int,
|
|
VASurfaceID*, int, VAContextID*>("vaCreateContext");
|
|
vaapi_gotcha_t::configure<4, VAStatus, VADisplay, unsigned int, unsigned int,
|
|
unsigned int, VASurfaceID*, unsigned int,
|
|
VASurfaceAttrib*, unsigned int>("vaCreateSurfaces");
|
|
vaapi_gotcha_t::configure<5, VAStatus, VADisplay, VASurfaceID*, int>(
|
|
"vaDestroySurfaces");
|
|
vaapi_gotcha_t::configure<6, VAStatus, VADisplay, VASurfaceID>("vaSyncSurface");
|
|
vaapi_gotcha_t::configure<7, VAStatus, VADisplay, VABufferID>("vaDestroyBuffer");
|
|
vaapi_gotcha_t::configure<8, VAStatus, VADisplay, VAConfigID>("vaDestroyConfig");
|
|
vaapi_gotcha_t::configure<9, VAStatus, VADisplay, VAContextID>(
|
|
"vaDestroyContext");
|
|
vaapi_gotcha_t::configure<10, VAStatus, VADisplay, VAContextID>("vaEndPicture");
|
|
vaapi_gotcha_t::configure<11, VAStatus, VADisplay, VASurfaceID, uint32_t,
|
|
uint32_t, void*>("vaExportSurfaceHandle");
|
|
vaapi_gotcha_t::configure<12, VAStatus, VADisplay, VAProfile, VAEntrypoint,
|
|
VAConfigAttrib*, int>("vaGetConfigAttributes");
|
|
vaapi_gotcha_t::configure<13, VAStatus, VADisplay, int*, int*>("vaInitialize");
|
|
vaapi_gotcha_t::configure<14, VAStatus, VADisplay, VAProfile, VAEntrypoint*,
|
|
int*>("vaQueryConfigEntrypoints");
|
|
vaapi_gotcha_t::configure<15, VAStatus, VADisplay, VAConfigID, VASurfaceAttrib*,
|
|
unsigned int*>("vaQuerySurfaceAttributes");
|
|
vaapi_gotcha_t::configure<16, VAStatus, VADisplay, VASurfaceID, VASurfaceStatus*>(
|
|
"vaQuerySurfaceStatus");
|
|
vaapi_gotcha_t::configure<17, VAStatus, VADisplay, VAContextID, VABufferID*, int>(
|
|
"vaRenderPicture");
|
|
vaapi_gotcha_t::configure<18, VAStatus, VADisplay>("vaTerminate");
|
|
vaapi_gotcha_t::configure<19, int, VADisplay>("vaDisplayIsValid");
|
|
vaapi_gotcha_t::configure<20, VAStatus, VADisplay, VAImageFormat*, int, int,
|
|
VAImage*>("vaCreateImage");
|
|
vaapi_gotcha_t::configure<21, VAStatus, VADisplay, VAImageID>("vaDestroyImage");
|
|
vaapi_gotcha_t::configure<22, VAStatus, VADisplay, VASurfaceID, int, int,
|
|
unsigned int, unsigned int, VAImageID>("vaGetImage");
|
|
vaapi_gotcha_t::configure<23, VAStatus, VADisplay, VASurfaceID, VAImage*>(
|
|
"vaDeriveImage");
|
|
vaapi_gotcha_t::configure<24, VAStatus, VADisplay, VAImageFormat*, int*>(
|
|
"vaQueryImageFormats");
|
|
vaapi_gotcha_t::configure<25, VAStatus, VADisplay, VABufferID, void**>(
|
|
"vaMapBuffer");
|
|
vaapi_gotcha_t::configure<26, VAStatus, VADisplay, VABufferID>("vaUnmapBuffer");
|
|
vaapi_gotcha_t::configure<27, VAStatus, VADisplay, VABufferID, VABufferInfo*>(
|
|
"vaAcquireBufferHandle");
|
|
vaapi_gotcha_t::configure<28, VAStatus, VADisplay, VABufferID>(
|
|
"vaReleaseBufferHandle");
|
|
vaapi_gotcha_t::configure<29, VAStatus, VADisplay, VASurfaceID, VAImageID, int,
|
|
int, unsigned int, unsigned int, int, int, unsigned int,
|
|
unsigned int>("vaPutImage");
|
|
};
|
|
}
|
|
|
|
void
|
|
vaapi_gotcha::shutdown()
|
|
{
|
|
vaapi_gotcha_t::disable();
|
|
}
|
|
|
|
void
|
|
vaapi_gotcha::start()
|
|
{
|
|
if(!get_vaapi_gotcha().get<vaapi_gotcha_t>()->get_is_running())
|
|
{
|
|
configure();
|
|
get_vaapi_gotcha().start();
|
|
}
|
|
}
|
|
|
|
void
|
|
vaapi_gotcha::stop()
|
|
{}
|
|
|
|
// vaBeginPicture
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy,
|
|
VAContextID context, VASurfaceID render_target)
|
|
{
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy", dpy,
|
|
"context", context, "render_target",
|
|
render_target);
|
|
}
|
|
|
|
// vaCreateBuffer
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy,
|
|
VAContextID context, VABufferType type, unsigned int size,
|
|
unsigned int num_elements, void* data, VABufferID* buf_id)
|
|
{
|
|
category_region<category::vaapi>::start(
|
|
std::string_view{ _data.tool_id }, "dpy", dpy, "context", context, "buffer_type",
|
|
type, "size", size, "num_elements", num_elements, "data", data, "buf_id", buf_id);
|
|
}
|
|
|
|
// vaCreateConfig
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy,
|
|
VAProfile profile, VAEntrypoint entrypoint,
|
|
VAConfigAttrib* attrib_list, int num_attribs, VAConfigID* config_id)
|
|
{
|
|
(void) attrib_list; // unused
|
|
category_region<category::vaapi>::start(
|
|
std::string_view{ _data.tool_id }, "dpy", dpy, "profile", profile, "entrypoint",
|
|
entrypoint, "num_attribs", num_attribs, "config_id", config_id);
|
|
}
|
|
|
|
// vaCreateContext
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy,
|
|
VAConfigID config_id, int picture_width, int picture_height, int flag,
|
|
VASurfaceID* render_targets, int num_render_targets,
|
|
VAContextID* context)
|
|
{
|
|
category_region<category::vaapi>::start(
|
|
std::string_view{ _data.tool_id }, "dpy", dpy, "config_id", config_id,
|
|
"picture_width", picture_width, "picture_height", picture_height, "flag", flag,
|
|
"render_targets", render_targets, "num_render_targets", num_render_targets,
|
|
"context", context);
|
|
}
|
|
|
|
// vaCreateSurfaces
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy,
|
|
unsigned int format, unsigned int width, unsigned int height,
|
|
VASurfaceID* surfaces, unsigned int num_surfaces,
|
|
VASurfaceAttrib* attrib_list, unsigned int num_attribs)
|
|
{
|
|
(void) attrib_list; // unused
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy", dpy,
|
|
"format", format, "width", width, "height",
|
|
height, "surfaces", surfaces, "num_surfaces",
|
|
num_surfaces, "num_attribs", num_attribs);
|
|
}
|
|
|
|
// vaCreateImage
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy,
|
|
VAImageFormat* format, int width, int height, VAImage* image)
|
|
{
|
|
(void) format; // unused
|
|
(void) image; // unused
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy", dpy,
|
|
"width", width, "height", height);
|
|
}
|
|
|
|
// vaPutImage
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy,
|
|
VASurfaceID surface, VAImageID image, int src_x, int src_y,
|
|
unsigned int src_width, unsigned int src_height, int dest_x,
|
|
int dest_y, unsigned int dest_width, unsigned int dest_height)
|
|
{
|
|
category_region<category::vaapi>::start(
|
|
std::string_view{ _data.tool_id }, "dpy", dpy, "surfaceID", surface, "imageID",
|
|
image, "x-cordinate", src_x, "y-cordinate", src_y, "src_width", src_width,
|
|
"src_height", src_height, "dest_x", dest_x, "dest_y", dest_y, "dest_width",
|
|
dest_width, "dest_height", dest_height);
|
|
}
|
|
|
|
// vaDestroyBuffer
|
|
// vaDestroyConfig
|
|
// vaDestroyContext
|
|
// vaEndPicture
|
|
// vaSyncSurface
|
|
// vaDestroyImage
|
|
// vaUnmapBuffer
|
|
// vaReleaseBufferHandle
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy,
|
|
VAContextID context)
|
|
{
|
|
if(_data.tool_id == "vaDestroyBuffer")
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy",
|
|
dpy, "buffer_id", context);
|
|
else if(_data.tool_id == "vaDestroyConfig")
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy",
|
|
dpy, "config_id", context);
|
|
else if(_data.tool_id == "vaDestroyContext")
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy",
|
|
dpy, "context", context);
|
|
else if(_data.tool_id == "vaEndPicture")
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy",
|
|
dpy, "context", context);
|
|
else if(_data.tool_id == "vaSyncSurface")
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy",
|
|
dpy, "render_target", context);
|
|
else if(_data.tool_id == "vaDestroyImage")
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy",
|
|
dpy, "image_id", context);
|
|
else if(_data.tool_id == "vaUnmapBuffer" || _data.tool_id == "vaReleaseBufferHandle")
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy",
|
|
dpy, "buffer_id", context);
|
|
else
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy",
|
|
dpy, "id", context);
|
|
}
|
|
|
|
// vaDestroySurfaces
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy,
|
|
VASurfaceID* surfaces, int num_surfaces)
|
|
{
|
|
(void) surfaces; // unused
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy", dpy,
|
|
"num_surfaces", num_surfaces);
|
|
}
|
|
|
|
// vaExportSurfaceHandle
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy,
|
|
VASurfaceID surface_id, uint32_t mem_type, uint32_t flags,
|
|
void* descriptor)
|
|
{
|
|
category_region<category::vaapi>::start(
|
|
std::string_view{ _data.tool_id }, "dpy", dpy, "surface_id", surface_id,
|
|
"mem_type", mem_type, "flags", flags, "descriptor", descriptor);
|
|
}
|
|
|
|
// vaGetImage
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy,
|
|
VASurfaceID surface, int x, int y, unsigned int width,
|
|
unsigned int height, VAImageID image)
|
|
{
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy", dpy,
|
|
"surfaceID", surface, "x-cordinate", x,
|
|
"y-cordinate", y, "width", width, "height",
|
|
height, "imageID", image);
|
|
}
|
|
|
|
// vaGetConfigAttributes
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy,
|
|
VAProfile profile, VAEntrypoint entrypoint,
|
|
VAConfigAttrib* attrib_list, int num_attribs)
|
|
{
|
|
(void) attrib_list; // unused
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy", dpy,
|
|
"profile", profile, "entrypoint", entrypoint,
|
|
"num_attribs", num_attribs);
|
|
}
|
|
|
|
// vaInitialize
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy,
|
|
int* major_version, int* minor_version)
|
|
{
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy", dpy,
|
|
"major_version", major_version,
|
|
"minor_version", minor_version);
|
|
}
|
|
|
|
// vaQueryImageFormats
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy,
|
|
VAImageFormat* format_list, int* num_formats)
|
|
{
|
|
(void) format_list; // unused
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy", dpy,
|
|
"num_formats", num_formats);
|
|
}
|
|
|
|
// vaQueryConfigEntrypoints
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy,
|
|
VAProfile profile, VAEntrypoint* entrypoint_list,
|
|
int* num_entrypoints)
|
|
{
|
|
category_region<category::vaapi>::start(
|
|
std::string_view{ _data.tool_id }, "dpy", dpy, "profile", profile,
|
|
"entrypoint_list", entrypoint_list, "num_entrypoints", num_entrypoints);
|
|
}
|
|
|
|
// vaQuerySurfaceAttributes
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy,
|
|
VAConfigID config, VASurfaceAttrib* attrib_list,
|
|
unsigned int* num_attribs)
|
|
{
|
|
(void) attrib_list; // unused
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy", dpy,
|
|
"config", config, "num_attribs", num_attribs);
|
|
}
|
|
|
|
// vaQuerySurfaceStatus
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy,
|
|
VASurfaceID render_target, VASurfaceStatus* status)
|
|
{
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy", dpy,
|
|
"render_target", render_target, "status",
|
|
status);
|
|
}
|
|
|
|
// vaDeriveImage
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy,
|
|
VASurfaceID surface, VAImage* image)
|
|
{
|
|
(void) image; // unused
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy", dpy,
|
|
"surfaceID", surface);
|
|
}
|
|
|
|
// vaMapBuffer
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy,
|
|
VABufferID buf_id, void** pbuf)
|
|
{
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy", dpy,
|
|
"bufferID", buf_id, "pbuf", pbuf);
|
|
}
|
|
|
|
// vaAcquireBufferHandle
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy,
|
|
VABufferID buf_id, VABufferInfo* buf_info)
|
|
{
|
|
(void) buf_info; // unused
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy", dpy,
|
|
"bufferID", buf_id);
|
|
}
|
|
|
|
// vaRenderPicture
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy,
|
|
VAContextID context, VABufferID* buffers, int num_buffers)
|
|
{
|
|
(void) buffers; // unused
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy", dpy,
|
|
"context", context, "num_buffers",
|
|
num_buffers);
|
|
}
|
|
|
|
// vaTerminate
|
|
// vaDisplayIsValid
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::incoming, VADisplay dpy)
|
|
{
|
|
category_region<category::vaapi>::start(std::string_view{ _data.tool_id }, "dpy",
|
|
dpy);
|
|
}
|
|
|
|
void
|
|
vaapi_gotcha::audit(const gotcha_data& _data, audit::outgoing, VAStatus ret)
|
|
{
|
|
category_region<category::vaapi>::stop(std::string_view{ _data.tool_id }, "return",
|
|
ret);
|
|
}
|
|
|
|
} // namespace component
|
|
} // namespace rocprofsys
|
|
|
|
TIMEMORY_STORAGE_INITIALIZER(rocprofsys::component::vaapi_gotcha)
|