Galantsev, Dmitrii
91be467cad
The 'value' pointer was being written to a lot and then used for reading within the same function. This likely caused issues all over RDC when reading the metrics. This commit changes it so *value is written to only once. Change-Id: I83c158c1e46c6ce46ff87d8a2e769f26ffa8c0da Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
96 líneas
3.3 KiB
C++
96 líneas
3.3 KiB
C++
/*
|
|
Copyright (c) 2022 - present Advanced Micro Devices, Inc. All rights reserved.
|
|
|
|
Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
of this software and associated documentation files (the "Software"), to deal
|
|
in the Software without restriction, including without limitation the rights
|
|
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
copies of the Software, and to permit persons to whom the Software is
|
|
furnished to do so, subject to the following conditions:
|
|
|
|
The above copyright notice and this permission notice shall be included in
|
|
all copies or substantial portions of the Software.
|
|
|
|
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
THE SOFTWARE.
|
|
*/
|
|
|
|
#ifndef RDC_MODULES_RDC_ROCP_RDCROCPBASE_H_
|
|
#define RDC_MODULES_RDC_ROCP_RDCROCPBASE_H_
|
|
#include <rocprofiler-sdk/agent.h>
|
|
|
|
#include <cstdint>
|
|
#include <map>
|
|
#include <unordered_set>
|
|
#include <utility>
|
|
#include <vector>
|
|
|
|
#include "rdc/rdc.h"
|
|
#include "rdc_lib/RdcTelemetryLibInterface.h"
|
|
#include "rdc_modules/rdc_rocp/RdcRocpCounterSampler.h"
|
|
|
|
namespace amd {
|
|
namespace rdc {
|
|
|
|
/// Common interface for RocP tests and samples
|
|
class RdcRocpBase {
|
|
public:
|
|
RdcRocpBase();
|
|
RdcRocpBase(const RdcRocpBase&) = default;
|
|
RdcRocpBase(RdcRocpBase&&) = delete;
|
|
RdcRocpBase& operator=(const RdcRocpBase&) = delete;
|
|
RdcRocpBase& operator=(RdcRocpBase&&) = delete;
|
|
~RdcRocpBase();
|
|
|
|
/**
|
|
* @brief Lookup ROCProfiler counter
|
|
*
|
|
* @param[in] gpu_field GPU_ID and FIELD_ID of requested metric
|
|
* @param[out] value A pointer that will be populated with returned value
|
|
*
|
|
* @retval ::ROCMTOOLS_STATUS_SUCCESS The function has been executed
|
|
* successfully.
|
|
*/
|
|
rdc_status_t rocp_lookup(rdc_gpu_field_t gpu_field, double* value);
|
|
const char* get_field_id_from_name(rdc_field_t);
|
|
const std::vector<rdc_field_t> get_field_ids();
|
|
|
|
protected:
|
|
private:
|
|
typedef std::pair<uint32_t, rdc_field_t> rdc_field_pair_t;
|
|
/**
|
|
* @brief Tweak this to change for how long each metric is collected
|
|
*/
|
|
static const uint32_t collection_duration_us_k = 10000;
|
|
|
|
double read_feature(rocprofiler_record_counter_t* record, uint32_t gpu_index);
|
|
double run_profiler(uint32_t gpu_index, rdc_field_t field);
|
|
|
|
std::vector<rocprofiler_agent_v0_t> agents = {};
|
|
std::vector<std::shared_ptr<CounterSampler>> samplers = {};
|
|
std::map<rdc_field_t, const char*> field_to_metric = {};
|
|
|
|
// these fields must be divided by time passed
|
|
std::unordered_set<rdc_field_t> eval_fields = {
|
|
RDC_FI_PROF_EVAL_MEM_R_BW, RDC_FI_PROF_EVAL_MEM_W_BW,
|
|
RDC_FI_PROF_EVAL_FLOPS_16, RDC_FI_PROF_EVAL_FLOPS_32,
|
|
RDC_FI_PROF_EVAL_FLOPS_64, RDC_FI_PROF_EVAL_FLOPS_16_PERCENT,
|
|
RDC_FI_PROF_EVAL_FLOPS_32_PERCENT, RDC_FI_PROF_EVAL_FLOPS_64_PERCENT,
|
|
};
|
|
|
|
/**
|
|
* @brief Convert from profiler status into RDC status
|
|
*/
|
|
rdc_status_t Rocp2RdcError(rocprofiler_status_t status);
|
|
};
|
|
|
|
} // namespace rdc
|
|
} // namespace amd
|
|
|
|
#endif // RDC_MODULES_RDC_ROCP_RDCROCPBASE_H_
|