Files
rocm-systems/projects/rocprofiler-systems/source/lib/rocprof-sys/library/rocprofiler-sdk/rccl.cpp
T
Milan Radosavljevic 318d13870f [rocprofiler-systems] Update logging to use spdlog library (#2428)
## Motivation

- Structured logging with proper log levels (TRACE, DEBUG, INFO, WARNING, ERROR, CRITICAL)
- Better performance through compile-time formatting
- Consistent formatting using fmt library
- Runtime log level control via arguments and environment variables
- Easier maintenance and debugging capabilities

## Technical Details

- Added spdlog as a submodule and integrated it into CMake build system
- Created new `rocprofiler-systems-logger` library wrapping spdlog functionality
- Replaced custom logging macros (`ROCPROFSYS_VERBOSE`, `ROCPROFSYS_DEBUG`, `ROCPROFSYS_FATAL`, `ROCPROFSYS_REQUIRE`, `ROCPROFSYS_CI_THROW`, etc.) with spdlog equivalents (`LOG_DEBUG`, `LOG_WARNING`, `LOG_CRITICAL`, etc.)
- Implemented log level control through command-line arguments and environment variables
- Converted assertion macros to proper error handling with exceptions and std::abort()
2026-01-14 15:27:51 -05:00

187 строки
6.2 KiB
C++

// MIT License
//
// Copyright (c) 2025 Advanced Micro Devices, Inc. All Rights Reserved.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in all
// copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
// SOFTWARE.
#include "library/rocprofiler-sdk/rccl.hpp"
#include "core/config.hpp"
#include "core/perfetto.hpp"
#include "library/tracing.hpp"
#include "logger/debug.hpp"
namespace rocprofsys
{
namespace rocprofiler_sdk
{
namespace
{
struct rccl_recv
{
static constexpr auto value = "comm_data";
static constexpr auto label = "RCCL Comm Recv";
};
struct rccl_send
{
static constexpr auto value = "comm_data";
static constexpr auto label = "RCCL Comm Send";
};
template <typename Tp, typename... Args>
void
write_perfetto_counter_track(uint64_t _val, uint64_t _begin_ts, uint64_t _end_ts)
{
using counter_track = rocprofsys::perfetto_counter_track<Tp>;
if(rocprofsys::get_use_perfetto() &&
rocprofsys::get_state() == rocprofsys::State::Active)
{
const size_t _idx = 0;
if(!counter_track::exists(_idx))
{
std::string _label =
(_idx > 0) ? JOIN(" ", Tp::label, JOIN("", '[', _idx, ']')) : Tp::label;
counter_track::emplace(_idx, _label, "bytes");
}
TRACE_COUNTER(Tp::value, counter_track::at(_idx, 0), _begin_ts, _val);
TRACE_COUNTER(Tp::value, counter_track::at(_idx, 0), _end_ts, 0);
}
}
static auto
rccl_type_size(ncclDataType_t datatype)
{
switch(datatype)
{
case ncclInt8:
case ncclUint8: return 1;
case ncclFloat16: return 2;
case ncclInt32:
case ncclUint32:
case ncclFloat32: return 4;
case ncclInt64:
case ncclUint64:
case ncclFloat64: return 8;
default:
{
LOG_CRITICAL("Unsupported RCCL datatype: {}", static_cast<int>(datatype));
::rocprofsys::set_state(::rocprofsys ::State ::Finalized);
std::abort();
}
};
}
} // namespace
/*
* @brief RCCL callback tracing handler
*
* This function processes RCCL API calls and writes the data transfer size to
* the Perfetto counter track.
*
* @param record The tracing record containing the RCCL API call information.
* @param begin_ts The timestamp when the operation started.
* @param end_ts The timestamp when the operation ended.
*/
void
tool_tracing_callback_rccl(rocprofiler_callback_tracing_record_t record,
uint64_t begin_ts, uint64_t end_ts)
{
if(record.kind == ROCPROFILER_CALLBACK_TRACING_RCCL_API)
{
auto* payload =
static_cast<rocprofiler_callback_tracing_rccl_api_data_t*>(record.payload);
size_t size = 0;
bool is_send = false;
auto set_recv = [&](size_t count, ncclDataType_t _dt) {
is_send = false;
size = count * rccl_type_size(_dt);
};
auto set_send = [&](size_t count, ncclDataType_t _dt) {
is_send = true;
size = count * rccl_type_size(_dt);
};
switch(record.operation)
{
// RCCL Data Receive
case ROCPROFILER_RCCL_API_ID_ncclAllGather:
set_recv(payload->args.ncclAllGather.sendcount,
payload->args.ncclAllGather.datatype);
break;
case ROCPROFILER_RCCL_API_ID_ncclAllToAll:
set_recv(payload->args.ncclAllToAll.count,
payload->args.ncclAllToAll.datatype);
break;
case ROCPROFILER_RCCL_API_ID_ncclAllReduce:
set_recv(payload->args.ncclAllReduce.count,
payload->args.ncclAllReduce.datatype);
break;
case ROCPROFILER_RCCL_API_ID_ncclGather:
set_recv(payload->args.ncclGather.sendcount,
payload->args.ncclGather.datatype);
break;
case ROCPROFILER_RCCL_API_ID_ncclRecv:
set_recv(payload->args.ncclRecv.count, payload->args.ncclRecv.datatype);
break;
case ROCPROFILER_RCCL_API_ID_ncclReduce:
set_recv(payload->args.ncclReduce.count,
payload->args.ncclReduce.datatype);
break;
// RCCL Data Send
case ROCPROFILER_RCCL_API_ID_ncclBroadcast:
set_send(payload->args.ncclBroadcast.count,
payload->args.ncclBroadcast.datatype);
break;
case ROCPROFILER_RCCL_API_ID_ncclReduceScatter:
set_send(payload->args.ncclReduceScatter.recvcount,
payload->args.ncclReduceScatter.datatype);
break;
case ROCPROFILER_RCCL_API_ID_ncclSend:
set_send(payload->args.ncclSend.count, payload->args.ncclSend.datatype);
break;
default:
// Skip other RCCL operations
break;
}
if(config::get_use_perfetto() && size > 0)
{
if(is_send)
write_perfetto_counter_track<rccl_send>(size, begin_ts, end_ts);
else
write_perfetto_counter_track<rccl_recv>(size, begin_ts, end_ts);
}
}
}
} // namespace rocprofiler_sdk
} // namespace rocprofsys