ae8f72fa79
* Use native tool for counter collection
* Add native counter collection tool which uses rocprofiler-sdk C++
library public API to get counter collection data
* This is enabled by default, unless --no-native-tool option is
provided or ROCPROF=rocprofv3 env. var. is provided
* This tool is only supported for ROCm version >=7.x.x
* This tool is not supported for attach/detach scenario
* Build native tool shared object during build time
* If using rocprof-compute without building then runtime compilation of
t push native tool shared object is performed
* rocprofiler-sdk tools is still used for services other than counter
collection and data collected by native tool is merged into the
rocpd/csv output of rocprofiler-sdk tool
* Make `rocpd` choice the default choice for `--format-rocprof-output`
option
* If `rocpd` public API from rocprofiler-sdk library is not present,
then fallback to `csv` choice
* In this case only `pmc_perf.csv` is written in workload folder
instead of multiple `csv` files for each profiling run
* Remove `json` choice from `--format-rocprof-output` option since it
functions identical to `csv` option
* Rename option `--rocprofiler-sdk-library-path` to
`--rocprofiler-sdk-tool-path` since we LD_PRELOAD the
rocprofiler-sdk tool shared object and not the rocprofiler-sdk library
shared object
* Fix the meaning of `--dispatch` option in `profile` mode to mention
dispatch iteration filtering instead of dispatch id filtering
* --dispatch option in analyze mode does dispatch id filtering
* Move standalone binary creation logic from cmake file to docker file
* fix native counter collection tool during attach/detach
* improve logging
* fix attach detach with native tool
* fix attach detach with native tool
* do not support attach/detach in native tool
* Update changelog
* add standalone binary creation functionality in cmake
* address review comments
* address review comments
* fix formatting
* address review comments
* Adding paths for cmake to search. Also updated min. cmake requirement to 3.21 as this was when hip was supported.
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
* Update hip compiler ID check, sometimes comes up as Clang, sometimes ROCMClang- depends on setup.
Updated formatting.
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
* RHEL8.10 unable to compile due to defaulting to old c++ version, need to force c++17
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
* Updating changelog per docs team recommendations
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
* Apply suggestions from code review to changelog
Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>
* Do not required HIP complier to build native counter collection tool
* fix cmake
* gersemi formatting on latest cmake change
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
* ex ci updated dependencies to include rocprofiler-sdk, but cmake was still not capturing the path- there was a commit that added to the cmake_prefix_path entry that specified rocprof-sdk's cmake location ut was too specific for the search paths in find_package's config mode.
removing the cmake_prefix_path var and adding hints to find_package call instead, and specifying config mode so it knows how to construct the search paths
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
* gersemi run for formatting
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
* Still need prefix path, should not have been removed in last commit but does need to be shortened to just the rocm path to allow for find_package config mode to do the job
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
* include cstdint for uint32_t
* Run formatting on helper.cpp
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
* Remove rocm 7.2 release stuff from version and changelog and handle it in separate pr
* fix version
* fix changelog
* fix changelog
* run ruff formatter
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
* fix rocprofiler-sdk attach so path
---------
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
Co-authored-by: Carrie Fallows <Carrie.Fallows@amd.com>
Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>
129 라인
3.7 KiB
YAML
129 라인
3.7 KiB
YAML
name: rocprofiler-compute Formatting
|
|
|
|
on:
|
|
push:
|
|
branches:
|
|
- develop
|
|
paths:
|
|
- 'projects/rocprofiler-compute/**'
|
|
pull_request:
|
|
paths:
|
|
- '.github/workflows/rocprofiler-compute-formatting.yml'
|
|
- 'projects/rocprofiler-compute/**'
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
python:
|
|
runs-on: ubuntu-22.04
|
|
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
with:
|
|
sparse-checkout: projects/rocprofiler-compute
|
|
- name: Set up Python '3.x'
|
|
uses: actions/setup-python@v5
|
|
with:
|
|
python-version: '3.x'
|
|
- name: Install dependencies
|
|
working-directory: projects/rocprofiler-compute
|
|
run: |
|
|
python -m pip install --upgrade pip
|
|
python -m pip install ruff
|
|
if [ -f requirements.txt ]; then python -m pip install -r requirements.txt; fi
|
|
- name: Run Ruff Linter and Import Sorter
|
|
run: |
|
|
ruff check . --fix --exit-zero
|
|
- name: Run Ruff Formatter
|
|
run: |
|
|
ruff format .
|
|
- name: Check for formatting/linting changes
|
|
run: |
|
|
git config --global user.name 'github-actions'
|
|
git config --global user.email 'github-actions@github.com'
|
|
git add -A .
|
|
if ! git diff --cached --quiet; then
|
|
echo "::error::Files were modified by ruff. Please run 'ruff check . --fix && ruff format .' locally and commit the changes."
|
|
git diff --cached --patch # Show the diff in the logs
|
|
exit 1
|
|
else
|
|
echo "Ruff found no issues or all issues were fixed and files are clean."
|
|
fi
|
|
|
|
cmake:
|
|
runs-on: ubuntu-22.04
|
|
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
with:
|
|
sparse-checkout: projects/rocprofiler-compute
|
|
- name: Install dependencies
|
|
working-directory: projects/rocprofiler-compute
|
|
run: |
|
|
sudo apt-get update
|
|
sudo apt-get install -y python3-pip
|
|
python3 -m pip install gersemi
|
|
- name: gersemi
|
|
working-directory: projects/rocprofiler-compute
|
|
run: |
|
|
set +e
|
|
gersemi -i $(find . -type f | egrep 'CMakeLists.txt|\.cmake$')
|
|
if [ $(git diff | wc -l) -gt 0 ]; then
|
|
echo -e "\nError! CMake code not formatted. Run gersemi...\n"
|
|
echo -e "\nFiles:\n"
|
|
git diff --name-only
|
|
echo -e "\nFull diff:\n"
|
|
git diff
|
|
exit 1
|
|
fi
|
|
|
|
cxx:
|
|
runs-on: ubuntu-22.04
|
|
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
with:
|
|
sparse-checkout: projects/rocprofiler-compute
|
|
- name: Install dependencies
|
|
working-directory: projects/rocprofiler-compute
|
|
run: |
|
|
sudo apt-get update
|
|
sudo apt-get install -y python3-pip
|
|
python3 -m pip install clang-format
|
|
- name: clang-format
|
|
working-directory: projects/rocprofiler-compute
|
|
run: |
|
|
set +e
|
|
clang-format -i $(find src -type f | egrep '\.(h|hpp|hh|c|cc|cpp)(|\.in)$')
|
|
if [ $(git diff | wc -l) -gt 0 ]; then
|
|
echo -e "\nError! cxx code not formatted. Run clang-format...\n"
|
|
echo -e "\nFiles:\n"
|
|
git diff --name-only
|
|
echo -e "\nFull diff:\n"
|
|
git diff
|
|
exit 1
|
|
fi
|
|
|
|
python-bytecode:
|
|
runs-on: ubuntu-22.04
|
|
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
with:
|
|
sparse-checkout: projects/rocprofiler-compute
|
|
- name: find-bytecode
|
|
working-directory: projects/rocprofiler-compute
|
|
run: |
|
|
set +e
|
|
FILES=$(find . -type f | egrep '__pycache__|\.pyc$')
|
|
if [ -n "${FILES}" ]; then
|
|
echo -e "\nError! Python bytecode included in commit\n"
|
|
echo -e "### FILES: ###"
|
|
echo -e "${FILES}"
|
|
echo -e "##############"
|
|
exit 1
|
|
fi
|