463126770a
## Motivation <!-- Explain the purpose of this PR and the goals it aims to achieve. --> - __Reduced Code Duplication__: Version parsing logic moved from individual Dockerfiles to the central build script - __Improved Edge Case Handling__: Better handling of ROCm versions with and without patch numbers (e.g., `6.2` vs `6.2.0`) - __Easier Maintenance__: Future version-related changes only need to be made in one place - __Cleaner Dockerfiles__: Simplified Dockerfiles focus on package installation rather than complex shell logic - __Updated Platform Support__: Refreshed container matrix to reflect current platform/ROCm version combinations - __Fix OpenSUSE Docker Generation__: OpenSUSE container generation fails due to a change to the `binutils-gold` package - __Error Handling__: Fix bug where errors in docker image build were being masked, allowing workflow to pass anyway. ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> - Updated `Dockerfile.opensuse` and `Dockerfile.opensuse.ci` docker files to remove `binutils-gold` - Not needed since we build `binutils` with systems anyways - Updated `rocprofiler-systems-containers.yml` to remove `pushd/popd` commands and just run the shell scripts - There was a silent failure observed here, which I verified in this PR before adding the fix for openSUSE - Refactor ROCm version parsing. Move this logic to the `build-docker.sh` script to reduce duplication. - Fix bug that caused ROCm 7.0 to fail installation. The trailing `.0` was being trimmed. - Fixed inconsistencies in `containers.yml` that lead to invalid ROCm-OS_VERSION combinations. - Formatting fixes - Removed trailing whitespace - Fix docker build warnings. Use an `=` rather than ` ` when assigning an environment variable.
186 строки
5.6 KiB
YAML
186 строки
5.6 KiB
YAML
name: rocprofiler-systems Continuous Integration Containers
|
|
run-name: ci-containers
|
|
|
|
# nightly build
|
|
on:
|
|
workflow_dispatch:
|
|
schedule:
|
|
- cron: 0 5 * * *
|
|
push:
|
|
branches:
|
|
- develop
|
|
paths:
|
|
- '.github/workflows/rocprofiler-systems-containers.yml'
|
|
- 'projects/rocprofiler-systems/docker/**'
|
|
pull_request:
|
|
paths:
|
|
- '.github/workflows/rocprofiler-systems-containers.yml'
|
|
- 'projects/rocprofiler-systems/docker/**'
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
env:
|
|
GIT_DISCOVERY_ACROSS_FILESYSTEM: 1
|
|
|
|
jobs:
|
|
prepare_matrix_ci:
|
|
if: github.repository == 'ROCm/rocm-systems'
|
|
runs-on: ubuntu-latest
|
|
outputs:
|
|
matrix_data: ${{ steps.generate_matrix_ci.outputs.matrix_data }}
|
|
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
with:
|
|
sparse-checkout: projects/rocprofiler-systems/docker
|
|
|
|
- name: Output data for containers matrix
|
|
working-directory: projects/rocprofiler-systems/docker
|
|
id: generate_matrix_ci
|
|
run: |
|
|
MATRIX_CONTENT=$(cat containers-ci.yml | yq '.matrix' -I=0 -o=json)
|
|
echo "matrix_data=$MATRIX_CONTENT" >> $GITHUB_OUTPUT
|
|
|
|
rocprofiler-systems-ci:
|
|
needs: prepare_matrix_ci
|
|
runs-on: ubuntu-latest
|
|
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
include: ${{ fromJSON(needs.prepare_matrix_ci.outputs.matrix_data) }}
|
|
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
with:
|
|
sparse-checkout: projects/rocprofiler-systems/docker
|
|
submodules: recursive
|
|
|
|
- name: Set up QEMU
|
|
uses: docker/setup-qemu-action@v2
|
|
|
|
- name: Set up Docker Buildx
|
|
uses: docker/setup-buildx-action@v2
|
|
|
|
- name: Login to DockerHub
|
|
uses: docker/login-action@v2
|
|
with:
|
|
username: ${{ secrets.ROCPROF_SYS_DOCKER_LOGIN }}
|
|
password: ${{ secrets.ROCPROF_SYS_DOCKER_TOKEN }}
|
|
|
|
- name: Build CI Container (PR - No Push)
|
|
if: github.event_name == 'pull_request'
|
|
timeout-minutes: 45
|
|
uses: nick-fields/retry@v3
|
|
with:
|
|
retry_wait_seconds: 60
|
|
timeout_minutes: 45
|
|
max_attempts: 3
|
|
command: |
|
|
cd projects/rocprofiler-systems/docker
|
|
./build-docker-ci.sh \
|
|
--distro ${{ matrix.distro }} \
|
|
--versions ${{ matrix.version }} \
|
|
--user ${{ secrets.ROCPROF_SYS_DOCKER_LOGIN }} \
|
|
--jobs 2 \
|
|
--elfutils-version 0.188 \
|
|
--boost-version 1.79.0
|
|
|
|
- name: Build Base Container (Push)
|
|
if: github.event_name != 'pull_request'
|
|
timeout-minutes: 45
|
|
uses: nick-fields/retry@v3
|
|
with:
|
|
retry_wait_seconds: 60
|
|
timeout_minutes: 45
|
|
max_attempts: 3
|
|
command: |
|
|
cd projects/rocprofiler-systems/docker
|
|
./build-docker-ci.sh \
|
|
--distro ${{ matrix.distro }} \
|
|
--versions ${{ matrix.version }} \
|
|
--user ${{ secrets.ROCPROF_SYS_DOCKER_LOGIN }} \
|
|
--jobs 2 \
|
|
--elfutils-version 0.188 \
|
|
--boost-version 1.79.0 \
|
|
--push
|
|
|
|
prepare_matrix_release:
|
|
if: github.repository == 'ROCm/rocm-systems'
|
|
runs-on: ubuntu-latest
|
|
outputs:
|
|
matrix_data: ${{ steps.generate_matrix_release.outputs.matrix_data }}
|
|
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
with:
|
|
sparse-checkout: projects/rocprofiler-systems
|
|
|
|
- name: Output data for containers matrix
|
|
working-directory: projects/rocprofiler-systems/docker
|
|
id: generate_matrix_release
|
|
run: |
|
|
MATRIX_CONTENT=$(cat containers.yml | yq '.matrix' -I=0 -o=json)
|
|
echo "matrix_data=$MATRIX_CONTENT" >> $GITHUB_OUTPUT
|
|
|
|
rocprofiler-systems-release:
|
|
needs: prepare_matrix_release
|
|
runs-on: ubuntu-latest
|
|
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
include: ${{ fromJSON(needs.prepare_matrix_release.outputs.matrix_data) }}
|
|
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
with:
|
|
sparse-checkout: projects/rocprofiler-systems
|
|
|
|
- name: Set up QEMU
|
|
uses: docker/setup-qemu-action@v2
|
|
|
|
- name: Set up Docker Buildx
|
|
uses: docker/setup-buildx-action@v2
|
|
|
|
- name: Login to DockerHub
|
|
uses: docker/login-action@v2
|
|
with:
|
|
username: ${{ secrets.ROCPROF_SYS_DOCKER_LOGIN }}
|
|
password: ${{ secrets.ROCPROF_SYS_DOCKER_TOKEN }}
|
|
|
|
- name: Build Base Container (PR - No Push)
|
|
if: github.event_name == 'pull_request'
|
|
timeout-minutes: 45
|
|
uses: nick-fields/retry@v3
|
|
with:
|
|
retry_wait_seconds: 60
|
|
timeout_minutes: 45
|
|
max_attempts: 3
|
|
command: |
|
|
cd projects/rocprofiler-systems/docker
|
|
./build-docker.sh \
|
|
--distro ${{ matrix.os-distro }} \
|
|
--versions ${{ matrix.os-version }} \
|
|
--rocm-versions ${{ matrix.rocm-version }} \
|
|
--user ${{ secrets.ROCPROF_SYS_DOCKER_LOGIN }}
|
|
|
|
- name: Build Base Container (Push)
|
|
if: github.event_name != 'pull_request'
|
|
timeout-minutes: 45
|
|
uses: nick-fields/retry@v3
|
|
with:
|
|
retry_wait_seconds: 60
|
|
timeout_minutes: 45
|
|
max_attempts: 3
|
|
command: |
|
|
cd projects/rocprofiler-systems/docker
|
|
./build-docker.sh \
|
|
--distro ${{ matrix.os-distro }} \
|
|
--versions ${{ matrix.os-version }} \
|
|
--rocm-versions ${{ matrix.rocm-version }} \
|
|
--user ${{ secrets.ROCPROF_SYS_DOCKER_LOGIN }} \
|
|
--push
|