81d1407565
* Incremental Counter Profile Creation
Adds support for incremental counter creation. How this functions is the
behavior of rocprofiler_create_profile_config has been changed.
rocprofiler_create_profile_config(rocprofiler_agent_id_t agent_id,
rocprofiler_counter_id_t* counters_list,
size_t counters_count,
rocprofiler_profile_config_id_t* config_id)
The behavior of this function now allows an existing config_id to be
supplied via config_id. The counters contained in this config will be
copied over and used as a base for a new config along with any counters
supplied in counters_list. The new config id is returned via config_id
and can be used in future dispatch/agent counting sessions.
A new config is created over modifying an existing config since there
is no gaurentee that the existing config isn't already in use. While we
could add locks (or other mutual exclusion properties) to check if its
in use and reject an update, the benefit from doing so is minor in
comparison to just creating a new config. This also side steps a common
pattern a tool may use to add additional counters at some point later on
during execution. Now they can do that without destroying the existing
config.
---------
Co-authored-by: Benjamin Welton <ben@amd.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
115 строки
4.8 KiB
C++
115 строки
4.8 KiB
C++
|
|
// MIT License
|
|
//
|
|
// Copyright (c) 2023 Advanced Micro Devices, Inc. All rights reserved.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in all
|
|
// copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
// SOFTWARE.
|
|
|
|
#pragma once
|
|
|
|
#include "lib/common/synchronized.hpp"
|
|
#include "lib/rocprofiler-sdk/aql/packet_construct.hpp"
|
|
#include "lib/rocprofiler-sdk/counters/evaluate_ast.hpp"
|
|
#include "lib/rocprofiler-sdk/counters/metrics.hpp"
|
|
|
|
#include <rocprofiler-sdk/agent.h>
|
|
#include <rocprofiler-sdk/dispatch_profile.h>
|
|
#include <rocprofiler-sdk/fwd.h>
|
|
#include <rocprofiler-sdk/rocprofiler.h>
|
|
|
|
namespace rocprofiler
|
|
{
|
|
namespace counters
|
|
{
|
|
// Stores counter profiling information such as the agent
|
|
// to collect counters on, the metrics to collect, the hw
|
|
// counters needed to evaluate the metrics, and the ASTs.
|
|
// This profile can be shared among many rocprof contexts.
|
|
struct profile_config
|
|
{
|
|
const rocprofiler_agent_t* agent = nullptr;
|
|
std::vector<counters::Metric> metrics{};
|
|
// HW counters that must be collected to compute the above
|
|
// metrics (derived metrics are broken down into hw counters
|
|
// in this vector).
|
|
std::set<counters::Metric> reqired_hw_counters{};
|
|
// Counters that are not hardware based but based on either a
|
|
// static value (such as those in agent)
|
|
std::set<counters::Metric> required_special_counters{};
|
|
// ASTs to evaluate
|
|
std::vector<counters::EvaluateAST> asts{};
|
|
rocprofiler_profile_config_id_t id{.handle = 0};
|
|
// Packet generator to create AQL packets for insertion
|
|
std::unique_ptr<rocprofiler::aql::CounterPacketConstruct> pkt_generator{nullptr};
|
|
// A packet cache of AQL packets. This allows reuse of AQL packets (preventing costly
|
|
// allocation of new packets/destruction).
|
|
rocprofiler::common::Synchronized<std::vector<std::unique_ptr<rocprofiler::hsa::AQLPacket>>>
|
|
packets{};
|
|
};
|
|
|
|
class CounterController
|
|
{
|
|
public:
|
|
CounterController();
|
|
|
|
// Adds a counter collection profile to our global cache.
|
|
// Note: these profiles can be used across multiple contexts
|
|
// and are independent of the context.
|
|
uint64_t add_profile(std::shared_ptr<profile_config>&& config);
|
|
|
|
void destroy_profile(uint64_t id);
|
|
// Setup the counter collection service. counter_callback_info is created here
|
|
// to contain the counters that need to be collected (specified in profile_id) and
|
|
// the AQL packet generator for injecting packets. Note: the service is created
|
|
// in the stop state.
|
|
static rocprofiler_status_t configure_dispatch(
|
|
rocprofiler_context_id_t context_id,
|
|
rocprofiler_buffer_id_t buffer,
|
|
rocprofiler_profile_counting_dispatch_callback_t callback,
|
|
void* callback_args,
|
|
rocprofiler_profile_counting_record_callback_t record_callback,
|
|
void* record_callback_args);
|
|
std::shared_ptr<profile_config> get_profile_cfg(rocprofiler_profile_config_id_t id);
|
|
|
|
static rocprofiler_status_t configure_agent_collection(rocprofiler_context_id_t context_id,
|
|
rocprofiler_buffer_id_t buffer_id,
|
|
rocprofiler_agent_id_t agent_id,
|
|
rocprofiler_agent_profile_callback_t cb,
|
|
void* user_data);
|
|
|
|
private:
|
|
rocprofiler::common::Synchronized<std::unordered_map<uint64_t, std::shared_ptr<profile_config>>>
|
|
_configs;
|
|
};
|
|
|
|
CounterController&
|
|
get_controller();
|
|
|
|
rocprofiler_status_t
|
|
create_counter_profile(std::shared_ptr<profile_config> config);
|
|
|
|
void
|
|
destroy_counter_profile(uint64_t id);
|
|
|
|
std::shared_ptr<profile_config>
|
|
get_profile_config(rocprofiler_profile_config_id_t id);
|
|
|
|
} // namespace counters
|
|
} // namespace rocprofiler
|