272e5b6e32
* External CI: rename pipeline to rocprofiler-compute (#463) Signed-off-by: Daniel Su <danielsu@amd.com> * Update webui branding (#459) * Update name and icon for browser tab to rocprofiler-compute. Signed-off-by: xuchen-amd <xuchen@amd.com> * Update name and icon for browser tab to rocprofiler-compute. Signed-off-by: xuchen-amd <xuchen@amd.com> --------- Signed-off-by: xuchen-amd <xuchen@amd.com> * Update branding in documentation (#442) * find/replace Omniperf to ROCm Compute Profiler Signed-off-by: Peter Park <peter.park@amd.com> * update name in Sphinx conf Signed-off-by: Peter Park <peter.park@amd.com> * mv what-is-omniperf.rst -> what-is-rocprof-compute.rst Signed-off-by: Peter Park <peter.park@amd.com> * update Tutorials section Signed-off-by: Peter Park <peter.park@amd.com> * add Omniperf as keyword to Conceptual section for internal search Signed-off-by: Peter Park <peter.park@amd.com> * update Reference section Signed-off-by: Peter Park <peter.park@amd.com> * black fmt conf.py Signed-off-by: Peter Park <peter.park@amd.com> * update profile mode and basic usage subsections Signed-off-by: Peter Park <peter.park@amd.com> * update how to use analyze mode subsection Signed-off-by: Peter Park <peter.park@amd.com> * update install section Signed-off-by: Peter Park <peter.park@amd.com> * fix sphinx warnings Signed-off-by: Peter Park <peter.park@amd.com> * fix cmd line examples in profile/mode.rst Signed-off-by: Peter Park <peter.park@amd.com> * update install decision tree image Signed-off-by: Peter Park <peter.park@amd.com> * fix TOC and index Signed-off-by: Peter Park <peter.park@amd.com> fix weird wording * fix cli text: deriving rocprofiler-compute metrics... Signed-off-by: Peter Park <peter.park@amd.com> * update standalone-gui.rst Signed-off-by: Peter Park <peter.park@amd.com> * restore removed doc updates from #428 Signed-off-by: Peter Park <peter.park@amd.com> * update ref to Omniperf in index.rst Signed-off-by: Peter Park <peter.park@amd.com> * fix grafana connection name to match image Signed-off-by: Peter Park <peter.park@amd.com> * update cmds in tutorials Signed-off-by: Peter Park <peter.park@amd.com> --------- Signed-off-by: Peter Park <peter.park@amd.com> * MI300 roofline enablement in rocprofiler-compute (#470) * MI300 roofline enablement in rocprofiler-compute requirements.txt - running some modules complained about numpy version too new, adding extra requirement that numpy be 1.x pmc_roof_perf.txt - adding TCC_BUBBLE_sum counter to profile soc_gfx940.py soc_gfx941.py soc_gfx942.py - remove console logs reading that roofline is temporarily disabled, uncommenting blocks that check for roofline csv and run roofline post-processing roofline_calc.py - add mi300 to supported soc - add new calculation for hbm_data for MI300 using tcc_bubble_sum, checks if counter > 0 to use - add to a few comments roofline-ubuntu-20_04-mi300-rocm6 - binary for the ubuntu systems to enable mi300 roofline calculations from rocm-amdgpu-bench Note- other distros will get roofline bins to enable mi300, but need to be further tested before putting into branch. Signed-off-by: Carrie Fallows <carrie.fallows@amd.com> * Reformatting roofline_calc.py Signed-off-by: Carrie Fallows <carrie.fallows@amd.com> --------- Signed-off-by: Carrie Fallows <carrie.fallows@amd.com> * Update Python format checker (#471) * Add pre commit hook for Python formatting Signed-off-by: coleramos425 <colramos@amd.com> * Update formatting workflow to run on latest Python and add isort formatter Signed-off-by: coleramos425 <colramos@amd.com> * Fix caught yaml formatting issues * Update pyproject file * Add pre-commit hook instruction to CONTRIBUTING guide * Remove target-version from black pyproject.toml * Fixed formatting errors found with black and isort Signed-off-by: David Galiffi <David.Galiffi@amd.com> * Run hook: Whitespaces, fix end of file spaces --------- Signed-off-by: coleramos425 <colramos@amd.com> Signed-off-by: David Galiffi <David.Galiffi@amd.com> Co-authored-by: David Galiffi <David.Galiffi@amd.com> * Bump cryptography from 43.0.0 to 43.0.1 in /docs/sphinx (#473) Bumps [cryptography](https://github.com/pyca/cryptography) from 43.0.0 to 43.0.1. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/43.0.0...43.0.1) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix file permission on MI300 roofline binary (#477) Signed-off-by: David Galiffi <David.Galiffi@amd.com> * Removing numpy requirements of <2 (#478) Checks are failing if version too high and no need for lower version Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com> * Fix crash when loading web UI roofline for gfx942 (#479) * Fix crash when loading web UI roofline for gfx942 * Fix formatting Signed-off-by: benrichard-amd <ben.richard@amd.com> * Make same changs for gfx940, gfx942. Signed-off-by: benrichard-amd <ben.richard@amd.com> * Fix formatting in soc_gfx940 and soc_gfx941. Signed-off-by: benrichard-amd <ben.richard@amd.com> --------- Signed-off-by: benrichard-amd <ben.richard@amd.com> * Rebranding name change patch (#469) * Patch in missed name change for rebranding. Signed-off-by: xuchen-amd <xuchen@amd.com> * Patch in missed name change for rebranding. Signed-off-by: xuchen-amd <xuchen@amd.com> --------- Signed-off-by: xuchen-amd <xuchen@amd.com> * Move dependabot.yml to .github/ and bump rocm-docs-core (#481) * Move dependabot.yml to .github/ * Bump rocm-docs-core to 1.8.5 * Bump rocm-docs-core to 1.9.0 * Fix packaging for upgrading (#486) Specify that "rocprofiler-compute" replaces / obsoletes the "omniperf" package. * Renamed extension path from omniperf to rocprofiler_compute (#487) Signed-off-by: Tim Gu <Tim.Gu@amd.com> * MI300 rhel and sles roofline binaries (#480) * Roofline bins for MI300 on rhel and sles distributions Built from rocm-amdgpu-bench, tested on respective distro systems with MI300 hardware. Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com> * Minor modifications removing hardcoded variables in roofline files. Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com> --------- Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com> * Modify test_profile_general.py ctest to include MI300 enablement (#498) Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com> * part 1 to support rocprofv3 (#492) * rocprofv3 support initial commit -Can run rocprofv3 but ultimately fails. rocprofv3 says the counter capacity is exceeded and the output CSV file format is different from v1/v2. * Add rocprofv3 detection so v2 can still be used It's hacky but it'll do for now. * Add code path to convert rocprofv3 JSON output into CSV * Grab correct value for Queue ID * Use _sum suffix to sum TCC counters Previously we were specifying each channel for TCC counters. rocprofv3 does not support specifing each TCC channel, and instead will auto sum given the TCC counter name. The counter name with the _sum suffix is also supported and is also supported in v1 and v2. So we will use the TCC counter name with the _sum suffix. * Fix incorrect counter outputs when using rocprofv3 In the JSON output some counters appear multime times and must be summed to get the correct value. These summed values match the rocprofv3 output in CSV mode and also match the rocprofv2 output. * Remove duplicate Correlation_ID and Wave_Size in output * Handle json output that does not contain any dispatches Omniperf was assuming each JSON output from rocprofv3 would always contain dispatches. This is not the case. For example, in a multi-process workload where one of the processes does not dispatch any kernels. A JSON file will still be output for this process but it will not contain any dispatches. * Code cleanup * Update search path for rocprofv3 results Rocprofv3 was updated to include the hostname in the path where it outputs results. * Handle accumulate counters In v1/v2 rocprof uses the SQ_ACCUM_PREV_HIRES counter for the accumualte counters. v3 does not have this. So we need to define our own counters in counter_defs.yaml. For this we use the counter name + _ACCUM, for example SQ_INSTR_LEVEL_SMEM_ACCUM. To use rocprofv3 you will need to update counter_defs.yaml to include these new counter definitions. * Use correct GPU ID When converting JSON -> CSV we were assigning node_id to GPU_ID. Since the JSON contains non-GPU devices, the node_id for GPUs might not start at 0 as expected. This commit maps the agent ID to the appropriate GPU ID. * Parse scratch memory per work item from JSON * Support rocprofv3 CSV parsing JSON decoding is very slow for large files. Include support for parsing rocprofv3 CSV output and make that the default. CSV/JSON can be toggled via the ROCPROF_OUTPUT_FORMAT environment variable e.g. ROCPROF_OUTPUT_FORMAT=csv or ROCPROF_OUTPUT_FORMAT=json * black format after merge * format isort * change return of rocprof_cmd to try to resolve test's error * hack to pick last part of rocminfo's name * debug log of hacks * Modify test_profile_general.py ctest to include MI300 enablement. Currently failing because of explicitly excluded roofline files for the soc and autofailed asserts for roof-only tests- originally in place because roofline was not enabled on mi300 yet. Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com> * black and isort formated * corrected line of copyright --------- Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com> Co-authored-by: benrichard-amd <ben.richard@amd.com> Co-authored-by: YANG WANG <ywang@ywang-ubuntu.amd.com> Co-authored-by: Carrie Fallows <Carrie.Fallows@amd.com> * fix for crash of timestamp of part 1 for rocprofv3 (#499) * fix the error caused by ignoring the lack of counter csv file from rocprofv3 for timestamp * isort and black formated * quick fix for gfx906 roofline (#505) * Multi node support (#503) * [CTest] Pipeline failures for MI300 (#483) * Propagate new chip_id logic to testing workflow Signed-off-by: coleramos425 <colramos@amd.com> * Add a debug line to tests Signed-off-by: coleramos425 <colramos@amd.com> * Trying to set rocprofv2 generally in CTest module Signed-off-by: coleramos425 <colramos@amd.com> * Remove temp debugging lines from CI Signed-off-by: coleramos425 <colramos@amd.com> * Add roofline entry for MI300 expected files in CI tests Signed-off-by: coleramos425 <colramos@amd.com> * Make num_devices modifier global in scope Signed-off-by: coleramos425 <colramos@amd.com> * Change kernel name in PyTest to confirm rocprofv2 bug Related to https://ontrack-internal.amd.com/browse/SWDEV-503453 Signed-off-by: coleramos425 <colramos@amd.com> --------- Signed-off-by: coleramos425 <colramos@amd.com> * Spatial-multiplexing: part 1 profiling stage (#465) * rocprofv3 support initial commit -Can run rocprofv3 but ultimately fails. rocprofv3 says the counter capacity is exceeded and the output CSV file format is different from v1/v2. * Add rocprofv3 detection so v2 can still be used It's hacky but it'll do for now. * Add code path to convert rocprofv3 JSON output into CSV * Grab correct value for Queue ID * Use _sum suffix to sum TCC counters Previously we were specifying each channel for TCC counters. rocprofv3 does not support specifing each TCC channel, and instead will auto sum given the TCC counter name. The counter name with the _sum suffix is also supported and is also supported in v1 and v2. So we will use the TCC counter name with the _sum suffix. * Fix incorrect counter outputs when using rocprofv3 In the JSON output some counters appear multime times and must be summed to get the correct value. These summed values match the rocprofv3 output in CSV mode and also match the rocprofv2 output. * Remove duplicate Correlation_ID and Wave_Size in output * Handle json output that does not contain any dispatches Omniperf was assuming each JSON output from rocprofv3 would always contain dispatches. This is not the case. For example, in a multi-process workload where one of the processes does not dispatch any kernels. A JSON file will still be output for this process but it will not contain any dispatches. * Code cleanup * Update search path for rocprofv3 results Rocprofv3 was updated to include the hostname in the path where it outputs results. * Handle accumulate counters In v1/v2 rocprof uses the SQ_ACCUM_PREV_HIRES counter for the accumualte counters. v3 does not have this. So we need to define our own counters in counter_defs.yaml. For this we use the counter name + _ACCUM, for example SQ_INSTR_LEVEL_SMEM_ACCUM. To use rocprofv3 you will need to update counter_defs.yaml to include these new counter definitions. * debug code * add logic code for multiplexing * minor fix * more fixes * rocprofv3 support initial commit -Can run rocprofv3 but ultimately fails. rocprofv3 says the counter capacity is exceeded and the output CSV file format is different from v1/v2. * Add rocprofv3 detection so v2 can still be used It's hacky but it'll do for now. * Add code path to convert rocprofv3 JSON output into CSV * Grab correct value for Queue ID * Use _sum suffix to sum TCC counters Previously we were specifying each channel for TCC counters. rocprofv3 does not support specifing each TCC channel, and instead will auto sum given the TCC counter name. The counter name with the _sum suffix is also supported and is also supported in v1 and v2. So we will use the TCC counter name with the _sum suffix. * Fix incorrect counter outputs when using rocprofv3 In the JSON output some counters appear multime times and must be summed to get the correct value. These summed values match the rocprofv3 output in CSV mode and also match the rocprofv2 output. * Remove duplicate Correlation_ID and Wave_Size in output * Handle json output that does not contain any dispatches Omniperf was assuming each JSON output from rocprofv3 would always contain dispatches. This is not the case. For example, in a multi-process workload where one of the processes does not dispatch any kernels. A JSON file will still be output for this process but it will not contain any dispatches. * Code cleanup * Update search path for rocprofv3 results Rocprofv3 was updated to include the hostname in the path where it outputs results. * Handle accumulate counters In v1/v2 rocprof uses the SQ_ACCUM_PREV_HIRES counter for the accumualte counters. v3 does not have this. So we need to define our own counters in counter_defs.yaml. For this we use the counter name + _ACCUM, for example SQ_INSTR_LEVEL_SMEM_ACCUM. To use rocprofv3 you will need to update counter_defs.yaml to include these new counter definitions. * count accu files as well * Use correct GPU ID When converting JSON -> CSV we were assigning node_id to GPU_ID. Since the JSON contains non-GPU devices, the node_id for GPUs might not start at 0 as expected. This commit maps the agent ID to the appropriate GPU ID. * fix error with csv file parse from json and merge during post-processing * implemented parsing of csv files from v3 output for optimization * Parse scratch memory per work item from JSON * Support rocprofv3 CSV parsing JSON decoding is very slow for large files. Include support for parsing rocprofv3 CSV output and make that the default. CSV/JSON can be toggled via the ROCPROF_OUTPUT_FORMAT environment variable e.g. ROCPROF_OUTPUT_FORMAT=csv or ROCPROF_OUTPUT_FORMAT=json * black format after merge * format isort * change return of rocprof_cmd to try to resolve test's error * hack to pick last part of rocminfo's name * debug log of hacks * Modify test_profile_general.py ctest to include MI300 enablement. Currently failing because of explicitly excluded roofline files for the soc and autofailed asserts for roof-only tests- originally in place because roofline was not enabled on mi300 yet. Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com> * black and isort formated * formated by isort and black * change default rocprof's output to csv * repaired crash caused by missing csv counter file when running for timestamp * change name to spatial-multiplexing from multiplexing * make necessary modification for review * set the value of spatial_multiplexing in argument defautly to None * repair the part that blocks regular pmc files' generation --------- Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com> Co-authored-by: benrichard-amd <ben.richard@amd.com> Co-authored-by: fei.zheng <fei.zheng@amd.com> Co-authored-by: YANG WANG <ywang@ywang-ubuntu.amd.com> Co-authored-by: Carrie Fallows <Carrie.Fallows@amd.com> * Simple fix for gpu model value. (#508) Signed-off-by: xuchen-amd <xuchen@amd.com> * Add FP64 to plot adhering to pdf name (#507) * Replacing FP32-only plot with an FP32&FP64 combo plot. Results will likely be negligible but the plot name indicates both should be graphed. Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com> * Remove duplicate AI plot to clean up fp32 fp64 graph Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com> --------- Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com> * Add gpu series for roofline (#510) * Add gpu_series for roofline. * Use gpu_series in path names for roofline. * Fix TCC on MI200 when introduce rocprofv3 (#509) * quick fix for v2 * one more fix * revert a bit --------- Co-authored-by: ywang103-amd <ywang103@amd.com> * Bump rocm-docs-core from 1.9.0 to 1.12.0 in /docs/sphinx (#511) Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.9.0 to 1.12.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.9.0...v1.12.0) --- updated-dependencies: - dependency-name: rocm-docs-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update sample roofline plot img (#516) * Modify path to use gpu_model instead of gpu_series to match other workload directory path creation/search points. Affects manual testing, does not seem to affect ctests. (#513) Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com> * Improve formatting when displaying rocprof command. (#476) * Improve formatting when displaying rocprof command. Signed-off-by: xuchen-amd <xuchen@amd.com> * Fix python formatting. Signed-off-by: xuchen-amd <xuchen@amd.com> * Strip unwanted characters (rocprofv1 specific) from rocprof commands. Signed-off-by: xuchen-amd <xuchen@amd.com> * Strip unwanted characters (rocprofv1 specific) from rocprof commands. Signed-off-by: xuchen-amd <xuchen@amd.com> * Save the unmodified arguments for rocprof for debug message display. Signed-off-by: xuchen-amd <xuchen@amd.com> --------- Signed-off-by: xuchen-amd <xuchen@amd.com> * quick fix for mpi_support (#518) * Pass accumulate counters to rocprofv3 using -E option (#522) rocprofv3 has a new -E option where extra counters can be passed (see accum_counters.yaml) instead of defining them in counter_defs.yaml. * Unify all file handling with pathlib (#512) * Replace occurences of os.path functions with equivalent functions from pathlib library * Remove unwanted imports of os.path and os * Add coding guidelines for using pathlib instead of os.path * Auto sync staging and mainline on a weekly cadence (#517) Signed-off-by: coleramos425 <colramos@amd.com> --------- Signed-off-by: Daniel Su <danielsu@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com> Signed-off-by: Peter Park <peter.park@amd.com> Signed-off-by: Carrie Fallows <carrie.fallows@amd.com> Signed-off-by: coleramos425 <colramos@amd.com> Signed-off-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com> Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: Tim Gu <Tim.Gu@amd.com> Co-authored-by: Daniel Su <danielsu@amd.com> Co-authored-by: xuchen-amd <xuchen@amd.com> Co-authored-by: Peter Park <peter.park@amd.com> Co-authored-by: cfallows-amd <Carrie.Fallows@amd.com> Co-authored-by: David Galiffi <David.Galiffi@amd.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ben Richard <143630488+benrichard-amd@users.noreply.github.com> Co-authored-by: Tim Gu <Tim.Gu@amd.com> Co-authored-by: ywang103-amd <ywang103@amd.com> Co-authored-by: benrichard-amd <ben.richard@amd.com> Co-authored-by: YANG WANG <ywang@ywang-ubuntu.amd.com> Co-authored-by: Fei Zheng <44449748+feizheng10@users.noreply.github.com> Co-authored-by: fei.zheng <fei.zheng@amd.com> Co-authored-by: vedithal-amd <Vignesh.Edithal@amd.com>
273 行
11 KiB
ReStructuredText
273 行
11 KiB
ReStructuredText
.. _lds-examples:
|
|
|
|
LDS examples
|
|
============
|
|
|
|
For this example, consider the
|
|
:dev-sample:`LDS sample <lds.hip>` distributed as a part of ROCm Compute Profiler. This
|
|
code contains two kernels to explore how both :doc:`LDS </conceptual/local-data-share>` bandwidth and
|
|
bank conflicts are calculated in ROCm Compute Profiler.
|
|
|
|
This example was compiled and run on an MI250 accelerator using ROCm
|
|
v5.6.0, and ROCm Compute Profiler v2.0.0.
|
|
|
|
.. code-block:: shell-session
|
|
|
|
$ hipcc -O3 lds.hip -o lds
|
|
|
|
Finally, we generate our ``rocprof-compute profile`` as:
|
|
|
|
.. code-block:: shell-session
|
|
|
|
$ rocprof-compute profile -n lds --no-roof -- ./lds
|
|
|
|
.. _lds-bandwidth:
|
|
|
|
LDS bandwidth
|
|
-------------
|
|
|
|
To explore our *theoretical LDS bandwidth* metric, we use a simple
|
|
kernel:
|
|
|
|
.. code-block:: cpp
|
|
|
|
constexpr unsigned max_threads = 256;
|
|
__global__ void load(int* out, int flag) {
|
|
__shared__ int array[max_threads];
|
|
int index = threadIdx.x;
|
|
// fake a store to the LDS array to avoid unwanted behavior
|
|
if (flag)
|
|
array[max_threads - index] = index;
|
|
__syncthreads();
|
|
int x = array[index];
|
|
if (x == int(-1234567))
|
|
out[threadIdx.x] = x;
|
|
}
|
|
|
|
Here we:
|
|
|
|
* Create an array of 256 integers in :doc:`LDS </conceptual/local-data-share>`
|
|
|
|
* Fake a write to the LDS using the ``flag`` variable (always set to zero on the
|
|
host) to avoid dead-code elimination
|
|
|
|
* Read a single integer per work-item from ``threadIdx.x`` of the LDS array
|
|
|
|
* If the integer is equal to a magic number (always false), write the value out
|
|
to global memory to again, avoid dead-code elimination
|
|
|
|
Finally, we launch this kernel repeatedly, varying the number of threads
|
|
in our workgroup:
|
|
|
|
.. code-block:: cpp
|
|
|
|
void bandwidth_demo(int N) {
|
|
for (int i = 1; i <= N; ++i)
|
|
load<<<1,i>>>(nullptr, 0);
|
|
hipDeviceSynchronize();
|
|
}
|
|
|
|
Next, let’s analyze the first of our bandwidth kernel dispatches:
|
|
|
|
.. code-block:: shell
|
|
|
|
$ rocprof-compute analyze -p workloads/lds/mi200/ -b 12.2.1 --dispatch 0 -n per_kernel
|
|
<...>
|
|
12. Local Data Share (LDS)
|
|
12.2 LDS Stats
|
|
╒═════════╤═══════════════════════╤════════╤════════╤════════╤══════════════════╕
|
|
│ Index │ Metric │ Avg │ Min │ Max │ Unit │
|
|
╞═════════╪═══════════════════════╪════════╪════════╪════════╪══════════════════╡
|
|
│ 12.2.1 │ Theoretical Bandwidth │ 256.00 │ 256.00 │ 256.00 │ Bytes per kernel │
|
|
╘═════════╧═══════════════════════╧════════╧════════╧════════╧══════════════════╛
|
|
|
|
Here we see that our Theoretical Bandwidth metric (**12.2.1**) is reporting
|
|
256 Bytes were loaded even though we launched a single work-item
|
|
workgroup, and thus only loaded a single integer from LDS. Why is this?
|
|
|
|
Recall our definition of this metric:
|
|
|
|
Indicates the maximum amount of bytes that could have been loaded
|
|
from/stored to/atomically updated in the LDS per
|
|
:ref:`normalization unit <normalization-units>`.
|
|
|
|
Here we see that this instruction *could* have loaded up to 256 bytes of
|
|
data (4 bytes for each work-item in the wavefront), and therefore this
|
|
is the expected value for this metric in ROCm Compute Profiler, hence why this metric
|
|
is named the “theoretical” bandwidth.
|
|
|
|
To further illustrate this point we plot the relationship of the
|
|
theoretical bandwidth metric (**12.2.1**) as compared to the effective (or
|
|
achieved) bandwidth of this kernel, varying the number of work-items
|
|
launched from 1 to 256:
|
|
|
|
.. figure:: ../data/profiling-by-example/ldsbandwidth.png
|
|
:align: center
|
|
:alt: Comparison of effective bandwidth versus the theoretical bandwidth
|
|
metric in ROCm Compute Profiler for our simple example.
|
|
:width: 800
|
|
|
|
Comparison of effective bandwidth versus the theoretical bandwidth
|
|
metric in ROCm Compute Profiler for our simple example.
|
|
|
|
Here we see that the theoretical bandwidth metric follows a step-function. It
|
|
increases only when another wavefront issues an LDS instruction for up to 256
|
|
bytes of data. Such increases are marked in the plot using dashed lines. In
|
|
contrast, the effective bandwidth increases linearly, by 4 bytes, with the
|
|
number of work-items in the kernel, N.
|
|
|
|
.. _lds-bank-conflicts:
|
|
|
|
Bank conflicts
|
|
--------------
|
|
|
|
Next we explore bank conflicts using a slight modification of our bandwidth
|
|
kernel:
|
|
|
|
.. code-block:: cpp
|
|
|
|
constexpr unsigned nbanks = 32;
|
|
__global__ void conflicts(int* out, int flag) {
|
|
constexpr unsigned nelements = nbanks * max_threads;
|
|
__shared__ int array[nelements];
|
|
// each thread reads from the same bank
|
|
int index = threadIdx.x * nbanks;
|
|
// fake a store to the LDS array to avoid unwanted behavior
|
|
if (flag)
|
|
array[max_threads - index] = index;
|
|
__syncthreads();
|
|
int x = array[index];
|
|
if (x == int(-1234567))
|
|
out[threadIdx.x] = x;
|
|
}
|
|
|
|
Here we:
|
|
|
|
* Allocate an :doc:`LDS </conceptual/local-data-share>` array of size
|
|
:math:`32*256*4{B}=32{KiB}`
|
|
|
|
* Fake a write to the LDS using the ``flag``
|
|
variable (always set to zero on the host) to avoid dead-code elimination
|
|
|
|
* Read a single integer per work-item from index
|
|
``threadIdx.x * nbanks`` of the LDS array
|
|
|
|
* If the integer is equal to a
|
|
magic number (always false), write the value out to global memory to,
|
|
again, avoid dead-code elimination.
|
|
|
|
On the host, we again repeatedly launch this kernel, varying the number
|
|
of work-items:
|
|
|
|
.. code-block:: cpp
|
|
|
|
void conflicts_demo(int N) {
|
|
for (int i = 1; i <= N; ++i)
|
|
conflicts<<<1,i>>>(nullptr, 0);
|
|
hipDeviceSynchronize();
|
|
}
|
|
|
|
Analyzing our first ``conflicts`` kernel (i.e., a single work-item), we
|
|
see:
|
|
|
|
.. code-block:: shell
|
|
|
|
$ rocprof-compute analyze -p workloads/lds/mi200/ -b 12.2.4 12.2.6 --dispatch 256 -n per_kernel
|
|
<...>
|
|
--------------------------------------------------------------------------------
|
|
12. Local Data Share (LDS)
|
|
12.2 LDS Stats
|
|
╒═════════╤════════════════╤═══════╤═══════╤═══════╤═══════════════════╕
|
|
│ Index │ Metric │ Avg │ Min │ Max │ Unit │
|
|
╞═════════╪════════════════╪═══════╪═══════╪═══════╪═══════════════════╡
|
|
│ 12.2.4 │ Index Accesses │ 2.00 │ 2.00 │ 2.00 │ Cycles per kernel │
|
|
├─────────┼────────────────┼───────┼───────┼───────┼───────────────────┤
|
|
│ 12.2.6 │ Bank Conflict │ 0.00 │ 0.00 │ 0.00 │ Cycles per kernel │
|
|
╘═════════╧════════════════╧═══════╧═══════╧═══════╧═══════════════════╛
|
|
|
|
In our :ref:`previous example <lds-bank-conflicts>`, we showed how a load
|
|
from a single work-item is considered to have a theoretical bandwidth of
|
|
256B. Recall, the :doc:`LDS </conceptual/local-data-share>` can load up to :math:`128B` per
|
|
cycle (i.e, 32 banks x 4B / bank / cycle). Hence, we see that loading an 4B
|
|
integer spends two cycles accessing the LDS
|
|
(:math:`2\ {cycle} = (256B) / (128\ B/{cycle})`).
|
|
|
|
Looking at the next ``conflicts`` dispatch (i.e., two work-items) yields:
|
|
|
|
.. code-block:: shell
|
|
|
|
$ rocprof-compute analyze -p workloads/lds/mi200/ -b 12.2.4 12.2.6 --dispatch 257 -n per_kernel
|
|
<...>
|
|
--------------------------------------------------------------------------------
|
|
12. Local Data Share (LDS)
|
|
12.2 LDS Stats
|
|
╒═════════╤════════════════╤═══════╤═══════╤═══════╤═══════════════════╕
|
|
│ Index │ Metric │ Avg │ Min │ Max │ Unit │
|
|
╞═════════╪════════════════╪═══════╪═══════╪═══════╪═══════════════════╡
|
|
│ 12.2.4 │ Index Accesses │ 3.00 │ 3.00 │ 3.00 │ Cycles per kernel │
|
|
├─────────┼────────────────┼───────┼───────┼───────┼───────────────────┤
|
|
│ 12.2.6 │ Bank Conflict │ 1.00 │ 1.00 │ 1.00 │ Cycles per kernel │
|
|
╘═════════╧════════════════╧═══════╧═══════╧═══════╧═══════════════════╛
|
|
|
|
Here we see a bank conflict! What happened?
|
|
|
|
Recall that the index for each thread was calculated as:
|
|
|
|
.. code-block:: cpp
|
|
|
|
int index = threadIdx.x * nbanks;
|
|
|
|
Or, precisely 32 elements, and each element is 4B wide (for a standard
|
|
integer). That is, each thread strides back to the same bank in the LDS,
|
|
such that each work-item we add to the dispatch results in another bank
|
|
conflict!
|
|
|
|
Recalling our discussion of bank conflicts in our
|
|
:doc:`LDS </conceptual/local-data-share>` description:
|
|
|
|
A bank conflict occurs when two (or more) work-items in a wavefront
|
|
want to read, write, or atomically update different addresses that
|
|
map to the same bank in the same cycle. In this case, the conflict
|
|
detection hardware will determined a new schedule such that the
|
|
access is split into multiple cycles with no conflicts in any
|
|
single cycle.
|
|
|
|
Here we see the conflict resolution hardware in action! Because we have
|
|
engineered our kernel to generate conflicts, we expect our bank conflict
|
|
metric to scale linearly with the number of work-items:
|
|
|
|
.. figure:: ../data/profiling-by-example/ldsconflicts.png
|
|
:align: center
|
|
:alt: Comparison of LDS conflict cycles versus access cycles for our simple
|
|
example.
|
|
:width: 800
|
|
|
|
Comparison of LDS conflict cycles versus access cycles for our simple
|
|
example.
|
|
|
|
Here we show the comparison of the Index Accesses (**12.2.4**), to the Bank
|
|
Conflicts (**12.2.6**) for the first 20 kernel invocations. We see that each grows
|
|
linearly, and there is a constant gap of 2 cycles between them (i.e., the first
|
|
access is never considered a conflict).
|
|
|
|
Finally, we can use these two metrics to derive the Bank Conflict Rate (**12.1.4**).
|
|
Since within an Index Access we have 32 banks that may need to be updated, we
|
|
use:
|
|
|
|
$$
|
|
Bank\ Conflict\ Rate = 100 * ((Bank\ Conflicts / 32) / (Index\ Accesses - Bank\ Conflicts))
|
|
$$
|
|
|
|
Plotting this, we see:
|
|
|
|
.. figure:: ../data/profiling-by-example/ldsconflictrate.png
|
|
:align: center
|
|
:alt: LDS bank conflict rate example
|
|
:width: 800
|
|
|
|
LDS Bank Conflict rate for our simple example.
|
|
|
|
The bank conflict rate linearly increases with the number of work-items
|
|
within a wavefront that are active, *approaching* 100%, but never quite
|
|
reaching it.
|