Jonathan R. Madsen
4ed8f8f762
- instead of args="<list-of-string>" in perfetto, each argument is added individually, enabling matching pointer values, etc. ## Previous behavior Previously, all function arguments were wrapped into a single string, e.g.:  ## New Behavior With the exception of the HIP API (whose args are provided as a single string via `hipApiString`), all functions from MPI, RCCL, pthreads, etc. have individual arguments in perfetto, e.g.:  In the above, previously, this would have been: | | | | - | - | | args | `pthread_rwlock_t*=0x1c1cc50` | The key benefit enabled is the ability to find slices with same arg values: <img width="753" alt="Screen Shot 2022-09-12 at 11 59 18 PM" src="https://user-images.githubusercontent.com/6001865/189812915-0342f841-e5ce-4f8e-8169-0cb52f3425b5.png"> Previously, the entire "args" field would have had to match, which essentially never happened if the pointer was used in two different functions with different function signatures ## Example  
86 satır
2.4 KiB
C++
86 satır
2.4 KiB
C++
// MIT License
|
|
//
|
|
// Copyright (c) 2022 Advanced Micro Devices, Inc. All Rights Reserved.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in all
|
|
// copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
// SOFTWARE.
|
|
|
|
#pragma once
|
|
|
|
#include "library/defines.hpp"
|
|
|
|
#include <timemory/mpl/concepts.hpp>
|
|
|
|
#include <memory>
|
|
#include <optional>
|
|
|
|
namespace omnitrace
|
|
{
|
|
namespace concepts = ::tim::concepts; // NOLINT
|
|
|
|
template <typename Tp>
|
|
struct thread_deleter;
|
|
|
|
// unique ptr type for omnitrace
|
|
template <typename Tp>
|
|
using unique_ptr_t = std::unique_ptr<Tp, thread_deleter<Tp>>;
|
|
} // namespace omnitrace
|
|
|
|
namespace tim
|
|
{
|
|
namespace concepts
|
|
{
|
|
template <typename Tp>
|
|
struct is_unique_pointer : std::false_type
|
|
{};
|
|
|
|
template <typename Tp>
|
|
struct is_unique_pointer<::omnitrace::unique_ptr_t<Tp>> : std::true_type
|
|
{};
|
|
|
|
template <typename Tp>
|
|
struct is_unique_pointer<std::unique_ptr<Tp>> : std::true_type
|
|
{};
|
|
|
|
template <typename Tp>
|
|
struct is_optional : std::false_type
|
|
{};
|
|
|
|
template <typename Tp>
|
|
struct is_optional<std::optional<Tp>> : std::true_type
|
|
{};
|
|
|
|
template <typename Tp>
|
|
struct can_stringify
|
|
{
|
|
private:
|
|
static constexpr auto sfinae(int)
|
|
-> decltype(std::declval<std::ostream&>() << std::declval<Tp>(), bool())
|
|
{
|
|
return true;
|
|
}
|
|
|
|
static constexpr auto sfinae(long) { return false; }
|
|
|
|
public:
|
|
static constexpr bool value = sfinae(0);
|
|
constexpr auto operator()() const { return sfinae(0); }
|
|
};
|
|
} // namespace concepts
|
|
} // namespace tim
|