Jaydeep Patel
be88e1dffc
https://gerrit-git.amd.com/c/compute/ec/clr/+/849086 changed stream sync behaviour and accordingly updated Unit_hipStreamCreateWithFlags_DefaultStreamInteraction. Update error code to match for hipStreamWaitEvent. Thread detach makes executions all async and while that is happening, It is unexpected effect for device reset so join thread is better. Change-Id: I1affa84089626dee478d8bcc5aaa318e320fd6b0
87 lignes
3.4 KiB
C++
87 lignes
3.4 KiB
C++
/*
|
|
Copyright (c) 2022 Advanced Micro Devices, Inc. All rights reserved.
|
|
Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
of this software and associated documentation files (the "Software"), to deal
|
|
in the Software without restriction, including without limitation the rights
|
|
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
copies of the Software, and to permit persons to whom the Software is
|
|
furnished to do so, subject to the following conditions:
|
|
The above copyright notice and this permission notice shall be included in
|
|
all copies or substantial portions of the Software.
|
|
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANNTY OF ANY KIND, EXPRESS OR
|
|
IMPLIED, INNCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
FITNNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANNY CLAIM, DAMAGES OR OTHER
|
|
LIABILITY, WHETHER INN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
OUT OF OR INN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
THE SOFTWARE.
|
|
*/
|
|
|
|
#include <chrono>
|
|
#include <hip_test_common.hh>
|
|
#include <utils.hh>
|
|
|
|
namespace hipStreamCreateWithFlagsTests {
|
|
|
|
TEST_CASE("Unit_hipStreamCreateWithFlags_Negative_NullStream") {
|
|
HIP_CHECK_ERROR(hipStreamCreateWithFlags(nullptr, hipStreamDefault), hipErrorInvalidValue);
|
|
}
|
|
|
|
TEST_CASE("Unit_hipStreamCreateWithFlags_Negative_InvalidFlag") {
|
|
hipStream_t stream{};
|
|
unsigned int flag = 0xFF;
|
|
REQUIRE(flag != hipStreamDefault);
|
|
REQUIRE(flag != hipStreamNonBlocking);
|
|
HIP_CHECK_ERROR(hipStreamCreateWithFlags(&stream, flag), hipErrorInvalidValue);
|
|
}
|
|
|
|
// create a stream and check the properties are correctly set
|
|
TEST_CASE("Unit_hipStreamCreateWithFlags_Default") {
|
|
const unsigned int flagUnderTest = GENERATE(hipStreamDefault, hipStreamNonBlocking);
|
|
hipStream_t stream{};
|
|
HIP_CHECK(hipStreamCreateWithFlags(&stream, flagUnderTest));
|
|
|
|
unsigned int flag{};
|
|
HIP_CHECK(hipStreamGetFlags(stream, &flag));
|
|
REQUIRE(flag == flagUnderTest);
|
|
|
|
int priority{};
|
|
HIP_CHECK(hipStreamGetPriority(stream, &priority));
|
|
// zero is considered default priority
|
|
REQUIRE(priority == 0);
|
|
|
|
HIP_CHECK(hipStreamDestroy(stream));
|
|
}
|
|
|
|
// a stream will default to blocking the null stream, but will not block the null stream when
|
|
// created with hipStreamNonBlocking
|
|
#if HT_AMD /* Disabled because frequency based wait is timing out on nvidia platforms */
|
|
TEST_CASE("Unit_hipStreamCreateWithFlags_DefaultStreamInteraction") {
|
|
const hipStream_t defaultStream = GENERATE(static_cast<hipStream_t>(nullptr), hipStreamPerThread);
|
|
const unsigned int flagUnderTest = GENERATE(hipStreamDefault, hipStreamNonBlocking);
|
|
CAPTURE(defaultStream, flagUnderTest);
|
|
|
|
hipStream_t stream{};
|
|
HIP_CHECK(hipStreamCreateWithFlags(&stream, flagUnderTest));
|
|
|
|
constexpr auto delay = std::chrono::milliseconds(500);
|
|
|
|
SECTION("default stream waiting for created stream") {
|
|
const hipError_t expectedError = (flagUnderTest == hipStreamDefault) && (defaultStream == nullptr)
|
|
? hipErrorNotReady
|
|
: hipSuccess;
|
|
LaunchDelayKernel(delay, stream);
|
|
REQUIRE(hipStreamQuery(defaultStream) == expectedError);
|
|
}
|
|
SECTION("created stream waiting for default stream") {
|
|
LaunchDelayKernel(delay, defaultStream);
|
|
REQUIRE(hipStreamQuery(stream) == hipSuccess);
|
|
}
|
|
|
|
HIP_CHECK(hipDeviceSynchronize());
|
|
HIP_CHECK(hipStreamDestroy(stream));
|
|
}
|
|
#endif
|
|
|
|
} // namespace hipStreamCreateWithFlagsTests
|