Jason Bonnell
463126770a
## Motivation <!-- Explain the purpose of this PR and the goals it aims to achieve. --> - __Reduced Code Duplication__: Version parsing logic moved from individual Dockerfiles to the central build script - __Improved Edge Case Handling__: Better handling of ROCm versions with and without patch numbers (e.g., `6.2` vs `6.2.0`) - __Easier Maintenance__: Future version-related changes only need to be made in one place - __Cleaner Dockerfiles__: Simplified Dockerfiles focus on package installation rather than complex shell logic - __Updated Platform Support__: Refreshed container matrix to reflect current platform/ROCm version combinations - __Fix OpenSUSE Docker Generation__: OpenSUSE container generation fails due to a change to the `binutils-gold` package - __Error Handling__: Fix bug where errors in docker image build were being masked, allowing workflow to pass anyway. ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> - Updated `Dockerfile.opensuse` and `Dockerfile.opensuse.ci` docker files to remove `binutils-gold` - Not needed since we build `binutils` with systems anyways - Updated `rocprofiler-systems-containers.yml` to remove `pushd/popd` commands and just run the shell scripts - There was a silent failure observed here, which I verified in this PR before adding the fix for openSUSE - Refactor ROCm version parsing. Move this logic to the `build-docker.sh` script to reduce duplication. - Fix bug that caused ROCm 7.0 to fail installation. The trailing `.0` was being trimmed. - Fixed inconsistencies in `containers.yml` that lead to invalid ROCm-OS_VERSION combinations. - Formatting fixes - Removed trailing whitespace - Fix docker build warnings. Use an `=` rather than ` ` when assigning an environment variable.
67 lines
2.5 KiB
Docker
67 lines
2.5 KiB
Docker
ARG DISTRO=opensuse/leap
|
|
ARG VERSION=15.5
|
|
FROM ${DISTRO}:${VERSION}
|
|
|
|
ENV HOME=/root
|
|
ENV SHELL=/bin/bash
|
|
ENV BASH_ENV=/etc/bash.bashrc
|
|
ENV DEBIAN_FRONTEND=noninteractive
|
|
|
|
WORKDIR /tmp
|
|
SHELL [ "/bin/bash", "-c" ]
|
|
|
|
ENV PATH=/usr/local/bin:${PATH}
|
|
|
|
ARG EXTRA_PACKAGES=""
|
|
ARG ELFUTILS_DOWNLOAD_VERSION="0.188"
|
|
ARG BOOST_DOWNLOAD_VERSION="1.79.0"
|
|
ARG NJOBS="8"
|
|
|
|
RUN set +e; \
|
|
zypper --non-interactive -i --gpg-auto-import-keys refresh; \
|
|
zypper --non-interactive -i patch; \
|
|
zypper --non-interactive -i patch; \
|
|
zypper --non-interactive -i --gpg-auto-import-keys refresh; \
|
|
exit 0
|
|
|
|
RUN zypper --non-interactive update -y && \
|
|
zypper --non-interactive dist-upgrade -y && \
|
|
zypper --non-interactive install -y -t pattern devel_basis && \
|
|
zypper --non-interactive install -y chrpath cmake curl dpkg-devel \
|
|
gcc-c++ gcc-fortran git gmock gtest iproute2 ninja nlohmann_json-devel \
|
|
openmpi3-devel papi-devel python3-devel python3-pip rpm-build \
|
|
sqlite3-devel vim wget && \
|
|
zypper --non-interactive clean --all && \
|
|
python3 -m pip install 'cmake==3.21' perfetto
|
|
|
|
ARG PYTHON_VERSIONS="6 7 8 9 10 11 12 13"
|
|
|
|
RUN wget https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-Linux-x86_64.sh -O miniforge.sh && \
|
|
bash miniforge.sh -b -p /opt/conda && \
|
|
export PATH="/opt/conda/bin:${PATH}" && \
|
|
conda config --set always_yes yes --set changeps1 no --set solver classic && \
|
|
conda update -c conda-forge -n base conda && \
|
|
for i in ${PYTHON_VERSIONS}; do conda create -n py3.${i} -c conda-forge python=3.${i} pip numpy; done && \
|
|
for i in ${PYTHON_VERSIONS}; do /opt/conda/envs/py3.${i}/bin/python -m pip install numpy perfetto dataclasses; done && \
|
|
conda clean -a -y && \
|
|
cd /tmp && \
|
|
shopt -s dotglob extglob && \
|
|
rm -rf *
|
|
|
|
# The Rock Tarball
|
|
ARG GPU_TYPE=""
|
|
ARG GPU_TARBALL=""
|
|
RUN if [ -n "$GPU_TYPE" ] && [ -n "$GPU_TARBALL" ]; then \
|
|
VERSION=$(echo "$GPU_TARBALL" | sed -nE 's/.*([0-9]+\.[0-9]+\.[0-9]+).*/\1/p'); \
|
|
if [ -z "$VERSION" ]; then \
|
|
echo "Error: Could not extract version from GPU_TARBALL ('$GPU_TARBALL')." >&2; \
|
|
exit 1; \
|
|
fi; \
|
|
python3 -m pip install -U awscli; \
|
|
aws s3 cp "s3://therock-nightly-tarball/${GPU_TARBALL}" rocm-${VERSION}-${GPU_TYPE}.tar.gz --no-sign-request; \
|
|
mv rocm-${VERSION}-${GPU_TYPE}.tar.gz /opt/rocm-${VERSION}-${GPU_TYPE}.tar.gz; \
|
|
fi
|
|
|
|
WORKDIR /home
|
|
SHELL [ "/bin/bash", "--login", "-c" ]
|