808ea7dfa7
## Overview
This is a significant PR which has 3 very notable characteristics:
1. Omnitrace colorizes most of it's logging
2. Completely reworked the sampling
- Samples now record the current instruction pointers instead of strings
- This _dramatically_ decreases the overhead of taking a sample
- The collection of metrics during a sample are split out into another component, enabling that data collection to be disabled -- which decreases the sampling overhead even further
- When both `OMNITRACE_SAMPLING_CPUTIME` and `OMNITRACE_SAMPLING_REALTIME` are ON:
- `OMNITRACE_SAMPLING_CPUTIME_FREQ` and `OMNITRACE_SAMPLING_REALTIME_FREQ` can be used to individually control the sampling frequency
- `OMNITRACE_SAMPLING_CPUTIME_DELAY` and `OMNITRACE_SAMPLING_REALTIME_DELAY` can be used to individually control the delay time before starting
- Now, omnitrace does not start a real-time sampler on the main thread unless `OMNITRACE_SAMPLING_REALTIME` is ON
- In the future, an `OMNITRACE_SAMPLING_TIDS` (and real-time, cpu-time variants) configuration variable(s) will allow you to select which threads will be sampled
3. Files produced by `omnitrace` exe -- `available-instr.txt`, `instrumented-instr.txt`, etc. -- now no longer has `-instr` suffix and are placed in `instrumentation/` subfolder, i.e. `available-instr.txt` -> instrumentation/available.txt`
- This helped de-clutter the output folder
Most of the other edits were reorganization (e.g. internal namespace changes), cleanup, and splitting up functionality.
## Bug Fixes
There is a bug fix with respect to the HSA callbacks which disabled sampling on child threads when an HSA API call was made
## Details
- created thread_info struct for mapping different thread IDs
- reorganized file structure significantly
- added categories.hpp, concepts.hpp
- moved around name trait definitions
- moved all omnitrace components into `omnitrace::component` namespace
- there was a lot of inconsistency b/t using `tim::component` in some places and `omnitrace::component`
- added macros like OMNITRACE_DECLARE_COMPONENT in lieu of TIMEMORY_DECLARE_COMPONENT
- OMNITRACE_CRITICAL_TRACE_NUM_THREADS -> OMNITRACE_THREAD_POOL_SIZE
- roctracer and critical_trace use same thread pool
- critical_trace functions do not lock anymore bc of thread-local TaskGroup
- added `component::local_category_region` to support using `component::category_region` without explicitly passing in name
- removed `component::omnitrace` (unused)
- migrated KokkosP and OMPT to use `component::local_category_region`
- removed `component::user_region` as a result
- migrated omnitrace_{push,pop}_{trace,region}_hidden to use component::category_region
- removed `component::functors` as a result
- migrated some ppdefs
- `api::omnitrace` -> `project::omnitrace`
- `api::(...)` -> `category::(...)`
- improved recording the execution time of threads
- migrated this functionality out of pthread_create_gotcha and into thread_info
- moved mpi_gotcha, fork_gotcha, exit_gotcha, rcclp into omnitrace::component namespace
- split backtrace up into backtrace, backtrace_metrics, backtrace_timestamp components
- sampling.cpp handles setup and post-processing that was formerly in backtrace
- updated logging to use colors
- `OMNITRACE_COLORIZED_LOG` config variable
- updated docs on JSON output from timemory
- instrumentation info in instrumentation subfolder
- added testing for KokkosP entries
- added testing for ompt entries
- add_critical_trace function defined in critical_trace.hpp
- disable push_thread_state and pop_thread_state when thread state is Disabled or Completed
- add comp::page_rss to main bundle
- thread_data supports std::optional instead of std::unique_ptr
- thread_data supports tim::identity<T> to avoid unique_ptr or optional
- tracing::record_thread_start_time()
- tracing::push_timemory and tracing::pop_timemory are templated on CategoryT
- removed anonymous namespace from omnitrace::utility
- sampling backtrace stores instruction pointers instead of strings
- component::category_region updates
- handle disabled thread state
- handle finalized state
- fewer debug messages
- invoke thread_init()
- invoke thread_init_sampling()
- handle push/pop count based on category
- push/pop count only modified when used
- component::cpu_freq
- components/ensure_storage.hpp
- reworked the pthread_create replacement function
- updated parallel-overhead example to report # of times locked
- OMNITRACE_MAX_UNWIND_DEPTH build option
- update timemory submodule
249 lines
8.1 KiB
C++
249 lines
8.1 KiB
C++
// MIT License
|
|
//
|
|
// Copyright (c) 2022 Advanced Micro Devices, Inc. All Rights Reserved.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in all
|
|
// copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
// SOFTWARE.
|
|
|
|
#include "library/components/roctracer.hpp"
|
|
#include "library/common.hpp"
|
|
#include "library/components/pthread_gotcha.hpp"
|
|
#include "library/config.hpp"
|
|
#include "library/debug.hpp"
|
|
#include "library/defines.hpp"
|
|
#include "library/dynamic_library.hpp"
|
|
#include "library/redirect.hpp"
|
|
#include "library/roctracer.hpp"
|
|
#include "library/sampling.hpp"
|
|
#include "library/thread_data.hpp"
|
|
|
|
namespace omnitrace
|
|
{
|
|
namespace component
|
|
{
|
|
namespace
|
|
{
|
|
auto&
|
|
roctracer_activity_count()
|
|
{
|
|
static std::atomic<int64_t> _v{ 0 };
|
|
return _v;
|
|
}
|
|
} // namespace
|
|
|
|
void
|
|
roctracer::preinit()
|
|
{
|
|
roctracer_data::label() = "roctracer";
|
|
roctracer_data::description() = "ROCm tracer (activity API)";
|
|
}
|
|
|
|
void
|
|
roctracer::start()
|
|
{
|
|
if(tracker_type::start() == 0) setup();
|
|
}
|
|
|
|
void
|
|
roctracer::stop()
|
|
{
|
|
if(tracker_type::stop() == 0) shutdown();
|
|
}
|
|
|
|
bool
|
|
roctracer::is_setup()
|
|
{
|
|
return roctracer_is_setup();
|
|
}
|
|
|
|
void
|
|
roctracer::add_setup(const std::string& _lbl, std::function<void()>&& _func)
|
|
{
|
|
roctracer_setup_routines().emplace_back(_lbl, std::move(_func));
|
|
}
|
|
|
|
void
|
|
roctracer::add_shutdown(const std::string& _lbl, std::function<void()>&& _func)
|
|
{
|
|
roctracer_shutdown_routines().emplace_back(_lbl, std::move(_func));
|
|
}
|
|
|
|
void
|
|
roctracer::remove_setup(const std::string& _lbl)
|
|
{
|
|
auto& _data = roctracer_setup_routines();
|
|
for(auto itr = _data.begin(); itr != _data.end(); ++itr)
|
|
{
|
|
if(itr->first == _lbl)
|
|
{
|
|
_data.erase(itr);
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
void
|
|
roctracer::remove_shutdown(const std::string& _lbl)
|
|
{
|
|
auto& _data = roctracer_setup_routines();
|
|
for(auto itr = _data.begin(); itr != _data.end(); ++itr)
|
|
{
|
|
if(itr->first == _lbl)
|
|
{
|
|
_data.erase(itr);
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
void
|
|
roctracer::setup()
|
|
{
|
|
if(!get_use_roctracer()) return;
|
|
|
|
auto_lock_t _lk{ type_mutex<roctracer>() };
|
|
if(roctracer_is_setup()) return;
|
|
roctracer_is_setup() = true;
|
|
|
|
OMNITRACE_VERBOSE_F(1, "setting up roctracer...\n");
|
|
pthread_gotcha::push_enable_sampling_on_child_threads(false);
|
|
|
|
dynamic_library _amdhip64{ "OMNITRACE_ROCTRACER_LIBAMDHIP64",
|
|
find_library_path("libamdhip64.so",
|
|
{ "OMNITRACE_ROCM_PATH", "ROCM_PATH" },
|
|
{ OMNITRACE_DEFAULT_ROCM_PATH }) };
|
|
|
|
#if OMNITRACE_HIP_VERSION_MAJOR == 4 && OMNITRACE_HIP_VERSION_MINOR < 4
|
|
dynamic_library _kfdwrapper{
|
|
"OMNITRACE_ROCTRACER_LIBKFDWRAPPER",
|
|
find_library_path("libkfdwrapper64.so", { "OMNITRACE_ROCM_PATH", "ROCM_PATH" },
|
|
{ OMNITRACE_DEFAULT_ROCM_PATH },
|
|
{ "roctracer/lib", "roctracer/lib64", "lib", "lib64" })
|
|
};
|
|
#endif
|
|
|
|
ROCTRACER_CALL(roctracer_set_properties(ACTIVITY_DOMAIN_HIP_API, nullptr));
|
|
|
|
// Allocating tracing pool
|
|
roctracer_properties_t properties{};
|
|
memset(&properties, 0, sizeof(roctracer_properties_t));
|
|
// properties.mode = 0x1000;
|
|
properties.buffer_size = 0x100;
|
|
properties.buffer_callback_fun = hip_activity_callback;
|
|
ROCTRACER_CALL(roctracer_open_pool(&properties));
|
|
|
|
#if OMNITRACE_HIP_VERSION_MAJOR == 4 && OMNITRACE_HIP_VERSION_MINOR >= 4
|
|
// HIP 4.5.0 has an invalid warning
|
|
redirect _rd{ std::cerr, "roctracer_enable_callback(), get_op_end(), invalid domain "
|
|
"ID(4) in: roctracer_enable_callback(hip_api_callback, "
|
|
"nullptr)roctracer_enable_activity_expl(), get_op_end(), "
|
|
"invalid domain ID(4) in: roctracer_enable_activity()" };
|
|
#endif
|
|
|
|
ROCTRACER_CALL(roctracer_enable_domain_callback(ACTIVITY_DOMAIN_HIP_API,
|
|
hip_api_callback, nullptr));
|
|
if(get_use_roctx())
|
|
{
|
|
ROCTRACER_CALL(roctracer_enable_domain_callback(ACTIVITY_DOMAIN_ROCTX,
|
|
roctx_api_callback, nullptr));
|
|
}
|
|
// Enable HIP activity tracing
|
|
ROCTRACER_CALL(roctracer_enable_domain_activity(ACTIVITY_DOMAIN_HIP_OPS));
|
|
|
|
// callback for HSA
|
|
for(auto& itr : roctracer_setup_routines())
|
|
itr.second();
|
|
|
|
pthread_gotcha::pop_enable_sampling_on_child_threads();
|
|
|
|
OMNITRACE_VERBOSE_F(1, "roctracer is setup\n");
|
|
}
|
|
|
|
void
|
|
roctracer::shutdown()
|
|
{
|
|
auto_lock_t _lk{ type_mutex<roctracer>() };
|
|
if(!roctracer_is_setup())
|
|
{
|
|
if(!roctracer_is_init() && tim::storage<comp::roctracer_data>::instance())
|
|
tim::storage<comp::roctracer_data>::instance()->reset();
|
|
return;
|
|
}
|
|
roctracer_is_setup() = false;
|
|
|
|
OMNITRACE_VERBOSE_F(1, "shutting down roctracer...\n");
|
|
|
|
OMNITRACE_VERBOSE_F(2, "executing hip_exec_activity_callbacks(0..%zu)\n",
|
|
max_supported_threads);
|
|
// make sure all async operations are executed
|
|
for(size_t i = 0; i < max_supported_threads; ++i)
|
|
hip_exec_activity_callbacks(i);
|
|
|
|
// callback for hsa
|
|
OMNITRACE_VERBOSE_F(2, "executing %zu roctracer_shutdown_routines...\n",
|
|
roctracer_shutdown_routines().size());
|
|
for(auto& itr : roctracer_shutdown_routines())
|
|
itr.second();
|
|
|
|
#if OMNITRACE_HIP_VERSION_MAJOR == 4 && OMNITRACE_HIP_VERSION_MINOR >= 4
|
|
OMNITRACE_DEBUG_F("redirecting roctracer warnings\n");
|
|
// HIP 4.5.0 has an invalid warning
|
|
redirect _rd{
|
|
std::cerr, "roctracer_disable_callback(), get_op_end(), invalid domain ID(4) "
|
|
"in: roctracer_disable_callback()roctracer_disable_activity(), "
|
|
"get_op_end(), invalid domain ID(4) in: roctracer_disable_activity()"
|
|
};
|
|
#endif
|
|
|
|
// ROCTRACER_CALL(roctracer_disable_domain_callback(ACTIVITY_DOMAIN_ROCTX));
|
|
OMNITRACE_VERBOSE_F(
|
|
2, "executing roctracer_disable_domain_callback(ACTIVITY_DOMAIN_HIP_API)...\n");
|
|
ROCTRACER_CALL(roctracer_disable_domain_callback(ACTIVITY_DOMAIN_HIP_API));
|
|
|
|
OMNITRACE_VERBOSE_F(
|
|
2, "executing roctracer_disable_domain_activity(ACTIVITY_DOMAIN_HIP_OPS)...\n");
|
|
ROCTRACER_CALL(roctracer_disable_domain_activity(ACTIVITY_DOMAIN_HIP_OPS));
|
|
|
|
if(roctracer_activity_count() == 0)
|
|
{
|
|
OMNITRACE_VERBOSE_F(2, "executing roctracer_flush_activity()...\n");
|
|
ROCTRACER_CALL(roctracer_flush_activity());
|
|
}
|
|
else
|
|
{
|
|
OMNITRACE_CI_FAIL(true,
|
|
"roctracer_activity_count() != 0 (== %li). "
|
|
"roctracer::shutdown() most likely called during abort",
|
|
roctracer_activity_count().load());
|
|
}
|
|
|
|
OMNITRACE_VERBOSE_F(1, "roctracer is shutdown\n");
|
|
}
|
|
|
|
scope::transient_destructor
|
|
roctracer::protect_flush_activity()
|
|
{
|
|
return scope::transient_destructor([]() { --roctracer_activity_count(); },
|
|
[]() { ++roctracer_activity_count(); });
|
|
}
|
|
} // namespace component
|
|
} // namespace omnitrace
|
|
|
|
OMNITRACE_INSTANTIATE_EXTERN_COMPONENT(roctracer, false, void)
|
|
OMNITRACE_INSTANTIATE_EXTERN_COMPONENT(roctracer_data, true, double)
|