Saurabh Verma
63775f241a
* EvaluateAST and validation of RawAST * Adding MetricDimension class and concepts * set_dimensions() and improved ValidateRawAST() * source formatting (clang-format v11) (#124) Co-authored-by: bwelton <bwelton@users.noreply.github.com> * Addressing 1st round of review comments * Modified the parser production rules to support the right syntax for REDUCE and SELECT derived metric expressions * changes to raw_ast.hpp and fmt::format() * Parser tests updated to support corrected REDUCE and SELECT syntax * changes to EvaluateAST::set_dimensions() and other dimension related code changes * Added a test for EvaluateAST::evaluate() to test basic arithmetic on EvaluateAST * Format source code (via clang-format v11) on sauverma/evaluate-ast (#146) * source formatting (clang-format v11) * Add dimension information to counter record Restructures counter records to have the following design: rocprofiler_record_id_t which is an int64_t that encodes both the counter id and dimension information for the record. The first 16 bits are reserved for the counter id while the last 48 are split among the dimensions specified in rocprofiler_dimension_t (currently 8 bits per dimension). Each of the 8 bits for the dimension stores the dimension value for that dimension for this record (i.e. a value of 8 on dimension XCC would denote XCC[8] for the counter). The split among the dimensions will automatically adjust as dimensions are added or removed. The record also contains a union of {int64_t hw_counter, double derived_counter} to specify the value of the record at rocprofiler_record_id_t. int64_t denotes a physical hardware counter that has integer types while the double is used for derived counters (which type this counters values are needs to be queried separately). * Integration of new id type + other fixes --------- Co-authored-by: sauverma93 <sauverma93@users.noreply.github.com> Co-authored-by: Benjamin Welton <bewelton@amd.com> * Fixed sissues with reduce() implementation and added a test for reduce() * Updated parser syntax for reduce() and updated the parser test. Disabled the test for select() * Build warning fixes * Modifications to support fetching xcc/etc info from agent * Initial plumbing working for single counters, cleanup+tests still needed * Remove string comparison from reduce ops * source formatting (clang-format v11) (#163) Co-authored-by: bwelton <bwelton@users.noreply.github.com> * cmake formatting (cmake-format) (#164) Co-authored-by: bwelton <bwelton@users.noreply.github.com> * source formatting (clang-format v11) (#171) Co-authored-by: bwelton <bwelton@users.noreply.github.com> * Merged with master * source formatting (clang-format v11) (#172) Co-authored-by: bwelton <bwelton@users.noreply.github.com> * source formatting (clang-format v11) (#173) Co-authored-by: bwelton <bwelton@users.noreply.github.com> * Test fix --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: bwelton <bwelton@users.noreply.github.com> Co-authored-by: sauverma93 <sauverma93@users.noreply.github.com> Co-authored-by: Benjamin Welton <bewelton@amd.com>
81 γραμμές
2.5 KiB
C++
81 γραμμές
2.5 KiB
C++
#pragma once
|
|
|
|
#include <atomic>
|
|
#include <cstdint>
|
|
#include <iostream>
|
|
#include <tuple>
|
|
#include <unordered_map>
|
|
#include <vector>
|
|
|
|
#include "lib/rocprofiler/counters/id_decode.hpp"
|
|
#include "lib/rocprofiler/counters/metrics.hpp"
|
|
|
|
namespace rocprofiler
|
|
{
|
|
namespace counters
|
|
{
|
|
class MetricDimension
|
|
{
|
|
public:
|
|
MetricDimension(std::string name,
|
|
uint64_t dim_size,
|
|
rocprofiler_profile_counter_instance_types type)
|
|
: name_(std::move(name))
|
|
, size_(dim_size)
|
|
, type_(type){};
|
|
|
|
const std::string& name() const { return name_; }
|
|
uint64_t size() const { return size_; }
|
|
rocprofiler_profile_counter_instance_types type() const { return type_; }
|
|
bool operator==(const MetricDimension& dim) const
|
|
{
|
|
return std::tie(name_, size_, type_) == std::tie(dim.name_, dim.size_, dim.type_);
|
|
}
|
|
|
|
private:
|
|
std::string name_;
|
|
uint64_t size_;
|
|
rocprofiler_profile_counter_instance_types type_;
|
|
};
|
|
|
|
/*
|
|
{
|
|
AgentBlockDimensionsMap = {
|
|
"gfx906":{},
|
|
"gfx908":{
|
|
"TCC": [dim_1, dim_2 ... dim_n]
|
|
"SQ": [dim_1, dim_2 ... dim_n]
|
|
"TCP": [dim_1, dim_2 ... dim_n]
|
|
}
|
|
}
|
|
}
|
|
*/
|
|
|
|
// // map block_name -> MetricDimension
|
|
// using BlockDimensionMap = std::unordered_map<std::string, std::vector<MetricDimension>>;
|
|
// // map agent_name -> BlockDimensionMap
|
|
// using AgentBlockDimensionsMap = std::unordered_map<std::string, BlockDimensionMap&>;
|
|
|
|
// // map dimension_id -> MetricDimension
|
|
// using DimensionIdMap = std::unordered_map<uint64_t, MetricDimension>;
|
|
|
|
// // get the complete AgentBlockDimensionsMap
|
|
// const AgentBlockDimensionsMap&
|
|
// getAgentBlockDimensionsMap();
|
|
|
|
// // get specific dimensions for an agent, block_name
|
|
// const std::vector<MetricDimension>&
|
|
// getBlockDimension(const std::string& agent,
|
|
// std::string block_name,
|
|
// rocprofiler_profile_counter_instance_types dim);
|
|
|
|
// get all dimensions for an agent, block_name
|
|
std::vector<MetricDimension>
|
|
getBlockDimensions(const std::string& agent, const counters::Metric&);
|
|
|
|
// // get a specific dimension by id
|
|
// const MetricDimension&
|
|
// getDimensionById(uint64_t id);
|
|
|
|
} // namespace counters
|
|
} // namespace rocprofiler
|