010693b795
* Migrate XML counter defs and reader from v1/v2 * Current Working Set * Modified parser * Evaluate AST Start * Update lib/common/xml - move definitions out of class declaration * Update lib/rocprofiler/counters/parser - update build of bison and flex build - reproducible generation - add ROCPROFILER_REGENERATE_COUNTERS_PARSER option - fix namespacing * Update lib/rocprofiler/counters/xml - change location of XML files and install them * Update lib/rocprofiler/counter/tests - normalize the test names - improve test failures (more clear about where failure is) * Update lib/rocprofiler/counters - fix namespace - update to new XML metrics directory * Update lib/rocprofiler/CMakeLists.txt - link to object library * Update lib/rocprofiler/hsa/types.hpp - reorganize includes * Add metric loading class/printers * Agent Implementation * Queue Implementation (#79) * Queue Implementation * API Implementation For Counters (part 1) (#80) * API Implementation For Counters * Bewelton/counter collection 3 (#84) * Added counter sample * More changes * More changes * Update samples/counter_collection - mostly formatting * Update include/rocprofiler/counters.h - formatting * Add lib.common/synchronized.hpp - Synchronized struct * Update lib/rocprofiler/counters/xml/basic_counters.xml - whitespace * Update scripts/patch-parser.cmake - tweaks for consistency * Update lib/rocprofiler/counters/parser/tests/parser_tests.cpp - formatting * Update lib/rocprofiler/counters/parser - improve consistency in rocprofiler-expr-parser-patch - update parser.{h,cpp} and scanner.cpp - formatting + regenerated * Update lib/rocprofiler/aql - formatting - clang-tidy fixes - guard against memory pool access errors * Update lib/rocprofiler/aql/tests - formatting - update use of get_val - normalize test names * Update lib/rocprofiler/counters/tests - formatting - patch basic_counters and derived_counters - normalize test names * Update lib/rocprofiler/aql/tests - set_tests_properties * Update test labels - fix minor issue with gtest labels * Update lib/rocprofiler/counters - formatting - clang-tidy fixes * Update lib/rocprofiler/hsa - fix includes - formatting - clang-tidy fixes - tweak to queue_controller_init interface * Update lib/rocprofiler - include fixes - namespace fixes - clang-tidy fixes - formatting * Update scripts/run-ci.py - exclude counters/parser from code coverage (generated files) * Update include/rocprofiler/counters.h - fix doxygen comment * Update lib/rocprofiler/aql/packet_construct.cpp - guard against HSA_AMD_MEMORY_POOL_ACCESS_DISALLOWED_BY_DEFAULT and HSA_AMD_MEMORY_POOL_ACCESS_NEVER_ALLOWED * Update lib/rocprofiler/counters/parser/raw_ast.hpp - clang-tidy fixes * Update lib/rocprofiler/counters/evaluate_ast.hpp - clang-tidy fixes * Update lib/rocprofiler/aql/tests - disable packet_generation_single and packet_generation_multi tests - the entire implementation rocprofiler::get_ext_table() is incorrect * Minor fixes before cleanup * More changes * More fixes * More fixes * source formatting (clang-format v11) (#99) Co-authored-by: bwelton <bwelton@users.noreply.github.com> * Revert PTL submodule * Update scripts/run-ci.py - exclude counters/parser from code coverage (generated files) * Migrating counters state to context * Linting * source formatting (clang-format v11) (#101) Co-authored-by: bwelton <bwelton@users.noreply.github.com> * revert run-ci * Testing fixes * More test changes * Fix minor typo * Small queue change * Small queue change * source formatting (clang-format v11) (#102) Co-authored-by: bwelton <bwelton@users.noreply.github.com> * source formatting (clang-format v11) (#105) Co-authored-by: bwelton <bwelton@users.noreply.github.com> * Documentation Change * More documentation fixes * source formatting (clang-format v11) (#106) Co-authored-by: bwelton <bwelton@users.noreply.github.com> * Threading fixes * Threading fixes * source formatting (clang-format v11) (#107) Co-authored-by: bwelton <bwelton@users.noreply.github.com> * Threading fixes * More test fixes * More agent fixes * More build fixes * source formatting (clang-format v11) (#109) Co-authored-by: bwelton <bwelton@users.noreply.github.com> * changed test timeouts * Build fix * Build fix * Updates to agent * source formatting (clang-format v11) (#114) Co-authored-by: bwelton <bwelton@users.noreply.github.com> * cmake formatting (cmake-format) (#113) Co-authored-by: bwelton <bwelton@users.noreply.github.com> * remove git worktree folder * Doc update * testing fix * Another test fix * More test changes * Rebase * source formatting (clang-format v11) (#116) Co-authored-by: bwelton <bwelton@users.noreply.github.com> * Documentation * source formatting (clang-format v11) (#119) Co-authored-by: bwelton <bwelton@users.noreply.github.com> * PTL Changes * Minor agent fix for empty labels * source formatting (clang-format v11) (#120) Co-authored-by: bwelton <bwelton@users.noreply.github.com> * Minor agent fix for empty labels * Refactor read_map * source formatting (clang-format v11) (#121) Co-authored-by: bwelton <bwelton@users.noreply.github.com> * Refactor read_map * Cache fixes * source formatting (clang-format v11) (#122) Co-authored-by: bwelton <bwelton@users.noreply.github.com> --------- Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: bwelton <bwelton@users.noreply.github.com>
191 строка
6.8 KiB
C++
191 строка
6.8 KiB
C++
#include <tuple>
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include "lib/rocprofiler/counters/evaluate_ast.hpp"
|
|
#include "lib/rocprofiler/counters/parser/reader.hpp"
|
|
|
|
namespace
|
|
{
|
|
bool
|
|
isIdentical(const EvaluateAST& eval_ast, const RawAST& raw_ast)
|
|
{
|
|
if(raw_ast.counter_set.size() != eval_ast.children().size() ||
|
|
raw_ast.type != eval_ast.type() || raw_ast.operation != eval_ast.op())
|
|
{
|
|
return false;
|
|
}
|
|
|
|
for(size_t i = 0; i < raw_ast.counter_set.size(); i++)
|
|
{
|
|
if(!isIdentical(eval_ast.children()[i], *raw_ast.counter_set[i]))
|
|
{
|
|
return false;
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
} // namespace
|
|
|
|
TEST(evaluate_ast, basic_copy)
|
|
{
|
|
std::unordered_map<std::string, Metric> metrics = {
|
|
{"SQ_WAVES", Metric("a", "a", "a", "a", "a", "", 0)},
|
|
{"TCC_HIT", Metric("b", "b", "b", "b", "b", "", 1)}};
|
|
|
|
RawAST* ast = nullptr;
|
|
auto* buf = yy_scan_string("SQ_WAVES + TCC_HIT");
|
|
yyparse(&ast);
|
|
ASSERT_TRUE(ast);
|
|
|
|
auto eval_ast = EvaluateAST(metrics, *ast);
|
|
|
|
EXPECT_TRUE(isIdentical(eval_ast, *ast));
|
|
yy_delete_buffer(buf);
|
|
delete ast;
|
|
}
|
|
|
|
TEST(evaluate_ast, counter_expansion)
|
|
{
|
|
std::unordered_map<std::string, Metric> metrics = {
|
|
{"SQ_WAVES", Metric("SQ_WAVES", "a", "a", "a", "", "", 0)},
|
|
{"TCC_HIT", Metric("TCC_HIT", "b", "b", "b", "", "", 1)},
|
|
{"TEST_DERRIVED", Metric("TEST_DERRIVED", "C", "C", "C", "SQ_WAVES+TCC_HIT", "", 2)}};
|
|
|
|
std::unordered_map<std::string, EvaluateAST> asts;
|
|
for(auto [val, metric] : metrics)
|
|
{
|
|
RawAST* ast = nullptr;
|
|
auto buf = yy_scan_string(metric.expression().empty() ? metric.name().c_str()
|
|
: metric.expression().c_str());
|
|
yyparse(&ast);
|
|
ASSERT_TRUE(ast);
|
|
asts.emplace(val, std::move(EvaluateAST(metrics, *ast)));
|
|
yy_delete_buffer(buf);
|
|
delete ast;
|
|
}
|
|
|
|
std::set<Metric> required_counters;
|
|
asts.at("TEST_DERRIVED").get_required_counters(asts, required_counters);
|
|
EXPECT_EQ(required_counters.size(), 2);
|
|
auto expected = std::set<Metric>{{Metric("TCC_HIT", "b", "b", "b", "", "", 1),
|
|
Metric("SQ_WAVES", "a", "a", "a", "", "", 0)}};
|
|
|
|
for(auto& counter_found : required_counters)
|
|
{
|
|
EXPECT_NE(expected.find(counter_found), expected.end());
|
|
}
|
|
}
|
|
|
|
TEST(evaluate_ast, counter_expansion_multi_derived)
|
|
{
|
|
std::unordered_map<std::string, Metric> metrics = {
|
|
{"SQ_WAVES", Metric("SQ_WAVES", "a", "a", "a", "", "", 0)},
|
|
{"TCC_HIT", Metric("TCC_HIT", "b", "b", "b", "", "", 1)},
|
|
{"TEST_DERRIVED", Metric("TEST_DERRIVED", "C", "C", "C", "SQ_WAVES+TCC_HIT", "", 2)},
|
|
{"TEST_DERRIVED3",
|
|
Metric("TEST_DERRIVED3", "C", "C", "C", "TEST_DERRIVED+SQ_WAVES+TCC_HIT", "", 3)}};
|
|
|
|
std::unordered_map<std::string, EvaluateAST> asts;
|
|
for(auto [val, metric] : metrics)
|
|
{
|
|
RawAST* ast = nullptr;
|
|
auto buf = yy_scan_string(metric.expression().empty() ? metric.name().c_str()
|
|
: metric.expression().c_str());
|
|
yyparse(&ast);
|
|
ASSERT_TRUE(ast);
|
|
asts.emplace(val, std::move(EvaluateAST(metrics, *ast)));
|
|
yy_delete_buffer(buf);
|
|
delete ast;
|
|
}
|
|
|
|
std::set<Metric> required_counters;
|
|
asts.at("TEST_DERRIVED3").get_required_counters(asts, required_counters);
|
|
EXPECT_EQ(required_counters.size(), 2);
|
|
auto expected = std::set<Metric>{{Metric("TCC_HIT", "b", "b", "b", "", "", 1),
|
|
Metric("SQ_WAVES", "a", "a", "a", "", "", 0)}};
|
|
|
|
for(auto& counter_found : required_counters)
|
|
{
|
|
EXPECT_NE(expected.find(counter_found), expected.end());
|
|
}
|
|
}
|
|
|
|
TEST(evaluate_ast, counter_expansion_order)
|
|
{
|
|
std::unordered_map<std::string, Metric> metrics = {
|
|
{"SQ_WAVES", Metric("SQ_WAVES", "a", "a", "a", "", "", 0)},
|
|
{"TCC_HIT", Metric("TCC_HIT", "b", "b", "b", "", "", 1)},
|
|
{"VLL", Metric("VLL", "b", "b", "b", "", "", 4)},
|
|
{"TEST_DERRIVED", Metric("TEST_DERRIVED", "C", "C", "C", "SQ_WAVES+VLL", "", 2)},
|
|
{"TEST_DERRIVED3",
|
|
Metric("TEST_DERRIVED3", "C", "C", "C", "TEST_DERRIVED+SQ_WAVES+TCC_HIT", "", 3)}};
|
|
|
|
std::unordered_map<std::string, EvaluateAST> asts;
|
|
for(auto [val, metric] : metrics)
|
|
{
|
|
RawAST* ast = nullptr;
|
|
auto buf = yy_scan_string(metric.expression().empty() ? metric.name().c_str()
|
|
: metric.expression().c_str());
|
|
yyparse(&ast);
|
|
ASSERT_TRUE(ast);
|
|
asts.emplace(val, std::move(EvaluateAST(metrics, *ast)));
|
|
yy_delete_buffer(buf);
|
|
delete ast;
|
|
}
|
|
|
|
std::set<Metric> required_counters;
|
|
asts.at("TEST_DERRIVED3").get_required_counters(asts, required_counters);
|
|
EXPECT_EQ(required_counters.size(), 3);
|
|
auto expected = std::set<Metric>{{Metric("VLL", "b", "b", "b", "", "", 4),
|
|
Metric("TCC_HIT", "b", "b", "b", "", "", 1),
|
|
Metric("SQ_WAVES", "a", "a", "a", "", "", 0)}};
|
|
|
|
for(auto& counter_found : required_counters)
|
|
{
|
|
EXPECT_NE(expected.find(counter_found), expected.end());
|
|
}
|
|
}
|
|
|
|
TEST(evaluate_ast, counter_expansion_function)
|
|
{
|
|
std::unordered_map<std::string, Metric> metrics = {
|
|
{"SQ_WAVES", Metric("SQ_WAVES", "a", "a", "a", "", "", 0)},
|
|
{"TCC_HIT", Metric("TCC_HIT", "b", "b", "b", "", "", 1)},
|
|
{"VLL", Metric("VLL", "b", "b", "b", "", "", 4)},
|
|
{"TEST_DERRIVED", Metric("TEST_DERRIVED", "C", "C", "C", "SQ_WAVES+VLL", "", 2)},
|
|
{"TEST_DERRIVED3",
|
|
Metric("TEST_DERRIVED3",
|
|
"C",
|
|
"C",
|
|
"C",
|
|
"reduce(TEST_DERRIVED,max)+SQ_WAVES+TCC_HIT",
|
|
"",
|
|
3)}};
|
|
|
|
std::unordered_map<std::string, EvaluateAST> asts;
|
|
for(auto [val, metric] : metrics)
|
|
{
|
|
RawAST* ast = nullptr;
|
|
auto buf = yy_scan_string(metric.expression().empty() ? metric.name().c_str()
|
|
: metric.expression().c_str());
|
|
yyparse(&ast);
|
|
ASSERT_TRUE(ast);
|
|
asts.emplace(val, std::move(EvaluateAST(metrics, *ast)));
|
|
yy_delete_buffer(buf);
|
|
delete ast;
|
|
}
|
|
|
|
std::set<Metric> required_counters;
|
|
asts.at("TEST_DERRIVED3").get_required_counters(asts, required_counters);
|
|
EXPECT_EQ(required_counters.size(), 3);
|
|
auto expected = std::set<Metric>{{Metric("VLL", "b", "b", "b", "", "", 4),
|
|
Metric("TCC_HIT", "b", "b", "b", "", "", 1),
|
|
Metric("SQ_WAVES", "a", "a", "a", "", "", 0)}};
|
|
|
|
for(auto& counter_found : required_counters)
|
|
{
|
|
EXPECT_NE(expected.find(counter_found), expected.end());
|
|
}
|
|
}
|