ac80bac82a
Child process hsaKmtOpenKFD() call must re-initialize global variables
copied from parent process. This includes close all file handles, free
dynamically malloc buf. Double free issue is because destroy_device_
debugging_memory() free the memory in parent process hsaKmtCloseKFD()
but don't reset it to null pointer. As a result, child process free it
again. kfd_fd is closed in parent process but don't reset to 0, so
child process close it again.
Fix: reset kfd_fd to 0 after close, reset is_device_debugged pointer to 0
after free
Change-Id: I421b3decbcaa4111298b8e599aa16940d851a58c
Signed-off-by: Philip Yang <Philip.Yang@amd.com>
[ROCm/ROCR-Runtime commit: 3501b2f40d]
192 líneas
4.7 KiB
C
192 líneas
4.7 KiB
C
/*
|
|
* Copyright © 2014 Advanced Micro Devices, Inc.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use, copy,
|
|
* modify, merge, publish, distribute, sublicense, and/or sell copies
|
|
* of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including
|
|
* the next paragraph) shall be included in all copies or substantial
|
|
* portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
* DEALINGS IN THE SOFTWARE.
|
|
*/
|
|
|
|
#include "libhsakmt.h"
|
|
|
|
#include <stdlib.h>
|
|
#include <sys/types.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/ioctl.h>
|
|
#include <fcntl.h>
|
|
#include <unistd.h>
|
|
#include <stdio.h>
|
|
#include <strings.h>
|
|
#include "fmm.h"
|
|
|
|
static const char kfd_device_name[] = "/dev/kfd";
|
|
static pid_t parent_pid = -1;
|
|
int hsakmt_debug_level;
|
|
|
|
static bool is_forked_child(void)
|
|
{
|
|
pid_t cur_pid = getpid();
|
|
|
|
if (parent_pid == -1) {
|
|
parent_pid = cur_pid;
|
|
return false;
|
|
}
|
|
|
|
if (parent_pid != cur_pid)
|
|
return true;
|
|
|
|
return false;
|
|
}
|
|
|
|
/* Call this from the child process after fork. This will clear all
|
|
* data that is duplicated from the parent process, that is not valid
|
|
* in the child.
|
|
* The topology information is duplicated from the parent is valid
|
|
* in the child process so it is not cleared
|
|
*/
|
|
static void clear_after_fork(void)
|
|
{
|
|
clear_process_doorbells();
|
|
clear_events_page();
|
|
fmm_clear_all_mem();
|
|
destroy_device_debugging_memory();
|
|
if (kfd_fd) {
|
|
close(kfd_fd);
|
|
kfd_fd = 0;
|
|
}
|
|
kfd_open_count = 0;
|
|
}
|
|
|
|
static inline void init_page_size(void)
|
|
{
|
|
PAGE_SIZE = sysconf(_SC_PAGESIZE);
|
|
PAGE_SHIFT = ffs(PAGE_SIZE) - 1;
|
|
}
|
|
|
|
/* Normally libraries don't print messages. For debugging purpose, we'll
|
|
* print messages if an environment variable, HSAKMT_DEBUG_LEVEL, is set.
|
|
*/
|
|
static void init_debug_level(void)
|
|
{
|
|
char *envvar;
|
|
int debug_level;
|
|
|
|
hsakmt_debug_level = HSAKMT_DEBUG_LEVEL_DEFAULT;
|
|
|
|
envvar = getenv("HSAKMT_DEBUG_LEVEL");
|
|
if (envvar) {
|
|
debug_level = atoi(envvar);
|
|
if (debug_level >= HSAKMT_DEBUG_LEVEL_ERR &&
|
|
debug_level <= HSAKMT_DEBUG_LEVEL_DEBUG)
|
|
hsakmt_debug_level = debug_level;
|
|
}
|
|
}
|
|
|
|
HSAKMT_STATUS HSAKMTAPI hsaKmtOpenKFD(void)
|
|
{
|
|
HSAKMT_STATUS result;
|
|
int fd;
|
|
HsaSystemProperties sys_props;
|
|
|
|
pthread_mutex_lock(&hsakmt_mutex);
|
|
|
|
/* If the process has forked, the child process must re-initialize
|
|
* it's connection to KFD. Any references tracked by kfd_open_count
|
|
* belong to the parent
|
|
*/
|
|
if (is_forked_child())
|
|
clear_after_fork();
|
|
|
|
if (kfd_open_count == 0) {
|
|
init_debug_level();
|
|
|
|
fd = open(kfd_device_name, O_RDWR | O_CLOEXEC);
|
|
|
|
if (fd != -1) {
|
|
kfd_fd = fd;
|
|
kfd_open_count = 1;
|
|
} else {
|
|
result = HSAKMT_STATUS_KERNEL_IO_CHANNEL_NOT_OPENED;
|
|
goto open_failed;
|
|
}
|
|
|
|
init_page_size();
|
|
|
|
result = topology_sysfs_get_system_props(&sys_props);
|
|
if (result != HSAKMT_STATUS_SUCCESS)
|
|
goto topology_sysfs_failed;
|
|
|
|
result = fmm_init_process_apertures(sys_props.NumNodes);
|
|
if (result != HSAKMT_STATUS_SUCCESS)
|
|
goto init_process_aperture_failed;
|
|
|
|
result = init_process_doorbells(sys_props.NumNodes);
|
|
if (result != HSAKMT_STATUS_SUCCESS)
|
|
goto init_doorbell_failed;
|
|
|
|
if (init_device_debugging_memory(sys_props.NumNodes) != HSAKMT_STATUS_SUCCESS)
|
|
pr_warn("Insufficient Memory. Debugging unavailable\n");
|
|
|
|
init_counter_props(sys_props.NumNodes);
|
|
} else {
|
|
kfd_open_count++;
|
|
result = HSAKMT_STATUS_SUCCESS;
|
|
}
|
|
|
|
pthread_mutex_unlock(&hsakmt_mutex);
|
|
return result;
|
|
|
|
init_doorbell_failed:
|
|
fmm_destroy_process_apertures();
|
|
init_process_aperture_failed:
|
|
topology_sysfs_failed:
|
|
close(fd);
|
|
open_failed:
|
|
pthread_mutex_unlock(&hsakmt_mutex);
|
|
|
|
return result;
|
|
}
|
|
|
|
HSAKMT_STATUS HSAKMTAPI hsaKmtCloseKFD(void)
|
|
{
|
|
HSAKMT_STATUS result;
|
|
|
|
pthread_mutex_lock(&hsakmt_mutex);
|
|
|
|
if (kfd_open_count > 0) {
|
|
if (--kfd_open_count == 0) {
|
|
destroy_counter_props();
|
|
destroy_device_debugging_memory();
|
|
destroy_process_doorbells();
|
|
fmm_destroy_process_apertures();
|
|
if (kfd_fd) {
|
|
close(kfd_fd);
|
|
kfd_fd = 0;
|
|
}
|
|
}
|
|
|
|
result = HSAKMT_STATUS_SUCCESS;
|
|
} else
|
|
result = HSAKMT_STATUS_KERNEL_IO_CHANNEL_NOT_OPENED;
|
|
|
|
pthread_mutex_unlock(&hsakmt_mutex);
|
|
|
|
return result;
|
|
}
|