79ba5904dc
SWDEV-151739 - [CQE OCL][DTB][Perf][QR][DTB-BLOCKER][VEGA10] Upto 18% performance drop observed while running Video Composition test sub test of Compubench due to faulty CL#1544622 - Implement customized TS tracking for managed buffers. The common TS tracking mechanism saves the event of the last command, assuming SDMA and compute operations occur in order, but for managed buffers it's not the case. Also managed buffer doesn't have to validate TS for the parent resource. Affected files ... ... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palblit.cpp#21 edit ... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palconstbuf.cpp#11 edit ... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palconstbuf.hpp#9 edit ... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palmemory.hpp#6 edit ... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.hpp#22 edit
158 lignes
4.8 KiB
C++
158 lignes
4.8 KiB
C++
//
|
|
// Copyright (c) 2015 Advanced Micro Devices, Inc. All rights reserved.
|
|
//
|
|
#pragma once
|
|
|
|
#include "device/pal/palmemory.hpp"
|
|
|
|
//! \namespace pal PAL Resource Implementation
|
|
namespace pal {
|
|
|
|
//! Managed buffer (staging or constant)
|
|
class ManagedBuffer : public amd::EmbeddedObject {
|
|
public:
|
|
//! Constructor for the ConstBuffer class
|
|
ManagedBuffer(VirtualGPU& gpu, //!< Virtual GPU device object
|
|
uint32_t size //!< size of the managed buffers in bytes
|
|
);
|
|
~ManagedBuffer() {}
|
|
|
|
//! Creates the managed buffers
|
|
bool create(Resource::MemoryType type);
|
|
|
|
//! Release the managed buffers
|
|
void release();
|
|
|
|
/*! \brief Uploads current constant buffer data from sysMemCopy_ to HW
|
|
*
|
|
* \return True if the data upload was succesful
|
|
*/
|
|
address reserve(uint32_t size, //!< real data size for upload
|
|
uint64_t* gpu_address);
|
|
|
|
//! Returns CB size
|
|
uint32_t size() const { return size_; }
|
|
|
|
//! Returns current write offset for the managed buffer
|
|
uint32_t wrtOffset() const { return wrtOffset_; }
|
|
|
|
//! Returns active GPU buffer
|
|
Memory* activeMemory() const { return pool_[activeBuffer_].buf; }
|
|
|
|
//! Retruns VM address for the active buffer
|
|
uint64_t vmAddress() const { return pool_[activeBuffer_].buf->vmAddress(); }
|
|
|
|
//! Update the timestamp for the HW operation
|
|
void pinGpuEvent();
|
|
|
|
//! Returns VirtualGPU object this managed resource associated
|
|
VirtualGPU& gpu() const { return gpu_; }
|
|
|
|
private:
|
|
struct TimeStampedBuffer {
|
|
Memory* buf;
|
|
GpuEvent events[AllEngines];
|
|
};
|
|
|
|
//! The maximum number of the managed buffers
|
|
static constexpr uint32_t MaxNumberOfBuffers = 3;
|
|
|
|
//! Disable copy constructor
|
|
ManagedBuffer(const ManagedBuffer&) = delete;
|
|
|
|
//! Disable operator=
|
|
ManagedBuffer& operator=(const ManagedBuffer&) = delete;
|
|
|
|
VirtualGPU& gpu_; //!< Virtual GPU object
|
|
std::vector<TimeStampedBuffer> pool_; //!< Buffers for management
|
|
uint32_t activeBuffer_; //!< Current active buffer
|
|
uint32_t size_; //!< Constant buffer size
|
|
uint32_t wrtOffset_; //!< Current write offset
|
|
address wrtAddress_; //!< Write address in CB
|
|
};
|
|
|
|
//! Constant buffer
|
|
class ConstantBuffer : public amd::HeapObject {
|
|
public:
|
|
//! Constructor for the ConstBuffer class
|
|
ConstantBuffer(ManagedBuffer& mbuf, //!< Managed buffer
|
|
uint32_t size //!< Max size of the constant buffer
|
|
);
|
|
|
|
//! Destructor for the ConstBuffer class
|
|
~ConstantBuffer();
|
|
|
|
//! Creates the HW constant buffer
|
|
bool Create();
|
|
|
|
/*! \brief Uploads current constant buffer data from sysMemCopy_ to HW
|
|
*
|
|
* \return GPU address for the uploaded data
|
|
*/
|
|
uint64_t UploadDataToHw(uint32_t size //!< real data size for upload
|
|
) const;
|
|
|
|
/*! \brief Uploads current constant buffer data from sysMemCopy_ to HW
|
|
*
|
|
* \return GPU address for the uploaded data
|
|
*/
|
|
uint64_t UploadDataToHw(const void* sysmem, //!< Pointer to the data for upload
|
|
uint32_t size //!< Real data size for upload
|
|
) const;
|
|
|
|
//! Returns a pointer to the system memory copy for CB
|
|
address SysMemCopy() const { return sys_mem_copy_; }
|
|
|
|
//! Returns active GPU buffer
|
|
Memory* ActiveMemory() const { return mbuf_.activeMemory(); }
|
|
|
|
private:
|
|
//! Disable copy constructor
|
|
ConstantBuffer(const ConstantBuffer&) = delete;
|
|
|
|
//! Disable operator=
|
|
ConstantBuffer& operator=(const ConstantBuffer&) = delete;
|
|
|
|
ManagedBuffer& mbuf_; //!< Managed buffer on GPU
|
|
address sys_mem_copy_; //!< System memory copy
|
|
uint32_t size_; //!< Constant buffer size
|
|
};
|
|
|
|
//! Staging buffer
|
|
class XferBuffer : public amd::EmbeddedObject {
|
|
public:
|
|
//! Constructor for the ConstBuffer class
|
|
XferBuffer(const Device& device, //!< Active GPU device
|
|
ManagedBuffer& mbuf, //!< Managed buffer
|
|
uint32_t size //!< Maximum size of the transfer buffer
|
|
);
|
|
|
|
//! Destructor for the ConstBuffer class
|
|
~XferBuffer() {}
|
|
|
|
/*! \brief Acquires free memory from the managed buffer
|
|
*
|
|
* \return GPU memory object associated with free memory
|
|
*/
|
|
Memory& Acquire(uint32_t size //!< data size for transfers
|
|
);
|
|
|
|
//! Releases memory object used in the staging transfer
|
|
void Release(Memory& mem //!< Memory object for release
|
|
) { buffer_view_.updateView(nullptr, 0, 0); }
|
|
|
|
size_t MaxSize() const { return static_cast<size_t>(size_); }
|
|
|
|
private:
|
|
//! Disable copy constructor
|
|
XferBuffer(const XferBuffer&) = delete;
|
|
|
|
//! Disable operator=
|
|
XferBuffer& operator=(const XferBuffer&) = delete;
|
|
|
|
Memory buffer_view_; //!< Buffer view returned in the acquire
|
|
ManagedBuffer& mbuf_; //!< Managed buffer on GPU
|
|
uint32_t size_; //!< Mx staging buffer size
|
|
};
|
|
/*@}*/} // namespace pal
|