Files
rocm-systems/source/lib/rocprofiler-sdk/ompt/ompt.hpp
T
Madsen, Jonathan 00c46fd5e5 SDK: OMPT Support (#22)
* Ability to select alternative compiler per file

Implementation of ompt interface to rocprofiler SDK. task_create and task_schedule are not supported.

Misc updates

Update OpenMP target sample

- samples/ompt -> samples/openmp_target
- fix sample test of openmp-target
- reorganize files

Rework OpenMP implementation

Minor OpenMP implementation cleanup

Rename samples/openmp_target CMake targets

Add tests/bin/openmp

- OpenMP target test app in tests/bin/openmp/target

Format samples/openmp_target CMakeLists.txt

Misc lib/rocprofiler-sdk/openmp cleanup

- fix includes
- convert_arg

Update openmp.def.cpp

- tweak includes
- remove lots of temporary variables

Update samples

- common::get_callback_id_names() -> common::get_callback_tracing_names()
- add kernel dispatch, memory copy, scratch memory buffered tracing to openmp target sample

Fix code object operation names

- add "CODE_OBJECT_" prefix

Update include/rocprofiler-sdk/openmp/api_id.h

- remove spurious comment

Miscellaneous openmp updates

- similar API for openmp_begin and openmp_end
- move implementations of ompt callbacks to openmp.cpp
- ompt_{thread_begin,thread_end,parallel_begin,parallel_end}_callbacks are openmp_events

[SWDEV-484495] Fix int truncation in CSV output (#1098)

CSV output truncates doubles to ints when it shouldn't. Derived metrics
are (mostly) doubles and lose precision (or become worthless) if treated
as an int. Converted these to double to match the format we return from
rocprof-sdk.

Co-authored-by: Benjamin Welton <ben@amd.com>

Update limit for max counter records in rocprof-tool (#1073)

A fixed sized std::array is used to store counter records in rocprofiler SDK. This limit was breached in SWDEV-484742. Upping the limit to 512 to be less likely to reach this limit again.

adding proxy ompt_data_t * arguments

fixes for proxy pointers

- Implement proxy ompt_data_t* pointers for clients
- Add ompt_data_t* arguments back to callback API
- Modify openmp sample to illustrate use of proxy pointers

formatting

SWDEV-467350: Skipping tool counter iteration for unsupported hardware (#1083)

Fixing some accumulate metrics (#1089)

* Fixing some accumulate metrics

* Fixing some more accumulate metrics

---------

Co-authored-by: Benjamin Welton <bewelton@amd.com>

updating rocprofv3 help options (#1113)

* updating rocprofv3 help options

* updating CHANGELOG

Fixing installed pacakge tests in CI (#1119)

* Fixing installed pacakge tests in CI

* Formatted rocprofv3.py with black formatter

SWDEV-488948: PC Sampling - Correlation class to provide some thread safety. Adding multithread tests. (#1112)

* SWDEV-488948: PC Sampling - Correlation class to provide some thread safety. Adding multithread tests.

* Update source/lib/rocprofiler-sdk/pc_sampling/parser/correlation.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

* Update source/lib/rocprofiler-sdk/pc_sampling/parser/correlation.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

* Adding backlog for codeobj changes

* Formatting

* Update source/lib/rocprofiler-sdk/pc_sampling/code_object.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

* Update source/lib/rocprofiler-sdk/pc_sampling/code_object.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

---------

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

SWDEV-487621: Fixes for metric definitions (#1118)

* Fixes for metric definitions

* Removing gfx8

* Update changelog

* Fixing unit tests

* Small fixes

* Fix for write size

Fix PSDB change (#1120)

Reverts change to `source/include/rocprofiler-sdk/callback_tracing.h`
from commit 9b2ece76c3

clang-18 build fix for RCCL (#1123)

Removes ambiguity on const usage, which clang-18 complains about
(preventing build with warn error).

mem copy direction field update (#1124)

Adding Node-id for debugging with log level trace (#1090)

fix botched rebase

Per Jonathan to remove -rdynamic warning so CI will continue

pedantic formatting

Correct the package name of rocprofiler-sdk (#1126)

* Correct the package name of rocprofiler-sdk

ROCM VERSION(for ex: 60300) was missing in the package name.
Added the same

* Use cmake cache string while setting the variable for ROCm Version

* correct the cmake-format

---------

Co-authored-by: Ranjith Ramakrishnan <Ranjith.Ramakrishnan@amd.com>

Fixing kokkosp tool library packaging (#1121)

* Fixing kokkosp tool library packaging

* Update source/lib/rocprofiler-sdk-tool/kokkosp/CMakeLists.txt

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update CMakeLists.txt

* Update CMakeLists.txt

* Component Requirement in CPack

* Adding package dependency

* Update CMakeLists.txt

* Update rocprofiler_config_packaging.cmake

* Fix rocprofiler-sdk-tool-kokkosp BUILD/INSTALL RPATH

- CMAKE_INSTALL_LIBDIR doesn't help

* Add BUILD/INSTALL RPATH to rocprofv3-trigger-list-metrics

- fixes packaging issues

* Update packaging

- core depends on rocprofiler-sdk-roctx
- add CPACK_DEBIAN_PACKAGE_SHLIBDEPS_PRIVATE_DIRS to resolve inter-package dependencies

* Fix package depends version format

* Improve tests/rocprofv3/summary/validate logging

* Update CI workflow

- prioritize roctx package in Install Packages step

* Remove setting <package-name>_VERSION in config.cmake.in

- this is automatically handled by existence of <package-name>-config-version.cmake

* Update rocprofiler-sdk-config.cmake

- relax find_package versioning requirements to same major and minor version

* Update rocprofiler-sdk-config.cmake

- relax find_package versioning requirements (remove EXACT, specify range)

* Tweak CI workflow

* Update perfetto_reader.py

- better handle failure to load trace processor

* Misc cleanup for config packaging

* Update config packaging

* Update config packaging

* Revert perfetto for core-rpm packages

* Revert perfetto for core-rpm packages

- perfetto < 0.9.0

* Tweak tests/rocprofv3/summary/validate.py

- reorder some checks

---------

Co-authored-by: Ammar Elwazir <aelwazir@useocpm2m-387-013.amd.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

Clang Warning Fixes (#1131)

Builds prevented on clang-18

Adding start and end timestamp columns in csv (#1128)

* Adding start and end timestamp columns in csv

* Adding assert check for the counter timestamps

---------

Co-authored-by: Gopesh Bhardwaj <gopesh.bhardwaj@amd.com>

rocprofv3: docs and help menu updates (#1129)

* doc updates

* Correcting ROCtx information

* Making ROCTx string consistent

* missing occurence

Renamed agent profiling service to device counting service (#1132)

* Renamed agent profiling service to device counting service

Name more aptly represents what agent profiling did (device wide
counter collection). Conversion of existing user code can be
performed by the following find/sed command:

find . -type f -exec sed -i 's/rocprofiler_agent_profile_callback_t/rocprofiler_device_counting_service_callback_t/g; s/rocprofiler_configure_agent_profile_counting_service/rocprofiler_configure_device_counting_service/g; s/agent_profile.h/device_counting_service.h/g; s/rocprofiler_sample_agent_profile_counting_service/rocprofiler_sample_device_counting_service/g' {} +

* Converted dispatch profile to dispatch counting service

* Debug for functioal counters test

* Minor changes for CI

* Minor fix

* More fixes for CI

* Update evaluate_ast.cpp

---------

Co-authored-by: Benjamin Welton <ben@amd.com>

Testing updated RPM dockers (#1136)

* Testing updated RPM dockers

* Trying to fix PSDB for test package dependency

Agent Profiling Fixes for Broken/Improper API Usage (#1122)

Prevent's multiple setups of agent profiling on the same agent.

Fixes agent read context to only read agents that were setup.

Prevent copy of agent profiling internal data struct and reset
hsa_signal on move to prevent inadvertant delete.

Simplifying PR template (#1139)

Implementation of ompt interface to rocprofiler SDK. task_create and task_schedule are not supported.

Fixing installed pacakge tests in CI (#1119)

* Fixing installed pacakge tests in CI

* Formatted rocprofv3.py with black formatter

Fix PSDB change (#1120)

Reverts change to `source/include/rocprofiler-sdk/callback_tracing.h`
from commit 9b2ece76c3

delete unused files

added arguments to some OMPT buffter records

* Fix cmake issues

Remove rocprofiler_ompt_finalize_tool

- a public API function is not necessary: should just finalize rocprofiler-sdk

Fix duplicate ROCPROFILER_{BUFFER,CALLBACK}_TRACING_KIND_STRING

Add lib/rocprofiler-sdk/ompt.hpp

- declares rocprofiler::sdk::finalize_ompt

Remove change to tests/rocprofv3/summary/conftest.py

Add set_fini_status(1) back to registration.cpp

Deleted uneeded files

Incoporate OpenMP code and sample

Fix merge issues with amd-staging

Add push_correlation_id for OpenMP tasking; improve debugability

fixup bad merge

* Suppress OpenMP data race

* Fix openmp_target sample

* Enum and struct name changes + source code reorg

- remove mix of ompt and openmp
  - opted for ompt
- changes made for consistency
  - ompt_api -> ompt
  - openmp_api -> ompt
  - OPENMP -> OMPT

* Update tests and more renaming

- dest_device_num -> dst_device_num
- src_addr -> src_address
- dest_addr -> dst_address
- remove info_type::begin
- require OMP_TARGET_OFFLOAD

* Update openmp-target test/sample env and labels

* Formatting

* Tweaks to cmake for openmp target

- Disable for thread sanitizers due to preloading issue

* OpenMP target cmake updates

- remove gfx1010 (fails on mi300)
- OPENMP_GPU_TARGETS

* Remove device_unload and target_map_emi support

- these are never supported by AMD OpenMP compilers

* Update CI workflow

- exclude openmp-target tests from navi3 and vega20

---------

Co-authored-by: Larry Meadows <Lawrence.Meadows@amd.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2024-12-05 22:48:19 -06:00

201 строка
8.2 KiB
C++

// mit license
//
// copyright (c) 2023 advanced micro devices, inc. all rights reserved.
//
// permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "software"), to deal
// in the software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the software, and to permit persons to whom the software is
// furnished to do so, subject to the following conditions:
//
// the above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the software.
//
// the software is provided "as is", without warranty of any kind, express or
// implied, including but not limited to the warranties of merchantability,
// fitness for a particular purpose and noninfringement. in no event shall the
// authors or copyright holders be liable for any claim, damages or other
// liability, whether in an action of contract, tort or otherwise, arising from,
// out of or in connection with the software or the use or other dealings in
// the software.
#pragma once
#include "lib/rocprofiler-sdk/context/correlation_id.hpp"
#include "lib/rocprofiler-sdk/tracing/fwd.hpp"
#include <rocprofiler-sdk/buffer_tracing.h>
#include <rocprofiler-sdk/callback_tracing.h>
#include <rocprofiler-sdk/external_correlation.h>
#include <rocprofiler-sdk/fwd.h>
#include <rocprofiler-sdk/ompt.h>
#include <rocprofiler-sdk/ompt/api_id.h>
#include <rocprofiler-sdk/ompt/omp-tools.h>
#include <cstdint>
#include <deque>
#include <vector>
namespace rocprofiler
{
namespace ompt
{
struct ompt_table
{
ompt_callback_thread_begin_t ompt_thread_begin_fn = nullptr;
ompt_callback_thread_end_t ompt_thread_end_fn = nullptr;
ompt_callback_parallel_begin_t ompt_parallel_begin_fn = nullptr;
ompt_callback_parallel_end_t ompt_parallel_end_fn = nullptr;
ompt_callback_task_create_t ompt_task_create_fn = nullptr;
ompt_callback_task_schedule_t ompt_task_schedule_fn = nullptr;
ompt_callback_implicit_task_t ompt_implicit_task_fn = nullptr;
ompt_callback_device_initialize_t ompt_device_initialize_fn = nullptr;
ompt_callback_device_finalize_t ompt_device_finalize_fn = nullptr;
ompt_callback_device_load_t ompt_device_load_fn = nullptr;
// ompt_callback_device_unload_t ompt_device_unload_fn = nullptr;
ompt_callback_sync_region_t ompt_sync_region_wait_fn = nullptr;
ompt_callback_mutex_t ompt_mutex_released_fn = nullptr;
ompt_callback_dependences_t ompt_dependences_fn = nullptr;
ompt_callback_task_dependence_t ompt_task_dependence_fn = nullptr;
ompt_callback_work_t ompt_work_fn = nullptr;
ompt_callback_masked_t ompt_masked_fn = nullptr;
ompt_callback_target_map_t ompt_target_map_fn = nullptr;
ompt_callback_sync_region_t ompt_sync_region_fn = nullptr;
ompt_callback_mutex_acquire_t ompt_lock_init_fn = nullptr;
ompt_callback_mutex_t ompt_lock_destroy_fn = nullptr;
ompt_callback_mutex_acquire_t ompt_mutex_acquire_fn = nullptr;
ompt_callback_mutex_t ompt_mutex_acquired_fn = nullptr;
ompt_callback_nest_lock_t ompt_nest_lock_fn = nullptr;
ompt_callback_flush_t ompt_flush_fn = nullptr;
ompt_callback_cancel_t ompt_cancel_fn = nullptr;
ompt_callback_sync_region_t ompt_reduction_fn = nullptr;
ompt_callback_dispatch_t ompt_dispatch_fn = nullptr;
ompt_callback_target_emi_t ompt_target_emi_fn = nullptr;
ompt_callback_target_data_op_emi_t ompt_target_data_op_emi_fn = nullptr;
ompt_callback_target_submit_emi_t ompt_target_submit_emi_fn = nullptr;
// ompt_callback_target_map_emi_t ompt_target_map_emi_fn = nullptr;
ompt_callback_error_t ompt_error_fn = nullptr;
};
struct ompt_domain_info
{
using args_type = rocprofiler_ompt_args_t;
using retval_type = void;
using callback_data_type = rocprofiler_callback_tracing_ompt_data_t;
using buffer_data_type = rocprofiler_buffer_tracing_ompt_record_t;
using enum_type = rocprofiler_ompt_operation_t;
static constexpr auto callback_domain_idx = ROCPROFILER_CALLBACK_TRACING_OMPT;
static constexpr auto buffered_domain_idx = ROCPROFILER_BUFFER_TRACING_OMPT;
static constexpr auto none = ROCPROFILER_OMPT_ID_NONE;
static constexpr auto last = ROCPROFILER_OMPT_ID_LAST;
static constexpr auto ompt_last = ROCPROFILER_OMPT_ID_callback_functions;
static constexpr auto external_correlation_id_domain_idx =
ROCPROFILER_EXTERNAL_CORRELATION_REQUEST_OMPT;
};
using buffer_ompt_record_t = rocprofiler_buffer_tracing_ompt_record_t;
using callback_ompt_data_t = rocprofiler_callback_tracing_ompt_data_t;
// save state for ompt between callbacks
struct ompt_save_state
{
uint64_t thr_id; // thread this was created on
uint64_t start_timestamp; // timestamp when it was created
rocprofiler_ompt_operation_t operation_idx; // for error checking
context::correlation_id* corr_id; // correlation id
tracing::external_correlation_id_map_t external_corr_ids;
tracing::callback_context_data_vec_t callback_contexts;
tracing::buffered_context_data_vec_t buffered_contexts;
};
// proxy for ompt_data_t pointers received from OMPT callbacks
// SDK gets index 0, client get index 1
class ompt_data_proxy
{
public:
ompt_data_t* get_client_ptr(ompt_data_t* ompt_ptr) { return get<1>(ompt_ptr); }
ompt_data_t* get_internal_ptr(ompt_data_t* ompt_ptr) { return get<0>(ompt_ptr); }
private:
struct proxy_ptrs
{
std::array<ompt_data_t, 2> v;
};
// get the proxy pointer for idx. If ompt_ptr->ptr is 0,
// allocate a new proxy struct and assign it to ompt_ptr->ptr
// return the address of the requested proxy element,
// or null if ompt_ptr is null
template <int idx>
ompt_data_t* get(ompt_data_t* ompt_ptr)
{
static constexpr proxy_ptrs nulval{};
if(ompt_ptr == nullptr) return nullptr;
if(ompt_ptr->ptr == nullptr)
{
std::lock_guard<std::mutex> lk(m);
ompt_ptr->ptr = &proxies.emplace_back(nulval);
}
auto* ptr = static_cast<proxy_ptrs*>(ompt_ptr->ptr);
return &(ptr->v[idx]);
}
std::deque<proxy_ptrs> proxies;
std::mutex m;
};
// function to return client pointer for use outside
ompt_data_t*
proxy_data_ptr(ompt_data_t* real_ptr);
struct ompt_task_save_state
{
context::correlation_id* corr_id;
int task_flags;
};
template <size_t opidx>
struct ompt_impl
{
template <typename DataArgst, typename... Args>
static void set_data_args(DataArgst&, Args... args);
template <typename... Args>
static void begin(ompt_data_t* data, Args... args);
template <typename... Args>
static void end(ompt_data_t* data, Args... args);
template <typename... Args>
static context::correlation_id* event_common(Args... args);
template <typename... Args>
static void event(Args&&... args);
};
template <size_t OpIdx>
struct ompt_info;
const char*
name_by_id(uint32_t id);
std::vector<uint32_t>
get_ids();
void
iterate_args(uint32_t id,
const rocprofiler_callback_tracing_ompt_data_t& data,
rocprofiler_callback_tracing_operation_args_cb_t callback,
int32_t max_deref,
void* user_data);
using ompt_update_func = void (*)(const char* cbname, ompt_callback_t* cbf, int cbnum);
void update_table(ompt_update_func);
void
update_callback(rocprofiler_ompt_callback_functions_t& cb_functions);
} // namespace ompt
} // namespace rocprofiler