Jaydeep Patel
be88e1dffc
https://gerrit-git.amd.com/c/compute/ec/clr/+/849086 changed stream sync behaviour and accordingly updated Unit_hipStreamCreateWithFlags_DefaultStreamInteraction. Update error code to match for hipStreamWaitEvent. Thread detach makes executions all async and while that is happening, It is unexpected effect for device reset so join thread is better. Change-Id: I1affa84089626dee478d8bcc5aaa318e320fd6b0
103 lines
3.8 KiB
C++
103 lines
3.8 KiB
C++
/*
|
|
Copyright (c) 2021 Advanced Micro Devices, Inc. All rights reserved.
|
|
Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
of this software and associated documentation files (the "Software"), to deal
|
|
in the Software without restriction, including without limitation the rights
|
|
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
copies of the Software, and to permit persons to whom the Software is
|
|
furnished to do so, subject to the following conditions:
|
|
The above copyright notice and this permission notice shall be included in
|
|
all copies or substantial portions of the Software.
|
|
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANNTY OF ANY KIND, EXPRESS OR
|
|
IMPLIED, INNCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
FITNNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANNY CLAIM, DAMAGES OR OTHER
|
|
LIABILITY, WHETHER INN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
OUT OF OR INN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
THE SOFTWARE.
|
|
*/
|
|
|
|
#include <hip_test_common.hh>
|
|
#include <vector>
|
|
#include <thread>
|
|
|
|
/*
|
|
hipDeviceReset deletes all active streams including hipStreamPerThread.
|
|
Scenario: App calls hipDeviceReset while in other thread some Async operation is in
|
|
progress on hipStreamPerThread.
|
|
Watch out: hipDeviceRest should be successfull without any crash
|
|
*/
|
|
static void Copy_to_device() {
|
|
unsigned int ele_size = (32 * 1024); // 32KB
|
|
int* A_h = nullptr;
|
|
int* A_d = nullptr;
|
|
|
|
hipError_t status = hipHostMalloc(&A_h, ele_size*sizeof(int));
|
|
if (status != hipSuccess) return;
|
|
|
|
status = hipMalloc(&A_d, ele_size * sizeof(int));
|
|
if (status != hipSuccess) return;
|
|
|
|
for(unsigned int i = 0; i < ele_size; ++i) {
|
|
A_h[i] = 123;
|
|
}
|
|
HIP_CHECK(hipMemcpyAsync(A_d, A_h, ele_size * sizeof(int), hipMemcpyHostToDevice,
|
|
hipStreamPerThread));
|
|
}
|
|
|
|
TEST_CASE("Unit_hipStreamPerThread_DeviceReset_1") {
|
|
constexpr unsigned int MAX_THREAD_CNT = 10;
|
|
std::vector<std::thread> threads(MAX_THREAD_CNT);
|
|
|
|
for (auto &th : threads) {
|
|
th = std::thread(Copy_to_device);
|
|
}
|
|
for (auto &th : threads) {
|
|
th.join();
|
|
}
|
|
|
|
HIP_CHECK(hipDeviceReset());
|
|
}
|
|
|
|
/*
|
|
hipDeviceReset deletes all active streams including hipStreamPerThread.
|
|
Scenario: i) Launch Async task on hipStreamPerThread and waits for it to complete.
|
|
ii) Call hipDeviceReset to delete all active stream
|
|
iii) Again try to launch Async task on hipStreamPerThread
|
|
Watch out: Since hipStreamPerThread is an implicit stream hence even after device reset
|
|
it should available to use.
|
|
*/
|
|
TEST_CASE("Unit_hipStreamPerThread_DeviceReset_2") {
|
|
unsigned int ele_size = (32 * 1024); // 32KB
|
|
int* A_h = nullptr;
|
|
int* A_d = nullptr;
|
|
|
|
hipError_t status = hipHostMalloc(&A_h, ele_size*sizeof(int));
|
|
if (status != hipSuccess) return;
|
|
status = hipMalloc(&A_d, ele_size * sizeof(int));
|
|
if (status != hipSuccess) return;
|
|
|
|
for (unsigned int i = 0; i < ele_size; ++i) {
|
|
A_h[i] = 123;
|
|
}
|
|
status = hipMemcpyAsync(A_d, A_h, ele_size * sizeof(int), hipMemcpyHostToDevice,
|
|
hipStreamPerThread);
|
|
if (status != hipSuccess) return;
|
|
HIP_CHECK(hipStreamSynchronize(hipStreamPerThread));
|
|
|
|
HIP_CHECK(hipDeviceReset());
|
|
|
|
// After reset all memory objects will be destroyed hence allocating them again
|
|
// Intension is to use hipStreamPerThread successfully after reset hence not validating
|
|
// values after copy
|
|
status = hipHostMalloc(&A_h, ele_size*sizeof(int));
|
|
if (status != hipSuccess) return;
|
|
status = hipMalloc(&A_d, ele_size * sizeof(int));
|
|
if (status != hipSuccess) return;
|
|
|
|
status = hipMemcpyAsync(A_d, A_h, ele_size * sizeof(int), hipMemcpyHostToDevice,
|
|
hipStreamPerThread);
|
|
if (status != hipSuccess) return;
|
|
HIP_CHECK(hipStreamSynchronize(hipStreamPerThread));
|
|
}
|