d85657e5f2
RAS plugin loaded rocm-smi which is in conflict with amd-smi library Main source of grief was the map 'devInfoTypesStrings' that is defined in both rocm-smi and amd-smi We assume that rocm-smi would get lazy-loaded by RAS library and overwrite symbols defined in amd-smi. devInfoTypesStrings in rocm-smi contains different number of elements, the enums are also different. RDC relies on amd-smi's enums. One such enum is kDevGpuMetrics: rocm-smi: kDevGpuMetrics = 68 amd-smi: kDevGpuMetrics = 75 Example of overlapping map definitions: $ objdump --dynamic-syms /opt/rocm/lib/libamd_smi.so | grep devInfoTypesStrings 00000000003c4980 g DO .data.rel.ro0000000000000008 Base devInfoTypesStrings 00000000003db830 g DO .bss0000000000000030 Base _ZN3amd3smi6Device19devInfoTypesStringsE $ objdump --dynamic-syms /opt/rocm/lib/librocm_smi64.so | grep devInfoTypesStrings 00000000003dc590 g DO .bss0000000000000030 Base _ZN3amd3smi6Device19devInfoTypesStringsE 00000000003c9c68 g DO .data.rel.ro0000000000000008 Base devInfoTypesStrings Change-Id: Ib2f2db32b6abd7ebe84e7807c25581461eb86bae Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
155 lines
5.7 KiB
C++
155 lines
5.7 KiB
C++
/*
|
|
Copyright (c) 2020 - present Advanced Micro Devices, Inc. All rights reserved.
|
|
|
|
Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
of this software and associated documentation files (the "Software"), to deal
|
|
in the Software without restriction, including without limitation the rights
|
|
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
copies of the Software, and to permit persons to whom the Software is
|
|
furnished to do so, subject to the following conditions:
|
|
|
|
The above copyright notice and this permission notice shall be included in
|
|
all copies or substantial portions of the Software.
|
|
|
|
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
THE SOFTWARE.
|
|
*/
|
|
#include "rdc_lib/impl/RdcTelemetryModule.h"
|
|
|
|
#include <memory>
|
|
|
|
#include "rdc_lib/RdcException.h"
|
|
#include "rdc_lib/RdcLogger.h"
|
|
#include "rdc_lib/RdcMetricFetcher.h"
|
|
#include "rdc_lib/impl/RdcSmiLib.h"
|
|
|
|
namespace amd {
|
|
namespace rdc {
|
|
|
|
// Return all supported fields
|
|
rdc_status_t RdcTelemetryModule::rdc_telemetry_fields_query(uint32_t field_ids[MAX_NUM_FIELDS],
|
|
uint32_t* field_count) {
|
|
if (field_count == nullptr) {
|
|
return RDC_ST_BAD_PARAMETER;
|
|
}
|
|
auto ite = telemetry_modules_.begin();
|
|
*field_count = 0;
|
|
for (; ite != telemetry_modules_.end(); ite++) {
|
|
uint32_t count = 0;
|
|
rdc_status_t status = (*ite)->rdc_telemetry_fields_query(&(field_ids[*field_count]), &count);
|
|
if (status == RDC_ST_OK) {
|
|
*field_count += count;
|
|
}
|
|
}
|
|
|
|
return RDC_ST_OK;
|
|
}
|
|
|
|
rdc_status_t RdcTelemetryModule::rdc_telemetry_fields_watch(rdc_gpu_field_t* fields,
|
|
uint32_t fields_count) {
|
|
if (fields == nullptr) {
|
|
return RDC_ST_BAD_PARAMETER;
|
|
}
|
|
|
|
std::map<RdcTelemetryPtr, std::vector<rdc_gpu_field_t>> fields_in_module;
|
|
std::vector<rdc_gpu_field_value_t> unsupport_fields;
|
|
get_fields_for_module(fields, fields_count, fields_in_module, unsupport_fields);
|
|
|
|
auto ite = fields_in_module.begin();
|
|
for (; ite != fields_in_module.end(); ite++) {
|
|
if (ite->second.size() > 0) {
|
|
ite->first->rdc_telemetry_fields_watch(&ite->second[0], ite->second.size());
|
|
}
|
|
}
|
|
|
|
return RDC_ST_OK;
|
|
}
|
|
|
|
rdc_status_t RdcTelemetryModule::rdc_telemetry_fields_unwatch(rdc_gpu_field_t* fields,
|
|
uint32_t fields_count) {
|
|
if (fields == nullptr) {
|
|
return RDC_ST_BAD_PARAMETER;
|
|
}
|
|
|
|
std::map<RdcTelemetryPtr, std::vector<rdc_gpu_field_t>> fields_in_module;
|
|
std::vector<rdc_gpu_field_value_t> unsupport_fields;
|
|
get_fields_for_module(fields, fields_count, fields_in_module, unsupport_fields);
|
|
|
|
auto ite = fields_in_module.begin();
|
|
for (; ite != fields_in_module.end(); ite++) {
|
|
if (ite->second.size() > 0) {
|
|
ite->first->rdc_telemetry_fields_unwatch(&ite->second[0], ite->second.size());
|
|
}
|
|
}
|
|
|
|
return RDC_ST_OK;
|
|
}
|
|
|
|
RdcTelemetryModule::RdcTelemetryModule(std::list<RdcTelemetryPtr> telemetry_modules)
|
|
: telemetry_modules_(telemetry_modules) {
|
|
auto ite = telemetry_modules_.begin();
|
|
for (; ite != telemetry_modules_.end(); ite++) {
|
|
uint32_t field_ids[MAX_NUM_FIELDS];
|
|
uint32_t field_count = 0;
|
|
rdc_status_t status = (*ite)->rdc_telemetry_fields_query(field_ids, &field_count);
|
|
if (status == RDC_ST_OK) {
|
|
for (uint32_t index = 0; index < field_count; index++) {
|
|
fields_id_module_.insert({field_ids[index], (*ite)});
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
void RdcTelemetryModule::get_fields_for_module(
|
|
rdc_gpu_field_t* fields, uint32_t fields_count,
|
|
std::map<RdcTelemetryPtr, std::vector<rdc_gpu_field_t>>& fields_in_module,
|
|
std::vector<rdc_gpu_field_value_t>& unsupport_fields) {
|
|
for (uint32_t findex = 0; findex < fields_count; findex++) {
|
|
RdcTelemetryPtr module = fields_id_module_[fields[findex].field_id];
|
|
if (module) {
|
|
fields_in_module[module].push_back(fields[findex]);
|
|
} else {
|
|
RDC_LOG(RDC_DEBUG, "Unsupported field " << field_id_string(fields[findex].field_id));
|
|
rdc_gpu_field_value_t value;
|
|
value.gpu_index = fields[findex].gpu_index;
|
|
value.field_value.field_id = fields[findex].field_id;
|
|
value.field_value.status = RDC_ST_NOT_SUPPORTED;
|
|
unsupport_fields.push_back(value);
|
|
}
|
|
}
|
|
}
|
|
|
|
rdc_status_t RdcTelemetryModule::rdc_telemetry_fields_value_get(rdc_gpu_field_t* fields,
|
|
uint32_t fields_count,
|
|
rdc_field_value_f callback,
|
|
void* user_data) {
|
|
if (fields == nullptr) {
|
|
return RDC_ST_BAD_PARAMETER;
|
|
}
|
|
|
|
// Dispatch the fields to the libraries
|
|
std::map<RdcTelemetryPtr, std::vector<rdc_gpu_field_t>> fields_to_fetch;
|
|
std::vector<rdc_gpu_field_value_t> unsupport_fields;
|
|
get_fields_for_module(fields, fields_count, fields_to_fetch, unsupport_fields);
|
|
|
|
auto ite = fields_to_fetch.begin();
|
|
for (; ite != fields_to_fetch.end(); ite++) {
|
|
rdc_gpu_field_t f[MAX_NUM_FIELDS];
|
|
std::copy(ite->second.begin(), ite->second.end(), f);
|
|
ite->first->rdc_telemetry_fields_value_get(f, ite->second.size(), callback, user_data);
|
|
}
|
|
|
|
// Notify the caller unsupported fields
|
|
callback(&unsupport_fields[0], unsupport_fields.size(), user_data);
|
|
|
|
return RDC_ST_OK;
|
|
}
|
|
|
|
} // namespace rdc
|
|
} // namespace amd
|