391451752b
Changes:
- Updated AMD SMI firmware to display "N/A" for unavailable firmware in partitioned environments, improving clarity.
Example (in DPX):
$ amd-smi firmware
GPU: 0
FW_LIST:
...
FW 12:
FW_ID: PM
FW_VERSION: 00.86.39.00
GPU: 1
FW_LIST: N/A
- Fixed amd-smi partition not showing current partition information on
asics with inablity to set memory or accelerator partitions.
$ amd-smi partition -c -m
CURRENT_PARTITION:
GPU_ID MEMORY ACCELERATOR_TYPE ACCELERATOR_PROFILE_INDEX PARTITION_ID
0 NPS1 CPX 2 0
1 N/A N/A N/A 1
2 N/A N/A N/A 2
3 N/A N/A N/A 3
4 N/A N/A N/A 4
5 N/A N/A N/A 5
6 NPS1 SPX 0 0
7 NPS1 SPX 0 0
8 NPS1 SPX 0 0
MEMORY_PARTITION:
GPU_ID MEMORY_PARTITION_CAPS CURRENT_MEMORY_PARTITION
0 N/A NPS1
1 N/A N/A
2 N/A N/A
3 N/A N/A
4 N/A N/A
5 N/A N/A
6 N/A NPS1
7 N/A NPS1
8 N/A NPS1
- Refactored amd_smi_drm_example.cc:
- Grouped partition changes and restores original partition settings.
- Now handles partitioned environments allowing example to continue even if some APIs are not supported in partitioned configurations.
- Modified amdsmi_asic_info_t (see amdsmi_get_gpu_asic_info()) to report OAM ID as N/A if 0xFFFFFFFF (was 0xFFFF).
Allows for better handling of OAM IDs in partitioned environments (DNE for non-primary nodes,
since its a physical identifier). Easier to handle in tests and example code (ie. now consistent w/ max size of the structure's value).
- Introduced amdsmi_RAII_open_FD() (internal API) to manage file descriptors using RAII, ensuring proper closure and preventing resource leaks.
Updated the following APIs to use this function:
- amdsmi_get_gpu_asic_info(), amdsmi_get_gpu_vram_usage(),
amdsmi_get_gpu_vram_info(), amdsmi_get_gpu_vbios_info(),
amdsmi_get_gpu_driver_info(), amdsmi_get_gpu_virtualization_mode()
- Updated AMD SMI test_base.cc/.h:
- Improved output and handling for partitioned environments.
- Added detailed ASIC information logging to align with structure changes.
- Enhanced error messages for better context before ASSERT checks.
- Resolved test failures in partitioned environments by updating
logic and handling for partition-specific configurations.
Fixed tests include:
- computepartition_read_write.cc, frequencies_read_write.cc,
gpu_metrics_read.cc, mem_util_read.cc, memorypartition_read_write.cc,
perf_level_read.cc, perf_level_read_write.cc, power_cap_read_write.cc,
power_read.cc, sys_info_read.cc, gpu_busy_read.cc
Change-Id: I36e903f8fddd714c74c719459c71aba8bbb77e6f
Signed-off-by: Charis Poag <Charis.Poag@amd.com>
Resetting head + adding fixes for tests ran in partitions
Change-Id: I0c1e9ac07488b50c95f3bc6d8a724e67d2c715dc
Signed-off-by: Charis Poag <Charis.Poag@amd.com>
209 строки
7.5 KiB
C++
209 строки
7.5 KiB
C++
/*
|
|
* Copyright (c) Advanced Micro Devices, Inc. All rights reserved.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
|
|
#include <stdint.h>
|
|
#include <stddef.h>
|
|
|
|
#include <iostream>
|
|
#include <map>
|
|
#include <bitset>
|
|
#include <string>
|
|
#include <algorithm>
|
|
|
|
#include <gtest/gtest.h>
|
|
#include "amd_smi/amdsmi.h"
|
|
#include "amd_smi/impl/amd_smi_utils.h"
|
|
#include "frequencies_read_write.h"
|
|
#include "../test_common.h"
|
|
|
|
|
|
TestFrequenciesReadWrite::TestFrequenciesReadWrite() : TestBase() {
|
|
set_title("AMDSMI Frequencies Read/Write Test");
|
|
set_description("The Frequencies tests verify that the frequency "
|
|
"settings can be read and controlled properly.");
|
|
}
|
|
|
|
TestFrequenciesReadWrite::~TestFrequenciesReadWrite(void) {
|
|
}
|
|
|
|
void TestFrequenciesReadWrite::SetUp(void) {
|
|
TestBase::SetUp();
|
|
|
|
return;
|
|
}
|
|
|
|
void TestFrequenciesReadWrite::DisplayTestInfo(void) {
|
|
TestBase::DisplayTestInfo();
|
|
}
|
|
|
|
void TestFrequenciesReadWrite::DisplayResults(void) const {
|
|
TestBase::DisplayResults();
|
|
return;
|
|
}
|
|
|
|
void TestFrequenciesReadWrite::Close() {
|
|
// This will close handles opened within rsmitst utility calls and call
|
|
// amdsmi_shut_down(), so it should be done after other hsa cleanup
|
|
TestBase::Close();
|
|
}
|
|
|
|
|
|
void TestFrequenciesReadWrite::Run(void) {
|
|
amdsmi_status_t ret;
|
|
amdsmi_frequencies_t f;
|
|
uint32_t freq_bitmask;
|
|
amdsmi_clk_type_t amdsmi_clk;
|
|
const std::map<amdsmi_clk_type_t, std::string> clk_type_map = {
|
|
{AMDSMI_CLK_TYPE_SYS, "SYS"},
|
|
{AMDSMI_CLK_TYPE_GFX, "GFX"},
|
|
{AMDSMI_CLK_TYPE_DF, "DF"},
|
|
{AMDSMI_CLK_TYPE_DCEF, "DCEF"},
|
|
{AMDSMI_CLK_TYPE_SOC, "SOC"},
|
|
{AMDSMI_CLK_TYPE_MEM, "MEM"},
|
|
{AMDSMI_CLK_TYPE_PCIE, "PCIE"},
|
|
{AMDSMI_CLK_TYPE_VCLK0, "VCLK0"},
|
|
{AMDSMI_CLK_TYPE_VCLK1, "VCLK1"},
|
|
{AMDSMI_CLK_TYPE_DCLK0, "DCLK0"},
|
|
{AMDSMI_CLK_TYPE_DCLK1, "DCLK1"},
|
|
};
|
|
|
|
TestBase::Run();
|
|
if (setup_failed_) {
|
|
std::cout << "** SetUp Failed for this test. Skipping.**" << std::endl;
|
|
return;
|
|
}
|
|
|
|
for (uint32_t dv_ind = 0; dv_ind < num_monitor_devs(); ++dv_ind) {
|
|
PrintDeviceHeader(processor_handles_[dv_ind]);
|
|
|
|
for (uint32_t clk = AMDSMI_CLK_TYPE_FIRST; clk <= AMDSMI_CLK_TYPE__MAX; ++clk) {
|
|
amdsmi_clk = (amdsmi_clk_type_t)clk;
|
|
|
|
auto freq_read = [&]() -> bool {
|
|
// Skip AMDSMI_CLK_TYPE_PCIE, which does not supported in rocm-smi.
|
|
if (auto it = clk_type_map.find(amdsmi_clk); it != clk_type_map.end()) {
|
|
if (amdsmi_clk == AMDSMI_CLK_TYPE_PCIE) {
|
|
return false; // Quietly skip PCIE clock
|
|
// Cannot read/write to PCIE clock in driver
|
|
}
|
|
std::cout << "amdsmi_get_clk_freq(" << it->second << ", f)";
|
|
}
|
|
|
|
ret = amdsmi_get_clk_freq(processor_handles_[dv_ind], amdsmi_clk, &f);
|
|
if (auto it = clk_type_map.find(amdsmi_clk); it != clk_type_map.end()) {
|
|
std::cout << ": " << smi_amdgpu_get_status_string(ret, false) << std::endl;
|
|
}
|
|
|
|
if (ret == AMDSMI_STATUS_NOT_SUPPORTED ||
|
|
ret == AMDSMI_STATUS_NOT_YET_IMPLEMENTED) {
|
|
std::cout << "\t**Set " << FreqEnumToStr(amdsmi_clk) <<
|
|
": Not supported on this machine" << std::endl;
|
|
return false;
|
|
}
|
|
|
|
// special driver issue, shouldn't normally occur
|
|
if (ret == AMDSMI_STATUS_UNEXPECTED_DATA) {
|
|
std::cerr << "WARN: Clock file [" << FreqEnumToStr(amdsmi_clk) << "] exists on device [" << dv_ind << "] but empty!" << std::endl;
|
|
std::cerr << " Likely a driver issue!" << std::endl;
|
|
}
|
|
|
|
// CHK_ERR_ASRT(ret)
|
|
IF_VERB(STANDARD) {
|
|
std::cout << "Initial frequency for clock " <<
|
|
FreqEnumToStr(amdsmi_clk) << " is " << f.current << std::endl;
|
|
}
|
|
return true;
|
|
};
|
|
|
|
auto freq_write = [&]() {
|
|
// Set clocks to something other than the usual default of the lowest
|
|
// frequency.
|
|
// Skip AMDSMI_CLK_TYPE_PCIE, which does not supported in rocm-smi.
|
|
if (amdsmi_clk == AMDSMI_CLK_TYPE_PCIE)
|
|
return;
|
|
|
|
freq_bitmask = 0b01100; // Try the 3rd and 4th clocks
|
|
|
|
std::string freq_bm_str =
|
|
std::bitset<AMDSMI_MAX_NUM_FREQUENCIES>(freq_bitmask).to_string();
|
|
|
|
freq_bm_str.erase(0, std::min(freq_bm_str.find_first_not_of('0'),
|
|
freq_bm_str.size()-1));
|
|
|
|
IF_VERB(STANDARD) {
|
|
std::cout << "Setting frequency mask for " <<
|
|
FreqEnumToStr(amdsmi_clk) << " to 0b" << freq_bm_str << " ..." <<
|
|
std::endl;
|
|
}
|
|
ret = amdsmi_set_clk_freq(processor_handles_[dv_ind], amdsmi_clk, freq_bitmask);
|
|
// Certain ASICs does not allow to set particular clocks. If set function for a clock returns
|
|
// permission error despite root access, manually set ret value to success and return
|
|
//
|
|
// Sometimes setting clock frequencies is completely not supported
|
|
if ((ret == AMDSMI_STATUS_NO_PERM && geteuid() == 0) ||
|
|
(ret == AMDSMI_STATUS_NOT_SUPPORTED)) {
|
|
std::cout << "\t**Set " << FreqEnumToStr(amdsmi_clk) <<
|
|
": Not supported on this machine. Skipping..." << std::endl;
|
|
ret = AMDSMI_STATUS_SUCCESS;
|
|
return;
|
|
}
|
|
|
|
CHK_ERR_ASRT(ret)
|
|
ret = amdsmi_get_clk_freq(processor_handles_[dv_ind], amdsmi_clk, &f);
|
|
if (ret != AMDSMI_STATUS_SUCCESS) {
|
|
return;
|
|
}
|
|
|
|
IF_VERB(STANDARD) {
|
|
std::cout << "Frequency is now index " << f.current << std::endl;
|
|
std::cout << "Resetting mask to all frequencies." << std::endl;
|
|
}
|
|
ret = amdsmi_set_clk_freq(processor_handles_[dv_ind], amdsmi_clk, 0xFFFFFFFF);
|
|
if (ret == AMDSMI_STATUS_NOT_SUPPORTED) {
|
|
std::cout << "\t**Set all frequencies: Not supported on this machine. Skipping..."
|
|
<< std::endl;
|
|
ret = AMDSMI_STATUS_SUCCESS;
|
|
return;
|
|
}
|
|
if (ret != AMDSMI_STATUS_SUCCESS) {
|
|
return;
|
|
}
|
|
|
|
ret = amdsmi_set_gpu_perf_level(processor_handles_[dv_ind], AMDSMI_DEV_PERF_LEVEL_AUTO);
|
|
if (ret == AMDSMI_STATUS_NOT_SUPPORTED) {
|
|
std::cout << "\t**Setting performance level is not supported on this machine. Skipping..." << std::endl;
|
|
ret = AMDSMI_STATUS_SUCCESS;
|
|
return;
|
|
}
|
|
};
|
|
|
|
if (freq_read()) {
|
|
CHK_ERR_ASRT(ret)
|
|
} else {
|
|
continue;
|
|
}
|
|
freq_write();
|
|
CHK_ERR_ASRT(ret)
|
|
}
|
|
}
|
|
}
|