Switch PAL to interface 610

Change-Id: Ida563f38513789f5ba105ac92a9737c59cd5d90d

rocclr/device/pal/palcdefs

@@ -1,3 +1,3 @@
 # PAL interface versions
-PAL_MAJOR_VERSION = 592
+PAL_MAJOR_VERSION = 610
 GPUOPEN_MAJOR_VERSION = 41

rocclr/device/pal/paldevice.cpp

@@ -902,10 +902,12 @@ bool Device::create(Pal::IDevice* device) {
   }
   appProfile_.init();
   device_ = device;
-  Pal::Result result;
 
   // Retrive device properties
-  result = iDev()->GetProperties(&properties_);
+  Pal::Result result = iDev()->GetProperties(&properties_);
+  if (result != Pal::Result::Success) {
+    return false;
+  }
 
   // Save the IP level for the offline detection
   ipLevel_ = properties().gfxLevel;
@@ -965,12 +967,14 @@ bool Device::create(Pal::IDevice* device) {
   palSettings->longRunningSubmissions = true;
   palSettings->cmdBufBatchedSubmitChainLimit = 0;
   palSettings->disableResourceProcessingManager = true;
-  palSettings->numScratchWavesPerCu = settings().numScratchWavesPerCu_;
   // Make sure CP DMA can be used for all possible transfers
   palSettings->cpDmaCmdCopyMemoryMaxBytes = 0xFFFFFFFF;
 
   // Commit the new settings for the device
   result = iDev()->CommitSettingsAndInit();
+  if (result != Pal::Result::Success) {
+    return false;
+  }
 
   iDev()->GetGpuMemoryHeapProperties(heaps_);
 

rocclr/device/pal/palvirtual.cpp

@@ -3636,11 +3636,6 @@ void VirtualGPU::buildKernelInfo(const HSAILKernel& hsaKernel, hsa_kernel_dispat
     dbgSetting.aclBinary_ = hsaKernel.prog().binaryElf();
     dbgSetting.event_ = enqueueEvent;
 
-    // Call the predispatch callback function & set the trap info
-    AqlCodeInfo aqlCodeInfo;
-    aqlCodeInfo.aqlCode_ = (amd_kernel_code_t*)hsaKernel.cpuAqlCode();
-    aqlCodeInfo.aqlCodeSize_ = hsaKernel.aqlCodeSize();
-
     // Execute the pre-dispatch call back function
     dbgManager->executePreDispatchCallBack(reinterpret_cast<void*>(aqlPkt), &dbgSetting);
 
@@ -3651,7 +3646,7 @@ void VirtualGPU::buildKernelInfo(const HSAILKernel& hsaKernel, hsa_kernel_dispat
 
     kernelInfo.trapPresent = (kernelInfo.trapHandler) ? true : false;
 
-    // Execption policy
+    // Exception policy
     kernelInfo.excpEn = dbgSetting.exceptionMask_;
     kernelInfo.cacheDisableMask = dbgSetting.cacheDisableMask_;
     kernelInfo.sqDebugMode = dbgSetting.gpuSingleStepMode_;