SWDEV-493299-Test Env variable to avoid silent errors with hipGetLastError feature

Change-Id: Iec5720021f626f2021595db5bb2d2c99c0deeefd

catch/unit/errorHandling/CMakeLists.txt

@@ -8,8 +8,11 @@ set(TEST_SRC
     hipGetLastError.cc
     hipPeekAtLastError.cc
 )
-
+add_executable(hipGetLastErrorEnv_Exe EXCLUDE_FROM_ALL hipGetLastErrorEnv_Exe.cc)
+add_executable(hipPeekAtLastErrorEnv_Exe EXCLUDE_FROM_ALL hipPeekAtLastErrorEnv_Exe.cc)
 hip_add_exe_to_target(NAME ErrorHandlingTest
                       TEST_SRC ${TEST_SRC}
                       TEST_TARGET_NAME build_tests
                       COMPILE_OPTIONS -std=c++17)
+
+add_dependencies(build_tests hipGetLastErrorEnv_Exe hipPeekAtLastErrorEnv_Exe)

catch/unit/errorHandling/hipGetLastErrorEnv_Exe.cc

@@ -0,0 +1,27 @@
+/*Copyright (c) 2024 Advanced Micro Devices, Inc. All rights reserved.
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+*/
+#include "hip/hip_runtime_api.h"
+#include <iostream>
+int main() {
+  hipError_t err;
+  err = hipGetLastError();
+  if (err == hipSuccess)
+    return 1;
+  else
+    return 0;
+}

catch/unit/errorHandling/hipPeekAtLastError.cc

@@ -1,16 +1,13 @@
 /*
-Copyright (c) 2022 Advanced Micro Devices, Inc. All rights reserved.
-
+Copyright (c) 2022-2024 Advanced Micro Devices, Inc. All rights reserved.
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
-
 The above copyright notice and this permission notice shall be included in
 all copies or substantial portions of the Software.
-
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
@@ -21,8 +18,15 @@ THE SOFTWARE.
 */
 
 #include <hip_test_common.hh>
+#include <hip_test_process.hh>
 #include <threaded_zig_zag_test.hh>
 
+#ifdef _WIN64
+#include <windows.h>
+#define setenv(x, y, z) _putenv_s(x, y)
+#define unsetenv(x) _putenv(x)
+#endif
+
 /**
  * @addtogroup hipPeekAtLastError hipPeekAtLastError
  * @{
@@ -34,7 +38,8 @@ THE SOFTWARE.
 /**
  * Test Description
  * ------------------------
- *  - Validate that `hipErrorInvalidValue` is returned after invalid `hipMalloc` call.
+ *  - Validate that `hipErrorInvalidValue` is returned after invalid `hipMalloc`
+ * call.
  *  - Validate that `hipSuccess` is returned again for getting the last error.
  * Test source
  * ------------------------
@@ -54,9 +59,10 @@ TEST_CASE("Unit_hipPeekAtLastError_Positive_Basic") {
 /**
  * Test Description
  * ------------------------
- *  - Validate that appropriate error is returned when working with multiple threads.
- *  - Validate that appropriate error is returned for getting the last error when working with
- * multiple threads.
+ *  - Validate that appropriate error is returned when working with multiple
+ * threads.
+ *  - Validate that appropriate error is returned for getting the last error
+ * when working with multiple threads.
  *  - Cause error on purpose within one of the threads.
  * Test source
  * ------------------------
@@ -66,21 +72,297 @@ TEST_CASE("Unit_hipPeekAtLastError_Positive_Basic") {
  *  - HIP_VERSION >= 5.2
  */
 TEST_CASE("Unit_hipPeekAtLastError_Positive_Threaded") {
-  class HipPeekAtLastErrorTest : public ThreadedZigZagTest<HipPeekAtLastErrorTest> {
+  class HipPeekAtLastErrorTest
+      : public ThreadedZigZagTest<HipPeekAtLastErrorTest> {
    public:
-    void TestPart2() { REQUIRE_THREAD(hipMalloc(nullptr, 1) == hipErrorInvalidValue); }
+    void TestPart2() {
+      REQUIRE_THREAD(hipMalloc(nullptr, 1) == hipErrorInvalidValue);
+    }
     void TestPart3() {
       HIP_CHECK(hipPeekAtLastError());
       HIP_CHECK(hipGetLastError());
     }
-    void TestPart4() { REQUIRE_THREAD(hipPeekAtLastError() == hipErrorInvalidValue); }
+    void TestPart4() {
+      REQUIRE_THREAD(hipPeekAtLastError() == hipErrorInvalidValue);
+    }
   };
 
   HipPeekAtLastErrorTest test;
   test.run();
 }
+/*
+ * New environment variable DEBUG_HIP_7_PREVIEW is added.
+ * This is used for enabling the backward incompatible changes before the next
+ * major ROCm release 7.0.
+ * This will be removed after the ROCm release 7.0.
+ */
+/**
+ * Test Description
+ * ------------------------
+ *  - With Env Var DEBUG_HIP_7_PREVIEW, Verify hipPeekAtLastError status
+ *    with hipMalloc api invalid arg call.
+ *    Status should be last Error reported in the thread/Runtime.
+ * Test source
+ * ------------------------
+ *  - unit/errorHandling/hipPeekAtLastError.cc
+ * Test requirements
+ * ------------------------
+ *  - HIP_VERSION >= 6.4
+ */
+TEST_CASE("Unit_hipPeekAtLastError_With_EnvVar_Positive_Basic") {
+  if (setenv("DEBUG_HIP_7_PREVIEW", "1", 1) == 0) {
+    HIP_CHECK_ERROR(hipMalloc(nullptr, 1), hipErrorInvalidValue);
+    int *A_d;
+    HIP_CHECK(hipMalloc(&A_d, 1024));
+    HIP_CHECK_ERROR(hipPeekAtLastError(), hipErrorInvalidValue);
+    HIP_CHECK(hipFree(A_d));
+    HIP_CHECK_ERROR(hipPeekAtLastError(), hipErrorInvalidValue);
+    HIP_CHECK_ERROR(hipPeekAtLastError(), hipErrorInvalidValue);
+    unsetenv("DEBUG_HIP_7_PREVIEW");
+  } else {
+    INFO("Env Not set");
+  }
+}
+/**
+ * Test Description
+ * ------------------------
+ *  - With Env Var DEBUG_HIP_7_PREVIEW, Verify hipPeekAtLastError status
+ *    with an Error - Success calls
+ *    Each time status should return the corresponding Error when it called.
+ * Test source
+ * ------------------------
+ *  - unit/errorHandling/hipPeekAtLastError.cc
+ * Test requirements
+ * ------------------------
+ *  - HIP_VERSION >= 6.4
+ */
+TEST_CASE("Unit_hipPeekAtLastError_With_EnvVar_Chk_Updated_Status") {
+  if (setenv("DEBUG_HIP_7_PREVIEW", "1", 1) == 0) {
+    hipGraph_t graph;
+    int value = 0;
+    HIP_CHECK_ERROR(hipGraphCreate(&graph, 1), hipErrorInvalidValue);
+    HIP_CHECK_ERROR(hipPeekAtLastError(), hipErrorInvalidValue);
+    int *C_d;
+    HIP_CHECK(hipMalloc(&C_d, 1024));
+    HIP_CHECK_ERROR(hipDeviceGetGraphMemAttribute(
+                        -1, hipGraphMemAttrUsedMemCurrent, &value),
+                    hipErrorInvalidDevice);
+    HIP_CHECK(hipFree(C_d));
+    HIP_CHECK_ERROR(hipPeekAtLastError(), hipErrorInvalidDevice);
+    unsetenv("DEBUG_HIP_7_PREVIEW");
+  } else {
+    INFO("Env Not set");
+  }
+}
+/**
+ * Test Description
+ * ------------------------
+ *  - With Env Var DEBUG_HIP_7_PREVIEW, Verify hipPeekAtLastError status
+ *    along with the hipGetLastError API call.
+ * Test source
+ * ------------------------
+ *  - unit/errorHandling/hipPeekAtLastError.cc
+ * Test requirements
+ * ------------------------
+ *  - HIP_VERSION >= 6.4
+ */
+TEST_CASE("Unit_hipPeekAtLastError_With_EnvVar_Chk_Along_hipGetLastError") {
+  if (setenv("DEBUG_HIP_7_PREVIEW", "1", 1) == 0) {
+    hipGraph_t graph;
+    HIP_CHECK_ERROR(hipGraphCreate(&graph, 1), hipErrorInvalidValue);
+    HIP_CHECK_ERROR(hipGetLastError(), hipErrorInvalidValue);
+    HIP_CHECK_ERROR(hipGetLastError(), hipSuccess);
+    int *C_d;
+    HIP_CHECK_ERROR(hipPeekAtLastError(), hipSuccess);
+    HIP_CHECK(hipMalloc(&C_d, 1024));
+    HIP_CHECK(hipFree(C_d));
+    HIP_CHECK_ERROR(hipPeekAtLastError(), hipSuccess);
+    unsetenv("DEBUG_HIP_7_PREVIEW");
+  } else {
+    INFO("Env Not set");
+  }
+}
 
 /**
-* End doxygen group ErrorTest.
-* @}
-*/
+ * Test Description
+ * ------------------------
+ *  - With Env Var DEBUG_HIP_7_PREVIEW, Verify hipPeekAtLastError status
+ *    with different Error and Success combinations.
+ *    Each time status should return the corresponding Error when it called.
+ * Test source
+ * ------------------------
+ *  - unit/errorHandling/hipPeekAtLastError.cc
+ * Test requirements
+ * ------------------------
+ *  - HIP_VERSION >= 6.4
+ */
+TEST_CASE("Unit_hipPeekAtLastError_With_EnvVar_Error_Combinations") {
+  int value = 0;
+  hipGraph_t graph;
+  SECTION("A case with Error-Error-Success-Success") {
+    if (setenv("DEBUG_HIP_7_PREVIEW", "1", 1) == 0) {
+      HIP_CHECK(hipPeekAtLastError());
+      HIP_CHECK_ERROR(hipGraphCreate(&graph, 1), hipErrorInvalidValue);
+      HIP_CHECK_ERROR(hipDeviceGetGraphMemAttribute(
+                          -1, hipGraphMemAttrUsedMemCurrent, &value),
+                      hipErrorInvalidDevice);
+      HIP_CHECK_ERROR(hipPeekAtLastError(), hipErrorInvalidDevice);
+      int *A_d;
+      HIP_CHECK(hipMalloc(&A_d, 1024));
+      HIP_CHECK(hipFree(A_d));
+      HIP_CHECK_ERROR(hipPeekAtLastError(), hipErrorInvalidDevice);
+      unsetenv("DEBUG_HIP_7_PREVIEW");
+    } else {
+      INFO("Env Not set");
+    }
+  }
+  SECTION("A case with Error-Success-Error-Success") {
+    if (setenv("DEBUG_HIP_7_PREVIEW", "1", 1) == 0) {
+      HIP_CHECK_ERROR(hipGraphCreate(&graph, 1), hipErrorInvalidValue);
+      int *A_d;
+      HIP_CHECK(hipMalloc(&A_d, 1024));
+      HIP_CHECK_ERROR(hipDeviceGetGraphMemAttribute(
+                          -1, hipGraphMemAttrUsedMemCurrent, &value),
+                      hipErrorInvalidDevice);
+      HIP_CHECK(hipFree(A_d));
+      HIP_CHECK_ERROR(hipPeekAtLastError(), hipErrorInvalidDevice);
+      unsetenv("DEBUG_HIP_7_PREVIEW");
+    } else {
+      INFO("Env Not set");
+    }
+  }
+  SECTION("A case with Success-Error-Error-Success") {
+    if (setenv("DEBUG_HIP_7_PREVIEW", "1", 1) == 0) {
+      int *A_d;
+      HIP_CHECK(hipMalloc(&A_d, 1024));
+      HIP_CHECK_ERROR(hipGraphCreate(&graph, 1), hipErrorInvalidValue);
+      HIP_CHECK_ERROR(hipDeviceGetGraphMemAttribute(
+                          -1, hipGraphMemAttrUsedMemCurrent, &value),
+                      hipErrorInvalidDevice);
+      HIP_CHECK(hipFree(A_d));
+      HIP_CHECK_ERROR(hipPeekAtLastError(), hipErrorInvalidDevice);
+      unsetenv("DEBUG_HIP_7_PREVIEW");
+    } else {
+      INFO("Env Not set");
+    }
+  }
+  SECTION("A Case with Success-Error-Success-Error") {
+    if (setenv("DEBUG_HIP_7_PREVIEW", "1", 1) == 0) {
+      int *A_d;
+      HIP_CHECK(hipMalloc(&A_d, 1024));
+      HIP_CHECK_ERROR(hipGraphCreate(&graph, 1), hipErrorInvalidValue);
+      HIP_CHECK(hipFree(A_d));
+      HIP_CHECK_ERROR(hipDeviceGetGraphMemAttribute(
+                          -1, hipGraphMemAttrUsedMemCurrent, &value),
+                      hipErrorInvalidDevice);
+      HIP_CHECK_ERROR(hipPeekAtLastError(), hipErrorInvalidDevice);
+      unsetenv("DEBUG_HIP_7_PREVIEW");
+    } else {
+      INFO("Env Not set");
+    }
+  }
+}
+
+static void thread_func() {
+  HIP_CHECK_ERROR(hipPeekAtLastError(), hipSuccess);
+  HIP_CHECK_ERROR(hipMalloc(nullptr, 1), hipErrorInvalidValue);
+  HIP_CHECK_ERROR(hipPeekAtLastError(), hipErrorInvalidValue);
+  int *A_d;
+  HIP_CHECK(hipMalloc(&A_d, 1024));
+  HIP_CHECK(hipFree(A_d));
+}
+/**
+ * Test Description
+ * ------------------------
+ *  - With Env Var DEBUG_HIP_7_PREVIEW, Verify hipPeekAtLastError status with a
+ *    runtime api invalid arg call.
+ *    Check in other thread this error should not report by hipPeekAtLastError()
+ * Test source
+ * ------------------------
+ *  - unit/errorHandling/hipPeekAtLastError.cc
+ * Test requirements
+ * ------------------------
+ *  - HIP_VERSION >= 6.4
+ */
+TEST_CASE("Unit_hipPeekAtLastError_With_EnvVar_With_Thread") {
+  hipGraph_t graph;
+  if (setenv("DEBUG_HIP_7_PREVIEW", "1", 1) == 0) {
+    int *A_d;
+    HIP_CHECK(hipMalloc(&A_d, 1024));
+    HIP_CHECK_ERROR(hipGraphCreate(&graph, 1), hipErrorInvalidValue);
+    std::thread t(thread_func);
+    t.join();
+    HIP_CHECK(hipFree(A_d));
+    HIP_CHECK_ERROR(hipPeekAtLastError(), hipErrorInvalidValue);
+    unsetenv("DEBUG_HIP_7_PREVIEW");
+  } else {
+    INFO("Env Not set");
+  }
+}
+/**
+ * Test Description
+ * ------------------------
+ *  - With Env Var DEBUG_HIP_7_PREVIEW, Verify hipPeekAtLastError status
+ *    in the multiple processes.
+ * Test source
+ * ------------------------
+ *  - unit/errorHandling/hipPeekAtLastError.cc
+ * Test requirements
+ * ------------------------
+ *  - HIP_VERSION >= 6.4
+ */
+// Disabled due to test failure
+#if 0
+TEST_CASE("Unit_hipPeekAtLastError_With_EnvVar_MultiProcess") {
+  hipGraph_t graph;
+  if (setenv("DEBUG_HIP_7_PREVIEW", "1", 1) == 0) {
+    /*int *A_d;
+    HIP_CHECK(hipMalloc(&A_d, 1024));
+    HIP_CHECK_ERROR(hipGraphCreate(&graph, 1), hipErrorInvalidValue);*/
+    hip::SpawnProc proc("hipPeekAtLastErrorEnv_Exe", true);
+    HIP_CHECK_ERROR(hipGraphCreate(&graph, 1), hipErrorInvalidValue);
+    HIP_CHECK_ERROR(hipPeekAtLastError(), hipErrorInvalidValue);
+    REQUIRE(proc.run() == 1);
+    //HIP_CHECK(hipFree(A_d));
+    HIP_CHECK_ERROR(hipPeekAtLastError(), hipErrorInvalidValue);
+    unsetenv("DEBUG_HIP_7_PREVIEW");
+  } else {
+    INFO("Env Not set");
+  }
+}
+#endif
+static void __global__ emptyKernl() {}
+/**
+ * Test Description
+ * ------------------------
+ *  - With Env Var DEBUG_HIP_7_PREVIEW, Verify hipPeekAtLastError status
+ *    with Invalid Configuration in kernel call.
+ *    Kernel call invalid configuration- blocks=0 & threadsPerBlock=0
+ * Test source
+ * ------------------------
+ *  - unit/errorHandling/hipPeekAtLastError.cc
+ * Test requirements
+ * ------------------------
+ *  - HIP_VERSION >= 6.4
+ */
+// Below test failed on NVIDIA due to error mismatch produced by the Invalid Kernel config.
+// For more details please check the ticket SWDEV-501896 comments.
+#if HT_AMD
+TEST_CASE("Unit_hipPeekAtLastError_With_EnvVar_Kernel_Invalid_Config") {
+  hipError_t ret;
+  if (setenv("DEBUG_HIP_7_PREVIEW", "1", 1) == 0) {
+    hipLaunchKernelGGL(emptyKernl, dim3(0), dim3(0), 0, 0);
+    int *A_d;
+    HIP_CHECK(hipMalloc(&A_d, 1024));
+    ret = hipPeekAtLastError();
+    REQUIRE(ret == hipErrorInvalidValue);
+    HIP_CHECK(hipFree(A_d));
+    unsetenv("DEBUG_HIP_7_PREVIEW");
+  }
+}
+#endif
+/**
+ * End doxygen group ErrorTest.
+ * @}
+ */
+

catch/unit/errorHandling/hipPeekAtLastErrorEnv_Exe.cc

@@ -0,0 +1,27 @@
+/*Copyright (c) 2024 Advanced Micro Devices, Inc. All rights reserved.
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+*/
+#include "hip/hip_runtime_api.h"
+#include <iostream>
+int main() {
+  hipError_t err;
+  err = hipPeekAtLastError();
+  if (err == hipSuccess)
+    return 1;
+  else
+    return 0;
+}