AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Correct minor issues in License text and sample code for hsa-rocr-dev package.

Browse Source 
Change-Id: If1c4387794de3cb707a8ba8281a40a1123130c95


[ROCm/ROCR-Runtime commit: 50339c12f1]
This commit is contained in:
James Edwards
2016-05-25 17:06:21 -05:00
committed by Gerrit Code Review
parent a09c9bfb04
commit 0a5966812c
5 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/rocr-runtime/runtime/packages/hsa-rocr-dev/CMakeLists.txt
+5 -5
View File
@@ -3,7 +3,7 @@
## The University of Illinois/NCSA
## Open Source License (NCSA)
##
## Copyright (c) 2014-2015, Advanced Micro Devices, Inc. All rights reserved.
## Copyright (c) 2014-2016, Advanced Micro Devices, Inc. All rights reserved.
##
## Developed by:
##
@@ -69,7 +69,7 @@ set ( PACKAGE_DIRECTORIES
"include"
"hsa/include"
"hsa/lib")
set ( RUNTIME_HEADER_NAMES
"hsa.h"
"amd_hsa_common.h"
@@ -97,8 +97,8 @@ set ( HSA_INCLUDE_LINK "${EXTERNAL_DIR}/hsa/include/hsa" )
set ( TOPLEVEL_INCLUDE_LINK "${EXTERNAL_DIR}/include/hsa" )
add_custom_command(OUTPUT ${PACKAGE_DIRECTORIES} WORKING_DIRECTORY ${EXTERNAL_DIR}
COMMAND mkdir -p include
add_custom_command(OUTPUT ${PACKAGE_DIRECTORIES} WORKING_DIRECTORY ${EXTERNAL_DIR}
COMMAND mkdir -p include
COMMAND mkdir -p lib
COMMAND mkdir -p hsa/lib
COMMAND mkdir -p hsa/include )
@@ -113,7 +113,7 @@ add_custom_command( OUTPUT ${TOPLEVEL_INCLUDE_LINK} WORKING_DIRECTORY ${EXTERNAL
add_custom_target (link_dirs DEPENDS create_dirs ${TOPLEVEL_INCLUDE_LINK} ${HSA_INCLUDE_LINK} )
add_custom_command( OUTPUT ${RUNTIME_LIBRARY_TARGET} WORKING_DIRECTORY ${EXTERNAL_DIR}
add_custom_command( OUTPUT ${RUNTIME_LIBRARY_TARGET} WORKING_DIRECTORY ${EXTERNAL_DIR}
COMMAND ${CMAKE_COMMAND} -E copy ${RUNTIME_LIBRARY_SOURCE} ${RUNTIME_LIBRARY_TARGET} )
add_custom_command( OUTPUT ${RUNTIME_LIBRARY_SONAME} WORKING_DIRECTORY ${EXTERNAL_DIR}/hsa/lib
projects/rocr-runtime/runtime/packages/hsa-rocr-dev/LICENSE.txt
+1 -1
View File
@@ -1,7 +1,7 @@
The University of Illinois/NCSA
Open Source License (NCSA)
Copyright (c) 2014-2015, Advanced Micro Devices, Inc. All rights reserved.
Copyright (c) 2014-2016, Advanced Micro Devices, Inc. All rights reserved.
Developed by:
projects/rocr-runtime/runtime/packages/hsa-rocr-dev/README.md
+6 -6
View File
@@ -27,13 +27,13 @@ Runtime extension package:
* A 64-bit version of AMD's finalizer extension for Boltzmann
* A 64-bit version of AMD's runtime tools library
The contents of these packages are installed in /opt/rocm/hsa and /opt/rocm by default.
The contents of these packages are installed in /opt/rocm/hsa and /opt/rocm by default.
The core runtime package depends on the hsakmt-roct-dev package
Installation instructions can be found in the ROCm manifest repository README.md:
https://github.com/RadeonOpenCompute/ROCm
#### Infrastructure
The HSA runtime is a thin, user-mode API that exposes the necessary interfaces to access and interact with graphics hardware driven by the AMDGPU driver set and the Boltzmann HSA kernel driver. Together they enable programmers to directly harness the power of AMD discrete graphics devices by allowing host applications to launch compute kernels directly to the graphics hardware.
@@ -48,7 +48,7 @@ The capabilities expressed by the HSA Runtime API are:
* Memory management
* HSA runtime fits into a typical software architecture stack.
The HSA runtime provides direct access to the graphics hardware to give the programmer more control of the execution. Some examples of low level hardware access is the support of one or more user mode queues provides programmers with a low-latency kernel dispatch interface, allowing them to develop customized dispatch algorithms specific to their application.
The HSA runtime provides direct access to the graphics hardware to give the programmer more control of the execution. An example of low level hardware access is the support of one or more user mode queues provides programmers with a low-latency kernel dispatch interface, allowing them to develop customized dispatch algorithms specific to their application.
The HSA Architected Queuing Language is an open standard, defined by the HSA Foundation, specifying the packet syntax used to control supported AMD/ATI Radeon (c) graphics devices. The AQL language supports several packet types, including packets that can command the hardware to automatically resolve inter-packet dependencies (barrier AND & barrier OR packet), kernel dispatch packets and agent dispatch packets.
@@ -66,9 +66,9 @@ If the sample runs without generating errors, the installation is complete.
#### Known Issues
* The image extension is currently not supported for discrete GPUs. An image extension library is not provided in the binary package. The standard hsa_ext_image.h extension include file is provided for reference.
* Each HSA process creates and internal DMA queue, but there is a system-wide limit of four DMA queues. The fifths simultaneous HSA process will fail hsa_init() with HSA_STATUS_ERROR_OUT_OF_RESOURCES. To run an unlimited number of simultaneous HSA processes, set the environment variable HSA_ENABLE_SDMA=0.
* The image extension is currently not supported for discrete GPUs. An image extension library is not provided in the binary package. The standard hsa_ext_image.h extension include file is provided for reference.
* Each HSA process creates and internal DMA queue, but there is a system-wide limit of four DMA queues. The fifth simultaneous HSA process will fail hsa_init() with HSA_STATUS_ERROR_OUT_OF_RESOURCES. To run an unlimited number of simultaneous HSA processes, set the environment variable HSA_ENABLE_SDMA=0.
#### Disclaimer
The information contained herein is for informational purposes only, and is subject to change without notice. While every precaution has been taken in the preparation of this document, it may contain technical inaccuracies, omissions and typographical errors, and AMD is under no obligation to update or otherwise correct this information. Advanced Micro Devices, Inc. makes no representations or warranties with respect to the accuracy or completeness of the contents of this document, and assumes no liability of any kind, including the implied warranties of noninfringement, merchantability or fitness for particular purposes, with respect to the operation or use of AMD hardware, software or other products described herein. No license, including implied or arising by estoppel, to any intellectual property rights is granted by this document. Terms and limitations applicable to the purchase or use of AMD's products are as set forth in a signed agreement between the parties or in AMD's Standard Terms and Conditions of Sale.
projects/rocr-runtime/runtime/packages/hsa-rocr-dev/sample/Makefile
+1 -1
View File
@@ -3,7 +3,7 @@
## The University of Illinois/NCSA
## Open Source License (NCSA)
##
## Copyright (c) 2014-2015, Advanced Micro Devices, Inc. All rights reserved.
## Copyright (c) 2014-2016, Advanced Micro Devices, Inc. All rights reserved.
##
## Developed by:
##
projects/rocr-runtime/runtime/packages/hsa-rocr-dev/sample/vector_copy.c
+3 -3
View File
@@ -3,7 +3,7 @@
// The University of Illinois/NCSA
// Open Source License (NCSA)
//
// Copyright (c) 2014-2015, Advanced Micro Devices, Inc. All rights reserved.
// Copyright (c) 2014-2016, Advanced Micro Devices, Inc. All rights reserved.
//
// Developed by:
//
@@ -331,12 +331,12 @@ int main(int argc, char **argv) {
* grained memory region.
*/
char* in;
err=hsa_memory_allocate(finegrained_region, 1024*1024*4, (void*) &in);
err=hsa_memory_allocate(finegrained_region, 1024*1024*4, (void**) &in);
check(Allocating argument memory for input parameter, err);
memset(in, 1, 1024*1024*4);
char* out;
err=hsa_memory_allocate(finegrained_region, 1024*1024*4, (void*) &out);
err=hsa_memory_allocate(finegrained_region, 1024*1024*4, (void**) &out);
check(Allocating argument memory for output parameter, err);
memset(out, 0, 1024*1024*4);