SWDEV-287018 - Remove requiredDump argument from Program::linkLLVMBitcode

Weirdly, the `requiredDump` argument to linkLLVMBitcode was used to enable/disable
the keeping temporary bytecode files (those generated by -save-temps=all) after linking.

This patch removes this argument as there is no obvious benefit from keepeing it
(the user would only rely on -save-temps=all to control this).

Change-Id: I0c00486f95eb1d4e296b5247c488407c47f0b2d9


[ROCm/clr commit: 8ab3fd58cf]

projects/clr/rocclr/device/devprogram.cpp

@@ -344,7 +344,7 @@ amd_comgr_status_t Program::createAction(const amd_comgr_language_t oclver,
 }
 
 bool Program::linkLLVMBitcode(const amd_comgr_data_set_t inputs,
-                              const std::vector<std::string>& options, const bool requiredDump,
+                              const std::vector<std::string>& options,
                               amd::option::Options* amdOptions, amd_comgr_data_set_t* output,
                               char* binaryData[], size_t* binarySize, const bool link_dev_libs) {
 
@@ -385,7 +385,7 @@ bool Program::linkLLVMBitcode(const amd_comgr_data_set_t inputs,
 
   if (status == AMD_COMGR_STATUS_SUCCESS) {
     std::string dumpFileName;
-    if (requiredDump && amdOptions->isDumpFlagSet(amd::option::DUMP_BC_LINKED)) {
+    if (amdOptions->isDumpFlagSet(amd::option::DUMP_BC_LINKED)) {
       dumpFileName = amdOptions->getDumpFileName("_linked.bc");
     }
     status = extractByteCodeBinary(*output, AMD_COMGR_DATA_KIND_BC, dumpFileName, binaryData,
@@ -971,7 +971,7 @@ bool Program::linkImplLC(const std::vector<Program*>& inputPrograms,
   size_t binarySize = 0;
   std::vector<std::string> linkOptions;
   constexpr bool kLinkDevLibs = false;
-  bool ret = linkLLVMBitcode(inputs, linkOptions, false, options, &output, &binaryData,
+  bool ret = linkLLVMBitcode(inputs, linkOptions, options, &output, &binaryData,
                              &binarySize, kLinkDevLibs);
 
   amd::Comgr::destroy_data_set(output);
@@ -1222,7 +1222,7 @@ bool Program::linkImplLC(amd::option::Options* options) {
     bool ret = (status == AMD_COMGR_STATUS_SUCCESS);
     if (ret) {
       hasLinkedBC = true;
-      ret = linkLLVMBitcode(inputs, linkOptions, true, options, &linked_bc);
+      ret = linkLLVMBitcode(inputs, linkOptions, options, &linked_bc);
     }
 
     amd::Comgr::destroy_data_set(inputs);

projects/clr/rocclr/device/devprogram.hpp

@@ -454,7 +454,7 @@ class Program : public amd::HeapObject {
 
   //! Create the bitcode of the linked input dataset
   bool linkLLVMBitcode(const amd_comgr_data_set_t inputs,
-    const std::vector<std::string>& options, const bool requiredDump,
+    const std::vector<std::string>& options,
     amd::option::Options* amdOptions, amd_comgr_data_set_t* output,
     char* binaryData[] = nullptr, size_t* binarySize = nullptr,
     const bool link_dev_libs = true);