AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SWDEV-321511 - Enable device related disabled tests on Nvidia platform (#2518)

Browse Source 
Change-Id: I95a62e9562a638cb3525862b9a5d2e640c10882c
This commit is contained in:
ROCm CI Service Account
2022-03-10 16:45:54 +05:30
committed by GitHub
parent 72af2f3299
commit 17105259fe
2 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/catch/unit/device/hipChooseDevice.cc
+1 -4
View File
@@ -1,5 +1,5 @@
/*
Copyright (c) 2021 Advanced Micro Devices, Inc. All rights reserved.
Copyright (c) 2022 Advanced Micro Devices, Inc. All rights reserved.
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
@@ -41,8 +41,6 @@ TEST_CASE("Unit_hipChooseDevice_ValidateDevId") {
* Scenario1: Validates if dev = nullptr returns error code
* Scenario2: Validates if prop = nullptr returns error code
*/
#if HT_AMD
// These test scenarios fail on NVIDIA.
TEST_CASE("Unit_hipChooseDevice_NegTst") {
hipDeviceProp_t prop;
int dev = -1;
@@ -57,4 +55,3 @@ TEST_CASE("Unit_hipChooseDevice_NegTst") {
REQUIRE_FALSE(hipSuccess == hipChooseDevice(&dev, nullptr));
}
}
#endif
tests/catch/unit/device/hipGetDeviceProperties.cc
+1 -4
View File
@@ -1,5 +1,5 @@
/*
Copyright (c) 2021 Advanced Micro Devices, Inc. All rights reserved.
Copyright (c) 2022 Advanced Micro Devices, Inc. All rights reserved.
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
@@ -182,14 +182,11 @@ TEST_CASE("Unit_hipGetDeviceProperties_ArchPropertiesTst") {
TEST_CASE("Unit_hipGetDeviceProperties_NegTst") {
hipDeviceProp_t prop;
#if HT_AMD
SECTION("props is nullptr") {
int device;
HIP_CHECK(hipGetDevice(&device));
// this test case results in segmentation fault on NVCC
REQUIRE_FALSE(hipSuccess == hipGetDeviceProperties(nullptr, device));
}
#endif
SECTION("device is -1") {
REQUIRE_FALSE(hipSuccess == hipGetDeviceProperties(&prop, -1));