AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rocr: Fix PC Sampling PRED_EXEC num dwords count

Browse Source 
Fix incorrect value for number of dwords in the PRED_EXEC command.
This commit is contained in:
David Yat Sin
2025-04-01 13:52:03 +00:00
committed by Yat Sin, David
parent 39e8911fbc
commit 2a433e2b96
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runtime/hsa-runtime/core/runtime/amd_gpu_agent.cpp
+9 -4
View File
@@ -3101,8 +3101,11 @@ hsa_status_t GpuAgent::PcSamplingFlushDeviceBuffers(
if (properties_.NumXcc > 1) {
pred_exec_cmd_sz = 2;
cmd_data[i++] = PM4_HDR(PM4_HDR_IT_OPCODE_PRED_EXEC, pred_exec_cmd_sz, isa_->GetMajorVersion());
cmd_data[i++] = PM4_PRED_EXEC_DW2_EXEC_COUNT(0xF) | PM4_PRED_EXEC_DW2_VIRTUALXCCID_SELECT(0x1);
const uint64_t command_bytes = atomic_ex_cmd_sz + copy_data_cmd_sz;
cmd_data[i++] =
PM4_HDR(PM4_HDR_IT_OPCODE_PRED_EXEC, pred_exec_cmd_sz, isa_->GetMajorVersion());
cmd_data[i++] =
PM4_PRED_EXEC_DW2_EXEC_COUNT(command_bytes) | PM4_PRED_EXEC_DW2_VIRTUALXCCID_SELECT(0x1);
}
/*
@@ -3169,10 +3172,12 @@ hsa_status_t GpuAgent::PcSamplingFlushDeviceBuffers(
if (properties_.NumXcc > 1) {
const uint64_t n = ceil(to_copy / (32 * 1024 * 1024));
const uint64_t command_bytes = wait_reg_mem_cmd_sz + write_data_cmd_sz + dma_data_cmd_sz * n;
pred_exec_cmd_sz = 2;
cmd_data[i++] = PM4_HDR(PM4_HDR_IT_OPCODE_PRED_EXEC, pred_exec_cmd_sz, isa_->GetMajorVersion());
cmd_data[i++] =
PM4_PRED_EXEC_DW2_EXEC_COUNT(0x13 + 7 * n) | PM4_PRED_EXEC_DW2_VIRTUALXCCID_SELECT(0x1);
PM4_HDR(PM4_HDR_IT_OPCODE_PRED_EXEC, pred_exec_cmd_sz, isa_->GetMajorVersion());
cmd_data[i++] =
PM4_PRED_EXEC_DW2_EXEC_COUNT(command_bytes) | PM4_PRED_EXEC_DW2_VIRTUALXCCID_SELECT(0x1);
}
/*