AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Addressing possible out-of-bounds mem access during channel duplication (#1193)

Browse Source
This commit is contained in:
gilbertlee-amd
2024-05-30 14:02:14 -06:00
committed by GitHub
parent 73221b4230
commit 354e0b29a6
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/graph/connect.cc
+9 -4
View File
@@ -86,7 +86,7 @@ ncclResult_t ncclTopoPreset(struct ncclComm* comm, struct ncclTopoGraph** graphs
topoRanks->nvlsHeads[topoRanks->nvlsHeadNum++] = nvlsIntra[0];
}
}
return ncclSuccess;
}
@@ -637,8 +637,13 @@ ncclResult_t ncclTopoPostset(struct ncclComm* comm, int* firstRanks, int* treePa
for (int c=0; c<nChannels; c++) {
struct ncclChannel* channel0 = comm->channels+c;
struct ncclChannel* channel1 = channel0+nChannels;
channel0->ring.prev = channel1->ring.prev = ringPrev[c*nranks+comm->rank];
channel0->ring.next = channel1->ring.next = ringNext[c*nranks+comm->rank];
channel0->ring.prev = ringPrev[c*nranks+comm->rank];
channel0->ring.next = ringNext[c*nranks+comm->rank];
if (c + nChannels < MAXCHANNELS) {
channel1->ring.prev = channel0->ring.prev;
channel1->ring.next = channel0->ring.next;
}
}
// Duplication should be complete now
@@ -699,4 +704,4 @@ ncclResult_t ncclTopoPostset(struct ncclComm* comm, int* firstRanks, int* treePa
free(nvlsHeads);
return ncclSuccess;
}
}