AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Correct strip command.

Browse Source 
Strip should only apply to the output target library.  Symlinks
with .so endings which will be relocated during install will cause
strip to fail, aborting the build.

Change-Id: Ieb598c2cec5277d9d14c8afa88b91ca2c7f4412d


[ROCm/ROCR-Runtime commit: 851ee799c4]
This commit is contained in:
Sean Keely
2019-10-30 01:24:43 -05:00
parent afc463c817
commit 37f96146f5
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/rocr-runtime/runtime/hsa-ext-image/CMakeLists.txt
+1 -1
View File
@@ -165,7 +165,7 @@ target_link_libraries (
## If the build is Release, strip the target library
if ( "${CMAKE_BUILD_TYPE}" STREQUAL Release )
add_custom_command ( TARGET ${IMAGE_TARGET} POST_BUILD COMMAND ${CMAKE_STRIP} *.so )
add_custom_command ( TARGET ${IMAGE_TARGET} POST_BUILD COMMAND ${CMAKE_STRIP} $<TARGET_FILE_NAME:${IMAGE_TARGET}> )
endif ()
## Create symlinks for legacy packaging and install
projects/rocr-runtime/runtime/hsa-runtime-tools/CMakeLists.txt
+1 -1
View File
@@ -232,7 +232,7 @@ target_link_libraries (
## If the build is Release, strip the target library
if ( "${CMAKE_BUILD_TYPE}" STREQUAL Release )
add_custom_command ( TARGET ${TOOLS_TARGET} POST_BUILD COMMAND ${CMAKE_STRIP} *.so )
add_custom_command ( TARGET ${TOOLS_TARGET} POST_BUILD COMMAND ${CMAKE_STRIP} $<TARGET_FILE_NAME:${TOOLS_TARGET}> )
endif ()
## Create symlinks for legacy packaging and install
projects/rocr-runtime/runtime/hsa-runtime/CMakeLists.txt
+1 -1
View File
@@ -169,7 +169,7 @@ target_link_libraries ( ${CORE_RUNTIME_TARGET}
## Strip should be optional or not at all
if ( "${CMAKE_BUILD_TYPE}" STREQUAL Release )
# add_custom_command ( TARGET ${CORE_RUNTIME_TARGET} POST_BUILD COMMAND ${CMAKE_STRIP} *.so )
# add_custom_command ( TARGET ${CORE_RUNTIME_TARGET} POST_BUILD COMMAND ${CMAKE_STRIP} $<TARGET_FILE_NAME:${CORE_RUNTIME_TARGET}> )
endif ()
## Set the VERSION and SOVERSION values