SWDEV-403638 - Fix warnings

- disable deprecated function use warning
- disalbe size_t to .type' warning
- disable conversion from 'type1' to 'type2' warning

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I64161fd37cf56de3d132102103267ae8da40193a

CMakeLists.txt

@@ -24,6 +24,11 @@ cmake_minimum_required(VERSION 3.16.8)
 ##########
 # Defaults
 ##########
+if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
+    add_compile_options("/wd4267" "/wd4244" "/wd4996")
+    string(REPLACE "/GR" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
+    string(REPLACE "/W3" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
+endif()
 option(CLR_BUILD_HIP "Build HIP" OFF)
 option(CLR_BUILD_OCL "Build OCL" OFF)
 

hipamd/src/hip_conversions.hpp

@@ -97,7 +97,7 @@ cl_mem_object_type getCLMemObjectType(const unsigned int hipWidth,
                                       const unsigned int hipHeight,
                                       const unsigned int hipDepth,
                                       const unsigned int flags) {
-  if (flags & hipArrayLayered == hipArrayLayered) {
+  if ((flags & hipArrayLayered) == hipArrayLayered) {
     if ((hipWidth != 0) && (hipHeight == 0) && (hipDepth != 0)) {
       return CL_MEM_OBJECT_IMAGE1D_ARRAY;
     } else if ((hipWidth != 0) && (hipHeight != 0) && (hipDepth != 0)) {

hipamd/src/hiprtc/hiprtcInternal.cpp

@@ -486,7 +486,7 @@ bool RTCLinkProgram::AddLinkerOptions(unsigned int num_options, hiprtcJIT_option
         link_args_.generate_debug_info_ = *(reinterpret_cast<int*>(options_vals_ptr[opt_idx]));
         break;
       case HIPRTC_JIT_LOG_VERBOSE:
-        link_args_.log_verbose_ = reinterpret_cast<long>(options_vals_ptr[opt_idx]);
+        link_args_.log_verbose_ = *(reinterpret_cast<long*>(options_vals_ptr[opt_idx]));
         break;
       case HIPRTC_JIT_GENERATE_LINE_INFO:
         link_args_.generate_line_info_ = *(reinterpret_cast<int*>(options_vals_ptr[opt_idx]));

rocclr/device/pal/palresource.cpp

@@ -1508,7 +1508,7 @@ bool Resource::partialMemCopyTo(VirtualGPU& gpu, const amd::Coord3D& srcOrigin,
   gpu.queue(gpu.engineID_).addCmdMemRef(memRef());
   gpu.queue(gpu.engineID_).addCmdMemRef(dstResource.memRef());
   if (desc().buffer_ && !dstResource.desc().buffer_) {
-    int arraySliceIdx = img2Darray ? dstOrigin[2] : 0;
+    uint32_t arraySliceIdx = img2Darray ? dstOrigin[2] : 0;
     Pal::SubresId ImgSubresId = {0, dstResource.desc().baseLevel_, arraySliceIdx};
     Pal::MemoryImageCopyRegion copyRegion = {};
     copyRegion.imageSubres = ImgSubresId;
@@ -1534,7 +1534,7 @@ bool Resource::partialMemCopyTo(VirtualGPU& gpu, const amd::Coord3D& srcOrigin,
     gpu.iCmd()->CmdCopyMemoryToImage(*iMem(), *dstResource.image_, imgLayout, 1, &copyRegion);
   } else if (!desc().buffer_ && dstResource.desc().buffer_) {
     Pal::MemoryImageCopyRegion copyRegion = {};
-    int arraySliceIdx = img2Darray ? dstOrigin[2] : 0;
+    uint32_t arraySliceIdx = img2Darray ? dstOrigin[2] : 0;
     Pal::SubresId ImgSubresId = {0, desc().baseLevel_, arraySliceIdx};
     copyRegion.imageSubres = ImgSubresId;
     copyRegion.imageOffset.x = srcOrigin[0];

rocclr/platform/activity.cpp

@@ -53,7 +53,7 @@ bool IsEnabled(OpId operation_id) {
 
 void ReportActivity(const amd::Command& command) {
   assert(command.profilingInfo().enabled_ && "profiling must be enabled for this command");
-  auto operation_id = OperationId(command.type());
+  activity_op_t operation_id = OperationId(command.type());
   if (operation_id >= OP_ID_NUMBER)
     // This command does not translate into a profiler activity (dispatch, memcopy, etc...), there
     // is nothing to report to the profiler.

rocclr/platform/command.hpp

@@ -1209,11 +1209,11 @@ class ExternalSemaphoreCmd : public Command {
 
  private:
   const void* sem_ptr_; //!< Pointer to external semaphore
-  int fence_;           //!< semaphore value to be set
+  uint64_t fence_;           //!< semaphore value to be set
   ExternalSemaphoreCmdType cmd_type_; //!< Signal or Wait semaphore command
 
  public:
-  ExternalSemaphoreCmd(HostQueue& queue, const void* sem_ptr, int fence,
+  ExternalSemaphoreCmd(HostQueue& queue, const void* sem_ptr, uint64_t fence,
                        ExternalSemaphoreCmdType cmd_type)
       : Command::Command(queue, CL_COMMAND_USER), sem_ptr_(sem_ptr), fence_(fence), cmd_type_(cmd_type) {}
 
@@ -1221,7 +1221,7 @@ class ExternalSemaphoreCmd : public Command {
     device.submitExternalSemaphoreCmd(*this);
   }
   const void* sem_ptr() const { return sem_ptr_; }
-  const int fence() { return fence_; }
+  const uint64_t fence() { return fence_; }
   const ExternalSemaphoreCmdType semaphoreCmd() { return cmd_type_; }
 
 };