AI/rocm-systems
2
0
Garpu 0
Kode Masalah Tarik Permintaan Actions Packages Projects Rilis Wiki Kegiatan

Ensure HSA_ENABLE_SDMA=0 persists on new copy on engine API

Telusuri Sumber 
Copy on engine API still needs to respect HSA_ENABLE_SDMA settings.

Change-Id: I26038b1e3082d62687c2e279615557583d20f229
This commit is contained in:
Jonathan Kim
2023-06-16 15:19:52 -04:00
committed by Jonathan Kim
orang tua 4142a77375
melakukan 3e3e11bc5a
1 mengubah file dengan 3 tambahan dan 3 penghapusan
Download Patch File Download Diff File Expand all files Collapse all files
runtime/hsa-runtime/core/runtime/amd_gpu_agent.cpp
+3 -3
Melihat File
@@ -856,8 +856,9 @@ hsa_status_t GpuAgent::DmaCopyOnEngine(void* dst, core::Agent& dst_agent,
bool is_p2p = !is_same_gpu && src_agent.device_type() == core::Agent::kAmdGpuDevice &&
dst_agent.device_type() == core::Agent::kAmdGpuDevice;
if (is_p2p &&
core::Runtime::runtime_singleton_->flag().enable_peer_sdma() == Flag::SDMA_DISABLE) {
if ((is_p2p &&
core::Runtime::runtime_singleton_->flag().enable_peer_sdma() == Flag::SDMA_DISABLE) ||
core::Runtime::runtime_singleton_->flag().enable_sdma() == Flag::SDMA_DISABLE) {
// Note that VDI/HIP will call DmaCopy instead of DmaCopyOnEngine for P2P copies, but
// we still want to handle force Blit Kernels in this function in case other libraries
// decide to use DmaCopyOnEngine for P2P copies
@@ -867,7 +868,6 @@ hsa_status_t GpuAgent::DmaCopyOnEngine(void* dst, core::Agent& dst_agent,
bool is_xgmi = is_p2p && dst_agent.HiveId() && src_agent.HiveId() == dst_agent.HiveId() &&
properties_.NumSdmaXgmiEngines;
// Due to a RAS issue, GFX90a can only support H2D copies on SDMA0
bool is_h2d_blit = (src_agent.device_type() == core::Agent::kAmdCpuDevice &&
dst_agent.device_type() == core::Agent::kAmdGpuDevice);