AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SWDEV-273235 - Do not use target_link_options()

Browse Source 
Some CI systems have a somewhat out of date version of cmake, which
does not have this functionality. Fall back to using
target_link_libraries() instead.

Change-Id: I2410b24bcb6f1be2c2c3303ccd0019b10c914d2e


[ROCm/clr commit: 58c93c8047]
This commit is contained in:
Vladislav Sytchenko
2021-06-02 20:59:35 -04:00
parent 208c198d71
commit 43b6294afb
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/clr/opencl/amdocl/CMakeLists.txt
+1 -1
View File
@@ -97,7 +97,7 @@ if(BUILD_SHARED_LIBS)
if(WIN32)
target_sources(amdocl PRIVATE amdocl.def)
else()
target_link_options(amdocl PRIVATE "-Wl,--version-script=${CMAKE_CURRENT_LIST_DIR}/amdocl.map")
target_link_libraries(amdocl PRIVATE "-Wl,--version-script=${CMAKE_CURRENT_LIST_DIR}/amdocl.map")
set_target_properties(amdocl PROPERTIES LINK_DEPENDS "${CMAKE_CURRENT_LIST_DIR}/amdocl.map")
endif()
endif()
projects/clr/opencl/tools/cltrace/CMakeLists.txt
+2 -2
View File
@@ -3,11 +3,11 @@ add_library(cltrace SHARED cltrace.cpp)
if(WIN32)
target_sources(cltrace PRIVATE cltrace.def)
else()
target_link_options(cltrace PRIVATE "-Wl,--version-script=${CMAKE_CURRENT_LIST_DIR}/cltrace.map")
target_link_libraries(cltrace PRIVATE "-Wl,--version-script=${CMAKE_CURRENT_LIST_DIR}/cltrace.map")
set_target_properties(cltrace PROPERTIES LINK_DEPENDS "${CMAKE_CURRENT_LIST_DIR}/cltrace.map")
endif()
target_link_libraries(cltrace OpenCL amdocl)
target_link_libraries(cltrace PRIVATE OpenCL amdocl)
INSTALL(TARGETS cltrace
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}