SWDEV-425678 - Fix build failure in HIP samples

- Due to file reorg path changes cmake fails at find_package(hip) unless CMAKE_PREFIX_PATH is set explicitly
- Update CMakeLists.txt to set CMAKE_PREFIX_PATH
- Update Readme

Change-Id: Ibdb4419efcdd6583b059a728e48dfdb8f927a48b
Этот коммит содержится в:
Rakesh Roy
2023-11-09 20:39:17 +05:30
коммит произвёл Rahul Manocha
родитель d04b8bf458
Коммит 4dfa7ca7e6
30 изменённых файлов: 220 добавлений и 6 удалений
+8
Просмотреть файл
@@ -30,6 +30,14 @@ if(${__HIP_ENABLE_PCH})
add_definitions(-D__HIP_ENABLE_PCH)
endif()
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find hip
find_package(hip)
+9
Просмотреть файл
@@ -23,6 +23,15 @@ project(module_api)
cmake_minimum_required(VERSION 3.10)
include_directories(../../common)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find hip
find_package(hip)
+8
Просмотреть файл
@@ -22,6 +22,14 @@ project(module_api_global)
cmake_minimum_required(VERSION 3.10)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find hip
find_package(hip)
+8
Просмотреть файл
@@ -24,6 +24,14 @@ project(square)
cmake_minimum_required(VERSION 3.10)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# create square.cpp
execute_process(COMMAND sh -c "${CMAKE_PREFIX_PATH}/bin/hipify-perl ../square.cu > ../square.cpp")
+1 -1
Просмотреть файл
@@ -20,7 +20,7 @@ $ export HIP_PATH=[MYHIP]
$ cd ~/hip/samples/0_Intro/square
mkdir -p build && cd build
cmake -DCMAKE_PREFIX_PATH=<path/to/rocm> -DHIP_CXX_COMPILER=<path/to/clang> ..
cmake ..
make
$ Building without cmake
+9
Просмотреть файл
@@ -23,6 +23,15 @@ project(hipDispatchLatency)
cmake_minimum_required(VERSION 3.10)
include_directories(../../common)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find hip
find_package(hip)
+7
Просмотреть файл
@@ -26,6 +26,13 @@ set(CMAKE_CXX_COMPILER_WORKS 1)
project(hipInfo)
cmake_minimum_required(VERSION 3.10)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# flag is set to ON in compute build for windows
option(HIPINFO_INTERNAL_BUILD "Enable building hipInfo from compute" OFF)
+8
Просмотреть файл
@@ -22,6 +22,14 @@ project(MatrixTranspose)
cmake_minimum_required(VERSION 3.10)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find hip
find_package(hip)
+8
Просмотреть файл
@@ -22,6 +22,14 @@ project(inline_asm)
cmake_minimum_required(VERSION 3.10)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find hip
find_package(hip)
+8
Просмотреть файл
@@ -22,6 +22,14 @@ project(texture2dDrv)
cmake_minimum_required(VERSION 3.10)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find hip
find_package(hip)
+8 -3
Просмотреть файл
@@ -19,9 +19,11 @@
# THE SOFTWARE.
cmake_minimum_required(VERSION 3.10)
if (NOT DEFINED ROCM_PATH )
set ( ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory." )
endif ()
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
endif()
if(NOT DEFINED HIP_PATH)
if(NOT DEFINED ENV{HIP_PATH})
@@ -30,6 +32,9 @@ if(NOT DEFINED HIP_PATH)
set(HIP_PATH $ENV{HIP_PATH} CACHE PATH "Path to which HIP has been installed")
endif()
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
set(CMAKE_MODULE_PATH "${HIP_PATH}/lib/cmake/hip/" ${CMAKE_MODULE_PATH})
set(CMAKE_HIP_ARCHITECTURES OFF)
project(12_cmake)
+8
Просмотреть файл
@@ -22,6 +22,14 @@ project(occupancy)
cmake_minimum_required(VERSION 3.10)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find hip
find_package(hip)
+8
Просмотреть файл
@@ -22,6 +22,14 @@ project(gpuarch)
cmake_minimum_required(VERSION 3.10)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find hip
find_package(hip)
+8
Просмотреть файл
@@ -2,6 +2,14 @@ project(static_lib)
cmake_minimum_required(VERSION 3.10)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find hip
find_package(hip REQUIRED)
+8
Просмотреть файл
@@ -2,6 +2,14 @@ project(static_lib)
cmake_minimum_required(VERSION 3.10)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find hip
find_package(hip REQUIRED)
+8
Просмотреть файл
@@ -24,6 +24,14 @@ cmake_minimum_required(VERSION 3.10.2)
include_directories(../../common)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find hip
find_package(hip REQUIRED)
+8
Просмотреть файл
@@ -4,6 +4,14 @@ cmake_minimum_required(VERSION 3.18.0)
project(cmake_lang_test CXX Fortran)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
find_package(hip REQUIRED)
add_executable(test_fortran TestFortran.F90)
+8
Просмотреть файл
@@ -22,6 +22,14 @@ project(hipEvent)
cmake_minimum_required(VERSION 3.10)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find hip
find_package(hip)
+8
Просмотреть файл
@@ -29,6 +29,14 @@ project(hipVulkan)
cmake_minimum_required(VERSION 3.10)
set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/cmake;${CMAKE_MODULE_PATH}")
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# need to set rocm_path for windows
# since clang and hip are two different folders during build/install step
if (WIN32 AND HIPINFO_INTERNAL_BUILD)
+1 -1
Просмотреть файл
@@ -25,6 +25,6 @@ Linux
Build with CMake:
• mkdir build; cd build
• cmake -DCMAKE_PREFIX_PATH=path\to\rocm -DHIP_CXX_COMPILER=path\to\clang
• cmake ..
• make
• run hipVulkan executable
+8
Просмотреть файл
@@ -24,6 +24,14 @@ project(cmake_cxx_amdclang++_test
DESCRIPTION "Verifies CXX Language Support with amdclang++"
LANGUAGES CXX)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find HIP
find_package(hip REQUIRED)
+8
Просмотреть файл
@@ -22,6 +22,14 @@ project(cmake_hiprtc_test)
cmake_minimum_required(VERSION 3.10.2)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find hiprtc
find_package(hiprtc REQUIRED)
# Find hip
+8
Просмотреть файл
@@ -22,6 +22,14 @@ project(sharedMemory)
cmake_minimum_required(VERSION 3.10)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find hip
find_package(hip)
+8
Просмотреть файл
@@ -22,6 +22,14 @@ project(shfl)
cmake_minimum_required(VERSION 3.10)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find hip
find_package(hip)
+8
Просмотреть файл
@@ -22,6 +22,14 @@ project(2dshfl)
cmake_minimum_required(VERSION 3.10)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find hip
find_package(hip)
+9
Просмотреть файл
@@ -23,6 +23,15 @@ project(dynamic_shared)
cmake_minimum_required(VERSION 3.10)
include_directories(../../common)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find hip
find_package(hip)
+8
Просмотреть файл
@@ -22,6 +22,14 @@ project(stream)
cmake_minimum_required(VERSION 3.10)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find hip
find_package(hip)
+7
Просмотреть файл
@@ -22,6 +22,13 @@ project(peer2peer)
cmake_minimum_required(VERSION 3.10)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find hip
find_package(hip)
+8
Просмотреть файл
@@ -22,6 +22,14 @@ project(unroll)
cmake_minimum_required(VERSION 3.10)
if(UNIX)
if(NOT DEFINED ROCM_PATH)
set(ROCM_PATH "/opt/rocm" CACHE STRING "Default ROCM installation directory.")
endif()
# Search for rocm in common locations
list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH})
endif()
# Find hip
find_package(hip)
+1 -1
Просмотреть файл
@@ -20,7 +20,7 @@ mkdir -p build && cd build
rm -rf * (to clear up)
cmake -DCMAKE_PREFIX_PATH=<path/to/rocm> -DHIP_CXX_COMPILER=<path/to/clang> ..
cmake ..
Then run,