AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SWDEV-236465 - Return error code as soon as global creation fails.

Browse Source 
Change-Id: I790b8b4fdd6ab8818bc5b6b9a79e6900b840372d
This commit is contained in:
kjayapra-amd
2020-05-27 18:02:47 -04:00
committed by Karthik Jayaprakash
parent 90453b68d3
commit 55cdef8e45
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
hipamd/rocclr/hip_platform.cpp
+7 -5
View File
@@ -442,10 +442,10 @@ hipFunction_t PlatformState::getFunc(const void* hostFunction, int deviceId) {
if (createFunc(&function, module, devFunc.deviceName.c_str()) &&
function != nullptr) {
devFunc.functions[deviceId] = function;
}
else {
// tprintf(DB_FB, "__hipRegisterFunction cannot find kernel %s for"
// " device %d\n", deviceName, deviceId);
} else {
DevLogPrintfError("__hipRegisterFunction cannot find kernel %s for device %d\n",
devFunc.deviceName.c_str(), deviceId);
return nullptr;
}
}
return devFunc.functions[deviceId];
@@ -547,7 +547,9 @@ bool PlatformState::getGlobalVar(const char* hostVar, int deviceId, hipModule_t
dvar->rvars[deviceId].amd_mem_obj_ = amd_mem_obj;
amd::MemObjMap::AddMemObj(device_ptr, amd_mem_obj);
} else {
LogError("__hipRegisterVar cannot find kernel for device \n");
DevLogPrintfError("__hipRegisterVar cannot find Var: %s for deviceId: 0x%x \n",
dvar->hostVar.c_str(), deviceId);
return false;
}
}
*size_ptr = dvar->rvars[deviceId].getvarsize();